Re: [PATCH] compat: add canonicalize_file_name

diff --git a/2d/a5593028e53611fefb4f8d241fb725bf07b9d7 b/2d/a5593028e53611fefb4f8d241fb725bf07b9d7
new file mode 100644 (file)
index 0000000..28dcefc
--- /dev/null
+++ b/2d/a5593028e53611fefb4f8d241fb725bf07b9d7
@@ -0,0 +1,83 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E1DDC431FBD\r
+       for <notmuch@notmuchmail.org>; Mon, 27 Jan 2014 11:07:16 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id aCWuVDpFgUEV for <notmuch@notmuchmail.org>;\r
+       Mon, 27 Jan 2014 11:07:09 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9858E431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 27 Jan 2014 11:07:09 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 9ABF1100051;\r
+       Mon, 27 Jan 2014 21:07:03 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] compat: add canonicalize_file_name\r
+In-Reply-To: <1390831932-7865-1-git-send-email-david@tethera.net>\r
+References: <8761p6n0wc.fsf@zancas.localnet>\r
+       <1390831932-7865-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.17+55~g4397960 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 27 Jan 2014 21:07:03 +0200\r
+Message-ID: <m2ppndnt0o.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 27 Jan 2014 19:07:17 -0000\r
+\r
+On Mon, Jan 27 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> the POSIX 2008 behaviour of realpath is not available everywhere so we\r
+> provide a simple wrapper function.  We use (and provide) the gnu\r
+> extension canonicalize_file_name to make it cleaner to test for the\r
+> feature we need; otherwise we have to rely on realpath segfaulting if\r
+> the second argument is null.\r
+> ---\r
+\r
+I think this patch is tolerable. I first thought we should check the\r
+combination of not having canonicalize_file_name() and having POSIX 2008\r
+behaviour of realpath()...\r
+\r
+... but the compat code is simple enough and basically done the same way\r
+as in (e.g.)\r
+\r
+http://svnweb.freebsd.org/base/release/9.2.0/lib/libc/stdlib/realpath.c?revision=255898&view=markup\r
+\r
+qualifying the implementation. So +1 from me.\r
+\r
+Tomi\r
+\r
+>  compat/Makefile.local                |  4 ++++\r
+>  compat/canonicalize_file_name.c      | 18 ++++++++++++++++++\r
+>  compat/compat.h                      |  8 ++++++++\r
+>  compat/have_canonicalize_file_name.c | 10 ++++++++++\r
+>  configure                            | 16 ++++++++++++++++\r
+>  notmuch-config.c                     |  2 +-\r
+>  6 files changed, 57 insertions(+), 1 deletion(-)\r
+>  create mode 100644 compat/canonicalize_file_name.c\r
+>  create mode 100644 compat/have_canonicalize_file_name.c\r
+>\r