krb5.git
12 years agoAllow clearpolicy restriction for kadmin addprinc
Greg Hudson [Thu, 26 Apr 2012 04:34:20 +0000 (04:34 +0000)]
Allow clearpolicy restriction for kadmin addprinc

Although the kadmin client never generates a KADM5_POLICY_CLR mask bit
with addprinc, the bit will be set if a kadm5.acl line imposes the
-clearpolicy restriction.  Relax the sanity checking in
kadm5_create_principal_3 to allow KADM5_POLICY_CLR as long as
KADM5_POLICY is not also set.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25827 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd k5test.py helpers for running kadmin
Greg Hudson [Thu, 26 Apr 2012 04:34:15 +0000 (04:34 +0000)]
Add k5test.py helpers for running kadmin

Add K5Realm.prep_kadmin() to create a ccache and K5Realm.run_kadmin()
to run a kadmin query using it.  Modify t_stringattr.py to use these
helpers instead of its own.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25826 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFlip the default of start_kadmind in k5test.py
Greg Hudson [Thu, 26 Apr 2012 04:33:48 +0000 (04:33 +0000)]
Flip the default of start_kadmind in k5test.py

Very few Python tests need kadmind, so it makes more sense to have to
turn it on than to have to turn it off.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25825 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoMinor cleanup (mostly to remove the "Contents" section titles)
Zhanna Tsitkov [Wed, 25 Apr 2012 19:15:30 +0000 (19:15 +0000)]
Minor cleanup (mostly to remove the "Contents" section titles)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25824 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoUse "agogo" HTML theme (with some modifications) for the Sphinx documentation. Do...
Zhanna Tsitkov [Wed, 25 Apr 2012 19:10:41 +0000 (19:10 +0000)]
Use "agogo" HTML theme (with some modifications) for the Sphinx documentation. Do not show the ReST source files

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25823 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoClear preauth use counts for each AS request
Greg Hudson [Wed, 25 Apr 2012 17:20:20 +0000 (17:20 +0000)]
Clear preauth use counts for each AS request

Initialize use_count fields in krb5_preauth_request_context_init,
which is invoked before each AS request.  Previously they were
initialized only in krb5_init_preauth_context, which is only invoked
once per krb5 library context.

ticket: 7119
target_version: 1.10.2
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25822 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd KRB5_TRACE test case
Greg Hudson [Tue, 24 Apr 2012 17:04:29 +0000 (17:04 +0000)]
Add KRB5_TRACE test case

In t_general.py, run kinit with KRB5_TRACE enabled and make sure we
see some basic strings in the resulting file.

ticket: 7113

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25821 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdjust t_general.py organization
Greg Hudson [Tue, 24 Apr 2012 17:04:21 +0000 (17:04 +0000)]
Adjust t_general.py organization

Move some tests out of the multipass_realms loop since they aren't
enctype-dependent.  Fix the success message not to mention kvno
wrapping.  Don't start kadmind in the multipass_realms loop since we
don't use it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25820 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoTry all history keys to decrypt password history
Greg Hudson [Tue, 24 Apr 2012 01:05:41 +0000 (01:05 +0000)]
Try all history keys to decrypt password history

A database created prior to 1.3 will have multiple password history
keys, and kadmin prior to 1.8 won't necessarily choose the first one.
So if there are multiple keys, we have to try them all.  If none of
the keys can decrypt a password history entry, don't fail the password
change operation; it's not worth it without positive evidence of
password reuse.

ticket: 7099

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25819 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoUse etypes from keytab in krb5_gic_keytab
Greg Hudson [Thu, 19 Apr 2012 17:55:14 +0000 (17:55 +0000)]
Use etypes from keytab in krb5_gic_keytab

When getting initial credentials with a keytab, filter the list of
request enctypes based on the keys in the keytab.

Based on a patch from Stef Walter.

ticket: 2131

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25818 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoUnify krb5_get_init_creds_keytab code paths
Greg Hudson [Thu, 19 Apr 2012 17:55:10 +0000 (17:55 +0000)]
Unify krb5_get_init_creds_keytab code paths

Use krb5_init_creds_set_keytab in krb5_get_init_creds_keytab, so that
processing added to the former will be used by the latter.  This is
slightly awkward because of the way we do the use_master fallback, in
that we have to duplicate some of krb5int_get_init_creds.

Based on a patch from Stef Walter.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25817 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoReturn kinit output in k5test's K5Realm.kinit
Greg Hudson [Thu, 19 Apr 2012 17:55:07 +0000 (17:55 +0000)]
Return kinit output in k5test's K5Realm.kinit

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25816 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd keytab kinit test cases
Greg Hudson [Thu, 19 Apr 2012 17:55:03 +0000 (17:55 +0000)]
Add keytab kinit test cases

Create a test script for keytab-related tests.  Move the kvno wrapping
test there from t_general.py, and augment it to better match what's in
standalone.exp.  Add tests for kinit with keytab, including kinit with
the most-preferred enctype missing from the keytab (which currently
fails).

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25815 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd Doxygen markup to API functions that were introduced in 1.9 release
Zhanna Tsitkov [Thu, 19 Apr 2012 14:45:20 +0000 (14:45 +0000)]
Add Doxygen markup to API functions that were introduced in 1.9 release

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25814 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoEdit resources page
Greg Hudson [Tue, 17 Apr 2012 18:18:08 +0000 (18:18 +0000)]
Edit resources page

Improve description of kerberos and krbcore.  Remove trailing
whitespace throughout.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25813 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoRename mitresources.rst to resources.rst
Greg Hudson [Tue, 17 Apr 2012 18:08:13 +0000 (18:08 +0000)]
Rename mitresources.rst to resources.rst

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25812 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoTranslate @version Doxygen markup into rst format
Zhanna Tsitkov [Tue, 17 Apr 2012 18:07:07 +0000 (18:07 +0000)]
Translate @version Doxygen markup into rst format

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25811 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd Doxygen markup to API functions that were introduced in 1.10 release
Zhanna Tsitkov [Tue, 17 Apr 2012 17:58:56 +0000 (17:58 +0000)]
Add Doxygen markup to API functions that were introduced in 1.10 release

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25810 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdded MIT resources document
Zhanna Tsitkov [Tue, 17 Apr 2012 17:49:10 +0000 (17:49 +0000)]
Added MIT resources document

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25809 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAllow preauth mechs to work with clock skew
Greg Hudson [Tue, 17 Apr 2012 04:07:34 +0000 (04:07 +0000)]
Allow preauth mechs to work with clock skew

Add a clpreauth callback which gets the time of day using an offset
determined by the preauth-required error, and use it in encrypted
timestamp and encrypted challenge.  This timestamp is not necessarily
authenticated, but the security consequences for those preauth mechs
are minor (and can be mitigated by turning off kdc_timesync on
clients).

Based on a patch from Stef Walter.

ticket: 7114

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25808 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd clock skew tests
Greg Hudson [Tue, 17 Apr 2012 03:19:12 +0000 (03:19 +0000)]
Add clock skew tests

Add a KDC option (-T) to run with a time offset, and use that to
test kdc_timesync behavior.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25807 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoCorrect kdc_timesync documentation
Greg Hudson [Tue, 17 Apr 2012 03:19:07 +0000 (03:19 +0000)]
Correct kdc_timesync documentation

kdc_timesync is read from the profile as an integer, not a boolean; go
back to documenting it that way.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25806 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoDocument kadm5_hook chpass randomize-key behavior
Greg Hudson [Mon, 16 Apr 2012 23:21:42 +0000 (23:21 +0000)]
Document kadm5_hook chpass randomize-key behavior

kadmind's randkey operation invokes the kadm5_hook chpass method with
a null newpass parameter, which wasn't documented.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25805 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix documention of unconfigured rsthml build
Tom Yu [Wed, 11 Apr 2012 22:45:56 +0000 (22:45 +0000)]
Fix documention of unconfigured rsthml build

It's necessary to specify srcdir=. on the command line when building
rsthtml in an unconfigured tree.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25804 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix trace logging initialization
Greg Hudson [Thu, 5 Apr 2012 14:07:05 +0000 (14:07 +0000)]
Fix trace logging initialization

Reported by stefw@gnome.org.

ticket: 7112

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25803 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix app tag choices for decoding EncASRepPart
Greg Hudson [Thu, 5 Apr 2012 13:57:37 +0000 (13:57 +0000)]
Fix app tag choices for decoding EncASRepPart

When decoding an AS-REP enc part, we should accept app tags 26 (the
bogus one we generate) and 25 (the correct value).  We were accepting
26 and 24.  Bug report and fix by stefw@gnome.org.

ticket: 7111

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25802 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix password reuse check with cpw -keepold
Greg Hudson [Wed, 4 Apr 2012 21:38:57 +0000 (21:38 +0000)]
Fix password reuse check with cpw -keepold

When we check for password reuse, only compare keys with the most
recent kvno against history entries, or else we will always fail with
-keepold.

This bug primarily affects rollover of cross-realm TGT principals,
which typically use password-derived keys and may have an associated
password policy such as "default".

Bug report and candidate fix (taken with a slight modification) by
Nicolas Williams.

ticket: 7110

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25801 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoIf trace logging facility is enabled, report misconfiguration errors encountered...
Zhanna Tsitkov [Mon, 2 Apr 2012 18:38:45 +0000 (18:38 +0000)]
If trace logging facility is enabled, report misconfiguration errors encountered while initializing krb5 library context

ticket: 7091

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25800 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoMake cross-TGT key rollover work from AD to MIT
Greg Hudson [Mon, 2 Apr 2012 17:49:56 +0000 (17:49 +0000)]
Make cross-TGT key rollover work from AD to MIT

Active Directory always issues cross-realm tickets without a kvno,
which we see as kvno 0.  When we see that, try the highest kvno (as we
already do) and then a few preceding kvnos so that key rollover of the
AD->MIT cross TGT can work.

Add new helpers kdc_rd_ap_req, which takes the place of a couple of
steps from kdc_process_tgs_req, and find_server_key, which takes the
place of some of the end steps of kdc_get_server_key.

Code changes by Nicolas Williams.  Test cases by me.

ticket: 7109

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25799 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoEdit RST docs on building RST docs
Greg Hudson [Sat, 31 Mar 2012 06:01:02 +0000 (06:01 +0000)]
Edit RST docs on building RST docs

Fix a couple of grammar errors noted by Ben Kaduk, and elaborate a
little bit on why generated man pages are checked into the repository.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25798 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix data handling in rd_req_decoded_opt
Greg Hudson [Sat, 31 Mar 2012 00:38:20 +0000 (00:38 +0000)]
Fix data handling in rd_req_decoded_opt

We shouldn't peer at trans->tr_contents.data[0] if
trans->tr_contents.length is 0, even if the data field is non-null.
Harmless as long as the ASN.1 decoder uses null data fields for empty
krb5_data values, but still wrong.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25797 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAvoid malloc(0) in ASN.1 bytestring decode
Greg Hudson [Sat, 31 Mar 2012 00:38:16 +0000 (00:38 +0000)]
Avoid malloc(0) in ASN.1 bytestring decode

In k5_asn1_decode_bytestring, just leave *str_out as NULL if len is 0,
instead of calling malloc(0) and possibly returning a spurious ENOMEM.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25796 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd doc target with configured path substitutions
Greg Hudson [Wed, 28 Mar 2012 21:11:06 +0000 (21:11 +0000)]
Add doc target with configured path substitutions

Add a new target "substhtml" in src/doc to create HTML documentation
with configured paths, suitable for installation by an OS package.
The build target generates a file named paths.py containing the
directory substitutions, copies it into the rst_composite directory,
and instructs conf.py to use it with the "pathsubs" tag.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25795 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoUse reference substitutions for paths in docs
Greg Hudson [Wed, 28 Mar 2012 21:11:01 +0000 (21:11 +0000)]
Use reference substitutions for paths in docs

For the default doc build (used for the web site and release tarball),
substitute path variables with links to the paths table in
mitK5defaults.rst, using symbolic names for the link text.

The substitution of kdcdir for man pages is slightly altered as a
side-effect of this commit.  Regenerate the man pages to match.  The
rendered man pages are unchanged.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25794 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoEdit defaults page in documentation
Greg Hudson [Wed, 28 Mar 2012 21:10:49 +0000 (21:10 +0000)]
Edit defaults page in documentation

Eliminate unused values and OS-specific stuff.  Reformat tables.  Add
a path substitution for sysconfdir to be used in the default config
file path.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25793 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoMove rstman build target to man directory
Greg Hudson [Wed, 28 Mar 2012 02:03:45 +0000 (02:03 +0000)]
Move rstman build target to man directory

rstman makes more sense in man than in doc, so move it there.  Remove
the rstman target from the top-level doc Makefile to avoid confusion.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25792 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAutomate RST HTML generation with doxygen info
Greg Hudson [Wed, 28 Mar 2012 02:03:33 +0000 (02:03 +0000)]
Automate RST HTML generation with doxygen info

In src/doc/Makefile.in, create an "rsthtml" target for generating
release tarball/web site HTML docs in doc/rst_html.  For now,
eliminate support for the bridge to the Doxygen HTML output; just
generate XML output with Doxygen and convert it to RST format.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25791 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix up gssapi_ext.h Doxygen markup somewhat
Greg Hudson [Tue, 27 Mar 2012 02:32:57 +0000 (02:32 +0000)]
Fix up gssapi_ext.h Doxygen markup somewhat

* Bring formatting for gss_userok and gss_authorize_localname into
  conformance.
* Bring parameter markup for gss_localname into conformance.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25790 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix up krb5.hin Doxygen markup somewhat
Greg Hudson [Tue, 27 Mar 2012 02:32:48 +0000 (02:32 +0000)]
Fix up krb5.hin Doxygen markup somewhat

* Put everything in an enclosing group, so it gets captured even
  without EXTRACT_ALL.
* Make sure there's documentation for all constants referenced by
  other markup.
* Fix references to the PAC constants.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25789 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoRemove krb5-send-pr man page
Greg Hudson [Sat, 24 Mar 2012 14:29:44 +0000 (14:29 +0000)]
Remove krb5-send-pr man page

The license on the krb5-send-pr man page was incompatible with the
rest of our documentation, and the content is questionably up to date
(krb5-send-pr still exists, but we don't use GNATS any more, and
free-form mail to krb5-bugs is equally acceptable at this point).  Get
rid of it for now.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25788 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoRemove references to the "feedback" and the original source of the document (such...
Zhanna Tsitkov [Fri, 23 Mar 2012 19:20:12 +0000 (19:20 +0000)]
Remove references to the "feedback" and the original source of the document (such as Kerberos V5 Installation Guide etc) in the rst files

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25787 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoInstall path-substituted man pages
Greg Hudson [Fri, 23 Mar 2012 16:27:05 +0000 (16:27 +0000)]
Install path-substituted man pages

Introduce src/doc/Makefile.in, which will eventually subsume
doc/Makefile (but will still pull sources from doc).  In the rstman
target there, create man pages with symbolic path references (like
@SBINDIR@).  In man/Makefile.in, substitute the path references with
the configured paths before installing.

Man pages generated from RST source are now checked into the source
tree under the name filename.man.  This lets us use a single implicit
.man.sub rule for the path substitutions.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25786 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoMiscellaneous small edits to RST docs
Greg Hudson [Thu, 22 Mar 2012 17:28:42 +0000 (17:28 +0000)]
Miscellaneous small edits to RST docs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25785 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoUse substitutions in RST docs
Greg Hudson [Thu, 22 Mar 2012 17:28:34 +0000 (17:28 +0000)]
Use substitutions in RST docs

Create an rst_epilog variable defining substitutions for pathnames and
default enctypes, and use them in the RST source files.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25784 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoSuppress some gcc uninitialized variable warnings
Greg Hudson [Thu, 22 Mar 2012 14:07:44 +0000 (14:07 +0000)]
Suppress some gcc uninitialized variable warnings
ticket: 7107
gcc 4.6.2 reportedly finds some spurious maybe-uninitialized warnings.
Suppress them.  Patch from Eray Aslan with some adjustment.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25783 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoDescribe trace logging in troubleshooting docs
Greg Hudson [Wed, 21 Mar 2012 17:44:18 +0000 (17:44 +0000)]
Describe trace logging in troubleshooting docs

Add a section to the troubleshooting page in the RST documentation
describing how to use trace logging and giving sample output.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25782 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoOnly store master mey list in DAL handle
Greg Hudson [Wed, 21 Mar 2012 16:57:05 +0000 (16:57 +0000)]
Only store master mey list in DAL handle

r24314 (#6778) created a hybrid owernship model for the master key
list, with one virtual copy stored in the DAL handle and one provided
to the caller of krb5_db_fetch_mkey_list.  Replace this with a model
where only the DAL handle owns the list, and a caller can get access
to an alias pointer with a new function krb5_db_mkey_list_alias().
Functions which previously accepted the master key list as an input
parameter now expect to find it in the DAL handle.

Patch by Will Fiveash <will.fiveash@oracle.com>.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25781 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoMove supported enc/salt type docs to kdc.conf(5)
Greg Hudson [Tue, 20 Mar 2012 17:39:04 +0000 (17:39 +0000)]
Move supported enc/salt type docs to kdc.conf(5)

Remove enc_types.rst and move its contents into kdc.conf(5).  Adjust
references so that man page readers can find the section in the
kdc.conf man page.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25780 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoDo not insert a timestamp into manpages and Sphinx main page
Zhanna Tsitkov [Mon, 19 Mar 2012 18:19:55 +0000 (18:19 +0000)]
Do not insert a timestamp into manpages and Sphinx main page

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25779 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoCorrect the location of k5identity and k5login in the man_page section of the Sphinx...
Zhanna Tsitkov [Mon, 19 Mar 2012 18:12:27 +0000 (18:12 +0000)]
Correct the location of k5identity and k5login in the man_page section of the Sphinx config file

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25778 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoMake localedir work in build with autoconf 2.5x
Greg Hudson [Mon, 19 Mar 2012 04:40:52 +0000 (04:40 +0000)]
Make localedir work in build with autoconf 2.5x

autoconf 2.5x does not define localedir, so we have to detect that and
do it ourselves.

ticket: 7095
target_version: 1.10.2
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25777 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoMiscellaneous RST documentation edits
Greg Hudson [Fri, 16 Mar 2012 13:57:55 +0000 (13:57 +0000)]
Miscellaneous RST documentation edits

Make small changes to various RST documentation pages to improve
clarity or remove outdated statements.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25776 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoMove privileges section in database admin docs
Greg Hudson [Fri, 16 Mar 2012 13:57:50 +0000 (13:57 +0000)]
Move privileges section in database admin docs

The "Privileges" section in the RST database administration
documentation was tucked away in the middle of a section on principal
operations.  Move it out and put it between policy operations and
kdb5_util operations, without changing its content.

(We may want to replace this whole section with a reference to the
appropriate part of the kadmind man page, but that requires a bit of
reconciliation since the kadmind man page doesn't document
restrictions yet.)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25775 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoReorder top-level RST doc sections
Greg Hudson [Fri, 16 Mar 2012 13:57:45 +0000 (13:57 +0000)]
Reorder top-level RST doc sections

Order the top-level documentation according to the expertise level of
the intended audience.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25774 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoDocument the ccselect interface in krb5.conf
Greg Hudson [Fri, 16 Mar 2012 13:57:31 +0000 (13:57 +0000)]
Document the ccselect interface in krb5.conf

r25158 (#6957) omitted krb5.conf documentation for the ccselect
interface.  Add it now.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25773 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoRevise RST install guide client configuration
Greg Hudson [Fri, 16 Mar 2012 13:57:05 +0000 (13:57 +0000)]
Revise RST install guide client configuration

Stop recommending login.krb5.  Remove outdated OSX instructions.
Don't suggest modifying /etc/services as we don't rely on it any more
(and it's generally already done by the OS these days).  Add new
guidance for krb5.conf settings.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25772 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoEdit RST user man pages for clarity and accuracy
Greg Hudson [Fri, 16 Mar 2012 04:31:57 +0000 (04:31 +0000)]
Edit RST user man pages for clarity and accuracy

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25771 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoEdit RST admin man pages for clarity and accuracy
Greg Hudson [Thu, 15 Mar 2012 22:52:45 +0000 (22:52 +0000)]
Edit RST admin man pages for clarity and accuracy

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25770 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoMiscellaneous corrections to RST docs
Greg Hudson [Thu, 15 Mar 2012 04:55:41 +0000 (04:55 +0000)]
Miscellaneous corrections to RST docs

Fix various small errors pointed out by Ben Kaduk (and a couple of
minor misstatements in text adjacent to them).

ticket: 7106

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25769 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd plugin configuration documentation
Greg Hudson [Wed, 14 Mar 2012 21:06:01 +0000 (21:06 +0000)]
Add plugin configuration documentation

In the RST admin guide, add a page for host configuration, and include
a subsection on registering, enabling, and disabling plugin modules.
For now, do not cover the private KDB and authdata plugin interfaces.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25768 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd config file section in RST user guide
Greg Hudson [Wed, 14 Mar 2012 19:55:49 +0000 (19:55 +0000)]
Add config file section in RST user guide

Move the .k5identity and .k5login man pages to a separate section from
user commands.  Also, kadmin.local and k5srvutil are not user-oriented
commands, so don't link to them in the user_commands index.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25767 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoRemove user_appl section in RST docs
Greg Hudson [Wed, 14 Mar 2012 19:55:44 +0000 (19:55 +0000)]
Remove user_appl section in RST docs

The user_appl directory contained documentation for krb5_appl programs
which have largely been subsumed by ssh, for ksu (essentially
duplicating the ksu man page), and for ssh (a stub).  Get rid of the
whole thing for now; we can add an ssh section back into the user
guide when we have more written about it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25766 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoBring ticket management documentation up to date
Greg Hudson [Wed, 14 Mar 2012 19:55:38 +0000 (19:55 +0000)]
Bring ticket management documentation up to date

Refer to ssh instead of telnet; refer to login system integration
instead of the Kerberos login program.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25765 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoCreated a new basic Kerberos concepts section and moved stash_file_def there
Zhanna Tsitkov [Wed, 14 Mar 2012 19:18:09 +0000 (19:18 +0000)]
Created a new basic Kerberos concepts section and moved stash_file_def there

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25764 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoConsolidate password and ticket management docs
Greg Hudson [Wed, 14 Mar 2012 18:30:39 +0000 (18:30 +0000)]
Consolidate password and ticket management docs

In the RST documentation, combine the pwd_mgmt and tkt_mgmt
subdirectories of krb_users into single files, without changing the
content.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25763 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoEdit RST admin guide for clarity and accuracy
Greg Hudson [Mon, 12 Mar 2012 20:24:45 +0000 (20:24 +0000)]
Edit RST admin guide for clarity and accuracy

Some more notable changes include:

* plugin development is a top-level guide, so remove the advanced
  topic page in the admin guide.
* Remove krb5-appl references in firewall configuration section.
* Remove dns.rst since it was only referenced from a man page (which
  doesn't work) and just contained a pair of links, one of which was
  to the immediately preceding section.
* Don't document TXT record support as if it were supported in the
  default build.  It can be documented in an appendix.
* A couple of troubleshooting segments gave very
  specifically-applicable advice based on general error messages, or
  described problems which were fixed several releases ago.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25762 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix the ref string
Zhanna Tsitkov [Fri, 9 Mar 2012 20:40:55 +0000 (20:40 +0000)]
Fix the ref string

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25761 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAvoid side effects in assert expressions
Greg Hudson [Fri, 9 Mar 2012 18:30:31 +0000 (18:30 +0000)]
Avoid side effects in assert expressions

asserts may be compiled out with -DNDEBUG, so it's wrong to use an
assert expression with an important side effect.

(We also have scores of side-effecting asserts in test programs, but
those are less important and can be dealt with separately.)

ticket: 7105

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25760 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd pluggable interface RST documentation
Greg Hudson [Thu, 8 Mar 2012 22:38:58 +0000 (22:38 +0000)]
Add pluggable interface RST documentation

Create a new top-level section for plugin module developers.  Document
the general conventions for pluggable interfaces and an overview of
each existing interface (except for GSSAPI mechanisms).

Since we're not currently generating doxygen markup for plugin
interface headers, refer to header files for detail-level
documentation for now.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25759 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoDocument conventions used in RST source
Greg Hudson [Thu, 8 Mar 2012 22:38:52 +0000 (22:38 +0000)]
Document conventions used in RST source

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25758 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoDo not generate "Feedback" sections in rst files for API documentation
Zhanna Tsitkov [Thu, 8 Mar 2012 15:51:43 +0000 (15:51 +0000)]
Do not generate "Feedback" sections in rst files for API documentation

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25751 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoRemove "Feedback" paragraphs from the rst files.
Zhanna Tsitkov [Thu, 8 Mar 2012 15:48:21 +0000 (15:48 +0000)]
Remove "Feedback" paragraphs from the rst files.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25750 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoExtended Sphinx layout.html with a "feedback" reference
Zhanna Tsitkov [Thu, 8 Mar 2012 14:58:55 +0000 (14:58 +0000)]
Extended Sphinx layout.html with a "feedback" reference

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25749 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoProperly decode etype-info2 with no salt
Greg Hudson [Thu, 8 Mar 2012 00:37:47 +0000 (00:37 +0000)]
Properly decode etype-info2 with no salt

The data-driven decoder for etype-info2 was neglecting to call
init_no_salt() when no salt is present in the encoding.  Add in the
missing call.  Also add decode test cases for etype-info2, which would
have caught this if they weren't missing.

ticket: 7100

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25744 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoSimplify some ASN.1 array encoder tests
Greg Hudson [Thu, 8 Mar 2012 00:37:44 +0000 (00:37 +0000)]
Simplify some ASN.1 array encoder tests

Use encode_run() for pa_data and etype_info tests.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25743 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoRemove unused arg from encode_run in ASN.1 tests
Greg Hudson [Thu, 8 Mar 2012 00:37:41 +0000 (00:37 +0000)]
Remove unused arg from encode_run in ASN.1 tests

Reformat call sites according to current coding conventions, since
we're touching them all anyway.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25742 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoDocument KDC settings in kdc.conf manual
Greg Hudson [Wed, 7 Mar 2012 18:02:29 +0000 (18:02 +0000)]
Document KDC settings in kdc.conf manual

Move the documentation for the [logging], [dbdefaults], and
[dbmodules] sections and the database_module tag in kdc.conf rather
than krb5.conf, now that (as of r18009, aka #3761, which went into
krb5 1.5) KDC settings can be placed in either file.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25737 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoEdit admin config file docs for clarity
Greg Hudson [Wed, 7 Mar 2012 18:02:20 +0000 (18:02 +0000)]
Edit admin config file docs for clarity

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25736 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoUse GETSOCKNAME_ARG3_TYPE to prevent warning in type incompatibility.
Ezra Peisach [Tue, 6 Mar 2012 10:48:00 +0000 (10:48 +0000)]
Use GETSOCKNAME_ARG3_TYPE to prevent warning in type incompatibility.
Fix a cast to prvent signed/unsigned warning.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25735 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoMake sure that
Zhanna Tsitkov [Mon, 5 Mar 2012 23:40:01 +0000 (23:40 +0000)]
Make sure that
1.  a new-line " ::"  is preceded by not more then one line of text;
2.  a new line does not start with a whitespace(s) and a dot

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25734 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoConsolidate application server docs into one file
Greg Hudson [Mon, 5 Mar 2012 19:27:49 +0000 (19:27 +0000)]
Consolidate application server docs into one file

Combine the contents of the krb_admins/appl_server directory into one
file appl_server.rst.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25733 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoConsolidate DB admin docs into one file
Greg Hudson [Mon, 5 Mar 2012 19:19:33 +0000 (19:19 +0000)]
Consolidate DB admin docs into one file

Combine the contents of the krb_admins/database directory into one
file database.rst.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25732 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoRemove eDirectory references in RST docs
Greg Hudson [Mon, 5 Mar 2012 18:32:12 +0000 (18:32 +0000)]
Remove eDirectory references in RST docs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25731 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix spurious password expiry warning
Greg Hudson [Mon, 5 Mar 2012 17:35:14 +0000 (17:35 +0000)]
Fix spurious password expiry warning

r24241 (#6755) introduced a bug where if the KDC sends a LastReq entry
containing an account expiry time, we send a prompter warning for
password expiry even if there was no entry containing a password
expiry time.  Typically, this results in the message "Warning: Your
password will expire in less than one hour on Thu Jan  1 12:00:00
1970".

Fix this by explicitly checking for pw_exp == 0 in warn_pw_expiry()
after we've gotten past the conditional for invoking the callback.

ticket: 7098
target_version: 1.9.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25730 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoRemove admin_keytab references in code and docs
Greg Hudson [Sun, 4 Mar 2012 00:38:48 +0000 (00:38 +0000)]
Remove admin_keytab references in code and docs

The admin keytab hasn't been needed or used by kadmind since 1.4
(except possibly by legacy admin daemons which we no longer ship).
Eliminate remaining references to it in code, test cases, and
documentation.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25729 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoConsolidate realm config docs into one file
Greg Hudson [Sat, 3 Mar 2012 06:17:51 +0000 (06:17 +0000)]
Consolidate realm config docs into one file

Move the contents of the realm_config directory into one file
realm_config.rst.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25728 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix the problem when the text of the examples and alike's was not properly indented...
Zhanna Tsitkov [Sat, 3 Mar 2012 03:30:36 +0000 (03:30 +0000)]
Fix the problem when the text of the examples and alike's was not properly indented in the man pages.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25727 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix the reference to the non-existing label
Zhanna Tsitkov [Fri, 2 Mar 2012 22:43:34 +0000 (22:43 +0000)]
Fix the reference to the non-existing label

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25726 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd test cases for Windows RODC kvno compatibility
Tom Yu [Fri, 2 Mar 2012 22:24:38 +0000 (22:24 +0000)]
Add test cases for Windows RODC kvno compatibility

ticket: 7092

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25725 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoConsolidate RST install docs into larger files
Greg Hudson [Fri, 2 Mar 2012 19:18:33 +0000 (19:18 +0000)]
Consolidate RST install docs into larger files

Create two larger files (install_kdc.rst and install_clients.rst) and
remove the install_kdc and install_clients directories.  No
significant changes to content.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25724 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix KDB iteration when callback does write calls
Greg Hudson [Thu, 1 Mar 2012 20:49:17 +0000 (20:49 +0000)]
Fix KDB iteration when callback does write calls

kdb_db2's ctx_iterate makes an convenience alias to dbc->db in order
to call more invoke call the DB's seq method.  This alias may become
invalidated if the callback writes to the DB, since ctx_lock() may
re-open the DB in order to acquire a write lock.  Fix the bug by
getting rid of the convenience alias.

Most KDB iteration operations in the code base do not write to the DB,
but kdb5_util update_princ_encryption does.

Bug discovered and diagnosed by will.fiveash@oracle.com.

ticket: 7096
target_version: 1.10.1
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25723 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoAdd GSSAPI acceptor names documentation
Greg Hudson [Wed, 29 Feb 2012 18:49:04 +0000 (18:49 +0000)]
Add GSSAPI acceptor names documentation

In the application developer documentation, create a little bit of
framing for documentation about krb5 GSS mechanism behavior and
extensions, and create an initial section about how host-based service
names affect keytab principal selection.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25722 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoRemove unused RST files
Zhanna Tsitkov [Tue, 28 Feb 2012 17:06:12 +0000 (17:06 +0000)]
Remove unused RST files

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25721 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoCorrect some references
Zhanna Tsitkov [Tue, 28 Feb 2012 16:28:21 +0000 (16:28 +0000)]
Correct some references

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25720 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoRequire IPv6 support
Ken Raeburn [Tue, 28 Feb 2012 16:15:56 +0000 (16:15 +0000)]
Require IPv6 support

The configure-time options to enable and disable IPv6 support have
been deprecated for some time, but the checks for OS support were
kept.  This removes those checks, and unconditionally compiles in the
IPv6 support.

There was a configure-time test to see if the macro INET6 needed to be
defined in order to enable (visibility of) OS support for IPv6, which
was needed on an IRIX system we tested with.  That check is retained,
but the revised code is untested on IRIX.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25719 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoFix the label
Zhanna Tsitkov [Tue, 28 Feb 2012 15:21:10 +0000 (15:21 +0000)]
Fix the label

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25718 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoEdit RST install guide for clarity and accuracy
Greg Hudson [Mon, 27 Feb 2012 23:29:09 +0000 (23:29 +0000)]
Edit RST install guide for clarity and accuracy

Notable changes include:

* In the example config files, configure logging in kdc.conf rather
  than krb5.conf.

* It is no longer necessary to create a dummy database on slaves
  before propagating the master DB with kprop; remove that step from
  the instructions.

* The admin keytab file is no longer required or used.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25717 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoPatch from Richard Basch to work around Solaris 8 lacking isblank()
Tom Yu [Mon, 27 Feb 2012 18:31:50 +0000 (18:31 +0000)]
Patch from Richard Basch to work around Solaris 8 lacking isblank()

ticket: 7074
target_version: 1.10.1
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25716 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoClean up labels in RST docs
Greg Hudson [Mon, 27 Feb 2012 18:17:19 +0000 (18:17 +0000)]
Clean up labels in RST docs

In various labels, correct typos, remove the redundant "_label"
suffix, and avoid overabbreviating.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25715 dc483132-0cff-0310-8789-dd5450dbe970

12 years agoImprove man page references in RST documentation
Greg Hudson [Mon, 27 Feb 2012 04:48:54 +0000 (04:48 +0000)]
Improve man page references in RST documentation

Give each command and config file a reference label, and change many
uses of command names and config file names to be references.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25714 dc483132-0cff-0310-8789-dd5450dbe970