Adjust NoteIndexList._index in .index() if it falls off the end of the list.

[hooke.git] / hooke / playlist.py

diff --git a/hooke/playlist.py b/hooke/playlist.py
index cd5f9fbd3e37cc01e60dcd121b9a8d9761db0ce4..52d8df1352e6077ae77651512a8eab1305ba3718 100644 (file)
--- a/hooke/playlist.py
+++ b/hooke/playlist.py
@@ -1,4 +1,4 @@
-# Copyright (C) 2010 W. Trevor King <wking@drexel.edu>
+# Copyright (C) 2010-2011 W. Trevor King <wking@drexel.edu>
 #
 # This file is part of Hooke.
 #
@@ -88,6 +88,8 @@ class NoteIndexList (list):
         is `None`.
         """
         if value == None:
+            if self._index >= len(self):  # perhaps items have been popped
+                self._index = len(self) - 1
             return self._index
         return super(NoteIndexList, self).index(value, *args, **kwargs)
 
@@ -127,6 +129,9 @@ class NoteIndexList (list):
         index = self._index
         items = self
         if reverse == True:
+            # could iterate through `c` if current_curve_callback()
+            # would work, but `c` is not bound to the local `hooke`,
+            # so curent_playlist_callback cannot point to it.
             items = reverse_enumerate(self)
         else:
             items = enumerate(self)
@@ -138,11 +143,11 @@ class NoteIndexList (list):
 
     def filter(self, keeper_fn=lambda item:True, load_curves=True,
                *args, **kwargs):
-        c = copy.deepcopy(self)
+        c = copy.copy(self)
         if load_curves == True:
-            items = c.items(reverse=True)
+            items = self.items(reverse=True)
         else:
-            items = reversed(c)
+            items = reversed(self)
         for item in items: 
             if keeper_fn(item, *args, **kwargs) != True:
                 c.remove(item)
@@ -210,7 +215,7 @@ class Playlist (NoteIndexList):
             pass
 
 
-def playlist_path(path):
+def playlist_path(path, expand=False):
     """Normalize playlist path extensions.
 
     Examples
@@ -226,6 +231,8 @@ def playlist_path(path):
         return None
     if not path.endswith('.hkp'):
         path += '.hkp'
+    if expand:
+        path = os.path.abspath(os.path.expanduser(path))
     return path
 
 
@@ -299,10 +306,9 @@ class FilePlaylist (Playlist):
             if self._base_path == None:
                 self._base_path = os.getcwd()
         else:
-            path = playlist_path(path)
+            path = playlist_path(path, expand=True)
             self.path = path
-            self._base_path = os.path.dirname(os.path.abspath(
-                os.path.expanduser(self.path)))
+            self._base_path = os.path.dirname(self.path)
             if self.name == None:
                 self.name = os.path.basename(path)
         if self._base_path != orig_base_path:
@@ -572,7 +578,7 @@ def from_string(string):
 def load(path=None, drivers=None, identify=True, hooke=None):
     """Load a playlist from a file.
     """
-    path = os.path.expanduser(playlist_path(path))
+    path = playlist_path(path, expand=True)
     with open(path, 'r') as f:
         text = f.read()
     playlist = from_string(text)