Merge branch 'jl/interrupt-clone-remove-separate-git-dir'
authorJunio C Hamano <gitster@pobox.com>
Thu, 10 Jan 2013 21:47:30 +0000 (13:47 -0800)
committerJunio C Hamano <gitster@pobox.com>
Thu, 10 Jan 2013 21:47:30 +0000 (13:47 -0800)
When "git clone --separate-git-dir" is interrupted, we failed to
remove the real location we created the repository.

* jl/interrupt-clone-remove-separate-git-dir:
  clone: support atomic operation with --separate-git-dir

1  2 
builtin/clone.c

diff --combined builtin/clone.c
index ec2f75b4f3b9d9acfb8aa6b423f3b0fc7fbbafdf,b054313ab659605b5902e68bdb6ff364c3333e5e..8d23a62e8a1b875f1415f78a4c283f4cdefac011
@@@ -8,7 -8,7 +8,7 @@@
   * Clone a repository into a different directory that does not yet exist.
   */
  
 -#include "cache.h"
 +#include "builtin.h"
  #include "parse-options.h"
  #include "fetch-pack.h"
  #include "refs.h"
   *
   */
  static const char * const builtin_clone_usage[] = {
 -      "git clone [options] [--] <repo> [<dir>]",
 +      N_("git clone [options] [--] <repo> [<dir>]"),
        NULL
  };
  
 -static int option_no_checkout, option_bare, option_mirror;
 -static int option_local, option_no_hardlinks, option_shared, option_recursive;
 -static char *option_template, *option_reference, *option_depth;
 +static int option_no_checkout, option_bare, option_mirror, option_single_branch = -1;
 +static int option_local = -1, option_no_hardlinks, option_shared, option_recursive;
 +static char *option_template, *option_depth;
  static char *option_origin = NULL;
  static char *option_branch = NULL;
  static const char *real_git_dir;
  static char *option_upload_pack = "git-upload-pack";
  static int option_verbosity;
 -static int option_progress;
 +static int option_progress = -1;
 +static struct string_list option_config;
 +static struct string_list option_reference;
 +
 +static int opt_parse_reference(const struct option *opt, const char *arg, int unset)
 +{
 +      struct string_list *option_reference = opt->value;
 +      if (!arg)
 +              return -1;
 +      string_list_append(option_reference, arg);
 +      return 0;
 +}
  
  static struct option builtin_clone_options[] = {
        OPT__VERBOSITY(&option_verbosity),
 -      OPT_BOOLEAN(0, "progress", &option_progress,
 -                      "force progress reporting"),
 +      OPT_BOOL(0, "progress", &option_progress,
 +               N_("force progress reporting")),
        OPT_BOOLEAN('n', "no-checkout", &option_no_checkout,
 -                  "don't create a checkout"),
 -      OPT_BOOLEAN(0, "bare", &option_bare, "create a bare repository"),
 +                  N_("don't create a checkout")),
 +      OPT_BOOLEAN(0, "bare", &option_bare, N_("create a bare repository")),
        { OPTION_BOOLEAN, 0, "naked", &option_bare, NULL,
 -              "create a bare repository",
 +              N_("create a bare repository"),
                PARSE_OPT_NOARG | PARSE_OPT_HIDDEN },
        OPT_BOOLEAN(0, "mirror", &option_mirror,
 -                  "create a mirror repository (implies bare)"),
 -      OPT_BOOLEAN('l', "local", &option_local,
 -                  "to clone from a local repository"),
 +                  N_("create a mirror repository (implies bare)")),
 +      OPT_BOOL('l', "local", &option_local,
 +              N_("to clone from a local repository")),
        OPT_BOOLEAN(0, "no-hardlinks", &option_no_hardlinks,
 -                  "don't use local hardlinks, always copy"),
 +                  N_("don't use local hardlinks, always copy")),
        OPT_BOOLEAN('s', "shared", &option_shared,
 -                  "setup as shared repository"),
 +                  N_("setup as shared repository")),
        OPT_BOOLEAN(0, "recursive", &option_recursive,
 -                  "initialize submodules in the clone"),
 +                  N_("initialize submodules in the clone")),
        OPT_BOOLEAN(0, "recurse-submodules", &option_recursive,
 -                  "initialize submodules in the clone"),
 -      OPT_STRING(0, "template", &option_template, "template-directory",
 -                 "directory from which templates will be used"),
 -      OPT_STRING(0, "reference", &option_reference, "repo",
 -                 "reference repository"),
 -      OPT_STRING('o', "origin", &option_origin, "branch",
 -                 "use <branch> instead of 'origin' to track upstream"),
 -      OPT_STRING('b', "branch", &option_branch, "branch",
 -                 "checkout <branch> instead of the remote's HEAD"),
 -      OPT_STRING('u', "upload-pack", &option_upload_pack, "path",
 -                 "path to git-upload-pack on the remote"),
 -      OPT_STRING(0, "depth", &option_depth, "depth",
 -                  "create a shallow clone of that depth"),
 -      OPT_STRING('L', "separate-git-dir", &real_git_dir, "gitdir",
 -                 "separate git dir from working tree"),
 -
 +                  N_("initialize submodules in the clone")),
 +      OPT_STRING(0, "template", &option_template, N_("template-directory"),
 +                 N_("directory from which templates will be used")),
 +      OPT_CALLBACK(0 , "reference", &option_reference, N_("repo"),
 +                   N_("reference repository"), &opt_parse_reference),
 +      OPT_STRING('o', "origin", &option_origin, N_("name"),
 +                 N_("use <name> instead of 'origin' to track upstream")),
 +      OPT_STRING('b', "branch", &option_branch, N_("branch"),
 +                 N_("checkout <branch> instead of the remote's HEAD")),
 +      OPT_STRING('u', "upload-pack", &option_upload_pack, N_("path"),
 +                 N_("path to git-upload-pack on the remote")),
 +      OPT_STRING(0, "depth", &option_depth, N_("depth"),
 +                  N_("create a shallow clone of that depth")),
 +      OPT_BOOL(0, "single-branch", &option_single_branch,
 +                  N_("clone only one branch, HEAD or --branch")),
 +      OPT_STRING(0, "separate-git-dir", &real_git_dir, N_("gitdir"),
 +                 N_("separate git dir from working tree")),
 +      OPT_STRING_LIST('c', "config", &option_config, N_("key=value"),
 +                      N_("set config inside the new repository")),
        OPT_END()
  };
  
@@@ -107,7 -93,7 +107,7 @@@ static const char *argv_submodule[] = 
  
  static char *get_repo_path(const char *repo, int *is_bundle)
  {
 -      static char *suffix[] = { "/.git", ".git", "" };
 +      static char *suffix[] = { "/.git", "", ".git/.git", ".git" };
        static char *bundle_suffix[] = { ".bundle", "" };
        struct stat st;
        int i;
        for (i = 0; i < ARRAY_SIZE(suffix); i++) {
                const char *path;
                path = mkpath("%s%s", repo, suffix[i]);
 -              if (is_directory(path)) {
 +              if (stat(path, &st))
 +                      continue;
 +              if (S_ISDIR(st.st_mode) && is_git_directory(path)) {
                        *is_bundle = 0;
                        return xstrdup(absolute_path(path));
 +              } else if (S_ISREG(st.st_mode) && st.st_size > 8) {
 +                      /* Is it a "gitfile"? */
 +                      char signature[8];
 +                      int len, fd = open(path, O_RDONLY);
 +                      if (fd < 0)
 +                              continue;
 +                      len = read_in_full(fd, signature, 8);
 +                      close(fd);
 +                      if (len != 8 || strncmp(signature, "gitdir: ", 8))
 +                              continue;
 +                      path = read_gitfile(path);
 +                      if (path) {
 +                              *is_bundle = 0;
 +                              return xstrdup(absolute_path(path));
 +                      }
                }
        }
  
@@@ -228,69 -197,39 +228,69 @@@ static void strip_trailing_slashes(cha
        *end = '\0';
  }
  
 -static void setup_reference(const char *repo)
 +static int add_one_reference(struct string_list_item *item, void *cb_data)
  {
 -      const char *ref_git;
 -      char *ref_git_copy;
 -
 -      struct remote *remote;
 -      struct transport *transport;
 -      const struct ref *extra;
 -
 -      ref_git = real_path(option_reference);
 -
 -      if (is_directory(mkpath("%s/.git/objects", ref_git)))
 -              ref_git = mkpath("%s/.git", ref_git);
 -      else if (!is_directory(mkpath("%s/objects", ref_git)))
 -              die("reference repository '%s' is not a local directory.",
 -                  option_reference);
 -
 -      ref_git_copy = xstrdup(ref_git);
 -
 -      add_to_alternates_file(ref_git_copy);
 +      char *ref_git;
 +      struct strbuf alternate = STRBUF_INIT;
 +
 +      /* Beware: real_path() and mkpath() return static buffer */
 +      ref_git = xstrdup(real_path(item->string));
 +      if (is_directory(mkpath("%s/.git/objects", ref_git))) {
 +              char *ref_git_git = mkpathdup("%s/.git", ref_git);
 +              free(ref_git);
 +              ref_git = ref_git_git;
 +      } else if (!is_directory(mkpath("%s/objects", ref_git)))
 +              die(_("reference repository '%s' is not a local directory."),
 +                  item->string);
 +
 +      strbuf_addf(&alternate, "%s/objects", ref_git);
 +      add_to_alternates_file(alternate.buf);
 +      strbuf_release(&alternate);
 +      free(ref_git);
 +      return 0;
 +}
  
 -      remote = remote_get(ref_git_copy);
 -      transport = transport_get(remote, ref_git_copy);
 -      for (extra = transport_get_remote_refs(transport); extra;
 -           extra = extra->next)
 -              add_extra_ref(extra->name, extra->old_sha1, 0);
 +static void setup_reference(void)
 +{
 +      for_each_string_list(&option_reference, add_one_reference, NULL);
 +}
  
 -      transport_disconnect(transport);
 +static void copy_alternates(struct strbuf *src, struct strbuf *dst,
 +                          const char *src_repo)
 +{
 +      /*
 +       * Read from the source objects/info/alternates file
 +       * and copy the entries to corresponding file in the
 +       * destination repository with add_to_alternates_file().
 +       * Both src and dst have "$path/objects/info/alternates".
 +       *
 +       * Instead of copying bit-for-bit from the original,
 +       * we need to append to existing one so that the already
 +       * created entry via "clone -s" is not lost, and also
 +       * to turn entries with paths relative to the original
 +       * absolute, so that they can be used in the new repository.
 +       */
 +      FILE *in = fopen(src->buf, "r");
 +      struct strbuf line = STRBUF_INIT;
  
 -      free(ref_git_copy);
 +      while (strbuf_getline(&line, in, '\n') != EOF) {
 +              char *abs_path, abs_buf[PATH_MAX];
 +              if (!line.len || line.buf[0] == '#')
 +                      continue;
 +              if (is_absolute_path(line.buf)) {
 +                      add_to_alternates_file(line.buf);
 +                      continue;
 +              }
 +              abs_path = mkpath("%s/objects/%s", src_repo, line.buf);
 +              normalize_path_copy(abs_buf, abs_path);
 +              add_to_alternates_file(abs_buf);
 +      }
 +      strbuf_release(&line);
 +      fclose(in);
  }
  
 -static void copy_or_link_directory(struct strbuf *src, struct strbuf *dest)
 +static void copy_or_link_directory(struct strbuf *src, struct strbuf *dest,
 +                                 const char *src_repo, int src_baselen)
  {
        struct dirent *de;
        struct stat buf;
  
        dir = opendir(src->buf);
        if (!dir)
 -              die_errno("failed to open '%s'", src->buf);
 +              die_errno(_("failed to open '%s'"), src->buf);
  
        if (mkdir(dest->buf, 0777)) {
                if (errno != EEXIST)
 -                      die_errno("failed to create directory '%s'", dest->buf);
 +                      die_errno(_("failed to create directory '%s'"), dest->buf);
                else if (stat(dest->buf, &buf))
 -                      die_errno("failed to stat '%s'", dest->buf);
 +                      die_errno(_("failed to stat '%s'"), dest->buf);
                else if (!S_ISDIR(buf.st_mode))
 -                      die("%s exists and is not a directory", dest->buf);
 +                      die(_("%s exists and is not a directory"), dest->buf);
        }
  
        strbuf_addch(src, '/');
                strbuf_setlen(dest, dest_len);
                strbuf_addstr(dest, de->d_name);
                if (stat(src->buf, &buf)) {
 -                      warning ("failed to stat %s\n", src->buf);
 +                      warning (_("failed to stat %s\n"), src->buf);
                        continue;
                }
                if (S_ISDIR(buf.st_mode)) {
                        if (de->d_name[0] != '.')
 -                              copy_or_link_directory(src, dest);
 +                              copy_or_link_directory(src, dest,
 +                                                     src_repo, src_baselen);
 +                      continue;
 +              }
 +
 +              /* Files that cannot be copied bit-for-bit... */
 +              if (!strcmp(src->buf + src_baselen, "/info/alternates")) {
 +                      copy_alternates(src, dest, src_repo);
                        continue;
                }
  
                if (unlink(dest->buf) && errno != ENOENT)
 -                      die_errno("failed to unlink '%s'", dest->buf);
 +                      die_errno(_("failed to unlink '%s'"), dest->buf);
                if (!option_no_hardlinks) {
                        if (!link(src->buf, dest->buf))
                                continue;
 -                      if (option_local)
 -                              die_errno("failed to create link '%s'", dest->buf);
 +                      if (option_local > 0)
 +                              die_errno(_("failed to create link '%s'"), dest->buf);
                        option_no_hardlinks = 1;
                }
                if (copy_file_with_time(dest->buf, src->buf, 0666))
 -                      die_errno("failed to copy file to '%s'", dest->buf);
 +                      die_errno(_("failed to copy file to '%s'"), dest->buf);
        }
        closedir(dir);
  }
  
 -static const struct ref *clone_local(const char *src_repo,
 -                                   const char *dest_repo)
 +static void clone_local(const char *src_repo, const char *dest_repo)
  {
 -      const struct ref *ret;
 -      struct strbuf src = STRBUF_INIT;
 -      struct strbuf dest = STRBUF_INIT;
 -      struct remote *remote;
 -      struct transport *transport;
 -
 -      if (option_shared)
 -              add_to_alternates_file(src_repo);
 -      else {
 +      if (option_shared) {
 +              struct strbuf alt = STRBUF_INIT;
 +              strbuf_addf(&alt, "%s/objects", src_repo);
 +              add_to_alternates_file(alt.buf);
 +              strbuf_release(&alt);
 +      } else {
 +              struct strbuf src = STRBUF_INIT;
 +              struct strbuf dest = STRBUF_INIT;
                strbuf_addf(&src, "%s/objects", src_repo);
                strbuf_addf(&dest, "%s/objects", dest_repo);
 -              copy_or_link_directory(&src, &dest);
 +              copy_or_link_directory(&src, &dest, src_repo, src.len);
                strbuf_release(&src);
                strbuf_release(&dest);
        }
  
 -      remote = remote_get(src_repo);
 -      transport = transport_get(remote, src_repo);
 -      ret = transport_get_remote_refs(transport);
 -      transport_disconnect(transport);
        if (0 <= option_verbosity)
 -              printf("done.\n");
 -      return ret;
 +              printf(_("done.\n"));
  }
  
  static const char *junk_work_tree;
@@@ -401,57 -340,14 +401,57 @@@ static void remove_junk_on_signal(int s
        raise(signo);
  }
  
 +static struct ref *find_remote_branch(const struct ref *refs, const char *branch)
 +{
 +      struct ref *ref;
 +      struct strbuf head = STRBUF_INIT;
 +      strbuf_addstr(&head, "refs/heads/");
 +      strbuf_addstr(&head, branch);
 +      ref = find_ref_by_name(refs, head.buf);
 +      strbuf_release(&head);
 +
 +      if (ref)
 +              return ref;
 +
 +      strbuf_addstr(&head, "refs/tags/");
 +      strbuf_addstr(&head, branch);
 +      ref = find_ref_by_name(refs, head.buf);
 +      strbuf_release(&head);
 +
 +      return ref;
 +}
 +
  static struct ref *wanted_peer_refs(const struct ref *refs,
                struct refspec *refspec)
  {
 -      struct ref *local_refs = NULL;
 -      struct ref **tail = &local_refs;
 +      struct ref *head = copy_ref(find_ref_by_name(refs, "HEAD"));
 +      struct ref *local_refs = head;
 +      struct ref **tail = head ? &head->next : &local_refs;
 +
 +      if (option_single_branch) {
 +              struct ref *remote_head = NULL;
 +
 +              if (!option_branch)
 +                      remote_head = guess_remote_head(head, refs, 0);
 +              else {
 +                      local_refs = NULL;
 +                      tail = &local_refs;
 +                      remote_head = copy_ref(find_remote_branch(refs, option_branch));
 +              }
  
 -      get_fetch_map(refs, refspec, &tail, 0);
 -      if (!option_mirror)
 +              if (!remote_head && option_branch)
 +                      warning(_("Could not find remote branch %s to clone."),
 +                              option_branch);
 +              else {
 +                      get_fetch_map(remote_head, refspec, &tail, 0);
 +
 +                      /* if --branch=tag, pull the requested tag explicitly */
 +                      get_fetch_map(remote_head, tag_refspec, &tail, 0);
 +              }
 +      } else
 +              get_fetch_map(refs, refspec, &tail, 0);
 +
 +      if (!option_mirror && !option_single_branch)
                get_fetch_map(refs, tag_refspec, &tail, 0);
  
        return local_refs;
@@@ -461,201 -357,11 +461,201 @@@ static void write_remote_refs(const str
  {
        const struct ref *r;
  
 -      for (r = local_refs; r; r = r->next)
 -              add_extra_ref(r->peer_ref->name, r->old_sha1, 0);
 +      for (r = local_refs; r; r = r->next) {
 +              if (!r->peer_ref)
 +                      continue;
 +              add_packed_ref(r->peer_ref->name, r->old_sha1);
 +      }
  
        pack_refs(PACK_REFS_ALL);
 -      clear_extra_refs();
 +}
 +
 +static void write_followtags(const struct ref *refs, const char *msg)
 +{
 +      const struct ref *ref;
 +      for (ref = refs; ref; ref = ref->next) {
 +              if (prefixcmp(ref->name, "refs/tags/"))
 +                      continue;
 +              if (!suffixcmp(ref->name, "^{}"))
 +                      continue;
 +              if (!has_sha1_file(ref->old_sha1))
 +                      continue;
 +              update_ref(msg, ref->name, ref->old_sha1,
 +                         NULL, 0, DIE_ON_ERR);
 +      }
 +}
 +
 +static void update_remote_refs(const struct ref *refs,
 +                             const struct ref *mapped_refs,
 +                             const struct ref *remote_head_points_at,
 +                             const char *branch_top,
 +                             const char *msg)
 +{
 +      if (refs) {
 +              write_remote_refs(mapped_refs);
 +              if (option_single_branch)
 +                      write_followtags(refs, msg);
 +      }
 +
 +      if (remote_head_points_at && !option_bare) {
 +              struct strbuf head_ref = STRBUF_INIT;
 +              strbuf_addstr(&head_ref, branch_top);
 +              strbuf_addstr(&head_ref, "HEAD");
 +              create_symref(head_ref.buf,
 +                            remote_head_points_at->peer_ref->name,
 +                            msg);
 +      }
 +}
 +
 +static void update_head(const struct ref *our, const struct ref *remote,
 +                      const char *msg)
 +{
 +      if (our && !prefixcmp(our->name, "refs/heads/")) {
 +              /* Local default branch link */
 +              create_symref("HEAD", our->name, NULL);
 +              if (!option_bare) {
 +                      const char *head = skip_prefix(our->name, "refs/heads/");
 +                      update_ref(msg, "HEAD", our->old_sha1, NULL, 0, DIE_ON_ERR);
 +                      install_branch_config(0, head, option_origin, our->name);
 +              }
 +      } else if (our) {
 +              struct commit *c = lookup_commit_reference(our->old_sha1);
 +              /* --branch specifies a non-branch (i.e. tags), detach HEAD */
 +              update_ref(msg, "HEAD", c->object.sha1,
 +                         NULL, REF_NODEREF, DIE_ON_ERR);
 +      } else if (remote) {
 +              /*
 +               * We know remote HEAD points to a non-branch, or
 +               * HEAD points to a branch but we don't know which one.
 +               * Detach HEAD in all these cases.
 +               */
 +              update_ref(msg, "HEAD", remote->old_sha1,
 +                         NULL, REF_NODEREF, DIE_ON_ERR);
 +      }
 +}
 +
 +static int checkout(void)
 +{
 +      unsigned char sha1[20];
 +      char *head;
 +      struct lock_file *lock_file;
 +      struct unpack_trees_options opts;
 +      struct tree *tree;
 +      struct tree_desc t;
 +      int err = 0, fd;
 +
 +      if (option_no_checkout)
 +              return 0;
 +
 +      head = resolve_refdup("HEAD", sha1, 1, NULL);
 +      if (!head) {
 +              warning(_("remote HEAD refers to nonexistent ref, "
 +                        "unable to checkout.\n"));
 +              return 0;
 +      }
 +      if (!strcmp(head, "HEAD")) {
 +              if (advice_detached_head)
 +                      detach_advice(sha1_to_hex(sha1));
 +      } else {
 +              if (prefixcmp(head, "refs/heads/"))
 +                      die(_("HEAD not found below refs/heads!"));
 +      }
 +      free(head);
 +
 +      /* We need to be in the new work tree for the checkout */
 +      setup_work_tree();
 +
 +      lock_file = xcalloc(1, sizeof(struct lock_file));
 +      fd = hold_locked_index(lock_file, 1);
 +
 +      memset(&opts, 0, sizeof opts);
 +      opts.update = 1;
 +      opts.merge = 1;
 +      opts.fn = oneway_merge;
 +      opts.verbose_update = (option_verbosity >= 0);
 +      opts.src_index = &the_index;
 +      opts.dst_index = &the_index;
 +
 +      tree = parse_tree_indirect(sha1);
 +      parse_tree(tree);
 +      init_tree_desc(&t, tree->buffer, tree->size);
 +      unpack_trees(1, &t, &opts);
 +
 +      if (write_cache(fd, active_cache, active_nr) ||
 +          commit_locked_index(lock_file))
 +              die(_("unable to write new index file"));
 +
 +      err |= run_hook(NULL, "post-checkout", sha1_to_hex(null_sha1),
 +                      sha1_to_hex(sha1), "1", NULL);
 +
 +      if (!err && option_recursive)
 +              err = run_command_v_opt(argv_submodule, RUN_GIT_CMD);
 +
 +      return err;
 +}
 +
 +static int write_one_config(const char *key, const char *value, void *data)
 +{
 +      return git_config_set_multivar(key, value ? value : "true", "^$", 0);
 +}
 +
 +static void write_config(struct string_list *config)
 +{
 +      int i;
 +
 +      for (i = 0; i < config->nr; i++) {
 +              if (git_config_parse_parameter(config->items[i].string,
 +                                             write_one_config, NULL) < 0)
 +                      die("unable to write parameters to config file");
 +      }
 +}
 +
 +static void write_refspec_config(const char* src_ref_prefix,
 +              const struct ref* our_head_points_at,
 +              const struct ref* remote_head_points_at, struct strbuf* branch_top)
 +{
 +      struct strbuf key = STRBUF_INIT;
 +      struct strbuf value = STRBUF_INIT;
 +
 +      if (option_mirror || !option_bare) {
 +              if (option_single_branch && !option_mirror) {
 +                      if (option_branch) {
 +                              if (strstr(our_head_points_at->name, "refs/tags/"))
 +                                      strbuf_addf(&value, "+%s:%s", our_head_points_at->name,
 +                                              our_head_points_at->name);
 +                              else
 +                                      strbuf_addf(&value, "+%s:%s%s", our_head_points_at->name,
 +                                              branch_top->buf, option_branch);
 +                      } else if (remote_head_points_at) {
 +                              strbuf_addf(&value, "+%s:%s%s", remote_head_points_at->name,
 +                                              branch_top->buf,
 +                                              skip_prefix(remote_head_points_at->name, "refs/heads/"));
 +                      }
 +                      /*
 +                       * otherwise, the next "git fetch" will
 +                       * simply fetch from HEAD without updating
 +                       * any remote tracking branch, which is what
 +                       * we want.
 +                       */
 +              } else {
 +                      strbuf_addf(&value, "+%s*:%s*", src_ref_prefix, branch_top->buf);
 +              }
 +              /* Configure the remote */
 +              if (value.len) {
 +                      strbuf_addf(&key, "remote.%s.fetch", option_origin);
 +                      git_config_set_multivar(key.buf, value.buf, "^$", 0);
 +                      strbuf_reset(&key);
 +
 +                      if (option_mirror) {
 +                              strbuf_addf(&key, "remote.%s.mirror", option_origin);
 +                              git_config_set(key.buf, "true");
 +                              strbuf_reset(&key);
 +                      }
 +              }
 +      }
 +
 +      strbuf_release(&key);
 +      strbuf_release(&value);
  }
  
  int cmd_clone(int argc, const char **argv, const char *prefix)
        const struct ref *remote_head_points_at;
        const struct ref *our_head_points_at;
        struct ref *mapped_refs;
 +      const struct ref *ref;
        struct strbuf key = STRBUF_INIT, value = STRBUF_INIT;
        struct strbuf branch_top = STRBUF_INIT, reflog_msg = STRBUF_INIT;
        struct transport *transport = NULL;
 -      char *src_ref_prefix = "refs/heads/";
 -      int err = 0;
 +      const char *src_ref_prefix = "refs/heads/";
 +      struct remote *remote;
 +      int err = 0, complete_refs_before_fetch = 1;
  
        struct refspec *refspec;
        const char *fetch_pattern;
  
        junk_pid = getpid();
  
 +      packet_trace_identity("clone");
        argc = parse_options(argc, argv, prefix, builtin_clone_options,
                             builtin_clone_usage, 0);
  
        if (argc > 2)
 -              usage_msg_opt("Too many arguments.",
 +              usage_msg_opt(_("Too many arguments."),
                        builtin_clone_usage, builtin_clone_options);
  
        if (argc == 0)
 -              usage_msg_opt("You must specify a repository to clone.",
 +              usage_msg_opt(_("You must specify a repository to clone."),
                        builtin_clone_usage, builtin_clone_options);
  
 +      if (option_single_branch == -1)
 +              option_single_branch = option_depth ? 1 : 0;
 +
        if (option_mirror)
                option_bare = 1;
  
        if (option_bare) {
                if (option_origin)
 -                      die("--bare and --origin %s options are incompatible.",
 +                      die(_("--bare and --origin %s options are incompatible."),
                            option_origin);
                option_no_checkout = 1;
        }
        if (path)
                repo = xstrdup(absolute_path(repo_name));
        else if (!strchr(repo_name, ':'))
 -              die("repository '%s' does not exist", repo_name);
 +              die(_("repository '%s' does not exist"), repo_name);
        else
                repo = repo_name;
 -      is_local = path && !is_bundle;
 +      is_local = option_local != 0 && path && !is_bundle;
        if (is_local && option_depth)
 -              warning("--depth is ignored in local clones; use file:// instead.");
 +              warning(_("--depth is ignored in local clones; use file:// instead."));
  
        if (argc == 2)
                dir = xstrdup(argv[1]);
  
        dest_exists = !stat(dir, &buf);
        if (dest_exists && !is_empty_dir(dir))
 -              die("destination path '%s' already exists and is not "
 -                      "an empty directory.", dir);
 +              die(_("destination path '%s' already exists and is not "
 +                      "an empty directory."), dir);
  
        strbuf_addf(&reflog_msg, "clone: from %s", repo);
  
        else {
                work_tree = getenv("GIT_WORK_TREE");
                if (work_tree && !stat(work_tree, &buf))
 -                      die("working tree '%s' already exists.", work_tree);
 +                      die(_("working tree '%s' already exists."), work_tree);
        }
  
        if (option_bare || work_tree)
                git_dir = xstrdup(dir);
        else {
                work_tree = dir;
 -              git_dir = xstrdup(mkpath("%s/.git", dir));
 +              git_dir = mkpathdup("%s/.git", dir);
        }
  
        if (!option_bare) {
                junk_work_tree = work_tree;
                if (safe_create_leading_directories_const(work_tree) < 0)
 -                      die_errno("could not create leading directories of '%s'",
 +                      die_errno(_("could not create leading directories of '%s'"),
                                  work_tree);
 -              if (!dest_exists && mkdir(work_tree, 0755))
 -                      die_errno("could not create work tree dir '%s'.",
 +              if (!dest_exists && mkdir(work_tree, 0777))
 +                      die_errno(_("could not create work tree dir '%s'."),
                                  work_tree);
                set_git_work_tree(work_tree);
        }
        setenv(CONFIG_ENVIRONMENT, mkpath("%s/config", git_dir), 1);
  
        if (safe_create_leading_directories_const(git_dir) < 0)
 -              die("could not create leading directories of '%s'", git_dir);
 +              die(_("could not create leading directories of '%s'"), git_dir);
  
        set_git_dir_init(git_dir, real_git_dir, 0);
-       if (real_git_dir)
+       if (real_git_dir) {
                git_dir = real_git_dir;
+               junk_git_dir = real_git_dir;
+       }
  
 -      if (0 <= option_verbosity)
 -              printf("Cloning into %s%s...\n",
 -                     option_bare ? "bare repository " : "", dir);
 +      if (0 <= option_verbosity) {
 +              if (option_bare)
 +                      printf(_("Cloning into bare repository '%s'...\n"), dir);
 +              else
 +                      printf(_("Cloning into '%s'...\n"), dir);
 +      }
        init_db(option_template, INIT_DB_QUIET);
 +      write_config(&option_config);
  
        /*
         * At this point, the config exists, so we do not need the
        }
  
        strbuf_addf(&value, "+%s*:%s*", src_ref_prefix, branch_top.buf);
 -
 -      if (option_mirror || !option_bare) {
 -              /* Configure the remote */
 -              strbuf_addf(&key, "remote.%s.fetch", option_origin);
 -              git_config_set_multivar(key.buf, value.buf, "^$", 0);
 -              strbuf_reset(&key);
 -
 -              if (option_mirror) {
 -                      strbuf_addf(&key, "remote.%s.mirror", option_origin);
 -                      git_config_set(key.buf, "true");
 -                      strbuf_reset(&key);
 -              }
 -      }
 -
        strbuf_addf(&key, "remote.%s.url", option_origin);
        git_config_set(key.buf, repo);
        strbuf_reset(&key);
  
 -      if (option_reference)
 -              setup_reference(git_dir);
 +      if (option_reference.nr)
 +              setup_reference();
  
        fetch_pattern = value.buf;
        refspec = parse_fetch_refspec(1, &fetch_pattern);
  
        strbuf_reset(&value);
  
 -      if (is_local) {
 -              refs = clone_local(path, git_dir);
 -              mapped_refs = wanted_peer_refs(refs, refspec);
 -      } else {
 -              struct remote *remote = remote_get(option_origin);
 -              transport = transport_get(remote, remote->url[0]);
 +      remote = remote_get(option_origin);
 +      transport = transport_get(remote, remote->url[0]);
  
 +      if (!is_local) {
                if (!transport->get_refs_list || !transport->fetch)
 -                      die("Don't know how to clone %s", transport->url);
 +                      die(_("Don't know how to clone %s"), transport->url);
  
                transport_set_option(transport, TRANS_OPT_KEEP, "yes");
  
                if (option_depth)
                        transport_set_option(transport, TRANS_OPT_DEPTH,
                                             option_depth);
 +              if (option_single_branch)
 +                      transport_set_option(transport, TRANS_OPT_FOLLOWTAGS, "1");
  
                transport_set_verbosity(transport, option_verbosity, option_progress);
  
                if (option_upload_pack)
                        transport_set_option(transport, TRANS_OPT_UPLOADPACK,
                                             option_upload_pack);
 -
 -              refs = transport_get_remote_refs(transport);
 -              if (refs) {
 -                      mapped_refs = wanted_peer_refs(refs, refspec);
 -                      transport_fetch_refs(transport, mapped_refs);
 -              }
        }
  
 +      refs = transport_get_remote_refs(transport);
 +
        if (refs) {
 -              clear_extra_refs();
 +              mapped_refs = wanted_peer_refs(refs, refspec);
 +              /*
 +               * transport_get_remote_refs() may return refs with null sha-1
 +               * in mapped_refs (see struct transport->get_refs_list
 +               * comment). In that case we need fetch it early because
 +               * remote_head code below relies on it.
 +               *
 +               * for normal clones, transport_get_remote_refs() should
 +               * return reliable ref set, we can delay cloning until after
 +               * remote HEAD check.
 +               */
 +              for (ref = refs; ref; ref = ref->next)
 +                      if (is_null_sha1(ref->old_sha1)) {
 +                              complete_refs_before_fetch = 0;
 +                              break;
 +                      }
  
 -              write_remote_refs(mapped_refs);
 +              if (!is_local && !complete_refs_before_fetch)
 +                      transport_fetch_refs(transport, mapped_refs);
  
                remote_head = find_ref_by_name(refs, "HEAD");
                remote_head_points_at =
                        guess_remote_head(remote_head, mapped_refs, 0);
  
                if (option_branch) {
 -                      struct strbuf head = STRBUF_INIT;
 -                      strbuf_addstr(&head, src_ref_prefix);
 -                      strbuf_addstr(&head, option_branch);
                        our_head_points_at =
 -                              find_ref_by_name(mapped_refs, head.buf);
 -                      strbuf_release(&head);
 -
 -                      if (!our_head_points_at) {
 -                              warning("Remote branch %s not found in "
 -                                      "upstream %s, using HEAD instead",
 -                                      option_branch, option_origin);
 -                              our_head_points_at = remote_head_points_at;
 -                      }
 +                              find_remote_branch(mapped_refs, option_branch);
 +
 +                      if (!our_head_points_at)
 +                              die(_("Remote branch %s not found in upstream %s"),
 +                                  option_branch, option_origin);
                }
                else
                        our_head_points_at = remote_head_points_at;
        }
        else {
 -              warning("You appear to have cloned an empty repository.");
 +              warning(_("You appear to have cloned an empty repository."));
 +              mapped_refs = NULL;
                our_head_points_at = NULL;
                remote_head_points_at = NULL;
                remote_head = NULL;
                                              "refs/heads/master");
        }
  
 -      if (remote_head_points_at && !option_bare) {
 -              struct strbuf head_ref = STRBUF_INIT;
 -              strbuf_addstr(&head_ref, branch_top.buf);
 -              strbuf_addstr(&head_ref, "HEAD");
 -              create_symref(head_ref.buf,
 -                            remote_head_points_at->peer_ref->name,
 -                            reflog_msg.buf);
 -      }
 +      write_refspec_config(src_ref_prefix, our_head_points_at,
 +                      remote_head_points_at, &branch_top);
  
 -      if (our_head_points_at) {
 -              /* Local default branch link */
 -              create_symref("HEAD", our_head_points_at->name, NULL);
 -              if (!option_bare) {
 -                      const char *head = skip_prefix(our_head_points_at->name,
 -                                                     "refs/heads/");
 -                      update_ref(reflog_msg.buf, "HEAD",
 -                                 our_head_points_at->old_sha1,
 -                                 NULL, 0, DIE_ON_ERR);
 -                      install_branch_config(0, head, option_origin,
 -                                            our_head_points_at->name);
 -              }
 -      } else if (remote_head) {
 -              /* Source had detached HEAD pointing somewhere. */
 -              if (!option_bare) {
 -                      update_ref(reflog_msg.buf, "HEAD",
 -                                 remote_head->old_sha1,
 -                                 NULL, REF_NODEREF, DIE_ON_ERR);
 -                      our_head_points_at = remote_head;
 -              }
 -      } else {
 -              /* Nothing to checkout out */
 -              if (!option_no_checkout)
 -                      warning("remote HEAD refers to nonexistent ref, "
 -                              "unable to checkout.\n");
 -              option_no_checkout = 1;
 -      }
 +      if (is_local)
 +              clone_local(path, git_dir);
 +      else if (refs && complete_refs_before_fetch)
 +              transport_fetch_refs(transport, mapped_refs);
  
 -      if (transport) {
 -              transport_unlock_pack(transport);
 -              transport_disconnect(transport);
 -      }
 +      update_remote_refs(refs, mapped_refs, remote_head_points_at,
 +                         branch_top.buf, reflog_msg.buf);
  
 -      if (!option_no_checkout) {
 -              struct lock_file *lock_file = xcalloc(1, sizeof(struct lock_file));
 -              struct unpack_trees_options opts;
 -              struct tree *tree;
 -              struct tree_desc t;
 -              int fd;
 -
 -              /* We need to be in the new work tree for the checkout */
 -              setup_work_tree();
 -
 -              fd = hold_locked_index(lock_file, 1);
 -
 -              memset(&opts, 0, sizeof opts);
 -              opts.update = 1;
 -              opts.merge = 1;
 -              opts.fn = oneway_merge;
 -              opts.verbose_update = (option_verbosity > 0);
 -              opts.src_index = &the_index;
 -              opts.dst_index = &the_index;
 -
 -              tree = parse_tree_indirect(our_head_points_at->old_sha1);
 -              parse_tree(tree);
 -              init_tree_desc(&t, tree->buffer, tree->size);
 -              unpack_trees(1, &t, &opts);
 -
 -              if (write_cache(fd, active_cache, active_nr) ||
 -                  commit_locked_index(lock_file))
 -                      die("unable to write new index file");
 -
 -              err |= run_hook(NULL, "post-checkout", sha1_to_hex(null_sha1),
 -                              sha1_to_hex(our_head_points_at->old_sha1), "1",
 -                              NULL);
 -
 -              if (!err && option_recursive)
 -                      err = run_command_v_opt(argv_submodule, RUN_GIT_CMD);
 -      }
 +      update_head(our_head_points_at, remote_head, reflog_msg.buf);
 +
 +      transport_unlock_pack(transport);
 +      transport_disconnect(transport);
 +
 +      err = checkout();
  
        strbuf_release(&reflog_msg);
        strbuf_release(&branch_top);