krb5.git
15 years agoCoding Style related fixes
Zhanna Tsitkov [Wed, 25 Nov 2009 19:03:29 +0000 (19:03 +0000)]
Coding Style related fixes

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23356 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5_db2_db_init, make a format string constant to make Coverity
Greg Hudson [Wed, 25 Nov 2009 14:36:05 +0000 (14:36 +0000)]
In krb5_db2_db_init, make a format string constant to make Coverity
happy.  (Previously it was a disjunction of two constants, which is
fine, but not as obviously safe to a static analysis tool.)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23355 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMark and reindent the pkinit plugin code, except for the header files
Greg Hudson [Wed, 25 Nov 2009 00:23:57 +0000 (00:23 +0000)]
Mark and reindent the pkinit plugin code, except for the header files
which are kind of difficult.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23354 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMark and reindent plugins, except for pkinit, which needs a little
Greg Hudson [Tue, 24 Nov 2009 23:52:25 +0000 (23:52 +0000)]
Mark and reindent plugins, except for pkinit, which needs a little
cleanup first.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23353 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove krb5_ prefix from the name of the static func get_as_key_keytab. Reindent
Zhanna Tsitkov [Tue, 24 Nov 2009 21:08:00 +0000 (21:08 +0000)]
Remove krb5_ prefix from the name of the static func get_as_key_keytab. Reindent

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23352 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMark and reindent what's left of the appl directory
Greg Hudson [Tue, 24 Nov 2009 17:46:45 +0000 (17:46 +0000)]
Mark and reindent what's left of the appl directory

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23342 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove appl man pages from the list of pages to convert in the doc
Greg Hudson [Tue, 24 Nov 2009 15:43:16 +0000 (15:43 +0000)]
Remove appl man pages from the list of pages to convert in the doc
build system.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23341 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix boilerplate in zap.c
Greg Hudson [Tue, 24 Nov 2009 03:11:22 +0000 (03:11 +0000)]
Fix boilerplate in zap.c

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23340 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPunt the volatile cast in the non-gcc, non-Windows version of zap.
Greg Hudson [Tue, 24 Nov 2009 01:25:10 +0000 (01:25 +0000)]
Punt the volatile cast in the non-gcc, non-Windows version of zap.
Use a function call into libkrb5support instead, since that's hard to
inline.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23339 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoKDC MUST NOT accept ap-request armor in FAST TGS
Sam Hartman [Tue, 24 Nov 2009 01:05:30 +0000 (01:05 +0000)]
KDC MUST NOT accept ap-request armor in FAST TGS

Per the latest preauth framework spec, the working group has decided
to forbid ap-request armor in the TGS request because of security
problems with that armor type.

This commit was tested against an implementation of FAST TGS client to
confirm that if explicit armor is sent, the request is rejected.

ticket: 6585
target_version: 1.7.1
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23325 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoExpand comments around 'zap' code
Ken Raeburn [Tue, 24 Nov 2009 00:03:19 +0000 (00:03 +0000)]
Expand comments around 'zap' code

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23319 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoSimplify depfix.pl by assuming that all files outside of the source
Greg Hudson [Mon, 23 Nov 2009 20:52:16 +0000 (20:52 +0000)]
Simplify depfix.pl by assuming that all files outside of the source
and build directory (after substitutions) are external headers which
should not be tracked.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23314 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCheck return value of gethostname in krb5_klog_init
Greg Hudson [Mon, 23 Nov 2009 19:24:42 +0000 (19:24 +0000)]
Check return value of gethostname in krb5_klog_init

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23313 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMake zap() work with non-gcc C++ compilers.
Greg Hudson [Sun, 22 Nov 2009 19:11:53 +0000 (19:11 +0000)]
Make zap() work with non-gcc C++ compilers.
Eliminate the intermediate name krb5int_zap_data.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23311 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove discussion of the unbundled applications from the install
Greg Hudson [Sun, 22 Nov 2009 18:44:46 +0000 (18:44 +0000)]
Remove discussion of the unbundled applications from the install
guide.

ticket: 6583

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23310 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUpdate the build system documentation:
Greg Hudson [Sun, 22 Nov 2009 18:20:36 +0000 (18:20 +0000)]
Update the build system documentation:
  * The test suite no longer requires root.
  * appl no longer contains what it used to contain.
  * Mention --disable-rpath as an alternative for make check.

ticket: 6583
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23309 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoConsolidate Makefile variables now that we have only a single global
Greg Hudson [Sun, 22 Nov 2009 18:13:29 +0000 (18:13 +0000)]
Consolidate Makefile variables now that we have only a single global
configure script:
    $(SRCTOP) --> $(top_srcdir)
    $(srcdir)/$(thisconfigdir) --> $(top_srcdir)
    $(thisconfigdir) --> $(BUILDTOP)
    $(myfulldir) --> $(mydir)

ticket: 6583
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23308 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove functions from aclocal.m4 which are no longer needed now that
Greg Hudson [Sun, 22 Nov 2009 17:00:45 +0000 (17:00 +0000)]
Remove functions from aclocal.m4 which are no longer needed now that
the applications are unbundled.

ticket: 6583
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23306 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUnbundle applications into separate repository
Greg Hudson [Sun, 22 Nov 2009 14:58:54 +0000 (14:58 +0000)]
Unbundle applications into separate repository

Remove libpty, gssftp, telnet, and the bsd applications from the
source tree, build system, and tests.

Docs still need to be updated to remove mentions of the applications.
The build system should be simplified now that we're down to one
configure script and don't need some of the functionality currently in
aclocal.m4.

ticket: 6583
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23305 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn _kadm5_init_any on error - if we created a cache entry, destroy it
Ezra Peisach [Sun, 22 Nov 2009 04:54:47 +0000 (04:54 +0000)]
In _kadm5_init_any on error - if we created a cache entry, destroy it
(parallel to kadm5_destroy code). Also - free config_params.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23300 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoClean up some memory leaks by releasing context
Ezra Peisach [Sun, 22 Nov 2009 04:26:48 +0000 (04:26 +0000)]
Clean up some memory leaks by releasing context

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23299 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFor the moment, test for nullity of pointers returned by k5alloc
Greg Hudson [Sat, 21 Nov 2009 23:08:03 +0000 (23:08 +0000)]
For the moment, test for nullity of pointers returned by k5alloc
instead of result codes, to make Coverity happy.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23298 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMemory leak in _kadm5_init_any introduced with ipropd
Ezra Peisach [Sat, 21 Nov 2009 04:50:55 +0000 (04:50 +0000)]
Memory leak in _kadm5_init_any introduced with ipropd

Fix minor memory leak introduced by the ipropd integration.

ticket: 6582

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23296 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCorrect argument to kadm5_get_principal is a pointer to a struct - not
Ezra Peisach [Fri, 20 Nov 2009 20:55:34 +0000 (20:55 +0000)]
Correct argument to kadm5_get_principal is a pointer to a struct - not
a pointer to a pointer.... Does not really matter as the field is not used -
this test program expects a failer.

Clean up memory leaks by freeing principal and releasing context.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23295 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoThe size of kadm5_server_handle_rec differs between the client and
Ezra Peisach [Fri, 20 Nov 2009 03:42:40 +0000 (03:42 +0000)]
The size of kadm5_server_handle_rec differs between the client and
server code. Valgrind picked up on access past end of allocated
structure.  Include proper internal header in client/server test.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23294 dc483132-0cff-0310-8789-dd5450dbe970

15 years agokrb5_free_ad_signedpath must free outer structure
Luke Howard [Thu, 19 Nov 2009 21:59:23 +0000 (21:59 +0000)]
krb5_free_ad_signedpath must free outer structure

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23293 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPut krb5_auth_con_set_req_cksumtype back in the public API, since it
Greg Hudson [Thu, 19 Nov 2009 16:27:47 +0000 (16:27 +0000)]
Put krb5_auth_con_set_req_cksumtype back in the public API, since it
is needed by the BSD applications which will be unbundled in 1.8.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23292 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMinor reindent fix
Zhanna Tsitkov [Wed, 18 Nov 2009 16:38:24 +0000 (16:38 +0000)]
Minor reindent fix

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23287 dc483132-0cff-0310-8789-dd5450dbe970

15 years agominor reindent
Zhanna Tsitkov [Wed, 18 Nov 2009 15:55:02 +0000 (15:55 +0000)]
minor reindent

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23286 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRework using "do { } while (0)" in macro bodies to avoid divergent
Tom Yu [Tue, 17 Nov 2009 01:21:31 +0000 (01:21 +0000)]
Rework using "do { } while (0)" in macro bodies to avoid divergent
emacs-22 vs emacs-23 indentation.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23252 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoClean up some open-parenthesis problems, and reindent
Tom Yu [Mon, 16 Nov 2009 22:32:40 +0000 (22:32 +0000)]
Clean up some open-parenthesis problems, and reindent

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23246 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoTypo fix
Zhanna Tsitkov [Mon, 16 Nov 2009 18:09:26 +0000 (18:09 +0000)]
Typo fix

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23238 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove unreferred krb5int_keyhash_aescbc_xxx. Cleaner krb5int_keyhash_md5_hmac init
Zhanna Tsitkov [Mon, 16 Nov 2009 17:30:09 +0000 (17:30 +0000)]
Remove unreferred krb5int_keyhash_aescbc_xxx. Cleaner krb5int_keyhash_md5_hmac init

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23237 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix coding style in lib/krb5/asn.1, remove from exclusions, and
Tom Yu [Mon, 16 Nov 2009 16:48:37 +0000 (16:48 +0000)]
Fix coding style in lib/krb5/asn.1, remove from exclusions, and
reindent.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23236 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMove prototypes for krb5int_send_tgs and krb5int_decode_tgs_rep to int-proto.h.
Ezra Peisach [Mon, 16 Nov 2009 01:49:21 +0000 (01:49 +0000)]
Move prototypes for krb5int_send_tgs and krb5int_decode_tgs_rep to int-proto.h.
These functions are not exported by the library.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23232 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMove krb5int_get_fq_local_hostname to os-proto.h. Not exported
Ezra Peisach [Sun, 15 Nov 2009 01:38:41 +0000 (01:38 +0000)]
Move krb5int_get_fq_local_hostname to os-proto.h.  Not exported

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23188 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMoved krb5int_sendto prototype to os-proto.h. This function is not exported
Ezra Peisach [Sun, 15 Nov 2009 00:51:21 +0000 (00:51 +0000)]
Moved krb5int_sendto prototype to os-proto.h.  This function is not exported
from libkrb5 - so the rest of the world does not need to see it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23186 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd an exception for include/iprop.h and revert its reformatting,
Greg Hudson [Sun, 15 Nov 2009 00:19:36 +0000 (00:19 +0000)]
Add an exception for include/iprop.h and revert its reformatting,
since it was generated with rpcgen.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23185 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix typos in previous
Tom Yu [Sat, 14 Nov 2009 19:24:39 +0000 (19:24 +0000)]
Fix typos in previous

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23182 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReindent include directory, reformatting prototypes as necessary.
Greg Hudson [Sat, 14 Nov 2009 18:56:43 +0000 (18:56 +0000)]
Reindent include directory, reformatting prototypes as necessary.
Exclude include/gssrpc due to its Sun origin and k5-platform.h due to
macros too hairy for emacs c-mode to handle.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23180 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove include/krb54proto.h as it is no longer used
Greg Hudson [Sat, 14 Nov 2009 15:24:56 +0000 (15:24 +0000)]
Remove include/krb54proto.h as it is no longer used

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23163 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoConstrained delegation without PAC support
Greg Hudson [Sat, 14 Nov 2009 04:46:30 +0000 (04:46 +0000)]
Constrained delegation without PAC support

Merge Luke's users/lhoward/s4u2proxy branch to trunk.  Implements a
Heimdal-compatible mechanism for allowing constrained delegation
without back-end support for PACs.  Back-end support exists in LDAP
only (via a new krbAllowedToDelegateTo attribute), not DB2.

ticket: 6580

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23160 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/rcache, ensure that function definition headers put the
Greg Hudson [Fri, 13 Nov 2009 00:28:30 +0000 (00:28 +0000)]
In lib/krb5/rcache, ensure that function definition headers put the
function name at the beginning of the line.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23157 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoTypo fix
Zhanna Tsitkov [Thu, 12 Nov 2009 20:22:53 +0000 (20:22 +0000)]
Typo fix

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23154 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPost-great-reindent check. Part II
Zhanna Tsitkov [Thu, 12 Nov 2009 20:17:34 +0000 (20:17 +0000)]
Post-great-reindent check. Part II

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23153 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRestore the local variable type
Zhanna Tsitkov [Thu, 12 Nov 2009 19:31:33 +0000 (19:31 +0000)]
Restore the local variable type

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23152 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPost-great-reindent check. Part I
Zhanna Tsitkov [Thu, 12 Nov 2009 19:12:51 +0000 (19:12 +0000)]
Post-great-reindent check. Part I

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23151 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFor iprop test, reduce expected attribute change count to reflect the three
Luke Howard [Wed, 11 Nov 2009 12:04:27 +0000 (12:04 +0000)]
For iprop test, reduce expected attribute change count to reflect the three
non-replicated attributes: last_success, last_failed and fail_auth_count.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23149 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/keytab, ensure that function definition headers have
Greg Hudson [Tue, 10 Nov 2009 19:59:39 +0000 (19:59 +0000)]
In lib/krb5/keytab, ensure that function definition headers have
function names at the beginning of lines, and avoid putting open
parentheses at the beginning of lines in function prototypes.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23148 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove the unnecessary src/lib/glue4.c
Greg Hudson [Tue, 10 Nov 2009 18:40:10 +0000 (18:40 +0000)]
Remove the unnecessary src/lib/glue4.c

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23147 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove src/lib/crypto/krb/enc_provider, which was accidentally
Greg Hudson [Tue, 10 Nov 2009 16:57:27 +0000 (16:57 +0000)]
Remove src/lib/crypto/krb/enc_provider, which was accidentally
resurrected (again) in r22875 when merging the authdata branch to the
trunk.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23146 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRevise patch to avoid using changequote
Ken Raeburn [Mon, 9 Nov 2009 16:56:01 +0000 (16:56 +0000)]
Revise patch to avoid using changequote

ticket: 6579

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23145 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoquoting bug causes solaris pre-10 thread handling bugs
Ken Raeburn [Mon, 9 Nov 2009 06:13:34 +0000 (06:13 +0000)]
quoting bug causes solaris pre-10 thread handling bugs

Quoting problems in pattern matching on the OS name cause Solaris
versions up through 9 to not be properly recognized in the
thread-system configuration setup.  This causes our libraries to make
the erroneous assumption that valid thread support routines are
available on all Solaris systems, rather than just assuming it for
Solaris 10 and later.

The result is assertion failures like this one reported by Meraj
Mohammed and others:

  Assertion failed: k5int_i->did_run != 0, file krb5_libinit.c, line 63

Thanks to Tom Shaw for noticing the cause of the problem.

The bug may be present in the 1.6.x series as well.

ticket: 6579
target_version: 1.7.1
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23144 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDon't flush stdout so much. Calculate and display some more averages
Ken Raeburn [Sat, 7 Nov 2009 00:14:37 +0000 (00:14 +0000)]
Don't flush stdout so much.  Calculate and display some more averages

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23142 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDelay start of test until the start of a new second on the system
Ken Raeburn [Sat, 7 Nov 2009 00:14:33 +0000 (00:14 +0000)]
Delay start of test until the start of a new second on the system
clock.  Print per-thread stats only once.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23141 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReformat some open-paren issues. Remove kprop.c and kpropd.c from
Tom Yu [Fri, 6 Nov 2009 23:29:12 +0000 (23:29 +0000)]
Reformat some open-paren issues.  Remove kprop.c and kpropd.c from
exclusions.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23140 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoChange INIT_ONCE compile-time flag into a run-time option. Delete
Ken Raeburn [Fri, 6 Nov 2009 20:17:00 +0000 (20:17 +0000)]
Change INIT_ONCE compile-time flag into a run-time option.  Delete
DIRECT support; always create threads.  Allow setting of test interval
and number of threads via run-time options.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23139 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDon't start by attempting to unlink replay caches by guessing
Ken Raeburn [Fri, 6 Nov 2009 20:16:57 +0000 (20:16 +0000)]
Don't start by attempting to unlink replay caches by guessing
pathnames specific to my uid on MIT Athena systems.  Instead, create a
replay cache object and then destroy it through the library.  Tweak
the rcache-init-error messages to be specific to the instance that
failed.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23138 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUse krb5_get_error_message for reporting if krb5_get_server_rcache fails
Ken Raeburn [Fri, 6 Nov 2009 20:16:53 +0000 (20:16 +0000)]
Use krb5_get_error_message for reporting if krb5_get_server_rcache fails

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23137 dc483132-0cff-0310-8789-dd5450dbe970

15 years agomake mark-cstyle; make reindent
Tom Yu [Fri, 6 Nov 2009 19:45:29 +0000 (19:45 +0000)]
make mark-cstyle; make reindent

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23136 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd slave/ to INDENTDIRS, with some exclusions
Tom Yu [Fri, 6 Nov 2009 19:45:25 +0000 (19:45 +0000)]
Add slave/ to INDENTDIRS, with some exclusions

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23135 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMove more reindent settings into variables
Tom Yu [Fri, 6 Nov 2009 18:53:31 +0000 (18:53 +0000)]
Move more reindent settings into variables

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23134 dc483132-0cff-0310-8789-dd5450dbe970

15 years agomake mark-cstyle; make reindent
Tom Yu [Thu, 5 Nov 2009 04:39:54 +0000 (04:39 +0000)]
make mark-cstyle; make reindent

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23133 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReformat some block comments. Refine lib/krb5/asn.1 reindent
Tom Yu [Thu, 5 Nov 2009 04:39:48 +0000 (04:39 +0000)]
Reformat some block comments.  Refine lib/krb5/asn.1 reindent
exclusion into individual file exclusions.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23132 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDeal with some open paren formatting issues, and reindent. Make
Tom Yu [Thu, 5 Nov 2009 03:26:25 +0000 (03:26 +0000)]
Deal with some open paren formatting issues, and reindent.  Make
preauth.c use the function pointer typdefs in the prototypes as well.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23131 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove cast-qual from the gcc warnings set; it is too common for us to
Greg Hudson [Wed, 4 Nov 2009 20:16:13 +0000 (20:16 +0000)]
Remove cast-qual from the gcc warnings set; it is too common for us to
have to explicitly override const in order to implement strchr-like
functions or place pointers into read-only krb5_data objects.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23130 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUse "unsigned short" instead of "u_short" in argument to SET macro;
Ken Raeburn [Wed, 4 Nov 2009 18:11:51 +0000 (18:11 +0000)]
Use "unsigned short" instead of "u_short" in argument to SET macro;
the Emacs cc-mode indentation code seems to get confused by the
one-word case.

Reindent.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23129 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRestore the krb5 1.6 behavior of not retrying AS requests after
Greg Hudson [Wed, 4 Nov 2009 16:31:41 +0000 (16:31 +0000)]
Restore the krb5 1.6 behavior of not retrying AS requests after
PREAUTH_FAILED errors.  Among other things, this change causes
krb5_get_init_creds_opt_set_pa to act (mostly) as a constraint rather
than simply as an optimistic set of preauth types, which is the
behavior apps had been seeing prior to 1.7.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23128 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDelete obsolete krb5-mark-cstyle.el. (replaced by a python script)
Tom Yu [Wed, 4 Nov 2009 04:28:24 +0000 (04:28 +0000)]
Delete obsolete krb5-mark-cstyle.el.  (replaced by a python script)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23127 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReindent and manually restore some BSD-style files that were
Tom Yu [Wed, 4 Nov 2009 04:28:17 +0000 (04:28 +0000)]
Reindent and manually restore some BSD-style files that were
previously incorrectly marked as krb5-style.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23126 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCorrect regexps for matching emacs and cc-mode versions. In reindent
Tom Yu [Wed, 4 Nov 2009 00:21:35 +0000 (00:21 +0000)]
Correct regexps for matching emacs and cc-mode versions.  In reindent
targets, chdir to SRCTOP to avoid excessive references to $(SRCTOP) in
the find script.  Define new variables to avoid errors when creating
exception lists for find scripts.

Use a python script instead of elisp to mark files.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23125 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReindent after making fixes for emacs-23
Tom Yu [Tue, 3 Nov 2009 03:27:56 +0000 (03:27 +0000)]
Reindent after making fixes for emacs-23

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23123 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMonkey patch for the cc-mode that comes with emacs-23.x; that version
Tom Yu [Tue, 3 Nov 2009 03:14:41 +0000 (03:14 +0000)]
Monkey patch for the cc-mode that comes with emacs-23.x; that version
of cc-mode has a bug that causes incorrect indentation of case labels
containing character constants.  Already fixed upstream in unreleased
cc-mode sources.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23122 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoEmacs 21 doesn't have custom-variable-p. Also, adjust to use the
Tom Yu [Mon, 2 Nov 2009 19:19:02 +0000 (19:19 +0000)]
Emacs 21 doesn't have custom-variable-p.  Also, adjust to use the
correct controlling variables for older incarnations of
whitespace-mode.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23121 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoClean up a bunch of signed/unsigned comparison warnings
Greg Hudson [Mon, 2 Nov 2009 18:00:40 +0000 (18:00 +0000)]
Clean up a bunch of signed/unsigned comparison warnings

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23120 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoSimplify krb5int_get_error (and fix a cast-qual warning) by not
Greg Hudson [Sun, 1 Nov 2009 22:32:47 +0000 (22:32 +0000)]
Simplify krb5int_get_error (and fix a cast-qual warning) by not
worrying so much about system errors longer than 1K.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23118 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoBe a little more const-correct in krb5int_vset_error_fl
Greg Hudson [Sun, 1 Nov 2009 22:14:25 +0000 (22:14 +0000)]
Be a little more const-correct in krb5int_vset_error_fl

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23117 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUn-constify struct errinfo's msg field because it is the owner of that
Greg Hudson [Sun, 1 Nov 2009 21:51:26 +0000 (21:51 +0000)]
Un-constify struct errinfo's msg field because it is the owner of that
memory (even though the memory is intended to be immutable during its
lifetime).

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23116 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn k5-int.h, fix make_data to work with C++
Greg Hudson [Sun, 1 Nov 2009 15:55:44 +0000 (15:55 +0000)]
In k5-int.h, fix make_data to work with C++

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23115 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMemory leak fix: in obtain_sam_padata, after claiming the contents of
Greg Hudson [Sun, 1 Nov 2009 14:13:32 +0000 (14:13 +0000)]
Memory leak fix: in obtain_sam_padata, after claiming the contents of
the scratch data object, free the outer structure before nulling the
pointer to it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23114 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRework in an attempt to deal with variant Emacs versions
Tom Yu [Sun, 1 Nov 2009 04:35:20 +0000 (04:35 +0000)]
Rework in an attempt to deal with variant Emacs versions

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23113 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMove the implementations of four deprecated crypto functions to
Greg Hudson [Sun, 1 Nov 2009 02:47:58 +0000 (02:47 +0000)]
Move the implementations of four deprecated crypto functions to
old_api_glue.c.  Move the prototypes of seven deprecated crypto
functions to old_api_glue.c instead of k5-int.h, since we don't use
those functions internally.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23112 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoStop using deprecated krb5_encrypt_data in preauth code. Use
Greg Hudson [Sun, 1 Nov 2009 02:46:36 +0000 (02:46 +0000)]
Stop using deprecated krb5_encrypt_data in preauth code.  Use
krb5_encrypt_helper instead.  (encrypt_helper takes a key usage
instead of an ivec, but that's okay since the invocations were using
null ivecs anyway.)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23111 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReformat to avoid parens at beginnings of lines
Tom Yu [Sat, 31 Oct 2009 18:08:09 +0000 (18:08 +0000)]
Reformat to avoid parens at beginnings of lines

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23109 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/ccache, ensure that function definition headers have
Greg Hudson [Sat, 31 Oct 2009 03:59:19 +0000 (03:59 +0000)]
In lib/krb5/ccache, ensure that function definition headers have
function names at the beginnings of lines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23107 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/asn.1, ensure that function definition headers have
Greg Hudson [Sat, 31 Oct 2009 03:52:01 +0000 (03:52 +0000)]
In lib/krb5/asn.1, ensure that function definition headers have
function names at the beginnings of lines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23106 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReformat lib/krb5/asn.1 internal prototypes to avoid problematic parens
Greg Hudson [Sat, 31 Oct 2009 03:50:54 +0000 (03:50 +0000)]
Reformat lib/krb5/asn.1 internal prototypes to avoid problematic parens
at beginnings of lines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23105 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReformat asn1_make.h prototypes to avoid the problematic parens at
Greg Hudson [Sat, 31 Oct 2009 03:37:09 +0000 (03:37 +0000)]
Reformat asn1_make.h prototypes to avoid the problematic parens at
beginnings of lines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23104 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/os, ensure that function definition headers have function
Greg Hudson [Sat, 31 Oct 2009 03:17:27 +0000 (03:17 +0000)]
In lib/krb5/os, ensure that function definition headers have function
names at the beginnings of lines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23103 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/krb, ensure all function definition headers are in ANSI
Greg Hudson [Sat, 31 Oct 2009 03:03:54 +0000 (03:03 +0000)]
In lib/krb5/krb, ensure all function definition headers are in ANSI
style and have the function name at the beginning of a line.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23102 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix indentation in gc_via_tkt.c which was messed up by a malformed #if
Greg Hudson [Sat, 31 Oct 2009 02:36:01 +0000 (02:36 +0000)]
Fix indentation in gc_via_tkt.c which was messed up by a malformed #if
0 block.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23101 dc483132-0cff-0310-8789-dd5450dbe970

15 years agomake mark-cstyle
Tom Yu [Sat, 31 Oct 2009 00:48:38 +0000 (00:48 +0000)]
make mark-cstyle
make reindent

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23100 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFixes for Emacs 22 compatibility
Ken Raeburn [Fri, 30 Oct 2009 23:08:48 +0000 (23:08 +0000)]
Fixes for Emacs 22 compatibility

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23099 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIf krb5_sname_to_principal returns a null realm for the client
Ken Raeburn [Fri, 30 Oct 2009 23:08:45 +0000 (23:08 +0000)]
If krb5_sname_to_principal returns a null realm for the client
principal name, print an error message.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23098 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoQuote realm name in error message.
Ken Raeburn [Fri, 30 Oct 2009 23:08:40 +0000 (23:08 +0000)]
Quote realm name in error message.
If realm name is an empty string, just return an error right away.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23097 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoTweak batch reindent some more. Limit the initial bulk reindent, and
Tom Yu [Fri, 30 Oct 2009 21:34:19 +0000 (21:34 +0000)]
Tweak batch reindent some more.  Limit the initial bulk reindent, and
refine the exception list somewhat.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23096 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUpdate the kadm5 design documentation slightly to reflect that MIT
Greg Hudson [Fri, 30 Oct 2009 10:49:38 +0000 (10:49 +0000)]
Update the kadm5 design documentation slightly to reflect that MIT
doesn't commit to a stable libkadm5 C API.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23095 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn process_tgs_req, fully initialize e_data since we may copy it in
Greg Hudson [Thu, 29 Oct 2009 23:07:33 +0000 (23:07 +0000)]
In process_tgs_req, fully initialize e_data since we may copy it in
prepare_error_tgs.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23093 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd a couple of krb5_data convenience constructor functions, to
Greg Hudson [Thu, 29 Oct 2009 23:00:13 +0000 (23:00 +0000)]
Add a couple of krb5_data convenience constructor functions, to
facilitate properly initializing krb5_data objects.  Adjust formatting
of the existing krb5_data convenience functions and remove the #if 0
block.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23092 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCorrected Copyrights and some minor reorganization in openssl impl.
Zhanna Tsitkov [Thu, 29 Oct 2009 21:36:47 +0000 (21:36 +0000)]
Corrected Copyrights and some minor reorganization in openssl impl.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23090 dc483132-0cff-0310-8789-dd5450dbe970