Alexandra Ellwood [Tue, 14 Oct 2008 16:54:04 +0000 (16:54 +0000)]
kim test suite reports error messages incorrectly
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20867
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 14 Oct 2008 16:52:39 +0000 (16:52 +0000)]
Free error message returned by krb5_get_error_message
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20866
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 21:58:26 +0000 (21:58 +0000)]
kim_os_string_create_localized leaks CFStringRef
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20865
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 20:55:47 +0000 (20:55 +0000)]
Test KIM plugin
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20864
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 20:55:24 +0000 (20:55 +0000)]
always zero out authentication strings
strings returned by the UI are usually passwords or pins
and should not get dripped all over memory.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20863
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 20:50:48 +0000 (20:50 +0000)]
kim_ui_plugin_fini sends pointer to context instead of context
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20862
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 20:50:07 +0000 (20:50 +0000)]
allow kim ui plugins to have any name
Note that there can still only be one, it will just use the
first one it finds. Just want to have different names for them
so that we can distinguish between different plugins.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20861
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 20:47:05 +0000 (20:47 +0000)]
change password should always reprompt on error
Since it collects the password ahead of time, the prompt
count won't get incremented. Checking whether it
called auth_prompt is useless.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20860
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 10 Oct 2008 20:14:25 +0000 (20:14 +0000)]
PKINIT specs, draft 9 and final standard
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20859
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 21:22:29 +0000 (21:22 +0000)]
Missing keys in KerberosAgent Info.plist
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20856
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 19:15:27 +0000 (19:15 +0000)]
prefs should not create empty dictionary for KIM_OPTIONS_DEFAULT
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20855
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 17:51:03 +0000 (17:51 +0000)]
preferences should handle KIM_OPTIONS_DEFAULT
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20854
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 17:49:23 +0000 (17:49 +0000)]
kim_options_create sometimes returns KIM_OPTIONS_DEFAULT
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20853
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 02:35:38 +0000 (02:35 +0000)]
KL APIs which take a NULL principal return klParameterErr
Fixed by making kim_ccache_create_from_client_identity take KIM_IDENTITY_ANY
(at which point it returns the system default ccache).
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20850
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 02:11:51 +0000 (02:11 +0000)]
Crash in kim_credential_create_from_keytab
Was dereferencing NULL freeing creds.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20849
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 01:05:08 +0000 (01:05 +0000)]
kim_options_copy should allow in_options to be KIM_OPTIONS_DEFAULT
(Don't error on NULL in_options)
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20848
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 8 Oct 2008 22:21:46 +0000 (22:21 +0000)]
KerberosAgent should log less
Remove auto-quit log message, "No active clients. Terminating."
ticket:new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20847
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 8 Oct 2008 22:20:48 +0000 (22:20 +0000)]
Removed unused header file include.
(Not necessary for fix, just a cleanup)
ticket: 6146
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20846
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 8 Oct 2008 22:14:27 +0000 (22:14 +0000)]
Ignore user interaction while busy. Done by toggling ignoresMouseEvents on auth dialogs
ticket:6144
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20845
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 8 Oct 2008 21:51:35 +0000 (21:51 +0000)]
KLL should use __attribute ((deprecated))
Switched from a macro to GCC deprecated attributes.
Also removed the deprecated struct used by KLSetApplicationOptions
and KLGetApplicationOptions because they weren't touching it.
Replaced pointer-to-struct arguments with void *.
KLGetApplicationOptions now also returns an error since it did
not modify its input. Not sure why it wasn't before since no one
should be calling it on Mac OS X.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20844
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 8 Oct 2008 02:01:06 +0000 (02:01 +0000)]
KerberosAgent should handle zoom button better
The Select Identity dialog should resize to fit the available identities in its table when the zoom button is clicked.
ticket: new
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20840
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Tue, 7 Oct 2008 21:55:01 +0000 (21:55 +0000)]
KerberosAgent fails to handle multiple clients because it attempts to message freed memory
ticket: new
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20839
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 7 Oct 2008 21:12:55 +0000 (21:12 +0000)]
KIM should remember options and identity if prefs indicate
Added code to remember ticket options if settings indicate it.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20838
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 7 Oct 2008 21:12:05 +0000 (21:12 +0000)]
KLL shim layer does not correctly handle options
KLGetDefaultLoginOption and KLSetDefaultLoginOption were
incorrectly casting parameters and were not parsing the
option argument correctly.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20837
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 7 Oct 2008 19:23:10 +0000 (19:23 +0000)]
If the caller is a bundle, look up keys in its plist file to get the name
ticket: 6146
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20836
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 7 Oct 2008 18:58:53 +0000 (18:58 +0000)]
KLLastChangedTime should return current time, not 0
cc_context_get_change_time returns 0 the first time it is called
if the CCacheServer is not running. KLLastChangedTime always
returned the current time on the first call. So use globals and
a mutex to make sure that KLLastChangedTime both monotonically
increases and also returns the current time on the first call.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20835
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 6 Oct 2008 21:58:59 +0000 (21:58 +0000)]
Include header to get error table for KLL
ticket: 6154
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20834
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 6 Oct 2008 21:24:20 +0000 (21:24 +0000)]
Hinge building KLL shim off KIM_TO_KLL_SHIM, not LEAN_CLIENT
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20833
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 6 Oct 2008 21:18:36 +0000 (21:18 +0000)]
Substitute LDAP in makefiles with "yes" or "no" depending on configuration.
Split ASN.1 encode and decode tests so that they can be run independently
and/or in parallel.
Add ASN.1 tests for LDAP key-data sequence type, run only if LDAP enabled.
Use krb5int_access to get at the encoder and decoder.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20832
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 6 Oct 2008 21:16:07 +0000 (21:16 +0000)]
Add KLL error table
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20831
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 6 Oct 2008 20:28:04 +0000 (20:28 +0000)]
Don't touch keychain if home directory access is disabled
Keychain is stored in the user's home directory.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20830
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 6 Oct 2008 20:25:45 +0000 (20:25 +0000)]
Change LDAP key-sequence encoder to use a single data structure
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20829
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 6 Oct 2008 20:04:12 +0000 (20:04 +0000)]
Fix a few missing-decl, signed/unsigned warnings
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20828
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 6 Oct 2008 20:03:09 +0000 (20:03 +0000)]
See if we need a prototype for isblank
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20827
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 6 Oct 2008 20:02:11 +0000 (20:02 +0000)]
In KRB5_NEED_PROTO, #undef the name before testing
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20826
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 6 Oct 2008 18:02:19 +0000 (18:02 +0000)]
whitespace
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20825
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 6 Oct 2008 17:31:00 +0000 (17:31 +0000)]
Fix some signed/unsigned warnings
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20824
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Sat, 4 Oct 2008 00:01:25 +0000 (00:01 +0000)]
Set up db_module_dir correctly in krb5.conf for test
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20823
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Fri, 3 Oct 2008 15:56:54 +0000 (15:56 +0000)]
Only close windows in response to fini messages from clients.
Only center the windows the first time they are shown for a client.
Improve the math on the NSRect sent to -[NSWindow setFrame:] so dialog windows don't jump around the screen and the title bar stays in the same place.
Refactor repeated view swapping code to -[AuthenticationController swapView:].
ticket: 6142
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20821
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Thu, 2 Oct 2008 21:19:16 +0000 (21:19 +0000)]
Make select identity dialog remember its size, but not the table column widths. Make its default width 500px
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20819
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Thu, 2 Oct 2008 21:00:18 +0000 (21:00 +0000)]
Localization fix for change password dialog
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20818
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Thu, 2 Oct 2008 20:56:14 +0000 (20:56 +0000)]
Select identity switched to using new NSDictionary based options and change password menu item support
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20817
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 2 Oct 2008 19:29:18 +0000 (19:29 +0000)]
Password is not expired when changing password from select and
enter identity dialogs.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20816
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 2 Oct 2008 19:13:48 +0000 (19:13 +0000)]
Don't write NULL name and path over stream. Just send empty strings
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20815
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 2 Oct 2008 19:12:59 +0000 (19:12 +0000)]
Fix to get application name correctly. Was dropping argument
from launchservices and not removing extension from path in
fallback code.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20814
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Thu, 2 Oct 2008 18:03:06 +0000 (18:03 +0000)]
Update to allow change password from select and enter identity dialogs
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20813
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 2 Oct 2008 17:38:36 +0000 (17:38 +0000)]
Support for change password checkbox in enter and select
identity ui elements.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20812
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Thu, 2 Oct 2008 17:34:17 +0000 (17:34 +0000)]
Resize dialogs better, added progress indicator to show KerberosAgent is working between interactions
Make Identity and Identities classes use NSDictionary representations of kim_options like the rest of KerberosAgent.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20811
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Thu, 2 Oct 2008 17:23:54 +0000 (17:23 +0000)]
Increase the default RPC timeout for kadmin from 25 seconds to 120
seconds. Code changes from a patch submitted by umich.
ticket: 6120
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20810
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Thu, 2 Oct 2008 16:53:57 +0000 (16:53 +0000)]
In clntudp_call, fix a bug in the handling of an error case (it failed
to set the error status field and generated a dead code warning).
ticket: 6121
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20809
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Thu, 2 Oct 2008 13:20:04 +0000 (13:20 +0000)]
Make enter identity dialog's smarter about matching a string with a set of favorite options
ticket:6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20808
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Thu, 2 Oct 2008 03:48:48 +0000 (03:48 +0000)]
Make Enter Identity dialog have one auto-completing, auto-validating text field for principals drawn from KIM's list of favorites.
Changed options for a favorite identity get saved out to kim_preferences.
Also, include copyright on more files.
ticket:6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20807
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 22:43:19 +0000 (22:43 +0000)]
Updated documentation to reflect new APIs and re-ran Doxygen
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20806
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 22:33:32 +0000 (22:33 +0000)]
Fixed a bug in kim_identity_get_components string where it
would return the first component multiple times.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20805
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 21:59:16 +0000 (21:59 +0000)]
Make unset strings in kim_options and kim_selection_hints
be empty strings rather than NULL. This simplifies the
stream code (and makes it easier to read and debug).
In order to prevent copying tons of NUL bytes around,
special case kim_string functions to use a special
constant kim_empty_string.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20804
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 21:16:44 +0000 (21:16 +0000)]
Fixed crash in kim_options_write_to_stream
when in_options is KIM_OPTIONS_DEFAULT.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20803
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 21:00:49 +0000 (21:00 +0000)]
Reversed sense of checks for NUL character in empty string. Fixed
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20802
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 20:58:56 +0000 (20:58 +0000)]
Correctly parse KIM_IDENTITY_ANY in error handler
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20801
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 20:56:57 +0000 (20:56 +0000)]
Loop on enter identity if auth fails
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20800
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 20:55:49 +0000 (20:55 +0000)]
Correctly translate NULL hints when reading from a stream
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20799
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 20:55:04 +0000 (20:55 +0000)]
Relaunch KerberosAgent more quickly so UI is more responsive
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20798
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 1 Oct 2008 20:38:26 +0000 (20:38 +0000)]
Update enterIdentity handler to support passing and setting ticket options.
Readded ticket options sheet to Enter Identity dialog.
Added helper methods to convert between kim_option and NSDictionary.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20797
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 19:34:06 +0000 (19:34 +0000)]
Finished KLL to KIM shim.
Switched krb5 code to using it.
ticket: 6134
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20796
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 17:11:22 +0000 (17:11 +0000)]
Fill out credentials when getting tickets with changed password
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20795
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 15:35:48 +0000 (15:35 +0000)]
Support for passing options back and forth for enter_identity and
hints back for select_identity.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20794
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 1 Oct 2008 14:12:31 +0000 (14:12 +0000)]
A working KIM-based KerberosAgent to handle all of KIM's built-in GUI prompting.
A few outstanding issues remain, like the ability to add duplicate entries to the list of favorite identities.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20793
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 1 Oct 2008 14:01:03 +0000 (14:01 +0000)]
When kim_options_write_to_stream is given NULL options, create default options in its place instead of erroring out
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20792
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 1 Oct 2008 14:00:16 +0000 (14:00 +0000)]
kim_selection_hints_get_identity should call kim_ui_fini even when kim_ui_select_identity returns an error, e.g. KIM_USER_CANCELED_ERR
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20791
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 1 Oct 2008 13:57:19 +0000 (13:57 +0000)]
Check for NULL hints_array passed back from kim_os_selection_hints_get_selection_hints_array in kim_os_selection_hints_lookup_identity
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20790
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 07:56:57 +0000 (07:56 +0000)]
First pass at KLL shim layer. (no private apis)
KIM support for KLL shim layer.
Fixed a bug where the cli support was double freeing a credential
in the change password case.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20789
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 1 Oct 2008 07:53:37 +0000 (07:53 +0000)]
Fixed typo where kpasswd was prompting for the new password
twice rather than once for new and once for verify.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20788
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 30 Sep 2008 21:23:17 +0000 (21:23 +0000)]
CCAPI should use common ipc and stream code
KIM and CCAPI should share the same IPC and stream object types.
Modified CCAPI to use code in src/util (stream) and src/util/mac (ipc)
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20787
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 30 Sep 2008 20:05:17 +0000 (20:05 +0000)]
krb5 library-side changes for com_err based error strings
ticket: 6138
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20786
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 30 Sep 2008 19:26:56 +0000 (19:26 +0000)]
kim_os_identity_get_saved_password should always return an error when
no password is returned.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20785
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Tue, 30 Sep 2008 19:13:30 +0000 (19:13 +0000)]
Check for null saved password in kim_ui_prompter. Just because kim_os_get_saved_password didn't return an error doesn't mean it successfully got a password
ticket:6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20784
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 30 Sep 2008 05:11:58 +0000 (05:11 +0000)]
Fixed a bug where getting addressless tickets would cause kim
to pass a NULL krb5_context into krb5_os_localaddr
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20783
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 29 Sep 2008 21:39:42 +0000 (21:39 +0000)]
Support legacy KerberosAgent preference for save passwords
and a new preference in the KIM preferences.
Updated test harness for save password arguments.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20782
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 29 Sep 2008 20:48:43 +0000 (20:48 +0000)]
Added support for disabling password saving, both globally
and also per prompt via the UI.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20781
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 29 Sep 2008 18:52:53 +0000 (18:52 +0000)]
UI should lazy init so that init and fini are only called if one
of the UI calls is called. The problem is that when you call
krb5_get_init_creds_* you don't know if it will call the prompter
or not. (It won't if the password is saved in the keychain or
if pkinit succeeds.)
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20780
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 29 Sep 2008 05:25:02 +0000 (05:25 +0000)]
test harness for KerberosAgent IPC layer
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20779
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 29 Sep 2008 05:21:46 +0000 (05:21 +0000)]
Removed useless init and cleanup functions.
Fixed request port list handling.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20778
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 29 Sep 2008 05:20:22 +0000 (05:20 +0000)]
If in_identity is NULL, use the identity the user entered.
(Fixed typo)
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20777
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 29 Sep 2008 05:19:37 +0000 (05:19 +0000)]
Fixed KerberosAgent plists so it is loading the correct server and
so they are both in plist format.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20776
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 29 Sep 2008 02:40:24 +0000 (02:40 +0000)]
kim_credential_create_new should support NULL in_identity.
Prompt for it.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20775
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Sun, 28 Sep 2008 23:51:09 +0000 (23:51 +0000)]
Actually make [Identity -componentsString] use kim_identity_get_components_string
Also, better error handling in Identity and Identities classes.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20774
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Sun, 28 Sep 2008 23:39:25 +0000 (23:39 +0000)]
Place structure in thread specific data to store client connection
port so that multiple services can be supported simultaneously.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20773
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Sun, 28 Sep 2008 22:38:20 +0000 (22:38 +0000)]
Make [Identity -componentsString] use kim_identity_get_components_string
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20772
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Sun, 28 Sep 2008 22:16:09 +0000 (22:16 +0000)]
Flesh out KerberosAgent Select Identity dialog. Can now add, edit, and remove favorite identities
Also, make formatters in KerberosFormatters.[hm] localizable.
Still need to add principal validation and prevent duplicates.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20771
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Sun, 28 Sep 2008 20:53:12 +0000 (20:53 +0000)]
Added kim_selection_hints_create_from_stream and
kim_selection_hints_write_to_stream for client/server
communication.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20770
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Sun, 28 Sep 2008 19:43:47 +0000 (19:43 +0000)]
Create common stream and ipc layer for CCAPI and KIM.
Will switch CCAPI to this new code later though, so as
not to destabilize KfM and the Windows builds.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20769
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Sun, 28 Sep 2008 03:59:55 +0000 (03:59 +0000)]
Make kim_credential_get_options set correct renewal lifetime
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20768
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Sat, 27 Sep 2008 23:14:40 +0000 (23:14 +0000)]
Added launchd plist file for KerberosAgent
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20767
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Sat, 27 Sep 2008 21:31:06 +0000 (21:31 +0000)]
Renamed kim_identity_get_components to kim_identity_get_components_string
to better reflect what it does (a string of everything but the realm, not
an array of components like the old name might imply).
Added private functions which will be used by KLL to shim on top of KIM.
Private functions also reduce memory allocations inside of KIM.
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20766
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Sat, 27 Sep 2008 19:22:10 +0000 (19:22 +0000)]
Add kim_preferences_get/set_minimum/maximum_lifetime functions to export lists
ticket:6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20765
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Sat, 27 Sep 2008 19:18:48 +0000 (19:18 +0000)]
kim_credential_get_options was setting the lifetime a second time instead of setting the renewal lifetime
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20764
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Sat, 27 Sep 2008 00:46:39 +0000 (00:46 +0000)]
KerberosAgent MachIPC support
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20763
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Sat, 27 Sep 2008 00:44:39 +0000 (00:44 +0000)]
C90 compliance
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20762
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 26 Sep 2008 20:49:23 +0000 (20:49 +0000)]
kim_options_set_service_name should be able to take a service name of NULL
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20761
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 26 Sep 2008 18:56:51 +0000 (18:56 +0000)]
Added kim_credential_get_options and kim_ccache_get_options
for KerberosAgent to use to create new favorite identities
ticket: 6055
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20760
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 26 Sep 2008 14:13:32 +0000 (14:13 +0000)]
Removed argument from kipc_client_lookup_server
Removed unused application path argument from kipc_client_lookup_server
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20759
dc483132-0cff-0310-8789-
dd5450dbe970