Ken Raeburn [Mon, 30 Dec 2002 19:49:21 +0000 (19:49 +0000)]
* kerberos_v4.c (process_v4): Use a temporary variable for the current time
instead of an incorrect pointer cast.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15072
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 30 Dec 2002 19:46:21 +0000 (19:46 +0000)]
* gss-misc.c (send_token, recv_token): Open-code the math to send and receive
the length as four bytes in network order, rather than using the first four
bytes of a size_t.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15071
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 23 Dec 2002 22:43:03 +0000 (22:43 +0000)]
Replace dependencies on generated krb524 and krb4 headers with
variables, to allow correct behavior when krb4 is disabled.
ticket: 1276
owner: tlyu
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15070
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 23 Dec 2002 18:12:29 +0000 (18:12 +0000)]
* setup_mkey.c (krb5_db_setup_mkey_name): Use size_t instead of
int for lengths.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15069
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 23 Dec 2002 18:10:56 +0000 (18:10 +0000)]
* asn1_k_decode.c (asn1_decode_sam_challenge_2_body): Add
unused_var declaration to cleanup warnings. Signed/unsigned fix as
well.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15068
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 23 Dec 2002 18:09:24 +0000 (18:09 +0000)]
* t_kerb.c: Include string.h for strcmp prototype
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15067
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 23 Dec 2002 18:08:02 +0000 (18:08 +0000)]
* prof_file.c: Cast return from prof_mutex_lock and
prof_mutex_unlock to void to avoid warnings of code with no side
effects.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15066
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 23 Dec 2002 18:01:54 +0000 (18:01 +0000)]
Cleanup unused
variables. Signed vs unsigned cleanup. Ensure variables set before
use.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15065
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 23 Dec 2002 17:57:48 +0000 (17:57 +0000)]
* t_crc.c: Declare local functions static
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15064
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 23 Dec 2002 17:55:44 +0000 (17:55 +0000)]
* t_cksum.c: Cleanup (potential) variable used before set warning
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15063
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 23 Dec 2002 17:53:01 +0000 (17:53 +0000)]
* authorization.c, heuristic.c, ksu.h: Use uid_t instead of int in
arguments to fowner() and get_best_princ_for_target(). Signed
vs. unsigned int cleanup.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15062
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 21 Dec 2002 04:28:06 +0000 (04:28 +0000)]
* prof_int.h: Define USE_PTHREADS and include pthread.h if on MacOS X.
(struct global_shared_profile_data) [USE_PTHREADS]: Add a mutex.
(g_shared_trees_mutex) [USE_PTHREADS]: New macro, references the global mutex.
(prof_mutex_lock, prof_mutex_unlock) [SHARE_TREE_DATA]: Define to use pthread
functions or do nothing.
(profile_free_file_data): Delete declaration.
(profile_dereference_data): Declare.
* prof_file.c (profile_free_file_data): Now static.
(profile_open_file, profile_dereference_data) [SHARE_TREE_DATA]: Grab lock
while manipulating global data list or its contents.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15061
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 20 Dec 2002 22:38:04 +0000 (22:38 +0000)]
Merge in data tree sharing, minus locking support, plus a bugfix or two
* prof_int.h (SHARE_TREE_DATA): Define.
(struct _prf_file_t) [SHARE_TREE_DATA]: Make data field a pointer rather than
an array.
(struct global_shared_profile_data): New type, for profile library global
data.
(krb5int_profile_shared_data): Declare new variable.
(g_shared_trees): New macro, refers to a field in the global data.
(PROFILE_FILE_SHARED): New flag macro.
* prof_file.c (krb5int_profile_shared_data): Initialize here.
(profile_open_file) [SHARE_TREE_DATA]: Scan g_shared_trees for an entry with
the same filename. If found, increment its reference count, update it, and
return it; otherwise, allocate a new one, and add it to the list after filling
it in.
(profile_dereference_data): New function. Decrement reference count if
SHARE_TREE_DATA, and free the data if appropriate.
(profile_free_file): Call profile_dereference_data.
(profile_free_file_data) [SHARE_TREE_DATA]: If the SHARED flag is set, remove
it from the g_shared_trees list before freeing. Free up the allocated space.
* prof_set.c (rw_setup) [SHARE_TREE_DATA]: If the object's data is shared, copy
it into a new data structure not in the global shared list, and dereference the
old one.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15060
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 19 Dec 2002 05:24:58 +0000 (05:24 +0000)]
Ignore some new generated files
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15059
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 19 Dec 2002 05:23:44 +0000 (05:23 +0000)]
Clean up some broken uses of "const" in function interfaces
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15058
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 19 Dec 2002 04:56:26 +0000 (04:56 +0000)]
* Makefile.in (check): Remove test_db before running tests
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15057
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 19 Dec 2002 01:56:45 +0000 (01:56 +0000)]
* api.2/init-v2.exp (test150, test151, test153): Don't try to set KRB5CCNAME;
only the fact that it wasn't being done correctly prevented it from causing
test failures.
* lib/lib.t (kinit): If kinit reports a problem initializing the credentials
cache, raise an error.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15056
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 19 Dec 2002 01:53:29 +0000 (01:53 +0000)]
* init_db (qualname): If "kdb5_util create" fails, exit
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15055
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 19 Dec 2002 01:48:21 +0000 (01:48 +0000)]
* env-setup.shin: Set KRB5CCNAME to something under $K5ROOT
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15054
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 18 Dec 2002 07:17:25 +0000 (07:17 +0000)]
* RealmsConfig-glue.c: Fix up KRB5_CALLCONV
* win_store.c (krb__get_srvtabname): Add const to parameter.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15053
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 18 Dec 2002 06:05:38 +0000 (06:05 +0000)]
Fix some 64-bit problems
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15052
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 18 Dec 2002 02:09:27 +0000 (02:09 +0000)]
* aclocal.m4 (KRB5_GETSOCKNAME_ARGS, KRB5_GETPEERANME_ARGS): Check for
socklen_t pointer as second argument.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15051
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 16 Dec 2002 20:55:15 +0000 (20:55 +0000)]
* tkt_string.c (krb5_set_tkt_string): Add KRB5_CALLCONV
* win_glue.c (krb_set_tkt_string): Add KRB5_CALLCONV.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15050
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 16 Dec 2002 19:12:16 +0000 (19:12 +0000)]
Changes to allow compilation --with-system-db and --enable-shared
(Do not depend on lib/db.so being present)
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15049
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Sat, 14 Dec 2002 04:10:42 +0000 (04:10 +0000)]
* ad_print.c, g_in_tkt.c, g_pw_in_tkt.c, kadm_net.c, klog.c:
* kuserok.c, log.c, memcache.c, netread.c, netwrite.c:
* password_to_key.c, recvauth.c, stime.c, tkt_string.c:
Change _WINDOWS to _WIN32 in many places. Update copyright
notices. Remove _WINDOWS handling completely in a few places
where it's not needed.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15048
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Dec 2002 21:33:16 +0000 (21:33 +0000)]
update dependencies
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15047
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Dec 2002 21:25:51 +0000 (21:25 +0000)]
More KfM merge work
Create new file FSp-glue.c including KfM functions that had previously
been scattered through various other files.
Port RealmsConfig-glue.c from KfM, including old Unix-ish krb4
configuration code as fallback. Remove other files containing old
realm/config file support.
Add KRB5_CALLCONV to krb_get_in_tkt_creds.
Fix various functions to take const char* as arguments now that
tkt_string() returns const.
Assorted minor cleanup.
Implement krb_get_err_text in terms of com_err. Implement gross
kludge to force krb_err_txt to remain in sync with com_err.
ticket: 1189
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15046
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Dec 2002 21:10:55 +0000 (21:10 +0000)]
Fix depend rules to keep state about whether verification of various
things succeeded. Change some double colons to single colons. Add a
new depend-dependencies target to allow Makefile.in to specify things
that must be built for depend to work.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15045
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Dec 2002 21:00:49 +0000 (21:00 +0000)]
* krb5.hin: Update comment on krb5_kt_free_entry prototype to
point at the correct recommended function.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15044
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Dec 2002 20:53:54 +0000 (20:53 +0000)]
* et_h.awk: It's "const struct error_table et_" in the c file, so
it's now const here too.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15043
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 9 Dec 2002 23:03:54 +0000 (23:03 +0000)]
* post.in: depfix2.sed -> .depfix2.sed to avoid a little clutter
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15042
dc483132-0cff-0310-8789-
dd5450dbe970
Sam Hartman [Mon, 9 Dec 2002 21:32:09 +0000 (21:32 +0000)]
Fix prototypes for *_wrapper_3
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15041
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 9 Dec 2002 16:26:17 +0000 (16:26 +0000)]
* misc.h: Rename prototypes from chpass_principal_wrapper and
randkey_principal_wrapper to chpass_principal_wrapper_3 and
randkey_principal_wrapper_3
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15040
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Sat, 7 Dec 2002 04:17:23 +0000 (04:17 +0000)]
* sendmsg.c (krb524_sendto_kdc): Update calls to locate_server()
and locate_kdc() to restrict protocol family to IPv4.
ticket: 1189
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15039
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Sat, 7 Dec 2002 04:14:07 +0000 (04:14 +0000)]
Fix some KRB5_CALLCONV botches that were causing trouble for Windows build
Update send_to_kdc() to use various krb5 internals to talk to the krb4
KDC. Add a new internal function to optionally return the local
address used to talk to the KDC. Many changes to lib/krb5/os to
support this. Fix bug in krb5int_sendto() that prevented correct UDP
length from being returned. Update callers of internal locate_* and
sendto_* functions.
ticket: 1189
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15038
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 7 Dec 2002 03:37:24 +0000 (03:37 +0000)]
Checkpoint first step of merge.
Moved per-file data into a separate object from the profile handle.
Dropped some old MacOS 9 code.
* prof_int.h: Include Mac OS X versions of header files if appropriate. Only
include prof_err.h if profile.h doesn't define ERROR_TABLE_BASE_prof.
(struct _prf_data_t): Move most of contents of _prf_file_t here. Add reference
count.
(prf_data_t): New typedef.
(struct _prf_file_t): Include an array of one _prf_data_t structure.
* prof_file.c (profile_open_file): Fill in "data" field. Drop some old Mac
specific code.
(profile_flush_file_data): Renamed from profile_flush_file, now takes
prf_data_t argument.
(profile_flush_file_data): Likewise.
(profile_free_file): Now calls profile_free_file_data.
(profile_free_file_data): New function, with most of old profile_free_file
code.
* prof_init.c (profile_init_path): Removed old Mac version.
(profile_ser_size, profile_ser_externalize): Get file data from new "data"
field.
* prof_set.c (rw_setup, profile_update_relation, profile_clear_relation,
profile_rename_section, profile_add_relation): Likewise.
* prof_tree.c (profile_node_iterator): Likewise.
* test_profile.c (do_batchmode): Likewise.
* prof_int.h (profile_flush_file): Now a macro.
* prof_err.et (PROF_MAGIC_FILE_DATA): New error code value.
ticket: 1237
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15037
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 7 Dec 2002 01:55:47 +0000 (01:55 +0000)]
* prof_get.c (conf_yes, conf_no): Entries now point to const.
(profile_parse_boolean): Updated type of 'p' correspondingly.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15036
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Fri, 6 Dec 2002 19:24:19 +0000 (19:24 +0000)]
* Makefile.in (clean-unix): Remove krb5-config
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15035
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Fri, 6 Dec 2002 19:23:12 +0000 (19:23 +0000)]
* Makefile.in (clean): Clean up more test executables and object
files.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15034
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Fri, 6 Dec 2002 19:01:46 +0000 (19:01 +0000)]
* configure.in: Quote the argument to AC_CHECK_HEADER. Autoconf
2.57 was having problems.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15033
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Fri, 6 Dec 2002 18:00:24 +0000 (18:00 +0000)]
* configure.in: Quote the argument to AC_CHECK_HEADER. Autoconf
2.57 was having problems.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15032
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 6 Dec 2002 03:27:01 +0000 (03:27 +0000)]
update dependencies
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15031
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 6 Dec 2002 03:22:41 +0000 (03:22 +0000)]
* kname_parse.c (kname_unparse): Add new function ported from
KfM, including support functions.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15030
dc483132-0cff-0310-8789-
dd5450dbe970
Sam Hartman [Fri, 6 Dec 2002 01:02:13 +0000 (01:02 +0000)]
2002-12-05 Sam Hartman <hartmans@mit.edu>
* util_token.c (g_verify_token_header g_make_token_header):
Accept -1 to mean that no token type is expected; the token type
is purely an RFC 1964 artifact and is not used in other mechanisms
such as SPNEGO.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15029
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 5 Dec 2002 20:01:48 +0000 (20:01 +0000)]
* decomp_tkt.c (decomp_ticket): Add KRB5_CALLCONV
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15028
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 5 Dec 2002 00:28:13 +0000 (00:28 +0000)]
* krb4int.h: Remove now conflicting prototype for
krb_set_lifetime().
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15027
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 4 Dec 2002 07:00:13 +0000 (07:00 +0000)]
* des.h: Move explicit definition of _WINDOWS to precede
conditionalized inclusion of win-mac.h.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15026
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 4 Dec 2002 06:35:46 +0000 (06:35 +0000)]
* kadm.h: Include port-sockets.h, not netinet/in.h, for Windows
portability.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15025
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 4 Dec 2002 06:34:59 +0000 (06:34 +0000)]
* Makefile.in: Fix up includes handling somewhat
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15024
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 3 Dec 2002 04:59:03 +0000 (04:59 +0000)]
Update Windows build for kadm_err.*
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15023
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 3 Dec 2002 04:43:37 +0000 (04:43 +0000)]
* Makefile.in (kadm_err.h): Build here
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15022
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 3 Dec 2002 03:40:27 +0000 (03:40 +0000)]
* change_password.c: Remove netdb.h inclusion
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15021
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 27 Nov 2002 17:15:17 +0000 (17:15 +0000)]
* post.in (clean-unix): Clean depfix2.sed as well
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15020
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 27 Nov 2002 17:10:11 +0000 (17:10 +0000)]
upde dependencies
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15019
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 27 Nov 2002 17:09:22 +0000 (17:09 +0000)]
* Makefile.in (SRCS): Add kadm_err.c. It was missing
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15018
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 27 Nov 2002 16:55:06 +0000 (16:55 +0000)]
* depfix.sed: Remove tcl-specific headers from dependencies.
Delete now obsolete comment about gcc-specific directories.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15017
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 27 Nov 2002 04:27:56 +0000 (04:27 +0000)]
update dependencies
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15016
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 27 Nov 2002 04:26:38 +0000 (04:26 +0000)]
* configure.in: Set SETENVSRC correctly
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15015
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 27 Nov 2002 03:09:35 +0000 (03:09 +0000)]
Merge more KfM krb4 things
Implement *_in_tkt_creds, mk_req_creds, and rd_req_int functions.
Implement KfM krb4 kadm password changing, mostly by pulling in the
client side of the kadm library into the krb4 library.
Do some more header file cleanup of des.h and krb.h.
Remove some ancient krb4 dead weight.
Some Mac-specific functionality still needs to be merged.
ticket: 1189
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15014
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 19 Nov 2002 03:28:21 +0000 (03:28 +0000)]
Remove references to kadm_err.et for now, since the requisite changes
have not yet been committed.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15013
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Fri, 15 Nov 2002 20:21:51 +0000 (20:21 +0000)]
* configure.in: Test for speed_t being present
* sys_term.c (addarg): When reallocing memory, ensure in size of
pointer. Use speed_t instead of int for termspeeds.
* authenc.c, ext.h, state.c, utility.c: Unsigned/signed cleanup.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15012
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Fri, 15 Nov 2002 20:21:35 +0000 (20:21 +0000)]
* sys_bsd.c: Moved declaration for susp() to type of file and
provide prototype.
* commands.c, externs.h, telnet.c, network.c: Add prototype
declaration for command handler table dispatch functions. Make
functions called consistant with prototype. Misc unsigned/signed
cleanups.
* authenc.c, main.c, utilities.c: Signed vs. unsigned cleanup.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15011
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Fri, 15 Nov 2002 20:21:18 +0000 (20:21 +0000)]
* enc-proto.h, enc_des.c, encrypt.c: Unsigned/signed cleanups
* forward.c: Include unistd.h if present on machine.
* misc-proto.h misc.c (auth_encrypt_user): Declare argument as
const.
* auth.c: Cast argument auth_encrypt_user. auth_gen_printsub() and
auth_printsub() take unsigned int as buffer length.
* auth.h, auth-proto.h, kerberos.c, kerberos5.c, spx.c:
auth_gen_printsub(), auth_printsub(), kerberos4_printsub(),
kerberos5_printsub(), spx_printsub() take unsigned int as length
argument.
* configure.in: Check for unistd.h
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15010
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 15 Nov 2002 19:26:55 +0000 (19:26 +0000)]
argh
let's try this again.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15009
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 15 Nov 2002 19:21:50 +0000 (19:21 +0000)]
* Makefile.in: Remove some missed references to adm_err.et
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15008
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Fri, 15 Nov 2002 16:12:20 +0000 (16:12 +0000)]
* accept_sec_context.c (krb5_gss_accept_sec_context): Use unsigned
lengths for arguments to g_token_size and g_make_token_header.
* export_name.c (krb5_gss_export_name): Change local length
variable to unsigned.
* k5unseal.c (kg_unseal_v1): Seqnum variable changed from
krb5_int32 to krb5_ui_4.
* k5seal.c (make_seal_token_v1): Change seqnum argument to
krb5_ui_4 from krb5_int32 to match krb5_gss_ctx_id_rec struct.
* gssapiP_krb5.h, util_crypt.c, util_seqnum.c: kg_make_seq_num(),
kg_get_seq_num() changed to use krb5_ui_4 for sequence
numbers. kg_encrypt(), kg_decrypt() length argument now unsigned.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15007
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Fri, 15 Nov 2002 16:12:03 +0000 (16:12 +0000)]
* gssapiP_generic.h, util_token.c: Change g_make_token_header and
g_verfy_token_header to take an unsigned length in.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15006
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 15 Nov 2002 01:20:28 +0000 (01:20 +0000)]
Better cleanup; reduce filename conflict
* Makefile.in (unit-test-ok): Depend only on unit-test-body.
(unit-test-body): Remove krb5cc_rpc_test_* on entry and on successful exit. On
error exit, let the trap handler do all the cleanup. Incorporate old
unit-test-setup commands.
(unit-test-setup, unit-test-cleanup): Targets deleted.
* lib/helpers.exp (start_client, wait_client): Set KRB5CCNAME to something in
the current directory.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15002
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 14 Nov 2002 19:10:33 +0000 (19:10 +0000)]
* changepw.c: Remove reference to adm_err.h
Update dependencies as well.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15001
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 14 Nov 2002 18:57:07 +0000 (18:57 +0000)]
* Makefile.in: Remove references to adm_err.h from here too
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15000
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 14 Nov 2002 18:46:06 +0000 (18:46 +0000)]
* Makefile.in: Remove references to adm_err.et. It's not used,
and conflicts with the krb4 kadm error table.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14999
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Thu, 14 Nov 2002 16:12:56 +0000 (16:12 +0000)]
* get_in_tkt.c (krb5_get_in_tkt): Do not pass NULL when an
integer 0 is intended to send_as_request().
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14998
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Hornstein [Thu, 14 Nov 2002 15:48:36 +0000 (15:48 +0000)]
Wrong size for memset()s in combine_keys()
The wrong size was used in the final memset()'s of various combine_key
temporary variables. Pointed out by Ken Renard.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14997
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Thu, 14 Nov 2002 04:43:25 +0000 (04:43 +0000)]
Invoke autoconf/autoreconf with the option --localdir or --include depending
on if pre/post autoconf 2.54. In 2.55 --localdir has been removed and replaced
with --include which was introduced in 2.53.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14996
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 13 Nov 2002 02:05:16 +0000 (02:05 +0000)]
Better type and bounds checking:
* fake-addrinfo.h [NEED_FAKE_GETADDRINFO]: Include errno.h.
(fake_getnameinfo): Check that socklen_t size arguments are positive and fit in
size_t; return EAI_SYSTEM/EINVAL if not. Use the size_t variants when calling
string functions.
Work around another AIX bug:
[_AIX]: Define NUMERIC_SERVICE_BROKEN.
[NUMERIC_SERVICE_BROKEN]: Include ctype.h and stdlib.h.
(getaddrinfo) [NUMERIC_SERVICE_BROKEN]: If the service name is a numeric
string, save its value and the socket type, pass a null pointer to the real
getaddrinfo, and patch the returned results.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14995
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 13 Nov 2002 01:50:12 +0000 (01:50 +0000)]
* Makefile.in (t_locate_kdc): Use normal CC_LINK rule for linking test program
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14994
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 12 Nov 2002 23:47:31 +0000 (23:47 +0000)]
Fix TCL_RPATH to explicitly insert system library path into
"-blibpath:" on AIX.
ticket: 1228
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14993
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 11 Nov 2002 21:54:53 +0000 (21:54 +0000)]
* get_myaddress.c (get_myaddress): Local array buf size should be counted in
ifreq structs, not ifconf structs.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14992
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Mon, 11 Nov 2002 20:23:43 +0000 (20:23 +0000)]
* Makefile.in (unit-test-body): Set RPC_TEST_SRVTAB based on process-id. Set
trap handler to delete it before returning an exit status.
(unit-test-cleanup): Don't delete files here.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14991
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Sat, 9 Nov 2002 03:35:29 +0000 (03:35 +0000)]
Oops, missed a few checks for eof
ticket: 1249
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14986
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Sat, 9 Nov 2002 01:39:45 +0000 (01:39 +0000)]
tests/dejagnu leaks ptys
* default.exp: Add (disabled) debugging code for catching leaking
ptys. expect eof from the correct spawn_ids when killing kdc and
kadmind to avoid leaking ptys.
ticket: new
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14984
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 9 Nov 2002 01:35:21 +0000 (01:35 +0000)]
* main.c (makeargv): Report an error if parsed arguments won't fit in margv
array.
* ftp_var.h (line, argbuf): Extend to 500 bytes.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14983
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 8 Nov 2002 22:33:59 +0000 (22:33 +0000)]
* pre.in (.et.h, .et.c): Drop "set -x"
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14982
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 7 Nov 2002 22:43:46 +0000 (22:43 +0000)]
rpc unit tests can fail due to race condition
The rpc unit tests can fail in fullrun.exp due to a failure to drain
output from the server in expire.exp. This commit works around the
problem by calling flush_server, but a real synchronization method
should probably be implemented, perhaps by having the server log when
a client disconnects.
* rpc_test.0/expire.exp (overlap): Add another call to
flush_server to make a race condition a little less likely. There
really should be better synchronization, as this test suite is
just full of race conditions waiting to happen.
ticket: new
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14979
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 7 Nov 2002 21:40:15 +0000 (21:40 +0000)]
Thanks, patch applied
* svr_principal.c (kadm5_setkey_principal_3): Apply patch from
Emily Ratliff to allow n_ks_tuple to be zero, which is the case if
being called from kadmind answering a client's setkey_principal
request.
ticket: 1008
target_version: 1.3
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14978
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Thu, 7 Nov 2002 20:14:19 +0000 (20:14 +0000)]
* conv_princ.c (strnchr): Make length argument unsigned int
* preauth2.c: Add parentheses around assignment used as truth
value. Cleanup unused variable.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14976
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Thu, 7 Nov 2002 20:09:02 +0000 (20:09 +0000)]
* asn1_k_encode.c (asn1_encode_sam_challenge_2): Test for error
returned from asn1buf_insert_oxtetstring and cleanup strctures
properly.
* asn1_k_decode.c (asn1_decode_sam_challenge_2_body): Change
sequence_of/end_sequence_of to use
sequence_of_no_tagvars/end_sequence_of_no_tagravs to avoid
shadowing variables.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14975
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Thu, 7 Nov 2002 17:01:34 +0000 (17:01 +0000)]
For sam_challenge do not encode optional strings if string not present.
Previously, a string of length zero was transmitted.
ticket: 1224
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14974
dc483132-0cff-0310-8789-
dd5450dbe970
Sam Hartman [Wed, 6 Nov 2002 19:41:13 +0000 (19:41 +0000)]
New file to define SPNEGO structures
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14973
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 6 Nov 2002 00:42:57 +0000 (00:42 +0000)]
This commit fixes up the in-tree callers of krb5_read_password() and
des_read_password(). We should perhaps tighten up the test suite now.
ticket: 1217
status: open
target_version: 1.3
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14972
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 5 Nov 2002 21:54:47 +0000 (21:54 +0000)]
* asn1_encode.h (asn1_encode_oid):
* asn1_encode.c (asn1_encode_oid): New function.
* asn1_decode.h (asn1_decode_oid):
* asn1_decode.c (asn1_decode_oid): New function.
ticket: 1223
target_version: 1.3
component: krb5-libs
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14971
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 5 Nov 2002 04:52:24 +0000 (04:52 +0000)]
New Makefile variable RPATH_FLAG, possibly used even when we're not
building shared libs. TCL_MAYBE_RPATH gets used to account for
linking a shared tcl lib when we're not building shared libs.
ticket: 1228
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14969
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 4 Nov 2002 02:20:51 +0000 (02:20 +0000)]
* do_as_req.c (process_as_req): Fix previous patch; it caused an
uninitialized pointer to be dereferenced under certain error
conditions.
ticket: 1206
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14964
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Hornstein [Sun, 3 Nov 2002 20:31:33 +0000 (20:31 +0000)]
Calling convention for krb5int_c_combine_keys does not match prototype
The Windows calling convention for krb5int_c_combine_keys does not match the
prototype in k5-int.h. I missed this during the initial commit since I
neglected to test out the build of this code on Windows.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14962
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Sat, 2 Nov 2002 18:27:11 +0000 (18:27 +0000)]
This fixes some test suite password prompt checks that were missed
earlier.
* kpasswd.0/changing.exp:
* lib/helpers.exp: Make checks for password prompts more lenient.
ticket: 1217
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14961
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 1 Nov 2002 22:13:57 +0000 (22:13 +0000)]
MITKRB5-SA-2002-002 buffer overflow in kadmind4
* kadm_ser_wrap.c (kadm_ser_in): Apply fix for MITKRB5-SA-2002-002
buffer overflow.
ticket: new
status: open
version_reported: 1.2.6
target_version: 1.2.7
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14959
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 31 Oct 2002 23:29:48 +0000 (23:29 +0000)]
* Makefile.in (check-unix): Don't run t_pkcs5
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14956
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 31 Oct 2002 23:03:47 +0000 (23:03 +0000)]
* xdr_alloc.c (xdralloc_putlong): Coerce value pointed to by argument to 32
bits, rather than reading only 32 bits from the supplied address.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14954
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 31 Oct 2002 22:54:00 +0000 (22:54 +0000)]
* k5-int.h (krb5_ser_handle): Now points to const.
(krb5_kt_dfl_ops): Now const.
(struct _krb5_kt_ops): Field serializer now points to const krb5_ser_entry
instead of void.
* krb5.hin (struct _krb5_kt): Field ops now points to const.
* kt_file.c (krb5_ktf_ops, krb5_ktf_writable_ops): Now const. Drop cast of
serializer entry initializer.
(fopen_mode_rbplus, fopen_mode_rb): Now const.
* kt_srvtab.c (krb5_kts_ops): Now const.
* ktbase.c (krb5_ktf_ops, krb5_kts_ops): Update declarations.
(struct krb5_kt_typelist): Field ops now points to const.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14953
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Thu, 31 Oct 2002 21:44:04 +0000 (21:44 +0000)]
* aclocal.m4 (AC_KRB5_TCL_FIND_CONFIG): Use 'eval' when setting TCL_LIBS to
force variable substitutions to take place.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14952
dc483132-0cff-0310-8789-
dd5450dbe970