krb5.git
16 years agoApply adapted patch from http://bugs.debian.org/480434 to recurse into
Tom Yu [Mon, 20 Oct 2008 20:11:33 +0000 (20:11 +0000)]
Apply adapted patch from bugs.debian.org/480434 to recurse into
SPNEGO creds when attempting to retrieve a mechanism cred.

ticket: 5807

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20900 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoApply (adapted) patch from Apple to check for SPNEGO mechanism in
Tom Yu [Mon, 20 Oct 2008 19:39:52 +0000 (19:39 +0000)]
Apply (adapted) patch from Apple to check for SPNEGO mechanism in
export_lucid_sec_ctx.

ticket: 6015

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20899 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUse strdup in place of malloc/strcpy in many places
Greg Hudson [Mon, 20 Oct 2008 18:18:49 +0000 (18:18 +0000)]
Use strdup in place of malloc/strcpy in many places

ticket: 6200
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20898 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoInclude k5-platform.h for SIZE_MAX
Ezra Peisach [Sun, 19 Oct 2008 13:10:52 +0000 (13:10 +0000)]
Include k5-platform.h for SIZE_MAX

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20897 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIn krb5_def_store_mkey(), mktemp was being invoked with a string WRFILE:....
Ezra Peisach [Sun, 19 Oct 2008 10:44:56 +0000 (10:44 +0000)]
In krb5_def_store_mkey(), mktemp was being invoked with a string WRFILE:....
This returns an error - as it actually tries to open the file.
Move some of the logic that points to the actual filename earlier - so
mktemp works on the .... portion.

Note that the netbsd linker gives a warning on using mktemp as it may be
insecure - but there is no obvious way to avoid it.

ticket: new
subhect: netbsd mktemp actually tries to open file

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20896 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMake all dialogs beyond the change password sheet also appear as sheets
Justin Anderson [Fri, 17 Oct 2008 22:08:12 +0000 (22:08 +0000)]
Make all dialogs beyond the change password sheet also appear as sheets

ticket:6145

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20894 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdapted patch from Apple to work around SAMBA mech OID quirks and to
Tom Yu [Fri, 17 Oct 2008 22:05:32 +0000 (22:05 +0000)]
Adapted patch from Apple to work around SAMBA mech OID quirks and to
disable sending request flags.

ticket: 6016

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20893 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoStop using -[NSWindow setIgnoresMouseEvents:] and manage enabled state of each contro...
Justin Anderson [Fri, 17 Oct 2008 19:41:02 +0000 (19:41 +0000)]
Stop using -[NSWindow setIgnoresMouseEvents:] and manage enabled state of each control individually with bindings

ticket:6198

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20890 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKerberosAgent continues to ignore mouse events after error
Justin Anderson [Fri, 17 Oct 2008 19:26:29 +0000 (19:26 +0000)]
KerberosAgent continues to ignore mouse events after error

Problem when trying to change password from behind a NAT. The ensuing error dialog ignores mouse events, making it impossible to dismiss.

ticket:new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20889 dc483132-0cff-0310-8789-dd5450dbe970

16 years agotemporary testing code
Alexandra Ellwood [Fri, 17 Oct 2008 18:50:19 +0000 (18:50 +0000)]
temporary testing code

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20888 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKLCreatePrincipalFromTriplet should work with empty instance
Alexandra Ellwood [Fri, 17 Oct 2008 18:34:51 +0000 (18:34 +0000)]
KLCreatePrincipalFromTriplet should work with empty instance

Fixed bug where shim layer was calling kim_identity_create_from_components
incorrectly in this case.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20887 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdded back KLL test programs
Alexandra Ellwood [Fri, 17 Oct 2008 18:15:25 +0000 (18:15 +0000)]
Added back KLL test programs

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20886 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoDouble free and leak in kim_os_library_get_application_path
Alexandra Ellwood [Fri, 17 Oct 2008 18:13:47 +0000 (18:13 +0000)]
Double free and leak in kim_os_library_get_application_path

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20885 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRemap some of the more confusing krb5 errors
Alexandra Ellwood [Fri, 17 Oct 2008 17:07:03 +0000 (17:07 +0000)]
Remap some of the more confusing krb5 errors

Also enlarged last error buffer for UTF8 strings with multibyte chars.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20884 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoTreat unreadable terminal as user cancelled so regression tests work
Alexandra Ellwood [Fri, 17 Oct 2008 17:05:31 +0000 (17:05 +0000)]
Treat unreadable terminal as user cancelled so regression tests work

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20883 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMake sure identity is set when using kim prompter
Alexandra Ellwood [Fri, 17 Oct 2008 17:04:09 +0000 (17:04 +0000)]
Make sure identity is set when using kim prompter

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20882 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUse a context to store error table info
Alexandra Ellwood [Fri, 17 Oct 2008 15:45:05 +0000 (15:45 +0000)]
Use a context to store error table info

Just sticking an einfo on the stack doesn't work because it's not
initialized.  Also the detailed error message doesn't end up propogated back
to KIM.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20881 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoWhen change password is called from the Select Identity dialog, it appears as a sheet...
Justin Anderson [Thu, 16 Oct 2008 21:41:38 +0000 (21:41 +0000)]
When change password is called from the Select Identity dialog, it appears as a sheet on that dialog instead of popping up as a separate window

ticket:6145

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20880 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFix tests/misc/Makefile.in to use KRB5_BASE_LIBS instead of KRB5_LIB,
Greg Hudson [Thu, 16 Oct 2008 17:21:06 +0000 (17:21 +0000)]
Fix tests/misc/Makefile.in to use KRB5_BASE_LIBS instead of KRB5_LIB,
making it consistent with other programs we build.  KRB5_LIB by itself
may not find dependent libraries if they haven't been installed yet.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20879 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMake it possible to make identities use default ticket options
Justin Anderson [Thu, 16 Oct 2008 01:44:39 +0000 (01:44 +0000)]
Make it possible to make identities use default ticket options

- Made KerberosAgent compatible with KIM's way of passing about NULL to mean "Use default options"
- Added "Use default ticket options" checkbox to both ticket options dialogs.
- Hid ticket options of select identity dialog by default, visible via the "Show Options" "Hide Options" toggle.

ticket:6147

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20878 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoremove unused variable in kim_ui_cli_ask_change_password
Alexandra Ellwood [Wed, 15 Oct 2008 22:45:10 +0000 (22:45 +0000)]
remove unused variable in kim_ui_cli_ask_change_password

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20877 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUntabify. Normalize whitespace. Reindent. Fix some of the most
Tom Yu [Wed, 15 Oct 2008 21:58:43 +0000 (21:58 +0000)]
Untabify.  Normalize whitespace.  Reindent.  Fix some of the most
egregious formatting quirks.  Add emacs mode settings to flag
untabified source files.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20876 dc483132-0cff-0310-8789-dd5450dbe970

16 years agouse KIM_BUILTIN_UI instead of LEAN_CLIENT for builtin UI
Alexandra Ellwood [Wed, 15 Oct 2008 21:50:26 +0000 (21:50 +0000)]
use KIM_BUILTIN_UI instead of LEAN_CLIENT for builtin UI

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20875 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMove GUI/CLI detection from KerberosIPC into KIM
Alexandra Ellwood [Wed, 15 Oct 2008 21:41:00 +0000 (21:41 +0000)]
Move GUI/CLI detection from KerberosIPC into KIM

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20874 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMerge KerberosIPC into k5_mig support
Alexandra Ellwood [Wed, 15 Oct 2008 21:35:23 +0000 (21:35 +0000)]
Merge KerberosIPC into k5_mig support

Now that there are no servers using only kipc_* calls, merge
them into the k5_mig_* calls.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20873 dc483132-0cff-0310-8789-dd5450dbe970

16 years agohandle stash file names with missing keytab type spec and colon in path
Ken Raeburn [Wed, 15 Oct 2008 17:37:21 +0000 (17:37 +0000)]
handle stash file names with missing keytab type spec and colon in path

Currently the keytab name resolution code will pass off any name with
no colon to the default keytab type handler, which is the FILE
handler.  It will also check for Windows file names consisting of one
letter followed by a colon, and treat them as FILE specs also.

If a UNIX pathname contains a colon, however, and no type was
explicitly specified, the leading part of the pathname gets treated as
a type name and fails to match anything.  It should instead treat
type-less names starting with "/" as FILE specs also.

Tweak the test suite to use such a name.

Report and patch from Apple.  rdar://problem/6179239

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20872 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoNow that we have support for conditionally exporting symbols from the support
Ken Raeburn [Wed, 15 Oct 2008 16:27:46 +0000 (16:27 +0000)]
Now that we have support for conditionally exporting symbols from the support
library, use that for the [v]asprintf replacement functions when needed.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20871 dc483132-0cff-0310-8789-dd5450dbe970

16 years agomakedepend
Ken Raeburn [Wed, 15 Oct 2008 16:18:16 +0000 (16:18 +0000)]
makedepend

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20870 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoPre-populate new clients with default client identity if that is set, as found by...
Justin Anderson [Tue, 14 Oct 2008 19:49:27 +0000 (19:49 +0000)]
Pre-populate new clients with default client identity if that is set, as found by kim_preferences_get_client_identity()

ticket:6183

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20869 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoDon't wipe out previously entered information with each new call from clients
Justin Anderson [Tue, 14 Oct 2008 19:48:06 +0000 (19:48 +0000)]
Don't wipe out previously entered information with each new call from clients

ticket: 6143

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20868 dc483132-0cff-0310-8789-dd5450dbe970

16 years agokim test suite reports error messages incorrectly
Alexandra Ellwood [Tue, 14 Oct 2008 16:54:04 +0000 (16:54 +0000)]
kim test suite reports error messages incorrectly

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20867 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFree error message returned by krb5_get_error_message
Alexandra Ellwood [Tue, 14 Oct 2008 16:52:39 +0000 (16:52 +0000)]
Free error message returned by krb5_get_error_message

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20866 dc483132-0cff-0310-8789-dd5450dbe970

16 years agokim_os_string_create_localized leaks CFStringRef
Alexandra Ellwood [Fri, 10 Oct 2008 21:58:26 +0000 (21:58 +0000)]
kim_os_string_create_localized leaks CFStringRef

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20865 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoTest KIM plugin
Alexandra Ellwood [Fri, 10 Oct 2008 20:55:47 +0000 (20:55 +0000)]
Test KIM plugin

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20864 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoalways zero out authentication strings
Alexandra Ellwood [Fri, 10 Oct 2008 20:55:24 +0000 (20:55 +0000)]
always zero out authentication strings

strings returned by the UI are usually passwords or pins
and should not get dripped all over memory.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20863 dc483132-0cff-0310-8789-dd5450dbe970

16 years agokim_ui_plugin_fini sends pointer to context instead of context
Alexandra Ellwood [Fri, 10 Oct 2008 20:50:48 +0000 (20:50 +0000)]
kim_ui_plugin_fini sends pointer to context instead of context

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20862 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoallow kim ui plugins to have any name
Alexandra Ellwood [Fri, 10 Oct 2008 20:50:07 +0000 (20:50 +0000)]
allow kim ui plugins to have any name

Note that there can still only be one, it will just use the
first one it finds.  Just want to have different names for them
so that we can distinguish between different plugins.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20861 dc483132-0cff-0310-8789-dd5450dbe970

16 years agochange password should always reprompt on error
Alexandra Ellwood [Fri, 10 Oct 2008 20:47:05 +0000 (20:47 +0000)]
change password should always reprompt on error

Since it collects the password ahead of time, the prompt
count won't get incremented.  Checking whether it
called auth_prompt is useless.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20860 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoPKINIT specs, draft 9 and final standard
Ken Raeburn [Fri, 10 Oct 2008 20:14:25 +0000 (20:14 +0000)]
PKINIT specs, draft 9 and final standard

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20859 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMissing keys in KerberosAgent Info.plist
Alexandra Ellwood [Thu, 9 Oct 2008 21:22:29 +0000 (21:22 +0000)]
Missing keys in KerberosAgent Info.plist

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20856 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoprefs should not create empty dictionary for KIM_OPTIONS_DEFAULT
Alexandra Ellwood [Thu, 9 Oct 2008 19:15:27 +0000 (19:15 +0000)]
prefs should not create empty dictionary for KIM_OPTIONS_DEFAULT

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20855 dc483132-0cff-0310-8789-dd5450dbe970

16 years agopreferences should handle KIM_OPTIONS_DEFAULT
Alexandra Ellwood [Thu, 9 Oct 2008 17:51:03 +0000 (17:51 +0000)]
preferences should handle KIM_OPTIONS_DEFAULT

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20854 dc483132-0cff-0310-8789-dd5450dbe970

16 years agokim_options_create sometimes returns KIM_OPTIONS_DEFAULT
Alexandra Ellwood [Thu, 9 Oct 2008 17:49:23 +0000 (17:49 +0000)]
kim_options_create sometimes returns KIM_OPTIONS_DEFAULT

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20853 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKL APIs which take a NULL principal return klParameterErr
Alexandra Ellwood [Thu, 9 Oct 2008 02:35:38 +0000 (02:35 +0000)]
KL APIs which take a NULL principal return klParameterErr

Fixed by making kim_ccache_create_from_client_identity take KIM_IDENTITY_ANY
(at which point it returns the system default ccache).

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20850 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoCrash in kim_credential_create_from_keytab
Alexandra Ellwood [Thu, 9 Oct 2008 02:11:51 +0000 (02:11 +0000)]
Crash in kim_credential_create_from_keytab

Was dereferencing NULL freeing creds.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20849 dc483132-0cff-0310-8789-dd5450dbe970

16 years agokim_options_copy should allow in_options to be KIM_OPTIONS_DEFAULT
Alexandra Ellwood [Thu, 9 Oct 2008 01:05:08 +0000 (01:05 +0000)]
kim_options_copy should allow in_options to be KIM_OPTIONS_DEFAULT

(Don't error on NULL in_options)

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20848 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKerberosAgent should log less
Justin Anderson [Wed, 8 Oct 2008 22:21:46 +0000 (22:21 +0000)]
KerberosAgent should log less

Remove auto-quit log message, "No active clients. Terminating."

ticket:new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20847 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRemoved unused header file include.
Alexandra Ellwood [Wed, 8 Oct 2008 22:20:48 +0000 (22:20 +0000)]
Removed unused header file include.
(Not necessary for fix, just a cleanup)

ticket: 6146

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20846 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIgnore user interaction while busy. Done by toggling ignoresMouseEvents on auth dialogs
Justin Anderson [Wed, 8 Oct 2008 22:14:27 +0000 (22:14 +0000)]
Ignore user interaction while busy. Done by toggling ignoresMouseEvents on auth dialogs

ticket:6144

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20845 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKLL should use __attribute ((deprecated))
Alexandra Ellwood [Wed, 8 Oct 2008 21:51:35 +0000 (21:51 +0000)]
KLL should use __attribute ((deprecated))

Switched from a macro to GCC deprecated attributes.

Also removed the deprecated struct used by KLSetApplicationOptions
and KLGetApplicationOptions because they weren't touching it.
Replaced pointer-to-struct arguments with void *.

KLGetApplicationOptions now also returns an error since it did
not modify its input.  Not sure why it wasn't before since no one
should be calling it on Mac OS X.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20844 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKerberosAgent should handle zoom button better
Justin Anderson [Wed, 8 Oct 2008 02:01:06 +0000 (02:01 +0000)]
KerberosAgent should handle zoom button better

The Select Identity dialog should resize to fit the available identities in its table when the zoom button is clicked.

ticket: new
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20840 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKerberosAgent fails to handle multiple clients because it attempts to message freed...
Justin Anderson [Tue, 7 Oct 2008 21:55:01 +0000 (21:55 +0000)]
KerberosAgent fails to handle multiple clients because it attempts to message freed memory

ticket: new
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20839 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKIM should remember options and identity if prefs indicate
Alexandra Ellwood [Tue, 7 Oct 2008 21:12:55 +0000 (21:12 +0000)]
KIM should remember options and identity if prefs indicate

Added code to remember ticket options if settings indicate it.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20838 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKLL shim layer does not correctly handle options
Alexandra Ellwood [Tue, 7 Oct 2008 21:12:05 +0000 (21:12 +0000)]
KLL shim layer does not correctly handle options

KLGetDefaultLoginOption and KLSetDefaultLoginOption were
incorrectly casting parameters and were not parsing the
option argument correctly.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20837 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIf the caller is a bundle, look up keys in its plist file to get the name
Alexandra Ellwood [Tue, 7 Oct 2008 19:23:10 +0000 (19:23 +0000)]
If the caller is a bundle, look up keys in its plist file to get the name

ticket: 6146

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20836 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKLLastChangedTime should return current time, not 0
Alexandra Ellwood [Tue, 7 Oct 2008 18:58:53 +0000 (18:58 +0000)]
KLLastChangedTime should return current time, not 0

cc_context_get_change_time returns 0 the first time it is called
if the CCacheServer is not running.  KLLastChangedTime always
returned the current time on the first call.  So use globals and
a mutex to make sure that KLLastChangedTime both monotonically
increases and also returns the current time on the first call.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20835 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoInclude header to get error table for KLL
Alexandra Ellwood [Mon, 6 Oct 2008 21:58:59 +0000 (21:58 +0000)]
Include header to get error table for KLL

ticket: 6154

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20834 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoHinge building KLL shim off KIM_TO_KLL_SHIM, not LEAN_CLIENT
Alexandra Ellwood [Mon, 6 Oct 2008 21:24:20 +0000 (21:24 +0000)]
Hinge building KLL shim off KIM_TO_KLL_SHIM, not LEAN_CLIENT

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20833 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoSubstitute LDAP in makefiles with "yes" or "no" depending on configuration.
Ken Raeburn [Mon, 6 Oct 2008 21:18:36 +0000 (21:18 +0000)]
Substitute LDAP in makefiles with "yes" or "no" depending on configuration.
Split ASN.1 encode and decode tests so that they can be run independently
and/or in parallel.
Add ASN.1 tests for LDAP key-data sequence type, run only if LDAP enabled.
Use krb5int_access to get at the encoder and decoder.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20832 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdd KLL error table
Alexandra Ellwood [Mon, 6 Oct 2008 21:16:07 +0000 (21:16 +0000)]
Add KLL error table

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20831 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoDon't touch keychain if home directory access is disabled
Alexandra Ellwood [Mon, 6 Oct 2008 20:28:04 +0000 (20:28 +0000)]
Don't touch keychain if home directory access is disabled

Keychain is stored in the user's home directory.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20830 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoChange LDAP key-sequence encoder to use a single data structure
Ken Raeburn [Mon, 6 Oct 2008 20:25:45 +0000 (20:25 +0000)]
Change LDAP key-sequence encoder to use a single data structure

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20829 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFix a few missing-decl, signed/unsigned warnings
Ken Raeburn [Mon, 6 Oct 2008 20:04:12 +0000 (20:04 +0000)]
Fix a few missing-decl, signed/unsigned warnings

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20828 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoSee if we need a prototype for isblank
Ken Raeburn [Mon, 6 Oct 2008 20:03:09 +0000 (20:03 +0000)]
See if we need a prototype for isblank

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20827 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIn KRB5_NEED_PROTO, #undef the name before testing
Ken Raeburn [Mon, 6 Oct 2008 20:02:11 +0000 (20:02 +0000)]
In KRB5_NEED_PROTO, #undef the name before testing

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20826 dc483132-0cff-0310-8789-dd5450dbe970

16 years agowhitespace
Ken Raeburn [Mon, 6 Oct 2008 18:02:19 +0000 (18:02 +0000)]
whitespace

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20825 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFix some signed/unsigned warnings
Ken Raeburn [Mon, 6 Oct 2008 17:31:00 +0000 (17:31 +0000)]
Fix some signed/unsigned warnings

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20824 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoSet up db_module_dir correctly in krb5.conf for test
Tom Yu [Sat, 4 Oct 2008 00:01:25 +0000 (00:01 +0000)]
Set up db_module_dir correctly in krb5.conf for test

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20823 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoOnly close windows in response to fini messages from clients.
Justin Anderson [Fri, 3 Oct 2008 15:56:54 +0000 (15:56 +0000)]
Only close windows in response to fini messages from clients.
Only center the windows the first time they are shown for a client.
Improve the math on the NSRect sent to -[NSWindow setFrame:] so dialog windows don't jump around the screen and the title bar stays in the same place.
Refactor repeated view swapping code to -[AuthenticationController swapView:].

ticket: 6142

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20821 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMake select identity dialog remember its size, but not the table column widths. Make...
Justin Anderson [Thu, 2 Oct 2008 21:19:16 +0000 (21:19 +0000)]
Make select identity dialog remember its size, but not the table column widths. Make its default width 500px

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20819 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoLocalization fix for change password dialog
Justin Anderson [Thu, 2 Oct 2008 21:00:18 +0000 (21:00 +0000)]
Localization fix for change password dialog

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20818 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoSelect identity switched to using new NSDictionary based options and change password...
Justin Anderson [Thu, 2 Oct 2008 20:56:14 +0000 (20:56 +0000)]
Select identity switched to using new NSDictionary based options and change password menu item support

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20817 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoPassword is not expired when changing password from select and
Alexandra Ellwood [Thu, 2 Oct 2008 19:29:18 +0000 (19:29 +0000)]
Password is not expired when changing password from select and
enter identity dialogs.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20816 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoDon't write NULL name and path over stream. Just send empty strings
Alexandra Ellwood [Thu, 2 Oct 2008 19:13:48 +0000 (19:13 +0000)]
Don't write NULL name and path over stream.  Just send empty strings

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20815 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFix to get application name correctly. Was dropping argument
Alexandra Ellwood [Thu, 2 Oct 2008 19:12:59 +0000 (19:12 +0000)]
Fix to get application name correctly.  Was dropping argument
from launchservices and not removing extension from path in
fallback code.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20814 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUpdate to allow change password from select and enter identity dialogs
Justin Anderson [Thu, 2 Oct 2008 18:03:06 +0000 (18:03 +0000)]
Update to allow change password from select and enter identity dialogs

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20813 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoSupport for change password checkbox in enter and select
Alexandra Ellwood [Thu, 2 Oct 2008 17:38:36 +0000 (17:38 +0000)]
Support for change password checkbox in enter and select
identity ui elements.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20812 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoResize dialogs better, added progress indicator to show KerberosAgent is working...
Justin Anderson [Thu, 2 Oct 2008 17:34:17 +0000 (17:34 +0000)]
Resize dialogs better, added progress indicator to show KerberosAgent is working between interactions

Make Identity and Identities classes use NSDictionary representations of kim_options like the rest of KerberosAgent.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20811 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIncrease the default RPC timeout for kadmin from 25 seconds to 120
Greg Hudson [Thu, 2 Oct 2008 17:23:54 +0000 (17:23 +0000)]
Increase the default RPC timeout for kadmin from 25 seconds to 120
seconds.  Code changes from a patch submitted by umich.

ticket: 6120

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20810 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIn clntudp_call, fix a bug in the handling of an error case (it failed
Greg Hudson [Thu, 2 Oct 2008 16:53:57 +0000 (16:53 +0000)]
In clntudp_call, fix a bug in the handling of an error case (it failed
to set the error status field and generated a dead code warning).

ticket: 6121

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20809 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMake enter identity dialog's smarter about matching a string with a set of favorite...
Justin Anderson [Thu, 2 Oct 2008 13:20:04 +0000 (13:20 +0000)]
Make enter identity dialog's smarter about matching a string with a set of favorite options

ticket:6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20808 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMake Enter Identity dialog have one auto-completing, auto-validating text field for...
Justin Anderson [Thu, 2 Oct 2008 03:48:48 +0000 (03:48 +0000)]
Make Enter Identity dialog have one auto-completing, auto-validating text field for principals drawn from KIM's list of favorites.
Changed options for a favorite identity get saved out to kim_preferences.

Also, include copyright on more files.

ticket:6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20807 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUpdated documentation to reflect new APIs and re-ran Doxygen
Alexandra Ellwood [Wed, 1 Oct 2008 22:43:19 +0000 (22:43 +0000)]
Updated documentation to reflect new APIs and re-ran Doxygen

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20806 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFixed a bug in kim_identity_get_components string where it
Alexandra Ellwood [Wed, 1 Oct 2008 22:33:32 +0000 (22:33 +0000)]
Fixed a bug in kim_identity_get_components string where it
would return the first component multiple times.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20805 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMake unset strings in kim_options and kim_selection_hints
Alexandra Ellwood [Wed, 1 Oct 2008 21:59:16 +0000 (21:59 +0000)]
Make unset strings in kim_options and kim_selection_hints
be empty strings rather than NULL.  This simplifies the
stream code (and makes it easier to read and debug).
In order to prevent copying tons of NUL bytes around,
special case kim_string functions to use a special
constant kim_empty_string.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20804 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFixed crash in kim_options_write_to_stream
Alexandra Ellwood [Wed, 1 Oct 2008 21:16:44 +0000 (21:16 +0000)]
Fixed crash in kim_options_write_to_stream
when in_options is KIM_OPTIONS_DEFAULT.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20803 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoReversed sense of checks for NUL character in empty string. Fixed
Alexandra Ellwood [Wed, 1 Oct 2008 21:00:49 +0000 (21:00 +0000)]
Reversed sense of checks for NUL character in empty string.  Fixed

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20802 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoCorrectly parse KIM_IDENTITY_ANY in error handler
Alexandra Ellwood [Wed, 1 Oct 2008 20:58:56 +0000 (20:58 +0000)]
Correctly parse KIM_IDENTITY_ANY in error handler

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20801 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoLoop on enter identity if auth fails
Alexandra Ellwood [Wed, 1 Oct 2008 20:56:57 +0000 (20:56 +0000)]
Loop on enter identity if auth fails

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20800 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoCorrectly translate NULL hints when reading from a stream
Alexandra Ellwood [Wed, 1 Oct 2008 20:55:49 +0000 (20:55 +0000)]
Correctly translate NULL hints when reading from a stream

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20799 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRelaunch KerberosAgent more quickly so UI is more responsive
Alexandra Ellwood [Wed, 1 Oct 2008 20:55:04 +0000 (20:55 +0000)]
Relaunch KerberosAgent more quickly so UI is more responsive

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20798 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUpdate enterIdentity handler to support passing and setting ticket options.
Justin Anderson [Wed, 1 Oct 2008 20:38:26 +0000 (20:38 +0000)]
Update enterIdentity handler to support passing and setting ticket options.
Readded ticket options sheet to Enter Identity dialog.
Added helper methods to convert between kim_option and NSDictionary.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20797 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFinished KLL to KIM shim.
Alexandra Ellwood [Wed, 1 Oct 2008 19:34:06 +0000 (19:34 +0000)]
Finished KLL to KIM shim.
Switched krb5 code to using it.

ticket: 6134

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20796 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFill out credentials when getting tickets with changed password
Alexandra Ellwood [Wed, 1 Oct 2008 17:11:22 +0000 (17:11 +0000)]
Fill out credentials when getting tickets with changed password

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20795 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoSupport for passing options back and forth for enter_identity and
Alexandra Ellwood [Wed, 1 Oct 2008 15:35:48 +0000 (15:35 +0000)]
Support for passing options back and forth for enter_identity and
hints back for select_identity.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20794 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoA working KIM-based KerberosAgent to handle all of KIM's built-in GUI prompting.
Justin Anderson [Wed, 1 Oct 2008 14:12:31 +0000 (14:12 +0000)]
A working KIM-based KerberosAgent to handle all of KIM's built-in GUI prompting.

A few outstanding issues remain, like the ability to add duplicate entries to the list of favorite identities.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20793 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoWhen kim_options_write_to_stream is given NULL options, create default options in...
Justin Anderson [Wed, 1 Oct 2008 14:01:03 +0000 (14:01 +0000)]
When kim_options_write_to_stream is given NULL options, create default options in its place instead of erroring out

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20792 dc483132-0cff-0310-8789-dd5450dbe970

16 years agokim_selection_hints_get_identity should call kim_ui_fini even when kim_ui_select_iden...
Justin Anderson [Wed, 1 Oct 2008 14:00:16 +0000 (14:00 +0000)]
kim_selection_hints_get_identity should call kim_ui_fini even when kim_ui_select_identity returns an error, e.g. KIM_USER_CANCELED_ERR

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20791 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoCheck for NULL hints_array passed back from kim_os_selection_hints_get_selection_hint...
Justin Anderson [Wed, 1 Oct 2008 13:57:19 +0000 (13:57 +0000)]
Check for NULL hints_array passed back from kim_os_selection_hints_get_selection_hints_array in kim_os_selection_hints_lookup_identity

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20790 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFirst pass at KLL shim layer. (no private apis)
Alexandra Ellwood [Wed, 1 Oct 2008 07:56:57 +0000 (07:56 +0000)]
First pass at KLL shim layer. (no private apis)
KIM support for KLL shim layer.

Fixed a bug where the cli support was double freeing a credential
in the change password case.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20789 dc483132-0cff-0310-8789-dd5450dbe970