krb5.git
17 years ago When using the Vista SDK version of NTSecAPI.h it is necessary
Jeffrey Altman [Wed, 21 Mar 2007 04:48:09 +0000 (04:48 +0000)]
When using the Vista SDK version of NTSecAPI.h it is necessary
to ensure the _WIN32_WINNT have a value of 0x0501 or greater.
Otherwise, required LSA type declarations are undeclared.

Provide a registry value that can be set to turn on Application
Event log messages for debugging.

HKLM\System\CurrentControlSet\Services\MIT Kerberos\Network Provider
DWORD "Debug"

Ensure that KFW_obtain_user_temp_directory() returns a value on
error.

Correct the declaration of KFW_copy_cache_to_system_file()
to match the prototype.

ticket: 5469

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19240 dc483132-0cff-0310-8789-dd5450dbe970

17 years agokrb5 library uses kdc.conf when it shouldn't
Ken Raeburn [Wed, 21 Mar 2007 04:14:02 +0000 (04:14 +0000)]
krb5 library uses kdc.conf when it shouldn't

Don't add kdc.conf to the list of config files to use unless it's
actually requested.  Reported by Will Fiveash.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19239 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoNIM: New Default View and miscellaneous fixes
Jeffrey Altman [Tue, 20 Mar 2007 20:41:52 +0000 (20:41 +0000)]
NIM: New Default View and miscellaneous fixes

================================
KfW 3.1 Alpha (NetIDMgr 1.1.11.0)

-- nidmgr32.dll

- Only one action in a menu is allowed to have KHUI_ACTIONREF_DEFAULT
  flag set.  This marks the action as being the default action for the
  menu and will be rendered as such.

- Newly created identities start off with the KCDB_IDENT_FLAG_EMPTY
  flag set.  Once credentials are associated with the identity and the
  identity is refreshed, the flag will be cleared.

- When creating actions, enforce the name length.

- khm_value_exists() now handles shadowed configuration spaces.

- Add new action KHUI_ACTION_LAYOUT_MINI which toggles between
  'Advanced' and 'Basic' views.

- Add support for F11 and F12 keys in khui_get_cmd_accel_string().

- New option for alerts to indicate that instead of just setting the
  response field in the alert, the UI should dispatch the command
  that the user has selected.

-- krb5common.obj

- khm_krb5_initialize() can return a handle to a krb5_ccache that has
  already been closed.  Now it doesn't.

- Also import 'krb5_string_to_deltat()'.

- Work around conditioned symbol definitions in ntsecapi.h in the
  Vista Platform SDK that affect Win 2000.

-- krb5cred.dll

- Don't clear the prompts when the options for an identity changes.
  The prompter code relies on the prompts being around so that the
  values that the user has entered can be retained if the new set of
  prompts is the same as the old one.

- Use the same code in the new credentials acquisition and the
  identity configuration code to obtain krb5 parameters for an
  identity.

- Reset the 'IMPORTED' flag when we get new credentials using a
  password.

- If the validity of a principal is not known, then we restrict the
  options that can be specified when calling
  krb5_get_init_creds_password() so that we can reliably determine if
  the principal is valid.  If we need to get new credentials for the
  principal, we need to make another call using the correct options.

- The return codes from the prompter need to indicate that the
  password read operation was cancelled instead of arbiraty non-zero
  values.

- When reading identity settings, if a particular setting is not
  defined in the registry, then default to reading the settings out of
  krb5.ini.

- Refer to credentials as 'credentials' or 'tickets' instead of
  'creds'.

- If an identity has imported credentials, don't import for the same
  identity again.

- When importing an identity, create the identity configuration in the
  registry if we don't already have any settings there.

- Work around conditioned symbol definitions in ntsecapi.h in the
  Vista Platform SDK that affect Win 2000.

- Rearrange declarations for clarity.

- Use the correct APIs to parse configuration values from krb5.ini.

-- krb4cred.dll

- The dialog layout was updated to accomodate a localized string that
  no longer fit in its control.

- Remove a spurious inclusion of ntsecapi.h and work around
  conditioned symbol definition in the Vista Platform SDK.

-- netidmgr.exe

- Fix the menu creation code to correctly tag the default action so
  that it will be rendered properly.

- Update the menu enumeration code to use documented functions instead
  of accessing acton lists directly.

- Pool of per-identity actions now include a set of actions for
  obtaining credentials for specific identities.

- The default action performed when the notification icon is clicked
  is now configurable.  When displaying the context menu in the
  notification area, the default action is highlighted.

- Remove unnecessary handlers from the notifcation event handler.

- Only handle NIN_SELECT instead of both NIN_SELECT and WM_LBUTTONUP
  in the notification event handler.  When the user clicks the
  notication icon, both events are generated. NIN_SELECT is canonical.

- When the handling NIN_BALLOONUSERCLICK in the notification event
  handler, reset balloon_alert before displaying any new alerts so
  that we won't overwrite it later.

- Reset the notification alert icon after displaying an alert.

- If a renewal fails, the displayed alert contains a button that the
  user can click to initiate the process of acquiring new credentials
  for the identity.

- Alerts can optionally dispatch the commands that were added to it
  using the KHUI_ALERT_FLAG_DISPATCH_CMD flag.

- Increase the size of the About dialog.

- Correct the action text for the IDS_ACTION_OPEN_APP and
  IDS_ACTION_CLOSE_APP to say 'Show' and 'Hide' instead of 'Open' and
  'Close'.  These actions only control the visible state of the NIM
  window.

- Add additional notification which signals that the commandline has
  finished processing.

- Add an 'acquire' action to the per-identity actions.

- The per identity actions (renew, destroy, acquire) now have useful
  captions, names and tooltips.

- Use WM_NEXTDLGCTL message when changing the focus of dialog
  controls.  SetFocus() is insufficient.

- If we get a request to show a new credential acquisition dialog and
  we are already showing one, bring that one to the foreground instead
  of trying to display a new one or waiting quietly.

- New configuration schema for the UI that include definitions for the
  new default view.

- The alerter window can now show more than one alert at once.

- If we are about to show queued alerts, then check if the alerts that
  are waiting are related and if they can be grouped together.  If so,
  show them in a single alert window instead of multiple ones.

- If new alerts are issued while a set of alerts are being displayed
  and if the new alert is related to the alerts that are being
  displayed, then add the new alert to the list being displayed.

- Make sure we have a lock on the alert when we are manipulating or
  accessing it.

- Set the focus to the correct control when displaying an alert.

- When adding alerts from the alert queue, make sure we iterate
  through the queue properly.

- Allow keyboard navigation inside the alert window and support scroll
  bars.

- Check if we have a valid code pointer before invoking a UI callback.

- Make sure the main window is in the normal configuration before
  switching to a layout that rquires it.

- When moving the main window around, if it comes close to an edge of
  the working area of the display, snap to it.

- Maintain two sets of settings for the main window placement.  One
  for the mini mode and one for the normal mode.

- When processing saved window placement information from the
  configuration, handle docking hints which note which edges of the
  screen the main window should be adjacent to, if any.

- Switching to the 'Basic' view disables the layout and column
  selection menus.

- Position the new credentials dialog above the main window if the
  main window is visible.

- The alert that is displayed to indicate that an identity has
  expired, now contains a command button that can be used to invoke
  the new credentials dialog for that identity.

-- source

- Update the documentation to reflect the change in behavior regarding
  KHUI_ACTIONREF_DEFAULT in khui_menu_insert_action() and
  khui_menu_insert_paction().

- Remove notes about menu access functions being not thread safe.
  This is no longer true.

- Update the documentation for khui_alert_show() to document new
  behavior regarding KHUI_ALERT_FLAG_DISPATCH_CMD.

- Update documentation to indicate which KHUI_ALERT_FLAG_* flags are
  internal and document the new KHUI_ALERT_FLAG_DISPATCH_CMD flag.

- Augment the queue handling macros to support additional operations.
  Also add new tree data structure with an ordered list of children.

- Code reorganization to reuse code for obtaining the caption and
  tooltip for a system defined action in netidmgr.exe.

ticket: new
component: windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19238 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoEnable Vista support for MSLSA
Jeffrey Altman [Tue, 20 Mar 2007 07:13:18 +0000 (07:13 +0000)]
Enable Vista support for MSLSA

The MSLSA: ccache type when used on Windows Vista can take advantage of an ability to write tickets to the LSA credential cache for the current logon session.   This is possible due to the addition of the KERB_SUBMIT_TICKET interface.

Also new to Vista is the CACHE_INFO_EX2 interface which permits a much more efficient method of enumerating the contents of the LSA credential cache.

The code to take advantage of these features has been present for more than a year.  However, due to the lack of a public SDK that included the necessary data structures the functionality has been disabled.  As of this commit, the functionality will be enabled if the version of NTSecAPI.h includes TRUST_ATTRIBUTE_TRUST_USES_AES_KEYS.  This is a preprocessor symbol that is new to the Vista SDK.

In order to build with the new Vista functionality when using the XP SP2 SDK, the NTSecAPI.h file from the Vista SDK must be used in place of the version from the XP SP2 SDK.

This commit also addresses the issues associated with the inability to read session keys from a UAC limited process.   When UAC limitation is detected by examining the process token elevation level all access to the MSLSA contents is disabled.   At some point in the future we can implement an elevated COM service in order to obtain access to the session keys.

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19237 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoZero sockaddrs in fai_add_entry() so we can compare them with memcmp()
Alexandra Ellwood [Mon, 19 Mar 2007 20:21:54 +0000 (20:21 +0000)]
Zero sockaddrs in fai_add_entry() so we can compare them with memcmp()

If we don't zero the struct sockaddrs in fai_add_entry() then any sin_zero
fields will be left as random memory and the memcmp() will return that the
addresses are different even if they aren't.

ticket: new
target_version: 1.6.1
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19235 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoKfW automated build scripts & supporting files
Kevin Koch [Fri, 16 Mar 2007 18:38:28 +0000 (18:38 +0000)]
KfW automated build scripts & supporting files

Updated scripts & additional configuration files.

Ticket: new
Target_Version: 1.6.1
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19234 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoUpdate 3.1.0 to 3.2.0; update location of sample directory
Kevin Koch [Fri, 16 Mar 2007 18:35:59 +0000 (18:35 +0000)]
Update 3.1.0 to 3.2.0; update location of sample directory

Ticket: 5409
Target_Version: 1.6.1
Tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19233 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoUpdate build files for new version and file locations
Kevin Koch [Fri, 16 Mar 2007 03:55:52 +0000 (03:55 +0000)]
Update build files for new version and file locations

Target_Version: 1.6.1
Tags:  pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19232 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoOn Linux, add linker flags -Bsymbolic (makes for smaller libraries, at
Ken Raeburn [Thu, 15 Mar 2007 01:11:40 +0000 (01:11 +0000)]
On Linux, add linker flags -Bsymbolic (makes for smaller libraries, at
the cost of being able to override the symbol names we export) and
--no-undefined (errors out on shared library generation with undefined
symbols).

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19229 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoDepend on kadm5 server library too, now that we use the config_params calls
Ken Raeburn [Thu, 15 Mar 2007 01:10:10 +0000 (01:10 +0000)]
Depend on kadm5 server library too, now that we use the config_params calls

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19228 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoUse "unsigned __int{16,32}" types for Windows in load_{16,32}_n, per Kevin
Ken Raeburn [Wed, 14 Mar 2007 20:25:41 +0000 (20:25 +0000)]
Use "unsigned __int{16,32}" types for Windows in load_{16,32}_n, per Kevin

ticket: 5425

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19227 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago* kadm5_create.c: Include fake-addrinfo.h.
Ken Raeburn [Wed, 14 Mar 2007 01:52:23 +0000 (01:52 +0000)]
* kadm5_create.c: Include fake-addrinfo.h.
(add_admin_princs): Use getaddrinfo instead of gethostbyname.  Report
the correct message on getaddrinfo errors, and return EINVAL to
caller.

ticket: 5257

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19226 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoFix tail portability problem by adding an expression test to the
Ken Raeburn [Wed, 14 Mar 2007 00:52:47 +0000 (00:52 +0000)]
Fix tail portability problem by adding an expression test to the
existing awk invocation instead.  Patch from Robert Basch at MIT.

ticket: 5447

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19225 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoRemove test pass that exercises AES256 over UDP, since we also have
Ken Raeburn [Wed, 14 Mar 2007 00:42:55 +0000 (00:42 +0000)]
Remove test pass that exercises AES256 over UDP, since we also have
one that exercises the same configuration over TCP.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19224 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago* include/k5-platform.h: Add load_{16,32,64}_n for loading values from
Ken Raeburn [Wed, 14 Mar 2007 00:35:06 +0000 (00:35 +0000)]
* include/k5-platform.h: Add load_{16,32,64}_n for loading values from
(possibly unaligned) memory in native order.
* lib/krb5/krb/get_in_tkt.c (krb5_get_init_creds): Fetch four random
bytes from the crypto library and generate a 31-bit (non-negative)
nonce, instead of using the timestamp.

ticket: 5425

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19223 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago* sendto_kdc.c (default_debug_handler): If writing to a log file, keep
Ken Raeburn [Wed, 14 Mar 2007 00:26:57 +0000 (00:26 +0000)]
* sendto_kdc.c (default_debug_handler): If writing to a log file, keep
it open and unbuffered instead of always opening and closing.  When
the format string has characters to be copied literally to the output,
write them all at once instead of individually.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19222 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoKFW: Vista Integrated Logon
Jeffrey Altman [Tue, 13 Mar 2007 06:35:13 +0000 (06:35 +0000)]
KFW: Vista Integrated Logon

        On Windows Vista the GINA architecture was removed.  As a side
        effect the support for the Logon Event Handlers was also removed.
        The KFW Integrated Logon functionality relies on the "Logon"
        event handler to migrate the user's tickets from a secure FILE:
        ccache to an API: ccache so that the tickets will be available
        to NetIDMgr and all other Kerberos applications.

        This functionality is especially important on Vista for
        accounts that are members of the Administrators group because
        the User Account Control (UAC) restricts access to the session
        keys of all tickets in the MSLSA ccache.  The only way for
        tickets to be made available to MIT Kerberos applications is
        by obtaining them within the Network Provider and pushing them
        into the Logon Session.

        This patch replaces the missing Logon Event Handler support
        with a new exported function "LogonEventHandler" which adheres
        to the rundll32.exe specifications.  The "LogonEventHandler"
        function accepts as input the name of a FILE ccache and moves
        the contents into an API: ccache and then deletes the FILE
        ccache.

        In order for this to work the FILE ccache must be owned by
        the account that was used to logon to the current session.
        The NPLogonNotify() function must therefore lookup the SID
        for the active account, assign an appropriate DACL to the
        ccache file, and change the owner.  In addition, when Vista
        is in use a LogonScript must be constructed that will perform
        the call to rundll32.exe.

        Other changes include altering the prototype of
        KFW_copy_ccache_system_file to accept a filename instead of
        the LogonID.  This improves the abstraction and allows the
        filename to be computed once and passed into multiple
        functions from NPLogonNotify().

        Many debugging calls were added to assist with implementation.
        #define DEBUG 1 at the top of kfwcommon.c when you wish to
        build with debugging that generates entries in the Windows
        Application Event Viewer.

It is important to note that Integrated Logon attempts to
logon the username within the default realm within the
krb5.ini file using the provided password.  This is so
a local machine account name matching the default realm
can obtain Kerberos tickets by synchronizing the password.

ticket: new
component: windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19221 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoRemove from unused_passes a configuration also listed in the default passes
Ken Raeburn [Fri, 9 Mar 2007 01:47:05 +0000 (01:47 +0000)]
Remove from unused_passes a configuration also listed in the default passes

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19215 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoDo use valgrind on /bin/sh commands, since that's how we launch kadmind currently
Ken Raeburn [Tue, 6 Mar 2007 23:36:34 +0000 (23:36 +0000)]
Do use valgrind on /bin/sh commands, since that's how we launch kadmind currently

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19212 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoreverting commit to windows WIX installer (revision 19207)
Jeffrey Altman [Tue, 6 Mar 2007 23:30:47 +0000 (23:30 +0000)]
reverting commit to windows WIX installer (revision 19207)

Revision 19207 committed by Kevin Koch does not document changes
made to the Wix installer files.  The changes that were made remove
the installation of the configuration files and the inclusion of
leash32.chm.

When the decision is made to remove Leash from the installer,
the entire Leash feature and the associated properties used to
determine when it is installed must be removed.  Commenting out
individual file components is not sufficient.

Configuration files must be installed as part of KFW.  The
source of the configuration files is defined by the variable
"ConfigDir" within the site-local.wxi directory.

Any changes made to the WIX installer must also be made to the NSIS
installer.

The changes to the src/windows/wix directory from 19207 are
therefore reverted.

ticket: new
component: windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19211 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoosf1: get proper library dependencies installed
Ken Raeburn [Mon, 5 Mar 2007 23:51:22 +0000 (23:51 +0000)]
osf1: get proper library dependencies installed

The LDCOMBINE setting for Tru64 left out $(CFLAGS), which meant the
-pthread option wasn't being passed in, so the libraries didn't
indicate a dependency on the pthread library despite the fact that we
need it unconditionally (if thread support is enabled).  Including
$(CFLAGS) should fix this.

Our own binaries get linked with -pthread anyways, so they build okay,
but other binaries trying to link against or load our libraries could
have problems.

ticket: new
target_version: 1.6.1
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19208 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoTrain build script to use repository sources, omit sample configuration. [wix area.]
Kevin Koch [Mon, 5 Mar 2007 22:34:25 +0000 (22:34 +0000)]
Train build script to use repository sources, omit sample configuration.  [wix area.]

Add control of the repository access step, fetch all sources from the repository.  Track in documentation.

Eliminate unhelpful output during pre-package step.

The next step is to fetch only krb5/src/windows/build and run the entire build.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19207 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoMove automation documentation from wiki to here.
Kevin Koch [Mon, 5 Mar 2007 16:37:41 +0000 (16:37 +0000)]
Move automation documentation from wiki to here.
Minor tweaks to script (start adding unzip support) and config (move svn url to right place).

Target_Version: 1.6.1

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19206 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoAutomation for building KfW
Kevin Koch [Mon, 5 Mar 2007 14:07:07 +0000 (14:07 +0000)]
Automation for building KfW

Target_Version: 1.6.1
Component: KfW

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19205 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoBack out windows specific makefile change
Sam Hartman [Sat, 3 Mar 2007 00:49:58 +0000 (00:49 +0000)]
Back out windows specific makefile change

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19204 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoMore existence tests; path update
Kevin Koch [Fri, 2 Mar 2007 21:44:07 +0000 (21:44 +0000)]
More existence tests; path update

Modify remainder of Makefiles that were sensitive to identity/obj or other cleaned files not being present.

Update util/et/Makefile.in to look for com_err.h in src/include, not src/include/src.

ticket: 5457
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19203 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoTest for existence of identity/obj before try to delete files
Kevin Koch [Fri, 2 Mar 2007 20:42:26 +0000 (20:42 +0000)]
Test for existence of identity/obj before try to delete files

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19202 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoOn unload, free up g_mechSet and g_mechList
Ken Raeburn [Fri, 2 Mar 2007 05:30:30 +0000 (05:30 +0000)]
On unload, free up g_mechSet and g_mechList

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19201 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoupdate dependencies
Ken Raeburn [Fri, 2 Mar 2007 04:17:12 +0000 (04:17 +0000)]
update dependencies

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19199 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoDelete more stuff for 'clean' and 'distclean' targets
Ken Raeburn [Fri, 2 Mar 2007 03:48:59 +0000 (03:48 +0000)]
Delete more stuff for 'clean' and 'distclean' targets

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19198 dc483132-0cff-0310-8789-dd5450dbe970

17 years agovalgrind detects uninitialized (but really unused) bytes in 'queue'
Ken Raeburn [Thu, 1 Mar 2007 02:19:41 +0000 (02:19 +0000)]
valgrind detects uninitialized (but really unused) bytes in 'queue'

The gsstest program exports a GSSAPI security context to a blob in
memory, writes that memory to a file, and reads it back to use it.
Under valgrind, the writing phase triggers a warning about
uninitialized storage.

The "queue" structure as implemented in generic/util_ordering.c holds
an array of values, some of which may never be initialized.  As far as
I can tell, those uninitialized values are never used before being
initialized, either, but valgrind doesn't know that.

This patch zaps the structure contents (including the array) before
using the queue object.

ticket: new
target_version: 1.6.1
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19196 dc483132-0cff-0310-8789-dd5450dbe970

17 years agokrb5_get_cred_from_kdc fails to null terminate the tgt list
Jeffrey Altman [Thu, 1 Mar 2007 01:49:11 +0000 (01:49 +0000)]
krb5_get_cred_from_kdc fails to null terminate the tgt list

if the next tgt in a cross-realm traversal cannot be
obtained find_nxt_kdc() was calling krb5_free_creds()
on the last tgt in the list but was failing to nullify
the pointer to the cred that was just freed.

if there were no additional tgts obtained,
krb5_get_cred_from_kdc() would return a non-NULL terminated
cred list to the caller.  This would result in a crash
when attempting to manipulate the non-existent cred past
the end of the list.

This commit nullifies the credential pointer in
find_nxt_kdc() after the call to krb5_free_creds()

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19195 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago Add intalert.h which should have been added as part of
Jeffrey Altman [Wed, 28 Feb 2007 18:00:43 +0000 (18:00 +0000)]
Add intalert.h which should have been added as part of
revision 19189

ticket: 5452

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19191 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoWindows - some apps define ssize_t as a preprocessor symbol
Jeffrey Altman [Wed, 28 Feb 2007 07:10:33 +0000 (07:10 +0000)]
Windows - some apps define ssize_t as a preprocessor symbol

ticket: new
component: krb5-libs
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19190 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoNIM Improved Alert Management
Jeffrey Altman [Wed, 28 Feb 2007 07:01:21 +0000 (07:01 +0000)]
NIM Improved Alert Management

This patch implements the new Alert Management functionality.

Many improvements to avoid race conditions and improve resource
  tracking.

ticket: new
component: windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19189 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoUnused macro NEG removed
Ken Raeburn [Mon, 26 Feb 2007 23:36:46 +0000 (23:36 +0000)]
Unused macro NEG removed

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19183 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoWhen importing a name with a valid (non-null) handle but a zero
Ken Raeburn [Sat, 24 Feb 2007 00:58:05 +0000 (00:58 +0000)]
When importing a name with a valid (non-null) handle but a zero
length, set GSS_S_BAD_NAME but not GSS_S_CALL_INACCESSIBLE_READ.

ticket: 5445
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19172 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoIf a reflection is detected, zap the message buffer pointer output
Ken Raeburn [Sat, 24 Feb 2007 00:56:23 +0000 (00:56 +0000)]
If a reflection is detected, zap the message buffer pointer output
argument as well as actually freeing the buffer.  (Found while using
the gsstest option to exercise error conditions.)

ticket: 5445
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19171 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoInitialize "loopback" field in newly allocated name structure
Ken Raeburn [Thu, 22 Feb 2007 22:57:34 +0000 (22:57 +0000)]
Initialize "loopback" field in newly allocated name structure

ticket: 5445
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19170 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoEnsure consistancy between prototypes and functions
Ezra Peisach [Mon, 19 Feb 2007 02:37:10 +0000 (02:37 +0000)]
Ensure consistancy between prototypes and functions

I am using an older compiler that is complaining that prototypes
do not match the functions they reference.  The issue is that a number
of prototypes are using "const int foo" while the function is "int foo".
From a caller sense it makes no difference - but the compiler is correct
they are different.

All is now consistant.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19169 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoConditionalize some ipv6 bits
Ken Raeburn [Fri, 16 Feb 2007 21:43:28 +0000 (21:43 +0000)]
Conditionalize some ipv6 bits

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19168 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoConditionalize more bits that might not be defined by the OS
Ken Raeburn [Fri, 16 Feb 2007 21:40:44 +0000 (21:40 +0000)]
Conditionalize more bits that might not be defined by the OS

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19167 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoDon't use struct in6_addr if we don't have IPv6 support
Ken Raeburn [Fri, 16 Feb 2007 21:12:40 +0000 (21:12 +0000)]
Don't use struct in6_addr if we don't have IPv6 support

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19165 dc483132-0cff-0310-8789-dd5450dbe970

17 years agorename krb5_server_decrypt_ticket_keyblock() to
Tom Yu [Tue, 13 Feb 2007 00:35:48 +0000 (00:35 +0000)]
rename krb5_server_decrypt_ticket_keyblock() to
krb5int_server_decrypt_ticket_keyblock()

ticket: 5349

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19159 dc483132-0cff-0310-8789-dd5450dbe970

17 years agohack to permit GetEnvironmentVariable usage without requiring getenv() conversion
Jeffrey Altman [Mon, 12 Feb 2007 14:54:28 +0000 (14:54 +0000)]
hack to permit GetEnvironmentVariable usage without requiring getenv() conversion

Windows has a major flaw when it comes to the use of getenv/putenv.
getenv/putenv do not modify the actual environment of the process.
Instead, they modify a copy of the environment block at the time the
C Runtime Library was initialized for the current module.  In other
words, the C Runtime Library environment block for the executable
is not the same as the C Runtime Library environment block for the
krb5_32.dll library, etc.

This results in problems when a process wants to set the default
ccache name outside the krb5_context.  The krb5_context default ccname
disappears when the context is destroyed.  gss_acquire_cred() suffers
from the creation and destruction of krb5_contexts and therefore the
krb5_context default ccname cannot be used to set a default ccname.
Instead, the process environment must be used.

In order to modify the process environment, SetEnvironmentVariable()
must be used.  However, this does not result in the C Runtime Library
environment blocks being updated.  putenv() does not see the definition
of "KRB5CCNAME".

This patch modifies get_os_ccname() for Windows to check
GetEnvironmentVariable() before checking the registry.  This hack will
work as long as there is no "KRB5CCNAME" variable in the C Runtime
Library environment block.

The long term solution is to replace all calls to getenv and putenv
with GetEnvironmentVariable/SetEnvironmentVariable for Windows.

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19154 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoIn the resolve function - ensure on memory allocation error -
Ezra Peisach [Mon, 12 Feb 2007 00:19:47 +0000 (00:19 +0000)]
In the resolve function - ensure on memory allocation error -
deref of null pointer does not happen.

Also include kt-int.h for prototypes.

ticket: 5411

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19153 dc483132-0cff-0310-8789-dd5450dbe970

17 years agokrb5_kt_default_name should take an unsized length
Ezra Peisach [Mon, 5 Feb 2007 20:39:59 +0000 (20:39 +0000)]
krb5_kt_default_name should take an unsized length

The internal code to krb5_kt_default_name was casting the length to size_t.
Change prototype to take an unsigned - which makes sense in how the code uses
it.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19144 dc483132-0cff-0310-8789-dd5450dbe970

17 years agokrb5_kt_get_type should return const char *.
Ezra Peisach [Mon, 5 Feb 2007 15:32:13 +0000 (15:32 +0000)]
krb5_kt_get_type should return const char *.

The code returns a pointer to static structures. Just to enforce the
assumption that users can not change the returned data.

Change prototype of krb5_kt_get_type to return const char *. The other
changes are to clean up warnings - no change in code - usage assumed const.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19143 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoAdd a new program to perform various tests on the WRFILE: and MEMORY: keytabs
Ezra Peisach [Sun, 4 Feb 2007 03:08:47 +0000 (03:08 +0000)]
Add a new program to perform various tests on the WRFILE: and MEMORY: keytabs

I developed this program to test functionality of the MEMORY keytab - which
resulted in the numerous fixes that have been committed recently.

Tests all functioanlity of keytabs except for krb5_kt_default() and
krb5_kt_read_service_key() - although essential functionality tested.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19142 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoMEMORY keytab krb5_kt_get_entry sets enctype to 0 if unspecified
Ezra Peisach [Sun, 4 Feb 2007 02:49:54 +0000 (02:49 +0000)]
MEMORY keytab krb5_kt_get_entry sets enctype to 0 if unspecified

If one invokes krb5_kt_get_entry() for a memory keytab w/ an unspecified
enctype (i.e. 0) - the returned keytab has it's enctype set to 0 as well.

Also - in copying out the found keytab_entry - when a kvno is unspecified,
the last match found is used  - not the one with the highest vno.
This was caused by copying out the variable "entry" and not "match".

Ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19141 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoMEMORY keytab does not copy keytab_entry keyblock contents
Ezra Peisach [Sun, 4 Feb 2007 02:03:48 +0000 (02:03 +0000)]
MEMORY keytab does not copy keytab_entry keyblock contents

In krb5_kt_add_entry: The MEMORY keytab does not make a copy of the
keytab_entry keyblock contents - but instead retains a pointer to the
incomming one.

In krb5_kt_get_entry and krb5_kt_get_next - a pointer to internal
keyblock contents memory is returned to the caller - which is subsequently
freed when tht caller invokes krb5_free_keytab_entry_contents.

Solution is to use krb5_copy_keyblock_contents() instead of simply copying
the structure.

Ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19140 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoThe default K4 compatibility mode is now none, not preauth. Also document
Russ Allbery [Sat, 3 Feb 2007 18:33:23 +0000 (18:33 +0000)]
The default K4 compatibility mode is now none, not preauth.  Also document
that the valid values for v4_mode are the valid arguments to the -4 flag
to krb5kdc.

Ticket: 2724
Component: krb5-doc
Target_Version: 1.6.1
Tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19139 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoMemory leak in new memory keytab
Ezra Peisach [Sat, 3 Feb 2007 18:09:56 +0000 (18:09 +0000)]
Memory leak in new memory keytab

The memory keytab introduced in ticket 5411 suffers from a memory leak
in the Heimdal compatible kt_close() handling and thread destructor in which
the cursor->entry is not freed.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19138 dc483132-0cff-0310-8789-dd5450dbe970

17 years agobuffer overflow in krb5_kt_get_name
Ezra Peisach [Thu, 1 Feb 2007 19:17:31 +0000 (19:17 +0000)]
buffer overflow in krb5_kt_get_name

krb5_kt_get_name() allows the called to specify the size of the buffer to copy
the name into. The size must be big enough for the tailing nul character.

If one specified a buffer length that is precisely the strlen w/o allowing for
the nul - the functions would copy one past the end of the buffer.

No code in our tree would be subject this problem - as buffers in use are 1024
or BUFSIZ....

The logic failure was:

strlen(p+1) vs. strlen(p)+1

The code is essentially duplicated in the three changed files.

Ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19137 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoUse krb5.h now for kdb errors, not kdb5_err.h
Ken Raeburn [Thu, 1 Feb 2007 01:05:41 +0000 (01:05 +0000)]
Use krb5.h now for kdb errors, not kdb5_err.h

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19136 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoDon't need to initialize error tables
Ken Raeburn [Thu, 1 Feb 2007 00:09:07 +0000 (00:09 +0000)]
Don't need to initialize error tables

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19133 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoDon't need to register WRFILE: keytab type, it's already in the compiled-in
Ken Raeburn [Thu, 1 Feb 2007 00:02:36 +0000 (00:02 +0000)]
Don't need to register WRFILE: keytab type, it's already in the compiled-in
list.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19132 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoFix merge botches:
Tom Yu [Wed, 31 Jan 2007 00:53:11 +0000 (00:53 +0000)]
Fix merge botches:

restore krb5_get_init_creds_opt_set_change_password_prompt()

undo accidental reversion of preauth_tryagain change to
krb5_get_init_creds()

ticket: 5420
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19131 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoremove krb5_get_init_creds_opt_set_pkinit() for now
Tom Yu [Wed, 31 Jan 2007 00:52:59 +0000 (00:52 +0000)]
remove krb5_get_init_creds_opt_set_pkinit() for now

ticket: 5420
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19130 dc483132-0cff-0310-8789-dd5450dbe970

17 years agosort, remove duplicates
Ken Raeburn [Tue, 30 Jan 2007 23:37:36 +0000 (23:37 +0000)]
sort, remove duplicates

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19129 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoupdate def-check to look at preauth_plugin.h
Tom Yu [Tue, 30 Jan 2007 21:40:20 +0000 (21:40 +0000)]
update def-check to look at preauth_plugin.h

ticket: 5420
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19128 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoget_init_creds_opt extensibility
Tom Yu [Tue, 30 Jan 2007 21:38:47 +0000 (21:38 +0000)]
get_init_creds_opt extensibility

 r18922@cathode-dark-space:  coffman | 2006-12-04 18:30:15 -0500
 First cut at making the get_init_creds_opt structure extendable
 and adding library functions to set options for preauthentication
 plugins.

 This does *not* include a compatibility function to work like
 Heimdal's krb5_get_init_creds_opt_set_pkinit() function.

 Hopefully, the test code that doesn't belong in kinit.c is
 obvious.

 r18929@cathode-dark-space:  coffman | 2006-12-07 10:01:20 -0500
 Remove extra "user_id" parameter.

 Add function which duplicates the Heimdal interface (if we can agree on
 what the matching attribute names should be).

 r18934@cathode-dark-space:  coffman | 2006-12-08 15:28:03 -0500
 Update to use the simplified interface for krb5_get_init_creds_opt_set_pa()

 Add code in kinit to process "-X" options as preauth options and pass
 them along.

 r18936@cathode-dark-space:  coffman | 2006-12-11 12:04:26 -0500
 Move prototypes for get_init_creds_opt_get_pa() and
 krb5_get_init_creds_opt_free_pa() into the
 preauth_plugin.h header rather than krb5.hin.

ticket: new
status: open
component: krb5-libs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19127 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago This commit adds a thread safe MEMORY keytab implementation
Jeffrey Altman [Tue, 30 Jan 2007 17:21:56 +0000 (17:21 +0000)]
This commit adds a thread safe MEMORY keytab implementation
that is compatible with Heimdal 0.7.  Each successful resolve
returns a handle to a keytab and increases the internal
reference count.  Each close invalidates the handle and
decreases the reference count.  When the reference count hits
zero, the keytab is destroyed.

When a kt_destroy function is added, the automatic destruction
after close behavior will be removed.

ticket: 5411

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19126 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago Conditionalize ssize_t declaration
Jeffrey Altman [Tue, 30 Jan 2007 11:23:59 +0000 (11:23 +0000)]
Conditionalize ssize_t declaration

ticket: 5419

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19125 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago The fix for the command line race conditions
Jeffrey Altman [Tue, 30 Jan 2007 11:22:45 +0000 (11:22 +0000)]
The fix for the command line race conditions
broke the ability to cancel and restart the
Obtain New Credentials dialog

ticket: 5414

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19124 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoMicrosoft Windows Visual Studio does not define ssize_t
Jeffrey Altman [Tue, 30 Jan 2007 11:17:35 +0000 (11:17 +0000)]
Microsoft Windows Visual Studio does not define ssize_t

Microsoft defines size_t but not ssize_t.
Provide a definition in win-mac.h that follows the style
used by Microsoft providing a preprocessor macro
SSIZE_T_DEFINED which can be used for conditional
definition and testing in case Microsoft decides to add
it later.

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19123 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoKFW: 32-bit builds use the pismere krbv4w32.dll library
Jeffrey Altman [Tue, 30 Jan 2007 11:02:32 +0000 (11:02 +0000)]
KFW: 32-bit builds use the pismere krbv4w32.dll library

Only the 32-bit builds should use the pismere krbv4w32.dll
library.   Pismere does not provide 64-bit support.

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19122 dc483132-0cff-0310-8789-dd5450dbe970

17 years agosort
Ken Raeburn [Sat, 27 Jan 2007 08:46:09 +0000 (08:46 +0000)]
sort

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19119 dc483132-0cff-0310-8789-dd5450dbe970

17 years agosort
Ken Raeburn [Sat, 27 Jan 2007 02:41:29 +0000 (02:41 +0000)]
sort

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19114 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoNIM Bug Fixes
Jeffrey Altman [Wed, 24 Jan 2007 00:09:13 +0000 (00:09 +0000)]
NIM Bug Fixes

Document User Interface Callbacks

Fix a race condition when performing renewal actions
triggered by command line parameters.

When importing credentials, kickoff a renewal after
the credentials after the API: ccache is created.

Another fix for identity expiration states.  This one
fixes the behavior of the system tray icon.

ticket: new
component: windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19110 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoideas for passing error msg info across kadm5 api
Ken Raeburn [Tue, 23 Jan 2007 23:15:36 +0000 (23:15 +0000)]
ideas for passing error msg info across kadm5 api

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19109 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoAdd const to variable to cleanup warnings
Ezra Peisach [Tue, 23 Jan 2007 20:44:06 +0000 (20:44 +0000)]
Add const to variable to cleanup warnings

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19108 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoInclude k5-int.h for krb5_cc_register() prototype. Remove defintion of
Ezra Peisach [Tue, 23 Jan 2007 20:40:58 +0000 (20:40 +0000)]
Include k5-int.h for krb5_cc_register() prototype. Remove defintion of
krb5_cc_dfl_ops - as k5-int.h defines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19107 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoChange second argument to krb5_cc_register to take a const krb5_cc_ops *. Makes
Ezra Peisach [Tue, 23 Jan 2007 20:17:08 +0000 (20:17 +0000)]
Change second argument to krb5_cc_register to take a const krb5_cc_ops *. Makes
sense - when krb5_Xcc_ops currently defined as such - and assignment of value
assumes same.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19106 dc483132-0cff-0310-8789-dd5450dbe970

17 years agogss_krb5int_unseal_token_v3() - change bodysize argument to unsigned -
Ezra Peisach [Tue, 23 Jan 2007 02:57:32 +0000 (02:57 +0000)]
gss_krb5int_unseal_token_v3() - change bodysize argument to unsigned -
which is consistent with how it is invoked and used.  Cleans up two
signed/unsigned warnings.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19105 dc483132-0cff-0310-8789-dd5450dbe970

17 years agokt_file.c memory leak on error in krb5_kt_resolve / krb5_kt_wresolve
Jeffrey Altman [Tue, 23 Jan 2007 01:18:17 +0000 (01:18 +0000)]
kt_file.c memory leak on error in krb5_kt_resolve / krb5_kt_wresolve

The krb5_kt_resolve and krb5_kt_wresolve functions leak the 'data'
memory allocation if the lock cannot be initialized.

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19104 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoInclude fake-addrinfo.h before krb5.h to get proper structure declarations
Ezra Peisach [Mon, 22 Jan 2007 14:32:15 +0000 (14:32 +0000)]
Include fake-addrinfo.h before krb5.h to get proper structure declarations

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19103 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoOnly declare cc_fcc_entry if USE_KEYRING_CCACHE is not defined
Ezra Peisach [Sun, 21 Jan 2007 19:15:02 +0000 (19:15 +0000)]
Only declare cc_fcc_entry if USE_KEYRING_CCACHE is not defined

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19102 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago small fixes
Jeffrey Altman [Sat, 20 Jan 2007 22:21:13 +0000 (22:21 +0000)]
small fixes

ticket: 5408

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19101 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago Move files to their correct location
Jeffrey Altman [Sat, 20 Jan 2007 21:10:10 +0000 (21:10 +0000)]
Move files to their correct location

ticket: 5408

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19100 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoUse intermediate target to prevent parallel invocations of 'make includes' in lib...
Ken Raeburn [Sat, 20 Jan 2007 20:30:36 +0000 (20:30 +0000)]
Use intermediate target to prevent parallel invocations of 'make includes' in lib/krb4

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19099 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoUse move-if-changed and a timestamp file to avoid re-running commands and
Ken Raeburn [Sat, 20 Jan 2007 19:11:34 +0000 (19:11 +0000)]
Use move-if-changed and a timestamp file to avoid re-running commands and
updating krb5.h when there are no textual changes.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19098 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoDon't copy headers to .../include
Ken Raeburn [Sat, 20 Jan 2007 18:47:32 +0000 (18:47 +0000)]
Don't copy headers to .../include

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19097 dc483132-0cff-0310-8789-dd5450dbe970

17 years agomake depend
Ken Raeburn [Sat, 20 Jan 2007 18:44:55 +0000 (18:44 +0000)]
make depend

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19096 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoBuild krb5.h using the _err.h files from the error_tables directory, not
Ken Raeburn [Sat, 20 Jan 2007 18:42:06 +0000 (18:42 +0000)]
Build krb5.h using the _err.h files from the error_tables directory, not
additional copies of them.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19095 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoDon't explicitly include error table headers that are also in krb5.h
Ken Raeburn [Sat, 20 Jan 2007 18:32:03 +0000 (18:32 +0000)]
Don't explicitly include error table headers that are also in krb5.h

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19094 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoMark as C source for Emacs mode selection
Ken Raeburn [Sat, 20 Jan 2007 18:06:27 +0000 (18:06 +0000)]
Mark as C source for Emacs mode selection

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19093 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoMove osconf input file to include directory instead of keeping it in its own
Ken Raeburn [Sat, 20 Jan 2007 17:23:36 +0000 (17:23 +0000)]
Move osconf input file to include directory instead of keeping it in its own
subdirectory.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19092 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago* Makefile.in (osconf.h): Use move-if-changed script
Ken Raeburn [Sat, 20 Jan 2007 17:05:02 +0000 (17:05 +0000)]
* Makefile.in (osconf.h): Use move-if-changed script

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19091 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago* pre.in (MOVEIFCHANGED): New variable
Ken Raeburn [Sat, 20 Jan 2007 17:04:25 +0000 (17:04 +0000)]
* pre.in (MOVEIFCHANGED): New variable

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19090 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoRemove unused file
Ken Raeburn [Sat, 20 Jan 2007 16:56:32 +0000 (16:56 +0000)]
Remove unused file

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19089 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoRemove varargs.h paths, always use stdarg.h
Ken Raeburn [Sat, 20 Jan 2007 16:54:37 +0000 (16:54 +0000)]
Remove varargs.h paths, always use stdarg.h

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19088 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoInclude stdarg.h, and don't conditionalize declarations of functions with
Ken Raeburn [Sat, 20 Jan 2007 12:52:34 +0000 (12:52 +0000)]
Include stdarg.h, and don't conditionalize declarations of functions with
va_list arguments.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19087 dc483132-0cff-0310-8789-dd5450dbe970

17 years agomake depend
Ken Raeburn [Sat, 20 Jan 2007 12:33:00 +0000 (12:33 +0000)]
make depend

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19086 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoHandle function names immediately preceded by "*", like "*strdup"
Ken Raeburn [Sat, 20 Jan 2007 12:13:15 +0000 (12:13 +0000)]
Handle function names immediately preceded by "*", like "*strdup"
in k5-int.h+krb5.h.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19085 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoMark as C source for Emacs mode selection
Ken Raeburn [Sat, 20 Jan 2007 12:07:41 +0000 (12:07 +0000)]
Mark as C source for Emacs mode selection

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19084 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoDon't define KRB5_PRIVATE, since it's not tested any more
Ken Raeburn [Sat, 20 Jan 2007 12:05:22 +0000 (12:05 +0000)]
Don't define KRB5_PRIVATE, since it's not tested any more

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19083 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoMove all KRB5_PRIVATE declarations from krb5.h(in) to k5-int.h, and drop the
Ken Raeburn [Sat, 20 Jan 2007 11:33:36 +0000 (11:33 +0000)]
Move all KRB5_PRIVATE declarations from krb5.h(in) to k5-int.h, and drop the
KRB5_PRIVATE preprocessor test.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19082 dc483132-0cff-0310-8789-dd5450dbe970

17 years ago* Makefile.in (private-and-public-decls): New target file, created from
Ken Raeburn [Sat, 20 Jan 2007 11:29:07 +0000 (11:29 +0000)]
* Makefile.in (private-and-public-decls): New target file, created from
k5-int.h and krb5.h.
(verify-calling-conventions-krb5): Use it instead of krb5.h.
(clean-unix): Get rid of it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19081 dc483132-0cff-0310-8789-dd5450dbe970

17 years agoInclude k5-int.h instead of krb5.h when 'private' functions are needed
Ken Raeburn [Sat, 20 Jan 2007 11:02:58 +0000 (11:02 +0000)]
Include k5-int.h instead of krb5.h when 'private' functions are needed

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19080 dc483132-0cff-0310-8789-dd5450dbe970