krb5.git
19 years ago krb5_unparse_name(), krb5_unparse_name_ext():
Jeffrey Altman [Mon, 17 Jan 2005 19:10:31 +0000 (19:10 +0000)]
krb5_unparse_name(), krb5_unparse_name_ext():

prevent dereferencing of pointer if 'name' or 'size' are NULL

ticket: new
tags: pullup
target_version: 1.4

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17049 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago * gc_frm_kdc.c (krb5_get_cred_from_kdc_opt): More memory leaks
Ezra Peisach [Mon, 17 Jan 2005 17:37:27 +0000 (17:37 +0000)]
* gc_frm_kdc.c (krb5_get_cred_from_kdc_opt): More memory leaks
fixed as introduced in ticket #2541. Do not rely on knowledge that
upon failure from krb5_cc_retrieve_cred, returned credential data
is untouched.

Testsuite passes all tests, but would like another set of eyes to look over code
before closing ticket.

ticket: 2885
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17048 dc483132-0cff-0310-8789-dd5450dbe970

19 years agosubject; krb5_do_preauth could attempt to free NULL pointer
Ezra Peisach [Mon, 17 Jan 2005 17:32:26 +0000 (17:32 +0000)]
subject; krb5_do_preauth could attempt to free NULL pointer

* preauth2.c (krb5_do_preauth): Upon error in decoding
krb5_type_info{,2}, on failure, do not call krb5_free_type_info
with a null pointer.

The only way to reach this code is to set a preauth list requesting for ETYPE_INFO
 or ETYPE_INFO2 in a call to krb5_get_in_tkt_with_password.

Before sending the request, krb5_do_preauth tries to parse a NULL length asn1 buffer,
fails and tries to free a null pointer.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17047 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago * rc_dfl.c: Move the extraction of the struct dfl_data
Jeffrey Altman [Sat, 15 Jan 2005 21:40:23 +0000 (21:40 +0000)]
    * rc_dfl.c: Move the extraction of the struct dfl_data
          from the krb5_rcache after obtaining the lock, not before.

ticket: new
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17046 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago * cp_key_cnt.c, copy_princ.c:
Jeffrey Altman [Sat, 15 Jan 2005 06:34:08 +0000 (06:34 +0000)]
  * cp_key_cnt.c, copy_princ.c:
    prevent krb5_copy_principal() and krb5_copy_keyblock() from
    calling malloc(0).  On platforms in which malloc(0) returns
    NULL, these functions will return an ENOMEM error the way
    they were written.

ticket: 2881
target_version: 1.4

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17045 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* k5-thread.h [HAVE_PTHREAD && HAVE_PRAGMA_WEAK_REF]: Mark pthread_self and
Ken Raeburn [Fri, 14 Jan 2005 23:50:22 +0000 (23:50 +0000)]
* k5-thread.h [HAVE_PTHREAD && HAVE_PRAGMA_WEAK_REF]: Mark pthread_self and
pthread_equal as weak references.

ticket: 2878
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17041 dc483132-0cff-0310-8789-dd5450dbe970

19 years agoFix braino in previous change to xdr_bytes. New test case for
Tom Yu [Fri, 14 Jan 2005 21:52:15 +0000 (21:52 +0000)]
Fix braino in previous change to xdr_bytes.  New test case for
RPCSEC_GSS fixed-size buffers.

ticket: 2877
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17039 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago * authgss_prot.c (xdr_rpc_gss_wrap_data): Use xdr_alloc to avoid
Tom Yu [Fri, 14 Jan 2005 06:02:01 +0000 (06:02 +0000)]
* authgss_prot.c (xdr_rpc_gss_wrap_data): Use xdr_alloc to avoid
size limit issues.  Use (unsigned int)-1 instead of MAX_NETOBJ_SZ.
(xdr_rpc_gss_unwrap_data): Use (unsigned int)-1 instead of
MAX_NETOBJ_SZ.

* xdr.c (xdr_bytes): Don't assign from *sizep if XDR_FREE, since
it'll be uninitialized then.  Shuts up Purify.

ticket: 2877
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17038 dc483132-0cff-0310-8789-dd5450dbe970

19 years agofix calling convention for thread support fns
Ken Raeburn [Fri, 14 Jan 2005 05:18:31 +0000 (05:18 +0000)]
fix calling convention for thread support fns

This depends on a change to k5-thread.h that was included with a checkin I did
earlier for 2878.

* threads.c (k5_mutex_lock_update_stats, krb5int_mutex_unlock_update_stats,
krb5int_mutex_report_stats): Define as KRB5_CALLCONV.
(krb5int_mutex_lock_update_stats, krb5int_mutex_unlock_update_stats,
krb5int_mutex_report_stats) [_WIN32]: Undef macros before defining functions.

ticket: new
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17037 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* k5-thread.h (k5_pthread_assert_locked): Only call pthread_equal if
Ken Raeburn [Fri, 14 Jan 2005 05:03:48 +0000 (05:03 +0000)]
* k5-thread.h (k5_pthread_assert_locked): Only call pthread_equal if
thread support is loaded.
(k5_pthread_mutex_unlock): Use k5_pthread_assert_locked instead of
duplicating it.

ticket: 2878
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17036 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* prof_file.c (profile_open_file): If mutex creation fails, free storage
Ken Raeburn [Fri, 14 Jan 2005 04:40:16 +0000 (04:40 +0000)]
* prof_file.c (profile_open_file): If mutex creation fails, free storage
directly instead of calling profile_close_file.

ticket: 2878
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17035 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* cc_file.c (struct _krb5_fcc_data): Fields disk_file_lock, file_is_locked
Ken Raeburn [Fri, 14 Jan 2005 03:39:24 +0000 (03:39 +0000)]
* cc_file.c (struct _krb5_fcc_data): Fields disk_file_lock, file_is_locked
deleted.
(krb5_fcc_open_file, krb5_fcc_close_file, dereference, krb5_fcc_resolve,
krb5_fcc_generate_new, krb5_fcc_set_flags): Don't set or check them.

ticket: 2874
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17034 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* prng.c (krb5int_prng_init): Incorporate do_yarrow_init body. Don't check
Ken Raeburn [Fri, 14 Jan 2005 03:27:51 +0000 (03:27 +0000)]
* prng.c (krb5int_prng_init): Incorporate do_yarrow_init body.  Don't check
inited variable.
(inited): Variable deleted.
(krb5_c_random_make_octets, krb5int_prng_cleanup): Don't check it.
(do_yarrow_init): Deleted.

ticket: 2878
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17033 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* yarrow.c (yarrow_reseed_locked): Renamed from krb5int_yarrow_reseed and made
Ken Raeburn [Fri, 14 Jan 2005 03:24:48 +0000 (03:24 +0000)]
* yarrow.c (yarrow_reseed_locked): Renamed from krb5int_yarrow_reseed and made
static.
(Yarrow_detect_fork, yarrow_input_maybe_locking, krb5int_yarrow_output_Block):
Call it.
(krb5int_yarrow_reseed): New function, grabs lock and calls the old version.
(krb5int_yarrow_final): Hold the lock until after clearing the Yarrow context
data.

ticket: 2878
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17032 dc483132-0cff-0310-8789-dd5450dbe970

19 years agoMore paranoid checking...
Ken Raeburn [Fri, 14 Jan 2005 03:19:39 +0000 (03:19 +0000)]
More paranoid checking...
* k5-thread.h (k5_os_mutex) [pthread case]: Add new field "owner" if
DEBUG_THREADS.
(k5_pthread_mutex_lock, k5_pthread_mutex_unlock, k5_pthread_assert_locked): New
macros/functions; if DEBUG_THREADS, set or check the owner field.
(K5_OS_MUTEX_PARTIAL_INITIALIZER) [pthread case && DEBUG_THREADS]: Set the
owner field.  If PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP is defined, use it.
(k5_os_mutex_lock, k5_os_mutex_unlock, k5_os_mutex_assert_locked) [pthread
case]: Use k5_pthread_ versions.
(k5_mutex_destroy): Update the location data with the mutex locked, before
destroying it.
(k5_mutex_unlock): Update the location data while the mutex is still locked,
and check the assertion that the mutex really is locked.  Convert inline
function to macro.

* k5-thread.h (krb5int_mutex_lock_update_stats,
krb5int_mutex_unlock_update_stats, krb5int_mutex_report_stats)
[!DEBUG_THREADS_STATS]: Declare KRB5_CALLCONV.

ticket: 2878
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17031 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* error_message.c (com_err_terminate): Lock the list mutex before walking
Ken Raeburn [Fri, 14 Jan 2005 03:15:41 +0000 (03:15 +0000)]
* error_message.c (com_err_terminate): Lock the list mutex before walking
through it; unlock and destroy it afterwards.

ticket: 2878
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17030 dc483132-0cff-0310-8789-dd5450dbe970

19 years agoprofile code never destroys its per-file mutexes
Ken Raeburn [Fri, 14 Jan 2005 03:12:21 +0000 (03:12 +0000)]
profile code never destroys its per-file mutexes

* prof_file.c (profile_free_file_data): Destroy mutex before freeing containing
structure.

ticket: new
target_version: 1.4

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17029 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago * ftpd.c: GCC 4.0 fixes... Move static declaration of gunique out
Ezra Peisach [Thu, 13 Jan 2005 11:51:51 +0000 (11:51 +0000)]
   * ftpd.c: GCC 4.0 fixes... Move static declaration of gunique out
        of function.

ticket: 2876
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17026 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago correction to previous commit. do not call krb5_gss_release_cred()
Jeffrey Altman [Thu, 13 Jan 2005 11:51:30 +0000 (11:51 +0000)]
 correction to previous commit.  do not call krb5_gss_release_cred()
 if the cred was not acquired.  destroy each field of the cred one
 piece at a time based upon what was allocated.

ticket: 2875

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17025 dc483132-0cff-0310-8789-dd5450dbe970

19 years agoTree does not compile with GCC 4.0
Ezra Peisach [Thu, 13 Jan 2005 11:32:47 +0000 (11:32 +0000)]
Tree does not compile with GCC 4.0

        * yarrow.c: Declare yarrow_gate_locked static before first use.

GCC 4.0 snapshots are more particular about using a static function
before a prototype is given.

ticket: new
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17024 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago Fix the calls to krb5_gss_release_cred to pass in the correct type.
Jeffrey Altman [Thu, 13 Jan 2005 08:19:06 +0000 (08:19 +0000)]
   Fix the calls to krb5_gss_release_cred to pass in the correct type.
   This fixes a mutex leak.

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17023 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago * prng.c (read_entropy_from_device): Use ssize_t, not size_t, so
Tom Yu [Thu, 13 Jan 2005 00:35:17 +0000 (00:35 +0000)]
* prng.c (read_entropy_from_device): Use ssize_t, not size_t, so
read() returning -1 doesn't cause trouble.

ticket: 2871
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17020 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* default.exp (start_tail): New proc. Handles GNU tail race condition with
Ken Raeburn [Wed, 12 Jan 2005 18:24:44 +0000 (18:24 +0000)]
* default.exp (start_tail): New proc.  Handles GNU tail race condition with
less delay than the old code that was in start_kerberos_daemons.
(start_kerberos_daemons): Call start_tail for both log files.

ticket: 2873
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17019 dc483132-0cff-0310-8789-dd5450dbe970

19 years agoFix some potential resource leaks in dnsglue.c
Tom Yu [Wed, 12 Jan 2005 17:18:28 +0000 (17:18 +0000)]
Fix some potential resource leaks in dnsglue.c

ticket: 2872
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17018 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago2005-01-11 Jeffrey Altman <jaltman@mit.edu>
Jeffrey Altman [Wed, 12 Jan 2005 04:57:22 +0000 (04:57 +0000)]
2005-01-11  Jeffrey Altman <jaltman@mit.edu>

        * cc_mslsa.c:
          - do not free krb5_creds if krb5_copy_creds fails
          - cause MSTicketToMITTicket to return failure if
            krb5_copy_data fails

ticket: 2870
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17017 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* krb-root/rlogin.exp (start_rlogin_daemon): Use built-in sleep command.
Ken Raeburn [Wed, 12 Jan 2005 03:47:58 +0000 (03:47 +0000)]
* krb-root/rlogin.exp (start_rlogin_daemon): Use built-in sleep command.
* krb-root/telnet.exp (start_telnet_daemon): Likewise.
* krb-standalone/gssftp.exp (start_ftp_daemon): Use built-in sleep command.
* krb-standalone/rcp.exp (start_rsh_daemon): Likewise.
* krb-standalone/rsh.exp (start_rsh_daemon): Likewise.
* krb-standalone/sample.exp (start_sserver_daemon): Likewise.
* krb-standalone/v4gssftp.exp (start_ftp_daemon): Likewise.
* krb-standalone/v4krb524d.exp (start_k524_daemon): Likewise.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17016 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* default.exp (start_kerberos_daemons): Format date internally rather than
Ken Raeburn [Wed, 12 Jan 2005 03:46:51 +0000 (03:46 +0000)]
* default.exp (start_kerberos_daemons): Format date internally rather than
running "date".

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17015 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* gc_frm_kdc.c (krb5_get_cred_from_kdc_opt): Free credentials retrieved from
Ken Raeburn [Wed, 12 Jan 2005 01:06:04 +0000 (01:06 +0000)]
* gc_frm_kdc.c (krb5_get_cred_from_kdc_opt): Free credentials retrieved from
ccache before returning.  Based on patch from fumihiko kakuma
<kakuma@valinux.co.jp>.  Also whitespace changes for readability.

ticket: 2541
tags: pullup
target_version: 1.4

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17014 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* k5-int.h (krb5int_zap_data): Fix preprocessor test for Windows
Ken Raeburn [Sun, 9 Jan 2005 06:05:02 +0000 (06:05 +0000)]
* k5-int.h (krb5int_zap_data): Fix preprocessor test for Windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17013 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* k5-thread.h (KRB5_CALLCONV, KRB5_CALLCONV_C): Define if not defined.
Ken Raeburn [Sun, 9 Jan 2005 06:03:56 +0000 (06:03 +0000)]
* k5-thread.h (KRB5_CALLCONV, KRB5_CALLCONV_C): Define if not defined.
(krb5int_mutx_lock_update_stats, krb5int_mutex_unlock_update_stats,
krb5int_mutex_report_stats) [!DEBUG_THREADS_STATS]: Declare, with KRB5_CALLCONV.
(k5_debug_make_loc): Change "lineno" to type int.
(k5_debug_make_loc): Likewise for argument "line".

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17012 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* crc-32.h (mit_crc32): Remove gratuitous "const" in argument declaration
Ken Raeburn [Sat, 8 Jan 2005 00:29:19 +0000 (00:29 +0000)]
* crc-32.h (mit_crc32): Remove gratuitous "const" in argument declaration

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17011 dc483132-0cff-0310-8789-dd5450dbe970

19 years agomake depend
Tom Yu [Thu, 6 Jan 2005 20:31:21 +0000 (20:31 +0000)]
make depend

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17007 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago Add new function krb5_boolean krb5_is_thread_safe(void) to library.
Jeffrey Altman [Wed, 5 Jan 2005 07:51:46 +0000 (07:51 +0000)]
  Add new function krb5_boolean krb5_is_thread_safe(void) to library.
  This function simply reports whether or not ENABLE_THREADS was specified
  at compile time.  It is meant to be used by applications which need to
  know whether or not multithread libraries must be initialized OR
  whether or not calls to Kerberos library functions from multi-threaded
  applications must be protected by an application global mutex.

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17003 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago * win-mac.h: define NEED_INSIXADDR_ANY for ipv6 symbol
Jeffrey Altman [Wed, 5 Jan 2005 07:45:21 +0000 (07:45 +0000)]
    * win-mac.h: define NEED_INSIXADDR_ANY for ipv6 symbol

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17002 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago Makefile.in: add krb5 support library to windows klist executable
Jeffrey Altman [Wed, 5 Jan 2005 07:41:30 +0000 (07:41 +0000)]
  Makefile.in: add krb5 support library to windows klist executable

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@17001 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* configure.in: Check for uint32_t and int32_t in system headers
Ken Raeburn [Wed, 5 Jan 2005 02:59:53 +0000 (02:59 +0000)]
* configure.in: Check for uint32_t and int32_t in system headers

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16999 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* Makefile.in (krb5.h): Don't pull in autoconf SIZEOF macros
Ken Raeburn [Wed, 5 Jan 2005 02:35:02 +0000 (02:35 +0000)]
* Makefile.in (krb5.h): Don't pull in autoconf SIZEOF macros

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16998 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* threads.c (krb5int_mutex_lock_update_stats,
Ken Raeburn [Wed, 5 Jan 2005 00:50:54 +0000 (00:50 +0000)]
* threads.c (krb5int_mutex_lock_update_stats,
krb5int_mutex_unlock_update_stats, krb5int_mutex_report_stats) [_WIN32
&& !DEBUG_THREADS_STATS]: Define empty versions for Windows.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16997 dc483132-0cff-0310-8789-dd5450dbe970

19 years agofix typo
Tom Yu [Tue, 4 Jan 2005 17:03:48 +0000 (17:03 +0000)]
fix typo

ticket: 2861
version_fixed:

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16996 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* implementor.texinfo (Porting Issues): New chapter with a bunch of notes from
Ken Raeburn [Mon, 3 Jan 2005 21:07:25 +0000 (21:07 +0000)]
* implementor.texinfo (Porting Issues): New chapter with a bunch of notes from
email I sent regarding porting to pSOS.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16992 dc483132-0cff-0310-8789-dd5450dbe970

19 years agoupdate thread support doc
Ken Raeburn [Mon, 3 Jan 2005 20:31:31 +0000 (20:31 +0000)]
update thread support doc

* threads.txt, thread-safety.txt: Updates.

ticket: new
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16991 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* build.texinfo (The util Directory): Add the new support library.
Ken Raeburn [Mon, 3 Jan 2005 20:29:58 +0000 (20:29 +0000)]
* build.texinfo (The util Directory): Add the new support library.
(Installing the Binaries): Discuss parallel builds under GNU make.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16990 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* implementor.texinfo (Host Address Lookup): Document Mac OS X issues
Ken Raeburn [Mon, 3 Jan 2005 20:27:16 +0000 (20:27 +0000)]
* implementor.texinfo (Host Address Lookup): Document Mac OS X issues

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16989 dc483132-0cff-0310-8789-dd5450dbe970

19 years agokrb5_parse_name not thread-safe, not responsive to environment changes
Ken Raeburn [Mon, 3 Jan 2005 19:30:18 +0000 (19:30 +0000)]
krb5_parse_name not thread-safe, not responsive to environment changes

As Ezra noted, krb5_parse_name saves away the default realm the first
time it looks it up, and will never look it up again, even if the
config file has changed, the context isn't the same one, etc.  It also
used a static variable which wasn't thread-safe.

With this patch, we still won't catch changes in the config file
specification after the default realm has been looked up for a given
krb5_context, because it's cached in the context too, but this will at
least be more responsive, and thread safe.

* parse.c (krb5_parse_name): Don't cache the default realm name.

ticket: new
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16988 dc483132-0cff-0310-8789-dd5450dbe970

19 years agorun "make depend"
Ken Raeburn [Thu, 30 Dec 2004 22:08:18 +0000 (22:08 +0000)]
run "make depend"

In most library directories, this just affects where the line breaks
are.  In most other directories, it's just dropping a trailing blank
line.  One or two files really do have updated dependencies.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16987 dc483132-0cff-0310-8789-dd5450dbe970

19 years agoDo the target object file name hacking in "make depend" earlier, before the
Ken Raeburn [Thu, 30 Dec 2004 22:05:12 +0000 (22:05 +0000)]
Do the target object file name hacking in "make depend" earlier, before the
line breaks are recomputed, instead of after.  This will result in lots of
whitespace changes in dependencies in directories that build library object
files, but the final output is nicer (fewer long lines), and running "make
depend" uses one fewer invocation of sed (balancing out the extra one I added
in another checkin earlier today).

* config/post.in (.depend): Don't do target name munging here.
(.depfix2.sed): Pass extra value $(STLIBOBJS).
* util/depfix.sed: Don't change foo.o to $(OUTPRE)foo.$(OBJEXT) here.
* util/depgen.sed: Add new argument for STLIBOBJS.  Do the OUTPRE/OBJEXT
substitution here, and if STLIBOBJS is non-empty, add foo.so and foo.po while
we're at it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16986 dc483132-0cff-0310-8789-dd5450dbe970

19 years ago* post.in (.depend): Delete blank lines in generated file.
Ken Raeburn [Thu, 30 Dec 2004 21:12:41 +0000 (21:12 +0000)]
* post.in (.depend): Delete blank lines in generated file.
(DEP_CFG_VERIFY, DEP_VERIFY, depend-verify-*, .depend-verify-*, .depfix2.sed):
Move all the flag files to $(BUILDTOP) so there'll be only one of each.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16985 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoMemory leak in asn1_decode_generaltime
Ezra Peisach [Tue, 28 Dec 2004 13:27:30 +0000 (13:27 +0000)]
Memory leak in asn1_decode_generaltime

When decoding a kerberos time, if the asn1 time is 19700101000000Z (i.e. time_t
of 0) - 15 bytes of memory are lost.

* asn1_decode.c (asn1_decode_generaltime): Fix memory leak when
time sent is "19700101000000Z".

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16983 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoMemory leaks in ccache due to thread integration
Ezra Peisach [Sat, 25 Dec 2004 15:29:39 +0000 (15:29 +0000)]
Memory leaks in ccache due to thread integration

* cc_file.c (krb5_fcc_close): Free the cache id.
(dereference): When removing fcc_set entry from list, free the
pointer as well.

The first was accidently dropped in the dereference code writing.
The cache id pointer is never freed.

The second error is the removal of the krb5_fcc_data from the linked list.
The fcc_set is removed from the chain, but the memory for the removed fcc_set
is never freed.

ticket:new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16981 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago * def-check.pl: Check for PRIVATE or INTERNAL annotations in defs
Tom Yu [Tue, 21 Dec 2004 05:18:12 +0000 (05:18 +0000)]
* def-check.pl: Check for PRIVATE or INTERNAL annotations in defs
file.

ticket: 2796
version_reported: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16976 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago * krb5.hin: Flag krb5_principal2salt as KRB5_CALLCONV_WRONG
Tom Yu [Tue, 21 Dec 2004 05:15:25 +0000 (05:15 +0000)]
* krb5.hin: Flag krb5_principal2salt as KRB5_CALLCONV_WRONG

ticket: 2840

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16975 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago * kerberos.c (kerberos4_status): Null-terminate the correct
Tom Yu [Mon, 20 Dec 2004 22:02:19 +0000 (22:02 +0000)]
* kerberos.c (kerberos4_status): Null-terminate the correct
string.  Reported by Marcin Garski.

ticket: 2838
tags: pullup
target_version: 1.4

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16969 dc483132-0cff-0310-8789-dd5450dbe970

20 years agofix MITKRB5-SA-2004-004
Tom Yu [Mon, 20 Dec 2004 21:15:41 +0000 (21:15 +0000)]
fix MITKRB5-SA-2004-004

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16961 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoMark krb5_principal2salt has being declared with the wrong calling convention
Jeffrey Altman [Mon, 20 Dec 2004 21:11:35 +0000 (21:11 +0000)]
Mark krb5_principal2salt has being declared with the wrong calling convention

ticket: new
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16960 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago Add support for optionally installing Debug Symbols
Jeffrey Altman [Sun, 19 Dec 2004 06:04:41 +0000 (06:04 +0000)]
  Add support for optionally installing Debug Symbols

ticket: new
tags: pullup
target_version: 1.4

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16955 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago2004-12-18 Jeffrey Altman <jaltman@mit.edu>
Jeffrey Altman [Sat, 18 Dec 2004 12:28:39 +0000 (12:28 +0000)]
2004-12-18  Jeffrey Altman <jaltman@mit.edu>

* kfw-fixed.nsi:
    Add "Debug Symbols" as a new category.  It defaults to on
    in debug builds and off in release builds.

ticket: new
tags: pullup
target_version: 1.4

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16954 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago2004-12-17 Jeffrey Altman <jaltman@mit.edu>
Jeffrey Altman [Sat, 18 Dec 2004 04:47:50 +0000 (04:47 +0000)]
2004-12-17  Jeffrey Altman <jaltman@mit.edu>

        * win-pre.in: add -debug switch to LOPTS if DEBUG_SYMBOLS

ticket: new
tags: pullup
target_version: 1.4

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16953 dc483132-0cff-0310-8789-dd5450dbe970

20 years agocan't build shared libraries on sparc64-netbsd
Ken Raeburn [Fri, 17 Dec 2004 23:58:47 +0000 (23:58 +0000)]
can't build shared libraries on sparc64-netbsd

Current trunk code fails to build shared libraries on sparc64-netbsd
because the generated relocations with -fpic don't have the range
necessary.  In general, any platform with sparc support that we want
to build for should use -fPIC instead of -fpic, with gcc.  (I haven't
checked whether openbsd or freebsd support sparc these days; I think
they're the only ones in our shlib.conf that we might care about.)

* shlib.conf (*-*-netbsd*): Use -fPIC instead of -fpic, which won't work on
sparc64 at least.

ticket: new
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16951 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago2004-12-16 Jeffrey Altman <jaltman@mit.edu>
Jeffrey Altman [Thu, 16 Dec 2004 19:57:17 +0000 (19:57 +0000)]
2004-12-16  Jeffrey Altman <jaltman@mit.edu>
        * cc_mslsa.c:
          Temporarily deactivate support for KerbSubmitTicketMessage
          and KerbQueryTicketCacheEx2Message until the new Platform SDK
          becomes publicly available.

ticket: new
tags: pullup
target_version: 1.4

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16945 dc483132-0cff-0310-8789-dd5450dbe970

20 years agokrb5-config needs to include krb5support library
Ezra Peisach [Thu, 16 Dec 2004 15:48:53 +0000 (15:48 +0000)]
krb5-config needs to include krb5support library

* krb5-config.in: Add krb5support library.

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16944 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoUpdate for WiX 2.1 installer
Jeffrey Altman [Wed, 15 Dec 2004 16:53:29 +0000 (16:53 +0000)]
Update for WiX 2.1 installer

ticket: 2805

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16938 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago remove unnecessary if statement
Jeffrey Altman [Wed, 15 Dec 2004 08:54:16 +0000 (08:54 +0000)]
  remove unnecessary if statement

ticket: 2814

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16937 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago2004-12-15 Jeffrey Altman <jaltman@mit.edu>
Jeffrey Altman [Wed, 15 Dec 2004 08:27:13 +0000 (08:27 +0000)]
2004-12-15  Jeffrey Altman <jaltman@mit.edu>

    Add kcpytkt.exe, kdeltkt.exe, k5sprt32.dll, mit2ms.exe

ticket: 2805

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16936 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago2004-12-15 Jeffrey Altman <jaltman@mit.edu>
Jeffrey Altman [Wed, 15 Dec 2004 08:25:28 +0000 (08:25 +0000)]
2004-12-15  Jeffrey Altman <jaltman@mit.edu>

        * cc_mslsa.c:
          - Activate support for KerbSubmitTicketMessage
          - Activate support for KerbQueryTicketCacheEx2Message
          - Add locale support for regions which use MultiByte characters

ticket: new
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16935 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago2004-12-15 Jeffrey Altman <jaltman@mit.edu>
Jeffrey Altman [Wed, 15 Dec 2004 08:24:03 +0000 (08:24 +0000)]
2004-12-15  Jeffrey Altman <jaltman@mit.edu>

       rename krb5support_32.dll to k5sprt32.dll

ticket: 2804

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16934 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago2004-12-15 Jeffrey Altman <jaltman@mit.edu>
Jeffrey Altman [Wed, 15 Dec 2004 08:20:09 +0000 (08:20 +0000)]
2004-12-15  Jeffrey Altman <jaltman@mit.edu>

        * Makefile.in: build/clean/install/etc kcpytkt,kdeltkt,ms2mit

ticket: 2802

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16933 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoinsufficient locking in profile re-reading case
Ken Raeburn [Wed, 15 Dec 2004 03:02:43 +0000 (03:02 +0000)]
insufficient locking in profile re-reading case

If profiles are open and iterators in use while the on-disk file is being
modified (see tests/threads/prof1.c), the re-reading of the file can cause data
to be freed up.  The iterator code does no locking and assumes that the profile
node tree won't be touched.

During our Monday meeting we discussed changing the iterator code to "snapshot"
the current state of the file if it were modified, so that a more consistent
picture could be returned, essentially by bumping a reference count for the
life of the iterator object.  The reference count I was thinking of turns out
to be used for a different purpose; we'd have to add another layer of
indirection, another ref count, and another mutex to accomplish this.  There
might be a more reasonable way to go about it, but I don't want to tackle it
for 1.4 when we're already shipping beta releases.

This patch just adds locking to the current iterator code so that the file data
can't be replaced while the iterator is being processed.  The inconsistent-view
issue remains.

* prof_tree.c (profile_node_iterator): When the iterator has a current file,
lock it, and unlock it before changing it or returning.

ticket: new
status: resolved
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16932 dc483132-0cff-0310-8789-dd5450dbe970

20 years agonew test prog "prof1" for profile reloading
Ken Raeburn [Sun, 12 Dec 2004 22:55:55 +0000 (22:55 +0000)]
new test prog "prof1" for profile reloading

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16931 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago* include/k5-int.h (struct _krb5int_access): Add function pointer field
Ken Raeburn [Wed, 8 Dec 2004 06:04:49 +0000 (06:04 +0000)]
* include/k5-int.h (struct _krb5int_access): Add function pointer field
use_dns_kdc.
* lib/krb5/os/accessor.c (krb5int_accessor): Set new field use_dns_kdc.
* lib/krb4/RealmsConfig-glue.c (krb_get_krbhst): Check if DNS should be used
for getting KDC names before actually using it.

ticket: 2772

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16920 dc483132-0cff-0310-8789-dd5450dbe970

20 years agobump accessor struct version number for 1.4
Ken Raeburn [Wed, 8 Dec 2004 05:14:44 +0000 (05:14 +0000)]
bump accessor struct version number for 1.4

The interface has changed from 1.3 (if nothing else, sendto_udp has a
new argument), so we need to have a new version number for 1.4.

* k5-int.h (KRB5INT_ACCESS_STRUCT_VERSION): Bump to 9.

ticket: new
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16919 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoallow build with KRB5_DNS_LOOKUP undefined
Tom Yu [Mon, 6 Dec 2004 23:26:34 +0000 (23:26 +0000)]
allow build with KRB5_DNS_LOOKUP undefined

* locate_kdc.c (krb5_locate_srv_dns_1): Don't compile if
KRB5_DNS_LOOKUP is not defined.

ticket: new
target_version: 1.4
tags: pullup
component: krb5-libs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16915 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago* libkrb5support.exports: Add krb5int_in6addr_any
Ken Raeburn [Mon, 6 Dec 2004 22:06:09 +0000 (22:06 +0000)]
* libkrb5support.exports: Add krb5int_in6addr_any

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16914 dc483132-0cff-0310-8789-dd5450dbe970

20 years agohooks for recording statistics on locking behavior
Ken Raeburn [Mon, 6 Dec 2004 22:00:26 +0000 (22:00 +0000)]
hooks for recording statistics on locking behavior

Finish the hooks (left disabled by default) for logging somewhere the recorded
timing behavior relating to the use of locks in the krb5 code.

Currently, "reporting" means writing to /dev/tty or stderr, and the data is the
number of times a mutex is locked, file and line where it was created,
min/avg/max/stddev wait times to acquire the lock and hold times, and stats are
only written out for locks that were locked a certain minimum number of times
and with a minimum average wait time.

The criteria are all controlled in threads.c, and k5-thread.h just has the
hooks for gathering data.  So turning on/off the data gathering requires a full
rebuild, but tweaking the reporting is mostly just a relinking pass.  (May also
require adding a dependence on the math library to the support library; for a
static build that may impact a lot of makefiles.)

* include/k5-thread.h [DEBUG_THREADS_STATS]: Include string.h and inttypes.h.
(get_current_time) [DEBUG_THREADS_STATS]: Define as inline.
(k5_mutex_init_stats) [DEBUG_THREADS_STATS]: Save away current time as creation
time.
(k5_mutex_stats_tmp): New typedef, k5_debug_time_t if recording stats, dummy
int otherwise.
(k5_mutex_stats_start): New macro, get current time if recording, zero
otherwise.
(krb5int_mutex_lock_update_stats, krb5int_mutex_unlock_update_stats,
krb5int_mutex_report_stats) [DEBUG_THREADS_STATS]: Declare.
(krb5int_mutex_report_stats) [! DEBUG_THREADS_STATS]: New macro, does nothing.
(k5_mutex_lock_update_stats, k5_mutex_unlock_update_stats): New macros, map to
krb5int_ functions if recording, dummy statements otherwise.
(k5_mutex_destroy): Call krb5int_mutex_report_stats.
(k5_mutex_lock, k5_mutex_lock_1): Call k5_mutex_stats_start and
k5_mutex_lock_update_stats.
(k5_mutex_unlock_1): Call k5_mutex_unlock_update_stats.

* util/support/threads.c [DEBUG_THREADS_STATS]: Include stdio.h.
(stats_logfile) [DEBUG_THREADS_STATS]: New variable.
(krb5int_thread_support_init) [DEBUG_THREADS_STATS]: Set it to point to a file
on /dev/tty or stderr.
(krb5int_thread_support_fini) [DEBUG_THREADS_STATS]: Flush it.
(k5_mutex_lock_update_stats, krb5int_mutex_unlock_update_stats, get_stddev,
krb5int_mutex_report_stats) [DEBUG_THREADS_STATS]: New functions.
* util/support/libkrb5support.exports: Add krb5int_mutex_*_stats.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16913 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoticket: new
Sam Hartman [Fri, 26 Nov 2004 23:30:28 +0000 (23:30 +0000)]
ticket: new
subject: ftpcmds.y: nbby should be 8

* ftpcmd.y: nbby should be 8 for anything platform we care about.
The previous test broke on Debian BSD, so the test has been
removed.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16909 dc483132-0cff-0310-8789-dd5450dbe970

20 years agofix missing mutex initialization in keytab file code
Ken Raeburn [Fri, 26 Nov 2004 06:03:24 +0000 (06:03 +0000)]
fix missing mutex initialization in keytab file code

Missed a case in the checked-in (and pulled-up) fix to 2781.

* kt_file.c (krb5_ktfile_wresolve): Initialize mutex here too.

ticket: new
status: open
target_version: 1.4

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16908 dc483132-0cff-0310-8789-dd5450dbe970

20 years agofix missing locking in keytab; fix stdio handling too
Ken Raeburn [Wed, 24 Nov 2004 02:39:44 +0000 (02:39 +0000)]
fix missing locking in keytab; fix stdio handling too

The keytab type list lock was implemented, but I missed the per-keytab lock.
Since I was in there, I ripped out the bogus stdio buffer mangling that the
code was doing, and set up a buffer to be used that we can sanitize later.

* kt_file.c (struct _krb5_ktfile_data): Add mutex and buffer.
(KTFILEBUFP, KTLOCK, KTUNLOCK, KTCHECKLOCK): New macros.
(krb5_ktfile_resolve): Initialize mutex.
(krb5_ktfile_close): Zap data buffer before freeing.
(krb5_ktfile_get_entry, krb5_ktfile_start_seq_get, krb5_ktfile_get_next,
krb5_ktfile_end_get, krb5_ktfile_add, krb5_ktfile_remove): Lock and unlock the
mutex.
(krb5_ktfileint_open): Check that the mutex is locked.  Set the stdio buffer to
the new buffer in the ktfile data.
(krb5_ktfileint_write_entry, krb5_ktfileint_find_slot): Check that the mutex is
locked.  Don't call setbuf.  Flush the stdio buffer after writing.

ticket: new
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16905 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoset errno=0 prior to fopen in kt_file
Tom Yu [Wed, 24 Nov 2004 01:28:03 +0000 (01:28 +0000)]
set errno=0 prior to fopen in kt_file

* kt_file.c (krb5_ktfileint_open): Update previous change by
explicitly setting errno=0 prior to calling fopen().  Also, return
EMFILE, not ENFILE, for compatibility with Solaris 8, which does
set errno when out of file descriptors.

ticket: new
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16904 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoKDC on Tru64 was hanging because of another case where Yarrow code
Ken Raeburn [Tue, 23 Nov 2004 03:15:12 +0000 (03:15 +0000)]
KDC on Tru64 was hanging because of another case where Yarrow code
assumes locks are recursive.  Probably didn't trigger on Linux,
Solaris, or NetBSD because they have /dev/random and Tru64 does not.

* yarrow.c (yarrow_input_maybe_locking): Renamed from
yarrow_input_maybe_locking, made static.  New argument indicates whether or not
to do locking.
(krb5int_yarrow_input): New wrapper function.
(yarrow_input_locked): New wrapper function.
(Yarrow_detect_fork): Call yarrow_input_locked.

ticket: 2755
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16903 dc483132-0cff-0310-8789-dd5450dbe970

20 years agodocument Solaris patches for pty-close bug
Tom Yu [Sat, 20 Nov 2004 02:06:55 +0000 (02:06 +0000)]
document Solaris patches for pty-close bug

* build.texinfo (Solaris 9): Document Solaris patches for pty
close bug.

ticket: new
version_reported: 1.4
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16901 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago* locate_kdc.c (krb5int_add_host_to_list): If debugging, log the requested
Ken Raeburn [Fri, 19 Nov 2004 22:12:50 +0000 (22:12 +0000)]
* locate_kdc.c (krb5int_add_host_to_list): If debugging, log the requested
family and socket type.  If AI_NUMERICSERV is defined, set it in ai_flags.  If
getaddrinfo returns an error with debugging enabled, log the error.
(krb5_locate_srv_conf_1): When logging an error from add_host_to_list, include
the corresponding error string.

* t_locate_kdc.c: Include port-sockets.h, instead of sys/socket.h, netdb.h,
netinet/in.h, and arpa/inet.h.
* Makefile.in ($(OUTPRE)t_locate_kdc.exe): New target.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16899 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago * kt_file.c (krb5_ktfileint_open): Patch from Roland Dowdeswell to
Tom Yu [Fri, 19 Nov 2004 22:12:32 +0000 (22:12 +0000)]
* kt_file.c (krb5_ktfileint_open): Patch from Roland Dowdeswell to
return ENFILE when fopen() returns NULL but doesn't set errno.

ticket: 2760
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16898 dc483132-0cff-0310-8789-dd5450dbe970

20 years agocreate rpc header install directory
Tom Yu [Fri, 19 Nov 2004 21:46:59 +0000 (21:46 +0000)]
create rpc header install directory

* pre.in (KRB5_INCSUBDIRS): Add KRB5_INCDIR/gssrpc.

ticket: new
version_reported: 1.4
target_version: 1.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16896 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago* cc_mslsa.c (MSCredToMITCred): Don't create an empty array for addresses, just
Ken Raeburn [Fri, 19 Nov 2004 21:39:48 +0000 (21:39 +0000)]
* cc_mslsa.c (MSCredToMITCred): Don't create an empty array for addresses, just
use a null pointer now.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16895 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago* fake-addrinfo.c (HAVE_GETADDRINFO, HAVE_GETNAMEINFO)[_WIN32]: Don't define
Ken Raeburn [Fri, 19 Nov 2004 21:09:45 +0000 (21:09 +0000)]
* fake-addrinfo.c (HAVE_GETADDRINFO, HAVE_GETNAMEINFO)[_WIN32]: Don't define
here.
(protoname): Handle IPPROTO_IGMP.
(debug_dump_addrinfo_args): Update for current interfaces to socktypename and
familyname.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16893 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago* win-mac.h (HAVE_GETADDRINFO, HAVE_GETNAMEINFO): Define
Ken Raeburn [Fri, 19 Nov 2004 21:03:03 +0000 (21:03 +0000)]
* win-mac.h (HAVE_GETADDRINFO, HAVE_GETNAMEINFO): Define

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16892 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago * aclocal.m4 (KRB5_AC_PRIOCNTL_HACK): Check for Solaris patch
Tom Yu [Fri, 19 Nov 2004 20:36:45 +0000 (20:36 +0000)]
* aclocal.m4 (KRB5_AC_PRIOCNTL_HACK): Check for Solaris patch
117171-11 (sparc) or 117172-11 (x86), which fixes the Solaris 9
bug which can cause final pty output to be on close.

ticket: 2776
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16891 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoafter 1.4 branch, trunk is effectively krb5-1.5-prerelease
Tom Yu [Fri, 19 Nov 2004 00:26:37 +0000 (00:26 +0000)]
after 1.4 branch, trunk is effectively krb5-1.5-prerelease

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16890 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago* Makefile.in (SHLIB_EXPLIBS): Remove -ldl accidentally added in last change
Ken Raeburn [Thu, 18 Nov 2004 21:07:05 +0000 (21:07 +0000)]
* Makefile.in (SHLIB_EXPLIBS): Remove -ldl accidentally added in last change

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16888 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoinstall rpc headers into correct directory
Tom Yu [Thu, 18 Nov 2004 20:46:45 +0000 (20:46 +0000)]
install rpc headers into correct directory

RPC headers need to be installed into PREFIX/include/gssrpc, not PREFIX/include

ticket: new
target_version: 1.4
version_reported: 1.4
tags: pullup
component: krb5-build

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16887 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago* prng.c (do_yarrow_init): Move mutex initialization here.
Ken Raeburn [Wed, 17 Nov 2004 08:03:51 +0000 (08:03 +0000)]
* prng.c (do_yarrow_init): Move mutex initialization here.
(krb5int_prng_init): Don't do it here.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16880 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago* Makefile.in (SHLIB_EXPDEPS, SHLIB_EXPLIBS): Add support library
Ken Raeburn [Wed, 17 Nov 2004 07:56:05 +0000 (07:56 +0000)]
* Makefile.in (SHLIB_EXPDEPS, SHLIB_EXPLIBS): Add support library

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16879 dc483132-0cff-0310-8789-dd5450dbe970

20 years agooops, bad update
Ken Raeburn [Tue, 16 Nov 2004 07:04:03 +0000 (07:04 +0000)]
oops, bad update

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16877 dc483132-0cff-0310-8789-dd5450dbe970

20 years agomake depend
Ken Raeburn [Tue, 16 Nov 2004 07:03:33 +0000 (07:03 +0000)]
make depend

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16876 dc483132-0cff-0310-8789-dd5450dbe970

20 years agomake depend
Ken Raeburn [Tue, 16 Nov 2004 06:51:16 +0000 (06:51 +0000)]
make depend

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16875 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago* k5-int.h (struct _krb5_cc_ops): Add new function pointer field get_flags
Ken Raeburn [Tue, 16 Nov 2004 06:01:08 +0000 (06:01 +0000)]
* k5-int.h (struct _krb5_cc_ops): Add new function pointer field get_flags

ticket: 2763
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16874 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoNow a kvno invocation will only open the ccache file a small number of
Ken Raeburn [Tue, 16 Nov 2004 05:28:38 +0000 (05:28 +0000)]
Now a kvno invocation will only open the ccache file a small number of
times, but there's still excessive seeking and re-reading of data
happening.

* cc_retr.c (krb5_cc_retrieve_cred_seq): Temporarily clear the
KRB5_TC_OPENCLOSE flag on the credentials cache while reading multiple entries
from it.

ticket: 2763
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16873 dc483132-0cff-0310-8789-dd5450dbe970

20 years ago* krb5.hin (krb5_cc_get_flags): Declare
Ken Raeburn [Tue, 16 Nov 2004 05:06:34 +0000 (05:06 +0000)]
* krb5.hin (krb5_cc_get_flags): Declare

ticket: 2763
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16872 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoCreate a ccache get-flags operation.
Ken Raeburn [Tue, 16 Nov 2004 05:04:56 +0000 (05:04 +0000)]
Create a ccache get-flags operation.
The MSLSA and CCAPI versions are untested!

* cc_file.c (krb5_fcc_get_flags): New function.
(krb5_fcc_ops, krb5_cc_file_ops): Add it.
* cc_memory.c (krb5_mcc_get_flags): New function.
(krb5_mcc_ops): Add it.
* cc_mslsa.c (krb5_lcc_get_flags): New function.
(krb5_lcc_ops): Add it.
* ccfns.c (krb5_cc_get_flags): New function.
* ccapi/stdcc.c (krb5_stdcc_get_flags): New function.
(krb5_cc_stdcc_ops): Add it.
* ccapi/stdcc.h (krb5_stdcc_get_flags): Declare.

ticket: 2763
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16871 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoConvert Yarrow to use AES not 3des. Update test vectors
Sam Hartman [Tue, 16 Nov 2004 03:28:08 +0000 (03:28 +0000)]
Convert Yarrow to use AES not 3des.  Update test vectors

ticket: 2410
Tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16870 dc483132-0cff-0310-8789-dd5450dbe970

20 years agoMake static linking not require -lsocket, -lnsl, etc.
Ken Raeburn [Mon, 15 Nov 2004 22:16:02 +0000 (22:16 +0000)]
Make static linking not require -lsocket, -lnsl, etc.
Don't duplicate macro definitions.

Header files and comments still need some cleanup.

* cache-addrinfo.h, init-addrinfo.c: New files, split out from fake-addrinfo.c.
* fake-addrinfo.c: Include cache-addrinfo.h.
(FAI_CACHE, struct face, struct fac): Moved to cache-addrinfo.h.
(krb5int_fac, krb5int_init_fac, krb5int_fini_fac): Moved to init-addrinfo.c.
(addrinfo, struct addrinfo): Don't define.
(AI_* and NI_* and EAI_* macros): Don't define.
* threads.c: Include cache-addrinfo.h.
(krb5int_init_fac, krb5int_fini_fac): Don't declare.
* Makefile.in (SRCS, STLIBOBJS, LIBOBJS): Updated.

ticket: 2761
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16867 dc483132-0cff-0310-8789-dd5450dbe970