krb5.git
15 years agoMove krb5int_get_fq_local_hostname to os-proto.h. Not exported
Ezra Peisach [Sun, 15 Nov 2009 01:38:41 +0000 (01:38 +0000)]
Move krb5int_get_fq_local_hostname to os-proto.h.  Not exported

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23188 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMoved krb5int_sendto prototype to os-proto.h. This function is not exported
Ezra Peisach [Sun, 15 Nov 2009 00:51:21 +0000 (00:51 +0000)]
Moved krb5int_sendto prototype to os-proto.h.  This function is not exported
from libkrb5 - so the rest of the world does not need to see it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23186 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd an exception for include/iprop.h and revert its reformatting,
Greg Hudson [Sun, 15 Nov 2009 00:19:36 +0000 (00:19 +0000)]
Add an exception for include/iprop.h and revert its reformatting,
since it was generated with rpcgen.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23185 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix typos in previous
Tom Yu [Sat, 14 Nov 2009 19:24:39 +0000 (19:24 +0000)]
Fix typos in previous

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23182 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReindent include directory, reformatting prototypes as necessary.
Greg Hudson [Sat, 14 Nov 2009 18:56:43 +0000 (18:56 +0000)]
Reindent include directory, reformatting prototypes as necessary.
Exclude include/gssrpc due to its Sun origin and k5-platform.h due to
macros too hairy for emacs c-mode to handle.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23180 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove include/krb54proto.h as it is no longer used
Greg Hudson [Sat, 14 Nov 2009 15:24:56 +0000 (15:24 +0000)]
Remove include/krb54proto.h as it is no longer used

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23163 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoConstrained delegation without PAC support
Greg Hudson [Sat, 14 Nov 2009 04:46:30 +0000 (04:46 +0000)]
Constrained delegation without PAC support

Merge Luke's users/lhoward/s4u2proxy branch to trunk.  Implements a
Heimdal-compatible mechanism for allowing constrained delegation
without back-end support for PACs.  Back-end support exists in LDAP
only (via a new krbAllowedToDelegateTo attribute), not DB2.

ticket: 6580

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23160 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/rcache, ensure that function definition headers put the
Greg Hudson [Fri, 13 Nov 2009 00:28:30 +0000 (00:28 +0000)]
In lib/krb5/rcache, ensure that function definition headers put the
function name at the beginning of the line.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23157 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoTypo fix
Zhanna Tsitkov [Thu, 12 Nov 2009 20:22:53 +0000 (20:22 +0000)]
Typo fix

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23154 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPost-great-reindent check. Part II
Zhanna Tsitkov [Thu, 12 Nov 2009 20:17:34 +0000 (20:17 +0000)]
Post-great-reindent check. Part II

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23153 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRestore the local variable type
Zhanna Tsitkov [Thu, 12 Nov 2009 19:31:33 +0000 (19:31 +0000)]
Restore the local variable type

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23152 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPost-great-reindent check. Part I
Zhanna Tsitkov [Thu, 12 Nov 2009 19:12:51 +0000 (19:12 +0000)]
Post-great-reindent check. Part I

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23151 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFor iprop test, reduce expected attribute change count to reflect the three
Luke Howard [Wed, 11 Nov 2009 12:04:27 +0000 (12:04 +0000)]
For iprop test, reduce expected attribute change count to reflect the three
non-replicated attributes: last_success, last_failed and fail_auth_count.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23149 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/keytab, ensure that function definition headers have
Greg Hudson [Tue, 10 Nov 2009 19:59:39 +0000 (19:59 +0000)]
In lib/krb5/keytab, ensure that function definition headers have
function names at the beginning of lines, and avoid putting open
parentheses at the beginning of lines in function prototypes.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23148 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove the unnecessary src/lib/glue4.c
Greg Hudson [Tue, 10 Nov 2009 18:40:10 +0000 (18:40 +0000)]
Remove the unnecessary src/lib/glue4.c

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23147 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove src/lib/crypto/krb/enc_provider, which was accidentally
Greg Hudson [Tue, 10 Nov 2009 16:57:27 +0000 (16:57 +0000)]
Remove src/lib/crypto/krb/enc_provider, which was accidentally
resurrected (again) in r22875 when merging the authdata branch to the
trunk.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23146 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRevise patch to avoid using changequote
Ken Raeburn [Mon, 9 Nov 2009 16:56:01 +0000 (16:56 +0000)]
Revise patch to avoid using changequote

ticket: 6579

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23145 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoquoting bug causes solaris pre-10 thread handling bugs
Ken Raeburn [Mon, 9 Nov 2009 06:13:34 +0000 (06:13 +0000)]
quoting bug causes solaris pre-10 thread handling bugs

Quoting problems in pattern matching on the OS name cause Solaris
versions up through 9 to not be properly recognized in the
thread-system configuration setup.  This causes our libraries to make
the erroneous assumption that valid thread support routines are
available on all Solaris systems, rather than just assuming it for
Solaris 10 and later.

The result is assertion failures like this one reported by Meraj
Mohammed and others:

  Assertion failed: k5int_i->did_run != 0, file krb5_libinit.c, line 63

Thanks to Tom Shaw for noticing the cause of the problem.

The bug may be present in the 1.6.x series as well.

ticket: 6579
target_version: 1.7.1
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23144 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDon't flush stdout so much. Calculate and display some more averages
Ken Raeburn [Sat, 7 Nov 2009 00:14:37 +0000 (00:14 +0000)]
Don't flush stdout so much.  Calculate and display some more averages

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23142 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDelay start of test until the start of a new second on the system
Ken Raeburn [Sat, 7 Nov 2009 00:14:33 +0000 (00:14 +0000)]
Delay start of test until the start of a new second on the system
clock.  Print per-thread stats only once.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23141 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReformat some open-paren issues. Remove kprop.c and kpropd.c from
Tom Yu [Fri, 6 Nov 2009 23:29:12 +0000 (23:29 +0000)]
Reformat some open-paren issues.  Remove kprop.c and kpropd.c from
exclusions.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23140 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoChange INIT_ONCE compile-time flag into a run-time option. Delete
Ken Raeburn [Fri, 6 Nov 2009 20:17:00 +0000 (20:17 +0000)]
Change INIT_ONCE compile-time flag into a run-time option.  Delete
DIRECT support; always create threads.  Allow setting of test interval
and number of threads via run-time options.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23139 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDon't start by attempting to unlink replay caches by guessing
Ken Raeburn [Fri, 6 Nov 2009 20:16:57 +0000 (20:16 +0000)]
Don't start by attempting to unlink replay caches by guessing
pathnames specific to my uid on MIT Athena systems.  Instead, create a
replay cache object and then destroy it through the library.  Tweak
the rcache-init-error messages to be specific to the instance that
failed.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23138 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUse krb5_get_error_message for reporting if krb5_get_server_rcache fails
Ken Raeburn [Fri, 6 Nov 2009 20:16:53 +0000 (20:16 +0000)]
Use krb5_get_error_message for reporting if krb5_get_server_rcache fails

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23137 dc483132-0cff-0310-8789-dd5450dbe970

15 years agomake mark-cstyle; make reindent
Tom Yu [Fri, 6 Nov 2009 19:45:29 +0000 (19:45 +0000)]
make mark-cstyle; make reindent

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23136 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd slave/ to INDENTDIRS, with some exclusions
Tom Yu [Fri, 6 Nov 2009 19:45:25 +0000 (19:45 +0000)]
Add slave/ to INDENTDIRS, with some exclusions

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23135 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMove more reindent settings into variables
Tom Yu [Fri, 6 Nov 2009 18:53:31 +0000 (18:53 +0000)]
Move more reindent settings into variables

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23134 dc483132-0cff-0310-8789-dd5450dbe970

15 years agomake mark-cstyle; make reindent
Tom Yu [Thu, 5 Nov 2009 04:39:54 +0000 (04:39 +0000)]
make mark-cstyle; make reindent

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23133 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReformat some block comments. Refine lib/krb5/asn.1 reindent
Tom Yu [Thu, 5 Nov 2009 04:39:48 +0000 (04:39 +0000)]
Reformat some block comments.  Refine lib/krb5/asn.1 reindent
exclusion into individual file exclusions.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23132 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDeal with some open paren formatting issues, and reindent. Make
Tom Yu [Thu, 5 Nov 2009 03:26:25 +0000 (03:26 +0000)]
Deal with some open paren formatting issues, and reindent.  Make
preauth.c use the function pointer typdefs in the prototypes as well.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23131 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove cast-qual from the gcc warnings set; it is too common for us to
Greg Hudson [Wed, 4 Nov 2009 20:16:13 +0000 (20:16 +0000)]
Remove cast-qual from the gcc warnings set; it is too common for us to
have to explicitly override const in order to implement strchr-like
functions or place pointers into read-only krb5_data objects.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23130 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUse "unsigned short" instead of "u_short" in argument to SET macro;
Ken Raeburn [Wed, 4 Nov 2009 18:11:51 +0000 (18:11 +0000)]
Use "unsigned short" instead of "u_short" in argument to SET macro;
the Emacs cc-mode indentation code seems to get confused by the
one-word case.

Reindent.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23129 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRestore the krb5 1.6 behavior of not retrying AS requests after
Greg Hudson [Wed, 4 Nov 2009 16:31:41 +0000 (16:31 +0000)]
Restore the krb5 1.6 behavior of not retrying AS requests after
PREAUTH_FAILED errors.  Among other things, this change causes
krb5_get_init_creds_opt_set_pa to act (mostly) as a constraint rather
than simply as an optimistic set of preauth types, which is the
behavior apps had been seeing prior to 1.7.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23128 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDelete obsolete krb5-mark-cstyle.el. (replaced by a python script)
Tom Yu [Wed, 4 Nov 2009 04:28:24 +0000 (04:28 +0000)]
Delete obsolete krb5-mark-cstyle.el.  (replaced by a python script)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23127 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReindent and manually restore some BSD-style files that were
Tom Yu [Wed, 4 Nov 2009 04:28:17 +0000 (04:28 +0000)]
Reindent and manually restore some BSD-style files that were
previously incorrectly marked as krb5-style.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23126 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCorrect regexps for matching emacs and cc-mode versions. In reindent
Tom Yu [Wed, 4 Nov 2009 00:21:35 +0000 (00:21 +0000)]
Correct regexps for matching emacs and cc-mode versions.  In reindent
targets, chdir to SRCTOP to avoid excessive references to $(SRCTOP) in
the find script.  Define new variables to avoid errors when creating
exception lists for find scripts.

Use a python script instead of elisp to mark files.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23125 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReindent after making fixes for emacs-23
Tom Yu [Tue, 3 Nov 2009 03:27:56 +0000 (03:27 +0000)]
Reindent after making fixes for emacs-23

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23123 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMonkey patch for the cc-mode that comes with emacs-23.x; that version
Tom Yu [Tue, 3 Nov 2009 03:14:41 +0000 (03:14 +0000)]
Monkey patch for the cc-mode that comes with emacs-23.x; that version
of cc-mode has a bug that causes incorrect indentation of case labels
containing character constants.  Already fixed upstream in unreleased
cc-mode sources.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23122 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoEmacs 21 doesn't have custom-variable-p. Also, adjust to use the
Tom Yu [Mon, 2 Nov 2009 19:19:02 +0000 (19:19 +0000)]
Emacs 21 doesn't have custom-variable-p.  Also, adjust to use the
correct controlling variables for older incarnations of
whitespace-mode.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23121 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoClean up a bunch of signed/unsigned comparison warnings
Greg Hudson [Mon, 2 Nov 2009 18:00:40 +0000 (18:00 +0000)]
Clean up a bunch of signed/unsigned comparison warnings

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23120 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoSimplify krb5int_get_error (and fix a cast-qual warning) by not
Greg Hudson [Sun, 1 Nov 2009 22:32:47 +0000 (22:32 +0000)]
Simplify krb5int_get_error (and fix a cast-qual warning) by not
worrying so much about system errors longer than 1K.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23118 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoBe a little more const-correct in krb5int_vset_error_fl
Greg Hudson [Sun, 1 Nov 2009 22:14:25 +0000 (22:14 +0000)]
Be a little more const-correct in krb5int_vset_error_fl

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23117 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUn-constify struct errinfo's msg field because it is the owner of that
Greg Hudson [Sun, 1 Nov 2009 21:51:26 +0000 (21:51 +0000)]
Un-constify struct errinfo's msg field because it is the owner of that
memory (even though the memory is intended to be immutable during its
lifetime).

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23116 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn k5-int.h, fix make_data to work with C++
Greg Hudson [Sun, 1 Nov 2009 15:55:44 +0000 (15:55 +0000)]
In k5-int.h, fix make_data to work with C++

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23115 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMemory leak fix: in obtain_sam_padata, after claiming the contents of
Greg Hudson [Sun, 1 Nov 2009 14:13:32 +0000 (14:13 +0000)]
Memory leak fix: in obtain_sam_padata, after claiming the contents of
the scratch data object, free the outer structure before nulling the
pointer to it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23114 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRework in an attempt to deal with variant Emacs versions
Tom Yu [Sun, 1 Nov 2009 04:35:20 +0000 (04:35 +0000)]
Rework in an attempt to deal with variant Emacs versions

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23113 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMove the implementations of four deprecated crypto functions to
Greg Hudson [Sun, 1 Nov 2009 02:47:58 +0000 (02:47 +0000)]
Move the implementations of four deprecated crypto functions to
old_api_glue.c.  Move the prototypes of seven deprecated crypto
functions to old_api_glue.c instead of k5-int.h, since we don't use
those functions internally.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23112 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoStop using deprecated krb5_encrypt_data in preauth code. Use
Greg Hudson [Sun, 1 Nov 2009 02:46:36 +0000 (02:46 +0000)]
Stop using deprecated krb5_encrypt_data in preauth code.  Use
krb5_encrypt_helper instead.  (encrypt_helper takes a key usage
instead of an ivec, but that's okay since the invocations were using
null ivecs anyway.)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23111 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReformat to avoid parens at beginnings of lines
Tom Yu [Sat, 31 Oct 2009 18:08:09 +0000 (18:08 +0000)]
Reformat to avoid parens at beginnings of lines

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23109 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/ccache, ensure that function definition headers have
Greg Hudson [Sat, 31 Oct 2009 03:59:19 +0000 (03:59 +0000)]
In lib/krb5/ccache, ensure that function definition headers have
function names at the beginnings of lines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23107 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/asn.1, ensure that function definition headers have
Greg Hudson [Sat, 31 Oct 2009 03:52:01 +0000 (03:52 +0000)]
In lib/krb5/asn.1, ensure that function definition headers have
function names at the beginnings of lines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23106 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReformat lib/krb5/asn.1 internal prototypes to avoid problematic parens
Greg Hudson [Sat, 31 Oct 2009 03:50:54 +0000 (03:50 +0000)]
Reformat lib/krb5/asn.1 internal prototypes to avoid problematic parens
at beginnings of lines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23105 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReformat asn1_make.h prototypes to avoid the problematic parens at
Greg Hudson [Sat, 31 Oct 2009 03:37:09 +0000 (03:37 +0000)]
Reformat asn1_make.h prototypes to avoid the problematic parens at
beginnings of lines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23104 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/os, ensure that function definition headers have function
Greg Hudson [Sat, 31 Oct 2009 03:17:27 +0000 (03:17 +0000)]
In lib/krb5/os, ensure that function definition headers have function
names at the beginnings of lines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23103 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn lib/krb5/krb, ensure all function definition headers are in ANSI
Greg Hudson [Sat, 31 Oct 2009 03:03:54 +0000 (03:03 +0000)]
In lib/krb5/krb, ensure all function definition headers are in ANSI
style and have the function name at the beginning of a line.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23102 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix indentation in gc_via_tkt.c which was messed up by a malformed #if
Greg Hudson [Sat, 31 Oct 2009 02:36:01 +0000 (02:36 +0000)]
Fix indentation in gc_via_tkt.c which was messed up by a malformed #if
0 block.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23101 dc483132-0cff-0310-8789-dd5450dbe970

15 years agomake mark-cstyle
Tom Yu [Sat, 31 Oct 2009 00:48:38 +0000 (00:48 +0000)]
make mark-cstyle
make reindent

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23100 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFixes for Emacs 22 compatibility
Ken Raeburn [Fri, 30 Oct 2009 23:08:48 +0000 (23:08 +0000)]
Fixes for Emacs 22 compatibility

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23099 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIf krb5_sname_to_principal returns a null realm for the client
Ken Raeburn [Fri, 30 Oct 2009 23:08:45 +0000 (23:08 +0000)]
If krb5_sname_to_principal returns a null realm for the client
principal name, print an error message.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23098 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoQuote realm name in error message.
Ken Raeburn [Fri, 30 Oct 2009 23:08:40 +0000 (23:08 +0000)]
Quote realm name in error message.
If realm name is an empty string, just return an error right away.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23097 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoTweak batch reindent some more. Limit the initial bulk reindent, and
Tom Yu [Fri, 30 Oct 2009 21:34:19 +0000 (21:34 +0000)]
Tweak batch reindent some more.  Limit the initial bulk reindent, and
refine the exception list somewhat.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23096 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUpdate the kadm5 design documentation slightly to reflect that MIT
Greg Hudson [Fri, 30 Oct 2009 10:49:38 +0000 (10:49 +0000)]
Update the kadm5 design documentation slightly to reflect that MIT
doesn't commit to a stable libkadm5 C API.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23095 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn process_tgs_req, fully initialize e_data since we may copy it in
Greg Hudson [Thu, 29 Oct 2009 23:07:33 +0000 (23:07 +0000)]
In process_tgs_req, fully initialize e_data since we may copy it in
prepare_error_tgs.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23093 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd a couple of krb5_data convenience constructor functions, to
Greg Hudson [Thu, 29 Oct 2009 23:00:13 +0000 (23:00 +0000)]
Add a couple of krb5_data convenience constructor functions, to
facilitate properly initializing krb5_data objects.  Adjust formatting
of the existing krb5_data convenience functions and remove the #if 0
block.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23092 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCorrected Copyrights and some minor reorganization in openssl impl.
Zhanna Tsitkov [Thu, 29 Oct 2009 21:36:47 +0000 (21:36 +0000)]
Corrected Copyrights and some minor reorganization in openssl impl.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23090 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFiles that were not picked up by svn rev #22995 commit:
Zhanna Tsitkov [Thu, 29 Oct 2009 18:46:52 +0000 (18:46 +0000)]
Files that were not picked up by svn rev #22995 commit:
Changed the crypto make system to add build flexibility. The update cancels the requirement for the dir structures to be identical in all crypto implementation and supports impl. dependent tests.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23089 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRestored few symbols in the crypto exports list to satisfy tests.`
Zhanna Tsitkov [Thu, 29 Oct 2009 17:52:21 +0000 (17:52 +0000)]
Restored few symbols in the crypto exports list to satisfy tests.`

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23088 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRename api.3 to api.current in the libkadm5 unit tests. This way the
Greg Hudson [Thu, 29 Oct 2009 16:13:36 +0000 (16:13 +0000)]
Rename api.3 to api.current in the libkadm5 unit tests.  This way the
main body of tests won't have to be moved every time the current API
version of libkadm5 changes.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23087 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRename some lingering krb5_derive_key references
Greg Hudson [Thu, 29 Oct 2009 15:02:23 +0000 (15:02 +0000)]
Rename some lingering krb5_derive_key references

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23086 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoremove times underflow/overflow checks, they break tests
Luke Howard [Thu, 29 Oct 2009 14:16:55 +0000 (14:16 +0000)]
remove times underflow/overflow checks, they break tests

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23084 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoNew elisp file to mark C styles in files. New top-level Makefile
Tom Yu [Wed, 28 Oct 2009 19:56:19 +0000 (19:56 +0000)]
New elisp file to mark C styles in files.  New top-level Makefile
target "make mark-cstyle".  The exception list is not final; it's just
a starting point for discussion.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23082 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoBump the accessor version number since we made changes.
Greg Hudson [Wed, 28 Oct 2009 19:17:35 +0000 (19:17 +0000)]
Bump the accessor version number since we made changes.
Take the opportunity to regularize accessor field names (no krb5 or
 krb5int prefixes).
Fix a test program which was still using krb5_hmac.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23081 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRestrict libk5crypto.exports list to API and ABI. Also, include functions needed...
Zhanna Tsitkov [Wed, 28 Oct 2009 18:37:18 +0000 (18:37 +0000)]
Restrict libk5crypto.exports list to API and ABI. Also, include functions needed to link kerb libs and tests properly

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23080 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReplace krb5_ with krb5Int_ prefix for non-API functions
Zhanna Tsitkov [Wed, 28 Oct 2009 18:12:38 +0000 (18:12 +0000)]
Replace krb5_ with krb5Int_ prefix for non-API functions

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23079 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUpdate to use heuristics for setting "krb5" style based on file local
Tom Yu [Wed, 28 Oct 2009 17:18:04 +0000 (17:18 +0000)]
Update to use heuristics for setting "krb5" style based on file local
variable settings.  Improve friendliness of variant loading orders.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23078 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPrint a "starting..." message on stderr if running in nofork mode, for
Tom Yu [Wed, 28 Oct 2009 17:09:00 +0000 (17:09 +0000)]
Print a "starting..." message on stderr if running in nofork mode, for
consistency with kadmind behavior.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23077 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove "verify" on make clean
Ezra Peisach [Wed, 28 Oct 2009 01:06:09 +0000 (01:06 +0000)]
Remove "verify" on make clean

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23076 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd variable DB_VERSION to Makefile.in. Generate deps so that
Ezra Peisach [Wed, 28 Oct 2009 01:00:34 +0000 (01:00 +0000)]
Add variable DB_VERSION to Makefile.in.  Generate deps so that
configure will work.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23075 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoHeimdal DB bridge plugin for KDC back end
Greg Hudson [Tue, 27 Oct 2009 14:24:01 +0000 (14:24 +0000)]
Heimdal DB bridge plugin for KDC back end

Merge Luke's users/lhoward/heimmig branch to trunk.  Implements a
KDC back-end plugin which interfaces to a Heimdal HDB plugin.

ticket: 6578

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23073 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd "reindent" target to top-level Makefile.in. Add
Tom Yu [Tue, 27 Oct 2009 02:13:31 +0000 (02:13 +0000)]
Add "reindent" target to top-level Makefile.in.  Add
krb5-batch-indent.el.  These perform a batch reindent based upon the
Emacs file-local variable settings, taking care to distinguish between
files that are supposed to conform to the coding style versus those
that are marked as being exceptions.  A later commit will explicitly
mark the files that we expect to conform to our coding standards.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23061 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDo not include com_err.h - not used here
Ezra Peisach [Tue, 27 Oct 2009 00:26:10 +0000 (00:26 +0000)]
Do not include com_err.h - not used here

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23060 dc483132-0cff-0310-8789-dd5450dbe970

15 years agowith an uninitialized entry on error exit
Ezra Peisach [Tue, 27 Oct 2009 00:22:50 +0000 (00:22 +0000)]
with an uninitialized entry on error exit

k5_hmac_md5_hash_iov: Initialize keyblock.length - so we do not invoke zapfree

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23059 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix missing emacs file variable markers. Add krb5-c-style.el: the
Tom Yu [Mon, 26 Oct 2009 19:08:43 +0000 (19:08 +0000)]
Fix missing emacs file variable markers.  Add krb5-c-style.el: the
emacs lisp settings for the standard coding style.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23049 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix printf argument type mismatches related to pw_max_fail in
Greg Hudson [Mon, 26 Oct 2009 15:10:00 +0000 (15:10 +0000)]
Fix printf argument type mismatches related to pw_max_fail in
kadmin.c.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23044 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove the libkadm5 api.2 unit tests which don't pertain to the cpol,
Greg Hudson [Mon, 26 Oct 2009 02:58:06 +0000 (02:58 +0000)]
Remove the libkadm5 api.2 unit tests which don't pertain to the cpol,
mpol, or gpol operations.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23043 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove the telnet-to-localhost sanity check in start_servers_local, as
Greg Hudson [Mon, 26 Oct 2009 02:56:34 +0000 (02:56 +0000)]
Remove the telnet-to-localhost sanity check in start_servers_local, as
the system telnet will not necessarily run correctly with
LD_LIBRARY_PATH pointing at the Kerberos libraries from the build
tree.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23042 dc483132-0cff-0310-8789-dd5450dbe970

15 years agonot try to free random stack garbage on error
Ezra Peisach [Sun, 25 Oct 2009 23:31:02 +0000 (23:31 +0000)]
not try to free random stack garbage on error

kdc_return_preauth: Set enc.ciphertext.data to null to ensure we do

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23040 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoReformat function definition headers in gss-krb5's util_crypt.c to
Greg Hudson [Sun, 25 Oct 2009 20:27:54 +0000 (20:27 +0000)]
Reformat function definition headers in gss-krb5's util_crypt.c to
meet coding standards.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23039 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAccount lockout
Greg Hudson [Sun, 25 Oct 2009 16:55:12 +0000 (16:55 +0000)]
Account lockout

Merge Luke's users/lhoward/lockout2 branch to trunk.  Implements
account lockout policies for preauth-using principals using existing
principal metadata fields and new policy fields.  The kadmin API
version is bumped from 2 to 3 to compatibly extend the policy_ent_rec
structure.

ticket: 6577

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23038 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoSet up an INIT-CMD to set CRYPTO_IMPL in config.status so that
Tom Yu [Sun, 25 Oct 2009 01:10:33 +0000 (01:10 +0000)]
Set up an INIT-CMD to set CRYPTO_IMPL in config.status so that
rebuilding Makefiles in lib/crypto works correctly.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23034 dc483132-0cff-0310-8789-dd5450dbe970

15 years agomake depend
Tom Yu [Sun, 25 Oct 2009 00:15:11 +0000 (00:15 +0000)]
make depend

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23030 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoResurrect deleted test files. Adjust Makefile.in files to correctly
Tom Yu [Sat, 24 Oct 2009 23:50:23 +0000 (23:50 +0000)]
Resurrect deleted test files.  Adjust Makefile.in files to correctly
define RUN_SETUP.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23029 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoComment out empty definition of krb5_gss_set_sec_context_option_ops and its
Luke Howard [Fri, 23 Oct 2009 21:18:47 +0000 (21:18 +0000)]
Comment out empty definition of krb5_gss_set_sec_context_option_ops and its
usage, because ISO C apparently forbids empty array initializers

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23002 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove #define DEBUG 1 that slipped in in S4U merge
Luke Howard [Fri, 23 Oct 2009 21:16:20 +0000 (21:16 +0000)]
Remove #define DEBUG 1 that slipped in in S4U merge

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23001 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoChanged the crypto make system to add build flexibility. The update cancels the requi...
Zhanna Tsitkov [Fri, 23 Oct 2009 19:45:48 +0000 (19:45 +0000)]
Changed the crypto make system to add build flexibility. The update cancels the requirement for the dir structures to be identical in all crypto implementation and supports impl. dependent tests. Also, minor libk5crypto.exports list reduction ( from f_tables)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22995 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoWhen iterating through the keytab in krb5_rd_req(), do not
Luke Howard [Thu, 22 Oct 2009 21:00:19 +0000 (21:00 +0000)]
When iterating through the keytab in krb5_rd_req(), do not
return success if we did not find any matching keytab entries,
otherwise we will crash upon accessing ticket->enc_part2.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22974 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoEnsure that a GSS_C_BOTH acquired for GSS_C_NO_NAME still passes
Luke Howard [Thu, 22 Oct 2009 20:58:37 +0000 (20:58 +0000)]
Ensure that a GSS_C_BOTH acquired for GSS_C_NO_NAME still passes
a NULL server principal to krb5_rd_req(). Without this the name
canonicalisation support in 1.7 was broken for GSS_C_BOTH
credentials, because cred->name would always be set.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22973 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAllow the constrained delegation authorization method to use the evidence ticket...
Luke Howard [Wed, 21 Oct 2009 18:21:50 +0000 (18:21 +0000)]
Allow the constrained delegation authorization method to use the evidence ticket client name as input to the authorization decision

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22963 dc483132-0cff-0310-8789-dd5450dbe970

15 years agosimplify logic fix introduced in r22960 for S4U2Self
Luke Howard [Wed, 21 Oct 2009 17:24:37 +0000 (17:24 +0000)]
simplify logic fix introduced in r22960 for S4U2Self

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22962 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoremove some unneeded extensions from the Novell backend authdata SPI
Luke Howard [Wed, 21 Oct 2009 16:03:40 +0000 (16:03 +0000)]
remove some unneeded extensions from the Novell backend authdata SPI

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22961 dc483132-0cff-0310-8789-dd5450dbe970