Alexandra Ellwood [Fri, 31 Oct 2008 19:35:22 +0000 (19:35 +0000)]
No . at end of strings
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20944
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Fri, 31 Oct 2008 18:35:28 +0000 (18:35 +0000)]
Add a few safeties to the k5buf code, to make static analysis tools happier
ticket: 6200
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20943
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 31 Oct 2008 17:11:47 +0000 (17:11 +0000)]
Avoid duplicate identical dialogs in KIM
Added KIM_DUPLICATE_UI_REQUEST_ERR error so UI can indicate it cancelled
its dialog due to getting multiple identical dialogs at the same time.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20942
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Thu, 30 Oct 2008 19:32:50 +0000 (19:32 +0000)]
Use the k5buf module instead of strcpy/strcat in several places
ticket: 6200
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20941
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 29 Oct 2008 21:58:56 +0000 (21:58 +0000)]
KerberosAgent now saves successfully authenticated identities to favorites automatically when they were acquired through the Enter Identity dialog
ticket: 6222
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20940
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 29 Oct 2008 21:14:39 +0000 (21:14 +0000)]
Clear auth prompt on success or cancel. Leave change password fields filled in when password is incorrect, to save user from reentering new password
ticket: 6221
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20939
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 29 Oct 2008 21:07:40 +0000 (21:07 +0000)]
Removed unnecessary code that was resetting options whenever the
array changes in the background. The problem is that any external
change to the ticket list will cause this to happen, even when the
options dialog is open.
Also removed unused function resetOptions.
ticket: 6224
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20938
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 29 Oct 2008 20:39:47 +0000 (20:39 +0000)]
Only prompt automatically from GUI apps
Direct callers such as kinit need command line prompts.
Do not automatically prompt (via krb5 or gssapi calls)
unless the caller has loaded GUI libraries.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20937
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 29 Oct 2008 20:36:49 +0000 (20:36 +0000)]
Remove saved password if it fails to get tickets
Note that if preauth is turned on the password may be removed for
other reasons. This is because preauth failing can mean several
things. Better to always remove it than have the user sometimes
get stuck though.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20936
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 29 Oct 2008 19:36:06 +0000 (19:36 +0000)]
KerberosAgent hangs changing pw for passwordless identities
Trying to change the password for an identity which only uses non-password authentication methods left KerberosAgent with a spinning progress indicator. Problem was with auth sheet not being ended.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20935
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Tue, 28 Oct 2008 22:43:49 +0000 (22:43 +0000)]
Cleanup memory leaks in test program for dynamically allocated buffers..
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20934
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Tue, 28 Oct 2008 22:09:12 +0000 (22:09 +0000)]
Update the exports file for krb5int_buf_add_fmt
ticket: 6200
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20933
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Tue, 28 Oct 2008 22:03:35 +0000 (22:03 +0000)]
In the k5buf module, add a function to append formatted data to a
buffer.
ticket: 6200
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20932
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Tue, 28 Oct 2008 20:28:52 +0000 (20:28 +0000)]
The last change to plugins.c erroneously passes a size_t as a field
width to asprintf. Address the signed/unsigned warning cleanup using
a cast instead.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20931
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Tue, 28 Oct 2008 20:21:50 +0000 (20:21 +0000)]
Eliminate use of strcpy/strcat/sprintf in wconfig.c. Use memcpy since
we cannot rely on libkrb5support to give us the good stuff. Also fix
up (to some extent) an assumption that size_t == int.
ticket: 6200
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20930
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Tue, 28 Oct 2008 15:34:29 +0000 (15:34 +0000)]
Add the k5buf string module to libkrb5support
ticket: 6200
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20929
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Tue, 28 Oct 2008 13:37:47 +0000 (13:37 +0000)]
Unsigned/signed warnings cleanup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20928
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 27 Oct 2008 21:01:00 +0000 (21:01 +0000)]
localize format strings, not final error string
errors.c should localize the incoming format string, not
the string produced by vasprintf. The format string is
constant and thus can be added to a localization table,
whereas the output string is not.
Note that this change depends on error_message also
localizing error table strings (which it does for KfM
already).
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20927
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 27 Oct 2008 19:01:12 +0000 (19:01 +0000)]
Remove empty declaration of struct _krb5_kt_ops after the fully defined structure
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20926
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 27 Oct 2008 18:59:08 +0000 (18:59 +0000)]
signed vs. unsigned warnings cleanup
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20925
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Mon, 27 Oct 2008 18:58:07 +0000 (18:58 +0000)]
Remove kproplog on make clean
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20924
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 25 Oct 2008 07:03:11 +0000 (07:03 +0000)]
partial rewrite of the ASN.1 encoders
Instead of a pile of macros generating code, that have to be threaded
together in just the right way to get a valid ASN.1 encoding, we now
have a pile of macros for defining data structures describing the
objects and the ASN.1 types they should be encoded as, which
structures are interpreted by recursive invocations of an encoder
engine; there should be somewhat less rope for accidentally creating
invalid encodings. The new macros are commented in asn1_k_encode.c.
Putting most of the work into the encoder engine also reduces the code
size (in one configuration, including LDAP-KDB and PKINIT encoders,
code size went from 37K to <16K, though 10K of tables were added, and
the PKINIT encoders are still open-coded).
Some encoder interfaces have been revised to be more regular -- all
now take one pointer to const argument (no two-input encoders, no
pointer-to-non-const-pointer-to-const). A few encoders were
eliminated or disabled because they were neither used nor exported
from the library.
The LDAP-KDB encoder has been converted, but the PKINIT encoders have
not as there are no regression tests for them currently.
There is still plenty of room for improvement; some notes on specific
ideas have been added.
String encoding primitives have been combined to reduce code size. A
primitive for encoding bit strings has been added.
Some miscellaneous warnings in the decoders have been cleaned up.
A new dejagnu test case is added that ensures that KRB-SAFE messages
get exercised.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20923
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 25 Oct 2008 05:58:13 +0000 (05:58 +0000)]
More regression tests for ASN.1 encoders
Export encode_krb5_sam_response_2 and encode_krb5_enc_sam_response_enc_2
via accessor. Add encode tests for encode_krb5_sam_key,
_enc_sam_response_enc, _predicted_sam_response, _sam_response_2,
_enc_sam_response_enc_2.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20922
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 24 Oct 2008 20:54:12 +0000 (20:54 +0000)]
krb5_build_principal_ext walks off beginning of array
On error, krb5_build_principal_ext walks off the beginning of the
array by using i-- in a conditional when it should be using --i
(so that it actually compares the value of i that will be used
below).
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20920
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Fri, 24 Oct 2008 20:07:00 +0000 (20:07 +0000)]
Use strlcpy instead of strcpy in many places
ticket: 6200
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20919
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 24 Oct 2008 19:46:41 +0000 (19:46 +0000)]
krb5_build_principal_va does not allocate krb5_principal
krb5_build_principal_va does not allocate the outer krb5_principal,
making it useless for generating krb5_principals which can be freed
with krb5_free_principal. Added krb5_build_principal_alloc_va which
allocates the krb5_principal.
Added krb5int_build_principal_alloc_va which is used by KIM to avoid
code duplication. KIM's kim_identity_create_from_components takes
the first component as an argument because principals with no
components cannot be represented with the KIM UI. Modified KIM
to use this new API.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20918
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 24 Oct 2008 19:40:35 +0000 (19:40 +0000)]
Add test for kim_identity_create_from_components
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20917
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Fri, 24 Oct 2008 17:12:00 +0000 (17:12 +0000)]
Add build system support for strlcpy and strlcat on platforms which do
not provide it natively.
ticket: 6200
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20916
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Fri, 24 Oct 2008 16:22:59 +0000 (16:22 +0000)]
Amend svn:ignore properties to include more generated files
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20915
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 24 Oct 2008 00:58:38 +0000 (00:58 +0000)]
Use CFStringGetCStringPtr if possible to avoid wasting memory
since CFStringGetMaximumSizeForEncoding is wasteful for UTF8.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20914
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 24 Oct 2008 00:57:10 +0000 (00:57 +0000)]
Add support for localizing krb5 errors on Mac OS X.
Split into a separate function to make it easier to add
support for other localization techniques.
ticket: 6245
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20913
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Thu, 23 Oct 2008 19:59:05 +0000 (19:59 +0000)]
Use snprintf instead of strcpy/strcat in many places
ticket: 6200
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20912
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 23 Oct 2008 17:50:43 +0000 (17:50 +0000)]
Free global mach ports on library unload
ticket: 6248
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20911
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 22 Oct 2008 21:17:07 +0000 (21:17 +0000)]
Fix previous commit by adding "extern" to header declarations for
SPNEGO mechanism OID stuff. It was causing tentative definition
issues on the Mac. (where there are constraints about common-block
symbols)
ticket: 6015
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20910
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 22 Oct 2008 20:41:34 +0000 (20:41 +0000)]
KIM should only display error dialogs if it has displayed UI already
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20909
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 22 Oct 2008 20:40:29 +0000 (20:40 +0000)]
Remove ipc message sent on cc_context_release
IPC message was causing problems when called from thread fini function
(via krb5_stdcc_shutdown).
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20908
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 21 Oct 2008 21:56:10 +0000 (21:56 +0000)]
kim_identity_change_password_with_credential leaks krb5_creds
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20907
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 21 Oct 2008 21:54:51 +0000 (21:54 +0000)]
kim_os_library_get_caller_name leaks file path
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20906
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 21 Oct 2008 21:54:00 +0000 (21:54 +0000)]
kim_ccache_iterator_next leaks principal
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20905
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 21 Oct 2008 21:52:29 +0000 (21:52 +0000)]
kim_preferences should free old identity before overwriting
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20904
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 21 Oct 2008 21:50:52 +0000 (21:50 +0000)]
Free data in tests so leaks checking is easier
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20903
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 21 Oct 2008 21:05:27 +0000 (21:05 +0000)]
krb5_change_set_password should free chpw_rep contents
ticket: 6214
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20902
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Mon, 20 Oct 2008 21:14:47 +0000 (21:14 +0000)]
Use asprintf instead of malloc/strcpy/strcat in many places
ticket: 6200
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20901
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 20 Oct 2008 20:11:33 +0000 (20:11 +0000)]
Apply adapted patch from bugs.debian.org/480434 to recurse into
SPNEGO creds when attempting to retrieve a mechanism cred.
ticket: 5807
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20900
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 20 Oct 2008 19:39:52 +0000 (19:39 +0000)]
Apply (adapted) patch from Apple to check for SPNEGO mechanism in
export_lucid_sec_ctx.
ticket: 6015
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20899
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Mon, 20 Oct 2008 18:18:49 +0000 (18:18 +0000)]
Use strdup in place of malloc/strcpy in many places
ticket: 6200
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20898
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Sun, 19 Oct 2008 13:10:52 +0000 (13:10 +0000)]
Include k5-platform.h for SIZE_MAX
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20897
dc483132-0cff-0310-8789-
dd5450dbe970
Ezra Peisach [Sun, 19 Oct 2008 10:44:56 +0000 (10:44 +0000)]
In krb5_def_store_mkey(), mktemp was being invoked with a string WRFILE:....
This returns an error - as it actually tries to open the file.
Move some of the logic that points to the actual filename earlier - so
mktemp works on the .... portion.
Note that the netbsd linker gives a warning on using mktemp as it may be
insecure - but there is no obvious way to avoid it.
ticket: new
subhect: netbsd mktemp actually tries to open file
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20896
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Fri, 17 Oct 2008 22:08:12 +0000 (22:08 +0000)]
Make all dialogs beyond the change password sheet also appear as sheets
ticket:6145
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20894
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 17 Oct 2008 22:05:32 +0000 (22:05 +0000)]
Adapted patch from Apple to work around SAMBA mech OID quirks and to
disable sending request flags.
ticket: 6016
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20893
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Fri, 17 Oct 2008 19:41:02 +0000 (19:41 +0000)]
Stop using -[NSWindow setIgnoresMouseEvents:] and manage enabled state of each control individually with bindings
ticket:6198
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20890
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Fri, 17 Oct 2008 19:26:29 +0000 (19:26 +0000)]
KerberosAgent continues to ignore mouse events after error
Problem when trying to change password from behind a NAT. The ensuing error dialog ignores mouse events, making it impossible to dismiss.
ticket:new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20889
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 17 Oct 2008 18:50:19 +0000 (18:50 +0000)]
temporary testing code
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20888
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 17 Oct 2008 18:34:51 +0000 (18:34 +0000)]
KLCreatePrincipalFromTriplet should work with empty instance
Fixed bug where shim layer was calling kim_identity_create_from_components
incorrectly in this case.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20887
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 17 Oct 2008 18:15:25 +0000 (18:15 +0000)]
Added back KLL test programs
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20886
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 17 Oct 2008 18:13:47 +0000 (18:13 +0000)]
Double free and leak in kim_os_library_get_application_path
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20885
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 17 Oct 2008 17:07:03 +0000 (17:07 +0000)]
Remap some of the more confusing krb5 errors
Also enlarged last error buffer for UTF8 strings with multibyte chars.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20884
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 17 Oct 2008 17:05:31 +0000 (17:05 +0000)]
Treat unreadable terminal as user cancelled so regression tests work
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20883
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 17 Oct 2008 17:04:09 +0000 (17:04 +0000)]
Make sure identity is set when using kim prompter
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20882
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 17 Oct 2008 15:45:05 +0000 (15:45 +0000)]
Use a context to store error table info
Just sticking an einfo on the stack doesn't work because it's not
initialized. Also the detailed error message doesn't end up propogated back
to KIM.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20881
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Thu, 16 Oct 2008 21:41:38 +0000 (21:41 +0000)]
When change password is called from the Select Identity dialog, it appears as a sheet on that dialog instead of popping up as a separate window
ticket:6145
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20880
dc483132-0cff-0310-8789-
dd5450dbe970
Greg Hudson [Thu, 16 Oct 2008 17:21:06 +0000 (17:21 +0000)]
Fix tests/misc/Makefile.in to use KRB5_BASE_LIBS instead of KRB5_LIB,
making it consistent with other programs we build. KRB5_LIB by itself
may not find dependent libraries if they haven't been installed yet.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20879
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Thu, 16 Oct 2008 01:44:39 +0000 (01:44 +0000)]
Make it possible to make identities use default ticket options
- Made KerberosAgent compatible with KIM's way of passing about NULL to mean "Use default options"
- Added "Use default ticket options" checkbox to both ticket options dialogs.
- Hid ticket options of select identity dialog by default, visible via the "Show Options" "Hide Options" toggle.
ticket:6147
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20878
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 15 Oct 2008 22:45:10 +0000 (22:45 +0000)]
remove unused variable in kim_ui_cli_ask_change_password
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20877
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 15 Oct 2008 21:58:43 +0000 (21:58 +0000)]
Untabify. Normalize whitespace. Reindent. Fix some of the most
egregious formatting quirks. Add emacs mode settings to flag
untabified source files.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20876
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 15 Oct 2008 21:50:26 +0000 (21:50 +0000)]
use KIM_BUILTIN_UI instead of LEAN_CLIENT for builtin UI
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20875
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 15 Oct 2008 21:41:00 +0000 (21:41 +0000)]
Move GUI/CLI detection from KerberosIPC into KIM
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20874
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 15 Oct 2008 21:35:23 +0000 (21:35 +0000)]
Merge KerberosIPC into k5_mig support
Now that there are no servers using only kipc_* calls, merge
them into the k5_mig_* calls.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20873
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 15 Oct 2008 17:37:21 +0000 (17:37 +0000)]
handle stash file names with missing keytab type spec and colon in path
Currently the keytab name resolution code will pass off any name with
no colon to the default keytab type handler, which is the FILE
handler. It will also check for Windows file names consisting of one
letter followed by a colon, and treat them as FILE specs also.
If a UNIX pathname contains a colon, however, and no type was
explicitly specified, the leading part of the pathname gets treated as
a type name and fails to match anything. It should instead treat
type-less names starting with "/" as FILE specs also.
Tweak the test suite to use such a name.
Report and patch from Apple. rdar://problem/
6179239
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20872
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 15 Oct 2008 16:27:46 +0000 (16:27 +0000)]
Now that we have support for conditionally exporting symbols from the support
library, use that for the [v]asprintf replacement functions when needed.
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20871
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Wed, 15 Oct 2008 16:18:16 +0000 (16:18 +0000)]
makedepend
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20870
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Tue, 14 Oct 2008 19:49:27 +0000 (19:49 +0000)]
Pre-populate new clients with default client identity if that is set, as found by kim_preferences_get_client_identity()
ticket:6183
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20869
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Tue, 14 Oct 2008 19:48:06 +0000 (19:48 +0000)]
Don't wipe out previously entered information with each new call from clients
ticket: 6143
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20868
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 14 Oct 2008 16:54:04 +0000 (16:54 +0000)]
kim test suite reports error messages incorrectly
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20867
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 14 Oct 2008 16:52:39 +0000 (16:52 +0000)]
Free error message returned by krb5_get_error_message
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20866
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 21:58:26 +0000 (21:58 +0000)]
kim_os_string_create_localized leaks CFStringRef
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20865
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 20:55:47 +0000 (20:55 +0000)]
Test KIM plugin
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20864
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 20:55:24 +0000 (20:55 +0000)]
always zero out authentication strings
strings returned by the UI are usually passwords or pins
and should not get dripped all over memory.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20863
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 20:50:48 +0000 (20:50 +0000)]
kim_ui_plugin_fini sends pointer to context instead of context
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20862
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 20:50:07 +0000 (20:50 +0000)]
allow kim ui plugins to have any name
Note that there can still only be one, it will just use the
first one it finds. Just want to have different names for them
so that we can distinguish between different plugins.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20861
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Fri, 10 Oct 2008 20:47:05 +0000 (20:47 +0000)]
change password should always reprompt on error
Since it collects the password ahead of time, the prompt
count won't get incremented. Checking whether it
called auth_prompt is useless.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20860
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Fri, 10 Oct 2008 20:14:25 +0000 (20:14 +0000)]
PKINIT specs, draft 9 and final standard
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20859
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 21:22:29 +0000 (21:22 +0000)]
Missing keys in KerberosAgent Info.plist
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20856
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 19:15:27 +0000 (19:15 +0000)]
prefs should not create empty dictionary for KIM_OPTIONS_DEFAULT
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20855
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 17:51:03 +0000 (17:51 +0000)]
preferences should handle KIM_OPTIONS_DEFAULT
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20854
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 17:49:23 +0000 (17:49 +0000)]
kim_options_create sometimes returns KIM_OPTIONS_DEFAULT
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20853
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 02:35:38 +0000 (02:35 +0000)]
KL APIs which take a NULL principal return klParameterErr
Fixed by making kim_ccache_create_from_client_identity take KIM_IDENTITY_ANY
(at which point it returns the system default ccache).
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20850
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 02:11:51 +0000 (02:11 +0000)]
Crash in kim_credential_create_from_keytab
Was dereferencing NULL freeing creds.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20849
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Thu, 9 Oct 2008 01:05:08 +0000 (01:05 +0000)]
kim_options_copy should allow in_options to be KIM_OPTIONS_DEFAULT
(Don't error on NULL in_options)
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20848
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 8 Oct 2008 22:21:46 +0000 (22:21 +0000)]
KerberosAgent should log less
Remove auto-quit log message, "No active clients. Terminating."
ticket:new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20847
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 8 Oct 2008 22:20:48 +0000 (22:20 +0000)]
Removed unused header file include.
(Not necessary for fix, just a cleanup)
ticket: 6146
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20846
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 8 Oct 2008 22:14:27 +0000 (22:14 +0000)]
Ignore user interaction while busy. Done by toggling ignoresMouseEvents on auth dialogs
ticket:6144
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20845
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Wed, 8 Oct 2008 21:51:35 +0000 (21:51 +0000)]
KLL should use __attribute ((deprecated))
Switched from a macro to GCC deprecated attributes.
Also removed the deprecated struct used by KLSetApplicationOptions
and KLGetApplicationOptions because they weren't touching it.
Replaced pointer-to-struct arguments with void *.
KLGetApplicationOptions now also returns an error since it did
not modify its input. Not sure why it wasn't before since no one
should be calling it on Mac OS X.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20844
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Wed, 8 Oct 2008 02:01:06 +0000 (02:01 +0000)]
KerberosAgent should handle zoom button better
The Select Identity dialog should resize to fit the available identities in its table when the zoom button is clicked.
ticket: new
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20840
dc483132-0cff-0310-8789-
dd5450dbe970
Justin Anderson [Tue, 7 Oct 2008 21:55:01 +0000 (21:55 +0000)]
KerberosAgent fails to handle multiple clients because it attempts to message freed memory
ticket: new
status: open
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20839
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 7 Oct 2008 21:12:55 +0000 (21:12 +0000)]
KIM should remember options and identity if prefs indicate
Added code to remember ticket options if settings indicate it.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20838
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 7 Oct 2008 21:12:05 +0000 (21:12 +0000)]
KLL shim layer does not correctly handle options
KLGetDefaultLoginOption and KLSetDefaultLoginOption were
incorrectly casting parameters and were not parsing the
option argument correctly.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20837
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 7 Oct 2008 19:23:10 +0000 (19:23 +0000)]
If the caller is a bundle, look up keys in its plist file to get the name
ticket: 6146
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20836
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Tue, 7 Oct 2008 18:58:53 +0000 (18:58 +0000)]
KLLastChangedTime should return current time, not 0
cc_context_get_change_time returns 0 the first time it is called
if the CCacheServer is not running. KLLastChangedTime always
returned the current time on the first call. So use globals and
a mutex to make sure that KLLastChangedTime both monotonically
increases and also returns the current time on the first call.
ticket: new
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20835
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 6 Oct 2008 21:58:59 +0000 (21:58 +0000)]
Include header to get error table for KLL
ticket: 6154
git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20834
dc483132-0cff-0310-8789-
dd5450dbe970