krb5.git
15 years agoKDC realm referral test
Tom Yu [Mon, 13 Apr 2009 20:26:27 +0000 (20:26 +0000)]
KDC realm referral test

pull up r22040 from trunk

 KDC realm referral test

ticket: 6457
version_fixed: 1.7
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22204 dc483132-0cff-0310-8789-dd5450dbe970

15 years agofix memory management in handle_referral_params
Tom Yu [Mon, 13 Apr 2009 20:26:24 +0000 (20:26 +0000)]
fix memory management in handle_referral_params

pull up r22037 from trunk

 Fix in handle_referral_params

ticket: 6456
version_fixed: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22203 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r22038 from trunk
Tom Yu [Mon, 13 Apr 2009 20:26:22 +0000 (20:26 +0000)]
pull up r22038 from trunk

 ticket: 6398
 subject: remove obsolete GNU.ORG realm info
 target_version: 1.7
 tags: pullup

 Our sample krb5.conf has obsolete info on the GNU.ORG realm; the DNS
 entries named don't exist, and AFAIK this hasn't been accurate in
 years.  (I don't even know if they're currently running a Kerberos
 realm.)

ticket: 6398
version_fixed: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22202 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up 21993 from trunk
Tom Yu [Mon, 13 Apr 2009 20:26:18 +0000 (20:26 +0000)]
pull up 21993 from trunk

 Subject: Implement TGS authenticator subkey usage
 ticket: 6393
 tags: enhancement

 Implement support for use of a subkey in the TGS req.  This is needed
 by FAST TGS support.  The interface to krb5_send_tgs changed in order
 to gain a subkey output parameter.  Since this is a private interface
 it was renamed to krb5int_send_tgs and removed from the export list.

 * send_tgs.c: generate a subkey and return to caller
 * decode_kdc_rep.c: Use subkey keyusage
 * gc_via_tkt.c: pass in subkey to decode_kdc_rep
 * send_tgs.c: use subkey for encrypting authorization data

ticket: 6393
version_fixed: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22201 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r22084 from trunk
Tom Yu [Mon, 16 Mar 2009 17:58:53 +0000 (17:58 +0000)]
pull up r22084 from trunk

acc_ctx_new() can return an error condition without establishing a
SPNEGO context structure.  This can cause a null pointer dereference
in cleanup code in spnego_gss_accept_sec_context().

ticket: 6402
version_fixed: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22099 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix accidental omission in "major changes": incremental propagation.
Tom Yu [Wed, 25 Feb 2009 16:47:43 +0000 (16:47 +0000)]
Fix accidental omission in "major changes": incremental propagation.
Add some missing acknowledgments.

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22054 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21980 from trunk
Tom Yu [Thu, 19 Feb 2009 00:38:27 +0000 (00:38 +0000)]
pull up r21980 from trunk

 ------------------------------------------------------------------------
 r21980 | ghudson | 2009-02-12 12:51:45 -0500 (Thu, 12 Feb 2009) | 8 lines
 Changed paths:
    M /trunk/src/lib/krb5/krb/walk_rtree.c

 ticket: 6392
 subject: Fix allocation failure check in walk_rtree
 tags: pullup
 target_version: 1.7

 Check the correct variable for null after allocating the server string
 in rtree_capath_vals.

 ------------------------------------------------------------------------

ticket: 6392
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22036 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21968 from trunk
Tom Yu [Thu, 19 Feb 2009 00:38:17 +0000 (00:38 +0000)]
pull up r21968 from trunk

 ------------------------------------------------------------------------
 r21968 | epeisach | 2009-02-11 08:01:11 -0500 (Wed, 11 Feb 2009) | 9 lines
 Changed paths:
    M /trunk/src/aclocal.m4

 ticket: 6390
 subject: --disable-rpath is not working
 tags: pullup
 target_version: 1.7

 AC_ARG_ENABLE returns its value in enableval not withval.  --disable-rpath
 was not working - or dependent on some previous setting...

 ------------------------------------------------------------------------

ticket: 6390
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22035 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21924 from trunk
Tom Yu [Thu, 19 Feb 2009 00:38:09 +0000 (00:38 +0000)]
pull up r21924 from trunk

 ------------------------------------------------------------------------
 r21924 | ghudson | 2009-02-09 13:52:40 -0500 (Mon, 09 Feb 2009) | 10 lines
 Changed paths:
    M /trunk/src/lib/krb5/krb/walk_rtree.c

 ticket: 6379
 subject: Fix possible free of uninitialized value in walk_rtree
 tags: pullup
 target_version: 1.7

 In rtree_hier_realms, if the first rtree_hier_tweens call failed, the
 cleanup handler would free stweens which had not been initialized.
 Initialize ctweens and stweens to NULL in the variable declarations to
 make the cleanup handler safe.

 ------------------------------------------------------------------------

ticket: 6379
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22034 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21923 from trunk
Tom Yu [Thu, 19 Feb 2009 00:37:45 +0000 (00:37 +0000)]
pull up r21923 from trunk

 ------------------------------------------------------------------------
 r21923 | ghudson | 2009-02-09 13:35:19 -0500 (Mon, 09 Feb 2009) | 9 lines
 Changed paths:
    M /trunk/src/include/k5-unicode.h
    M /trunk/src/lib/krb5/error_tables/krb5_err.et
    M /trunk/src/lib/krb5/unicode/ucstr.c

 ticket: 6378
 subject: Change contract of krb5int_utf8_normalize and fix memory leaks
 tags: pullup
 target_version: 1.7

 Make krb5int_utf8_normalize return a krb5_error_code and always allocate
 a structure to be placed in the output parameter.  Adjust the function
 structure to use a cleanup handler, fixing many memory leaks.

 ------------------------------------------------------------------------

ticket: 6378
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22033 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21920, r21922, r21926 from trunk
Tom Yu [Thu, 19 Feb 2009 00:37:16 +0000 (00:37 +0000)]
pull up r21920, r21922, r21926 from trunk

 ------------------------------------------------------------------------
 r21926 | raeburn | 2009-02-09 15:39:54 -0500 (Mon, 09 Feb 2009) | 7 lines
 Changed paths:
    M /trunk/src/lib/krb5/krb/kfree.c

 ticket: 6377

 Fix one more case of an explicit null check before calling a free
 function that does the null check.

 Also, use krb5_free_keyblock_contents instead of open-coding all the
 work (and not trying hard enough to clear the memory).
 ------------------------------------------------------------------------
 r21922 | raeburn | 2009-02-09 13:13:08 -0500 (Mon, 09 Feb 2009) | 3 lines
 Changed paths:
    M /trunk/src/lib/krb5/os/free_krbhs.c

 ticket: 6377

 Provide omitted return value in last change.
 ------------------------------------------------------------------------
 r21920 | raeburn | 2009-02-09 12:53:21 -0500 (Mon, 09 Feb 2009) | 8 lines
 Changed paths:
    M /trunk/src/lib/krb5/krb/free_rtree.c
    M /trunk/src/lib/krb5/krb/init_ctx.c
    M /trunk/src/lib/krb5/krb/kfree.c
    M /trunk/src/lib/krb5/krb/preauth2.c
    M /trunk/src/lib/krb5/os/free_krbhs.c
    M /trunk/src/lib/krb5/os/promptusr.c

 ticket: 6377
 subject: make krb5_free_* functions ignore NULL

 This makes them safer to call in various contexts where NULL may leak
 through, and makes analysis easier.

 Also, remove some checks for NULL before calling a free routine that
 will also check for NULL.
 ------------------------------------------------------------------------

ticket: 6377
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22032 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21912 from trunk
Tom Yu [Thu, 19 Feb 2009 00:37:02 +0000 (00:37 +0000)]
pull up r21912 from trunk

 ------------------------------------------------------------------------
 r21912 | ghudson | 2009-02-06 15:43:44 -0500 (Fri, 06 Feb 2009) | 10 lines
 Changed paths:
    M /trunk/src/lib/krb5/krb/walk_rtree.c

 ticket: 6376
 subject: Memory handling fixes in walk_rtree
 tags: pullup
 target_version: 1.7

 In walk_rtree's rtree_hier_tree, don't leak the result of
 rtree_hier_realms.  In rtree_hier_realms, avoid freeing one too many
 krb5_data contents on allocation failure, and use the recommend
 pattern to ensure well-defined output parameter values.

 ------------------------------------------------------------------------

ticket: 6376
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22031 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21909 from trunk
Tom Yu [Thu, 19 Feb 2009 00:36:51 +0000 (00:36 +0000)]
pull up r21909 from trunk

 ------------------------------------------------------------------------
 r21909 | ghudson | 2009-02-06 13:40:04 -0500 (Fri, 06 Feb 2009) | 9 lines
 Changed paths:
    M /trunk/src/lib/krb5/krb/walk_rtree.c

 ticket: 6375
 subject: Fix error handling in krb5_walk_realm_tree
 tags: pullup
 target_version: 1.7

 rtree_hier_realms was forgetting to assign the return value of
 krb5int_copy_data_contents to retval, which would cause a failure to
 notice out-of-memory conditions.

 ------------------------------------------------------------------------

ticket: 6375
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22030 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21906 from trunk
Tom Yu [Thu, 19 Feb 2009 00:36:31 +0000 (00:36 +0000)]
pull up r21906 from trunk

 ------------------------------------------------------------------------
 r21906 | epeisach | 2009-02-06 00:22:34 -0500 (Fri, 06 Feb 2009) | 12 lines
 Changed paths:
    M /trunk/src/lib/kadm5/kadm_rpc_xdr.c

 ticket: 6374
 subject: Do not assume sizeof(bool_t) == sizeof(krb5_boolean)

 bool_t is defined as int, krb5_boolean as unsigned int.  These are
 similar size but someone someday might change the krb5_boolean.
 Instead of passing a krb5_boolean * to xdr_bool, implement xdr_krb5_boolean
 which keeps the different types separate.

 This cleans up a number of warnings.

 ------------------------------------------------------------------------

ticket: 6374
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22029 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21903 from trunk
Tom Yu [Thu, 19 Feb 2009 00:36:22 +0000 (00:36 +0000)]
pull up r21903 from trunk

 ------------------------------------------------------------------------
 r21903 | raeburn | 2009-02-05 20:07:32 -0500 (Thu, 05 Feb 2009) | 7 lines
 Changed paths:
    M /trunk/src/lib/gssapi/krb5/krb5_gss_glue.c

 ticket: 6373
 subject: remove some redundant or useless qualifiers
 target_version: 1.7
 tags: pullup

 Remove some redundant qualifiers specified redundantly multiple times more than once in variable declarations.
 Also remove some useless qualifiers in casts and function argument declarations.
 ------------------------------------------------------------------------

ticket: 6373
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22028 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21901 from trunk
Tom Yu [Thu, 19 Feb 2009 00:36:07 +0000 (00:36 +0000)]
pull up r21901 from trunk

 ------------------------------------------------------------------------
 r21901 | ghudson | 2009-02-05 16:27:54 -0500 (Thu, 05 Feb 2009) | 8 lines
 Changed paths:
    M /trunk/src/lib/krb5/krb/mk_req_ext.c

 ticket: 6372
 subject: Fix memory handling bug in mk_req_ext
 tags: pullup
 target_version: 1.7

 In make_etype_list, assign *authdata before we have a chance to fail,
 since we may have invalidated the previous value with realloc.

 ------------------------------------------------------------------------

ticket: 6372
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22027 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21900 from trunk
Tom Yu [Thu, 19 Feb 2009 00:35:56 +0000 (00:35 +0000)]
pull up r21900 from trunk

 ------------------------------------------------------------------------
 r21900 | wfiveash | 2009-02-05 15:57:09 -0500 (Thu, 05 Feb 2009) | 10 lines
 Changed paths:
    M /trunk/src/kadmin/dbutil/kdb5_mkey.c
    M /trunk/src/lib/kdb/kdb5.c
    M /trunk/src/lib/kdb/kdb_default.c

 ticket: 6371
 subject: deal with memleaks in migrate mkey project
 Version_Reported: 1.7
 Target_Version: 1.7
 Tags: pullup

 Ken R. told me that Coverity found several potential memleaks introduced
 by the mkey migration project.  This addresses those leaks and tweaks
 the code formatting in a few places.

 ------------------------------------------------------------------------

ticket: 6371
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22026 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21899 from trunk
Tom Yu [Thu, 19 Feb 2009 00:35:36 +0000 (00:35 +0000)]
pull up r21899 from trunk

 ------------------------------------------------------------------------
 r21899 | ghudson | 2009-02-05 15:07:45 -0500 (Thu, 05 Feb 2009) | 3 lines
 Changed paths:
    M /trunk/src/lib/krb5/krb/gc_frm_kdc.c

 In gc_frm_kdc.c's do_traversal(), fix an assert which was doing an
 assignment instead of a compare.

 ------------------------------------------------------------------------

ticket: 6370
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22025 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21895 from trunk
Tom Yu [Wed, 18 Feb 2009 18:19:18 +0000 (18:19 +0000)]
pull up r21895 from trunk

 ------------------------------------------------------------------------
 r21895 | epeisach | 2009-02-05 14:02:29 -0500 (Thu, 05 Feb 2009) | 7 lines
 Changed paths:
    M /trunk/src/lib/rpc/unit-test/config/unix.exp
    M /trunk/src/lib/rpc/unit-test/rpc_test.0/expire.exp
    M /trunk/src/lib/rpc/unit-test/rpc_test.0/fullrun.exp
    M /trunk/src/lib/rpc/unit-test/rpc_test.0/gsserr.exp

 ticket: 6349

 Detect failure to register with rpcbind/portmap due to security
 restrictons and not bomb out in tests.

 ------------------------------------------------------------------------

ticket: 6349
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22022 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21894 from trunk
Tom Yu [Wed, 18 Feb 2009 18:19:10 +0000 (18:19 +0000)]
pull up r21894 from trunk

 ------------------------------------------------------------------------
 r21894 | ghudson | 2009-02-05 13:43:08 -0500 (Thu, 05 Feb 2009) | 7 lines
 Changed paths:
    M /trunk/src/lib/krb5/krb/chpw.c

 ticket: 6368
 tags: pullup
 target_version: 1.7

 Add a missing break in the switch statement of
 krb5int_setpw_result_code_string.

 ------------------------------------------------------------------------

ticket: 6368
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22021 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21890 from trunk
Tom Yu [Wed, 18 Feb 2009 18:18:56 +0000 (18:18 +0000)]
pull up r21890 from trunk

 ------------------------------------------------------------------------
 r21890 | ghudson | 2009-02-05 13:19:23 -0500 (Thu, 05 Feb 2009) | 7 lines
 Changed paths:
    M /trunk/src/lib/krb5/keytab/ktbase.c

 ticket: 6367
 tags: pullup
 target_version: 1.7

 Fix a memory leak in krb5_kt_resolve when we fail to lock
 kt_typehead_lock.

 ------------------------------------------------------------------------

ticket: 6367
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22020 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21889 from trunk
Tom Yu [Wed, 18 Feb 2009 18:18:28 +0000 (18:18 +0000)]
pull up r21889 from trunk

 ------------------------------------------------------------------------
 r21889 | raeburn | 2009-02-04 21:59:08 -0500 (Wed, 04 Feb 2009) | 7 lines
 Changed paths:
    M /trunk/src/kadmin/server/kadm_rpc_svc.c
    M /trunk/src/lib/kadm5/chpass_util.c
    M /trunk/src/plugins/kdb/db2/pol_xdr.c

 ticket: 6365
 subject: include omitted system header string.h
 target_version: 1.7
 tags: pullup

 Sun cc warns about some of the string functions being undeclared in
 several source files.  So, include string.h there.
 ------------------------------------------------------------------------

ticket: 6365
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22019 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21888 from trunk
Tom Yu [Wed, 18 Feb 2009 18:18:21 +0000 (18:18 +0000)]
pull up r21888 from trunk

 ------------------------------------------------------------------------
 r21888 | raeburn | 2009-02-04 21:16:22 -0500 (Wed, 04 Feb 2009) | 11 lines
 Changed paths:
    M /trunk/src/include/k5-platform.h

 ticket: 6364
 subject: declare replacement [v]asprintf functions
 target_version: 1.7
 tags: pullup

 If HAVE_VASPRINTF is not defined, make sure krb5int_{,v}asprintf
 functions always get declared, applying the preprocessor conditional
 test only to the GCC format attribute.  If HAVE_VASPRINTF is defined,
 don't declare them at all.

 This fixes a bunch of function-not-declared warnings under Sun cc.
 ------------------------------------------------------------------------

ticket: 6364
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22018 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21887 from trunk
Tom Yu [Wed, 18 Feb 2009 18:18:14 +0000 (18:18 +0000)]
pull up r21887 from trunk

 ------------------------------------------------------------------------
 r21887 | raeburn | 2009-02-04 20:49:21 -0500 (Wed, 04 Feb 2009) | 8 lines
 Changed paths:
    M /trunk/src/aclocal.m4
    M /trunk/src/lib/gssapi/krb5/k5seal.c

 ticket: 6363
 subject: int/ptr bug in gssapi code
 target_version: 1.7
 tags: pullup

 Fix a pointer argument passed where an integer is needed.
 Update Sun compiler options to make that an error.  (The options we're
 currently using make it an error for assignment but not for argument passing.)
 ------------------------------------------------------------------------

ticket: 6363
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22017 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21886 from trunk
Tom Yu [Wed, 18 Feb 2009 18:17:54 +0000 (18:17 +0000)]
pull up r21886 from trunk
 ------------------------------------------------------------------------
 r21886 | raeburn | 2009-02-04 18:28:09 -0500 (Wed, 04 Feb 2009) | 5 lines
 Changed paths:
    M /trunk/src/aclocal.m4
    M /trunk/src/lib/gssapi/generic/oid_ops.c

 ticket: 6362
 subject: don't do arithmetic on void pointers

 Fix one file in gssapi where we compute offsets from a void* without casting.
 Change options used with Sun compiler to make such expressions an error.
 ------------------------------------------------------------------------

ticket: 6362
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22016 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21884 from trunk
Tom Yu [Wed, 18 Feb 2009 18:17:47 +0000 (18:17 +0000)]
pull up r21884 from trunk

 ------------------------------------------------------------------------
 r21884 | wfiveash | 2009-02-04 17:29:44 -0500 (Wed, 04 Feb 2009) | 7 lines
 Changed paths:
    M /trunk/src/kadmin/dbutil/kdb5_mkey.c
    M /trunk/src/lib/kdb/kdb5.c

 ticket: 6361

 new multi-masterkey support doesn't work well when system clock is set
 back

 The ticket contains the details.

 ------------------------------------------------------------------------

ticket: 6361
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22015 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21881 from trunk
Tom Yu [Wed, 18 Feb 2009 18:17:40 +0000 (18:17 +0000)]
pull up r21881 from trunk

 ------------------------------------------------------------------------
 r21881 | ghudson | 2009-02-04 14:25:51 -0500 (Wed, 04 Feb 2009) | 7 lines
 Changed paths:
    M /trunk/src/util/support/utf8_conv.c

 ticket: 6360
 tags: pullup
 target_version: 1.7

 In krb5int_utf8s_to_ucs2les, free the correct value on error, instead
 of the caller-supplied result pointer.

 ------------------------------------------------------------------------

ticket: 6360
status: resolved
version_fixed: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22014 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21871, r21872, r21873, r21879, r21880 from trunk
Tom Yu [Wed, 18 Feb 2009 18:14:48 +0000 (18:14 +0000)]
pull up r21871, r21872, r21873, r21879, r21880 from trunk

 ------------------------------------------------------------------------
 r21880 | ghudson | 2009-02-04 14:15:13 -0500 (Wed, 04 Feb 2009) | 3 lines
 Changed paths:
    M /trunk/src/plugins/preauth/pkinit/pkinit_clnt.c
    M /trunk/src/plugins/preauth/pkinit/pkinit_matching.c
    M /trunk/src/plugins/preauth/pkinit/pkinit_srv.c

 Include k5-int.h in several pkinit source files, in order to define
 the KRB5_CONFIG symbols now used by those files.

 ------------------------------------------------------------------------
 r21879 | tsitkova | 2009-02-04 12:08:44 -0500 (Wed, 04 Feb 2009) | 2 lines
 Changed paths:
    M /trunk/src/include/k5-int.h
    M /trunk/src/kdc/do_tgs_req.c
    M /trunk/src/kdc/main.c
    M /trunk/src/lib/kadm5/alt_prof.c
    M /trunk/src/lib/kdb/kdb5.c
    M /trunk/src/lib/krb5/krb/conv_princ.c
    M /trunk/src/lib/krb5/krb/get_in_tkt.c
    M /trunk/src/lib/krb5/krb/init_ctx.c
    M /trunk/src/lib/krb5/krb/vfy_increds.c
    M /trunk/src/lib/krb5/os/an_to_ln.c
    M /trunk/src/lib/krb5/os/def_realm.c
    M /trunk/src/lib/krb5/os/get_krbhst.c
    M /trunk/src/lib/krb5/os/hst_realm.c
    M /trunk/src/lib/krb5/os/ktdefname.c
    M /trunk/src/lib/krb5/os/localaddr.c
    M /trunk/src/lib/krb5/os/locate_kdc.c
    M /trunk/src/lib/krb5/os/realm_dom.c
    M /trunk/src/lib/krb5/os/sendto_kdc.c
    M /trunk/src/lib/krb5/os/sn2princ.c
    M /trunk/src/plugins/kdb/ldap/libkdb_ldap/ldap_misc.c
    M /trunk/src/plugins/preauth/pkinit/pkinit_clnt.c
    M /trunk/src/plugins/preauth/pkinit/pkinit_matching.c
    M /trunk/src/plugins/preauth/pkinit/pkinit_profile.c
    M /trunk/src/plugins/preauth/pkinit/pkinit_srv.c

 Use macros for config parameters.

 ------------------------------------------------------------------------
 r21873 | ghudson | 2009-02-02 16:55:13 -0500 (Mon, 02 Feb 2009) | 3 lines
 Changed paths:
    M /trunk/src/include/k5-int.h

 Fix a whitespace error introduced when fixing a typo in the defines
 added to k5-int.h.

 ------------------------------------------------------------------------
 r21872 | ghudson | 2009-02-02 16:53:16 -0500 (Mon, 02 Feb 2009) | 2 lines
 Changed paths:
    M /trunk/src/include/k5-int.h

 Fix a typo in the defines added to k5-int.h.

 ------------------------------------------------------------------------
 r21871 | tsitkova | 2009-02-02 16:34:19 -0500 (Mon, 02 Feb 2009) | 2 lines
 Changed paths:
    M /trunk/src/include/k5-int.h

 Introduces macros for config parameters.

 ------------------------------------------------------------------------

ticket: 6397
status: resolved
version_fixed: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22013 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21867, r21868 from trunk
Tom Yu [Tue, 17 Feb 2009 16:11:49 +0000 (16:11 +0000)]
pull up r21867, r21868 from trunk

 ------------------------------------------------------------------------
 r21868 | raeburn | 2009-02-02 15:37:41 -0500 (Mon, 02 Feb 2009) | 6 lines
 Changed paths:
    M /trunk/src/kadmin/passwd/unit-test/kpasswd.0/changing.exp
    M /trunk/src/kadmin/testing/scripts/init_db

 ticket: 6358

 Revise last change to better resemble the original test, keeping the
 min-lifetime test code collected together.  Change policy to have a
 minimum password lifetime of 10s instead of 30s, and reduce the test
 delays accordingly.
 ------------------------------------------------------------------------
 r21867 | raeburn | 2009-02-02 14:29:52 -0500 (Mon, 02 Feb 2009) | 10 lines
 Changed paths:
    M /trunk/src/kadmin/passwd/unit-test/kpasswd.0/changing.exp

 ticket: 6358
 subject: speed up kpasswd tests

 Reorder some tests and tune delays, so that we don't need to run for
 much more than twice the min-password-life interval when testing that
 functionality.  (This could be made faster if we can assume that
 init_db will always have been run immediately before the tests start.)

 In my tests, this cuts something like 11 seconds off the run time (now
 down to about 65 seconds).
 ------------------------------------------------------------------------

ticket: 6358
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22009 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21865, r21866 from trunk
Tom Yu [Tue, 17 Feb 2009 16:10:53 +0000 (16:10 +0000)]
pull up r21865, r21866 from trunk

 ------------------------------------------------------------------------
 r21866 | raeburn | 2009-02-02 13:42:06 -0500 (Mon, 02 Feb 2009) | 8 lines
 Changed paths:
    M /trunk/src/lib/kadm5/unit-test/api.0/mod-principal.exp
    M /trunk/src/lib/kadm5/unit-test/api.2/mod-principal.exp

 ticket: 6357
 subject: address lib/kadm5 test suite slowness
 target_version: 1.7

 In mod-principal tests for clearing the principal's policy, instead of
 just testing to see if the wrong string is output and timing out
 looking for it, check also for the new expected value.  Cuts test
 suite run time by about two minutes for each pass (client vs server).
 ------------------------------------------------------------------------
 r21865 | raeburn | 2009-02-02 13:29:28 -0500 (Mon, 02 Feb 2009) | 1 line
 Changed paths:
    M /trunk/src/kadmin/testing/scripts/start_servers_local

 don't delay so long while waiting for daemon startup
 ------------------------------------------------------------------------

ticket: 6357
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22008 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21860 from trunk
Tom Yu [Tue, 17 Feb 2009 16:10:21 +0000 (16:10 +0000)]
pull up r21860 from trunk

 ------------------------------------------------------------------------
 r21860 | raeburn | 2009-02-02 11:54:38 -0500 (Mon, 02 Feb 2009) | 7 lines
 Changed paths:
    M /trunk/src/kdc/main.c

 ticket: 6356
 subject: small storage leak in KDC startup
 target_version: 1.7
 tags: pullup

 Remove duplicate strdup call.

 ------------------------------------------------------------------------

ticket: 6356
version_fixed: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22007 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull up r21855 from trunk
Tom Yu [Tue, 17 Feb 2009 16:10:11 +0000 (16:10 +0000)]
pull up r21855 from trunk

 ------------------------------------------------------------------------
 r21855 | raeburn | 2009-01-30 23:39:34 -0500 (Fri, 30 Jan 2009) | 28 lines
 Changed paths:
    M /trunk/src/tests/dejagnu/krb-standalone/rcp.exp
    M /trunk/src/tests/dejagnu/krb-standalone/rsh.exp
    M /trunk/src/tests/dejagnu/krb-standalone/sample.exp
    M /trunk/src/tests/dejagnu/t_inetd.c

 ticket: 6355
 subject: use t_inetd with a ready message and avoid waiting a lot in non-root tests
 target_version: 1.7
 tags: pullup

 Change t_inetd to print a ready message when it has started listening
 on the indicated port number.

 Look for this message in sample.exp rather than waiting an arbitrary
 (and usually excessive) 2s each time for the inetd-mode tests.  Use
 run_once to perform the standalone-mode test only once per test suite
 invocation.

 Change rsh and rcp tests to start the servers via t_inetd and avoid
 excessive waiting at startup.

 In some of my tests, this reduces the tests/dejagnu tests from taking
 over 6 minutes to taking around 2 minutes.

 (This does mean the server process will no longer have started up
 before we launch the client, so it may be slower to respond, but it'll
 still be faster than the 2s delay we used before even trying to
 connect.)

 We can probably eliminate the -D option code from krshd.c now.

 The tests run as root (rlogin, telnet) still need updating.

 ------------------------------------------------------------------------

ticket: 6355
version_fixed: 1.7
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22006 dc483132-0cff-0310-8789-dd5450dbe970

15 years agokrb5-1.7-alpha1-postrelease
Tom Yu [Sun, 1 Feb 2009 03:39:10 +0000 (03:39 +0000)]
krb5-1.7-alpha1-postrelease

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@21859 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopatchlevel.h for krb5-1.7-alpha1
Tom Yu [Sun, 1 Feb 2009 03:37:41 +0000 (03:37 +0000)]
patchlevel.h for krb5-1.7-alpha1

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@21857 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUpdate README with changes by ticket ID
Tom Yu [Sun, 1 Feb 2009 03:05:56 +0000 (03:05 +0000)]
Update README with changes by ticket ID

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@21856 dc483132-0cff-0310-8789-dd5450dbe970

15 years agorelease branch for krb5-1.7
Tom Yu [Sat, 31 Jan 2009 04:03:11 +0000 (04:03 +0000)]
release branch for krb5-1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@21853 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoREADME and patchlevel.h for 1.7 release branch
Tom Yu [Sat, 31 Jan 2009 04:00:10 +0000 (04:00 +0000)]
README and patchlevel.h for 1.7 release branch

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21852 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDefault allow_weak_crypto=true for now. Default supported_enctypes to
Tom Yu [Sat, 31 Jan 2009 03:57:20 +0000 (03:57 +0000)]
Default allow_weak_crypto=true for now.  Default supported_enctypes to
exclude single-DES enctypes.

ticket: 6353
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21851 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoexport new functions
Ken Raeburn [Sat, 31 Jan 2009 02:55:25 +0000 (02:55 +0000)]
export new functions

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21850 dc483132-0cff-0310-8789-dd5450dbe970

15 years agofix resource leak
Ken Raeburn [Sat, 31 Jan 2009 01:50:37 +0000 (01:50 +0000)]
fix resource leak

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21849 dc483132-0cff-0310-8789-dd5450dbe970

15 years agorecode as more straight-line code to simplify analysis
Ken Raeburn [Sat, 31 Jan 2009 01:07:04 +0000 (01:07 +0000)]
recode as more straight-line code to simplify analysis

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21848 dc483132-0cff-0310-8789-dd5450dbe970

15 years agodon't use uninitialized variable
Ken Raeburn [Sat, 31 Jan 2009 00:54:33 +0000 (00:54 +0000)]
don't use uninitialized variable

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21847 dc483132-0cff-0310-8789-dd5450dbe970

15 years agohandle freeing null keyblock
Ken Raeburn [Sat, 31 Jan 2009 00:49:53 +0000 (00:49 +0000)]
handle freeing null keyblock

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21846 dc483132-0cff-0310-8789-dd5450dbe970

15 years agodon't double-free
Ken Raeburn [Sat, 31 Jan 2009 00:39:51 +0000 (00:39 +0000)]
don't double-free

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21845 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMaster Key Migration Project
Will Fiveash [Fri, 30 Jan 2009 23:55:14 +0000 (23:55 +0000)]
Master Key Migration Project

Commit for the Master Key Migration Project.
http://k5wiki.kerberos.org/wiki/Projects/Master_Key_Migration

This commit provides the ability to add a new master key (with an
enctype differing from the current master key) to the master key
principal and stash file and then migrate the encryption of existing
principals long term keys to use the new master key.  In addition
deletion of master keys is provided.

ticket: 6354

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21844 dc483132-0cff-0310-8789-dd5450dbe970

15 years agokrb5_get_server_rcache had some dead (and incorrect) code for cleaning
Greg Hudson [Fri, 30 Jan 2009 21:25:40 +0000 (21:25 +0000)]
krb5_get_server_rcache had some dead (and incorrect) code for cleaning
up the rcache on failure.  Fix the cleanup code and make use of it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21842 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMake output parameter value of krb5_rc_resolve_full well-defined on
Greg Hudson [Fri, 30 Jan 2009 21:22:31 +0000 (21:22 +0000)]
Make output parameter value of krb5_rc_resolve_full well-defined on
error return.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21841 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5_kdcrep2creds, call the correct free function when cleaning up
Greg Hudson [Fri, 30 Jan 2009 21:21:10 +0000 (21:21 +0000)]
In krb5_kdcrep2creds, call the correct free function when cleaning up
the keyblock, and clean up the keyblock if krb5_copy_data fails.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21840 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoChanged the name match_config_pattern to krb5_match_config_pattern. Check strdup...
Zhanna Tsitkov [Fri, 30 Jan 2009 20:40:46 +0000 (20:40 +0000)]
Changed the name match_config_pattern to krb5_match_config_pattern. Check strdup return code.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21838 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIntroduced match_config_pattern function to find a pattern in the config value strings
Zhanna Tsitkov [Thu, 29 Jan 2009 19:23:22 +0000 (19:23 +0000)]
Introduced match_config_pattern function to find a pattern in the config value strings

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21828 dc483132-0cff-0310-8789-dd5450dbe970

15 years agowhitespace
Ken Raeburn [Thu, 29 Jan 2009 01:19:01 +0000 (01:19 +0000)]
whitespace

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21826 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoclear outbuf[0].data to unconfuse coverity
Ken Raeburn [Thu, 29 Jan 2009 01:12:17 +0000 (01:12 +0000)]
clear outbuf[0].data to unconfuse coverity

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21825 dc483132-0cff-0310-8789-dd5450dbe970

15 years agodisable single-DES by default
Tom Yu [Wed, 28 Jan 2009 23:22:27 +0000 (23:22 +0000)]
disable single-DES by default

Mark all single-DES enctypes as "weak", and create a new libdefaults
variable "allow_weak_crypto", which defaults to "false".

ticket: 6353
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21823 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoinclude netinet/in.h to make sure we know what struct in_addr looks like
Ken Raeburn [Wed, 28 Jan 2009 17:01:36 +0000 (17:01 +0000)]
include netinet/in.h to make sure we know what struct in_addr looks like

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21820 dc483132-0cff-0310-8789-dd5450dbe970

15 years agono more -r option for setting krb.conf path
Ken Raeburn [Wed, 28 Jan 2009 05:42:11 +0000 (05:42 +0000)]
no more -r option for setting krb.conf path

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21819 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoremove some remnants of krb4-related config file options
Ken Raeburn [Wed, 28 Jan 2009 05:37:10 +0000 (05:37 +0000)]
remove some remnants of krb4-related config file options

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21818 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoreturn correct kvno in TGS case
Sam Hartman [Wed, 28 Jan 2009 01:28:25 +0000 (01:28 +0000)]
return correct kvno in TGS case

krb5_c_encrypt sets the kvno of ciphertext to 0.
So fill it in after the call to encrypt_tkt_part.

ticket: 6352

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21815 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRun a single expect statement to read from both client and server, to
Tom Yu [Wed, 28 Jan 2009 00:32:29 +0000 (00:32 +0000)]
Run a single expect statement to read from both client and server, to
avoid an apparent race condition on Darwin.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21814 dc483132-0cff-0310-8789-dd5450dbe970

15 years agowhitespace
Ken Raeburn [Wed, 28 Jan 2009 00:30:06 +0000 (00:30 +0000)]
whitespace

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21813 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoStart to phase out krb5_xfree macro, which just casts its argument to
Ken Raeburn [Wed, 28 Jan 2009 00:04:15 +0000 (00:04 +0000)]
Start to phase out krb5_xfree macro, which just casts its argument to
char* and calls free.

Replace most uses, outside of the LDAP KDB plugin, which doesn't build
on my test system of the moment because of version dependencies.  Add
one explicit cast to make the change warning-neutral (under gcc 4.0.1
on Mac OS X 10.5.6).

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21812 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoHelper script for processing valgrind logs that don't indicate any errors, or are...
Ken Raeburn [Tue, 27 Jan 2009 23:14:35 +0000 (23:14 +0000)]
Helper script for processing valgrind logs that don't indicate any errors, or are for system programs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21810 dc483132-0cff-0310-8789-dd5450dbe970

15 years agouse memchr
Ken Raeburn [Tue, 27 Jan 2009 22:00:15 +0000 (22:00 +0000)]
use memchr

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21809 dc483132-0cff-0310-8789-dd5450dbe970

15 years ago"Coding practices" related fixes
Zhanna Tsitkov [Tue, 27 Jan 2009 21:09:35 +0000 (21:09 +0000)]
"Coding practices" related fixes

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21808 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn asn1_decode_pa_for_user(), ensure that user member is allocated
Luke Howard [Mon, 26 Jan 2009 22:50:02 +0000 (22:50 +0000)]
In asn1_decode_pa_for_user(), ensure that user member is allocated
before assigning a value to it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21805 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIntroduced new static function prep_reprocess_req to make code more readable
Zhanna Tsitkov [Mon, 26 Jan 2009 21:26:33 +0000 (21:26 +0000)]
Introduced new static function prep_reprocess_req to make code more readable

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21801 dc483132-0cff-0310-8789-dd5450dbe970

15 years agogss_header|trailerlen should be unsigned int
Sam Hartman [Mon, 26 Jan 2009 20:02:54 +0000 (20:02 +0000)]
gss_header|trailerlen should be unsigned int

The krb5_c_crypto_length API returns unsigned int per its design.
so, use unsigned int not size_t for its output.

ticket: 6351

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21799 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPreliminary update of README for krb5-1.7 release
Tom Yu [Mon, 26 Jan 2009 19:47:57 +0000 (19:47 +0000)]
Preliminary update of README for krb5-1.7 release

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21798 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUse 16/32-bit big/little-endian store functions in more places
Ken Raeburn [Mon, 26 Jan 2009 19:06:21 +0000 (19:06 +0000)]
Use 16/32-bit big/little-endian store functions in more places

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21796 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCheck asprintf return codes. Styling
Zhanna Tsitkov [Mon, 26 Jan 2009 16:20:41 +0000 (16:20 +0000)]
Check asprintf return codes. Styling

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21795 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUse a struct in_addr to insure alignment of address - instead of
Ezra Peisach [Sun, 25 Jan 2009 16:44:02 +0000 (16:44 +0000)]
Use a struct in_addr to insure alignment of address - instead of
random alignment on the stack. Solaris 2.10 has issues if the address
is not aligned.  The rest of the code in the tree uses a struct
in_addr or mallocs the address - which will be sufficiently aligned.

ticket: 6308

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21794 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoChange 16/32/64-bit big-/little-endian/native unaligned load/store
Ken Raeburn [Sat, 24 Jan 2009 01:27:16 +0000 (01:27 +0000)]
Change 16/32/64-bit big-/little-endian/native unaligned load/store
routines to take void pointers, so they can operate on both plain and
unsigned char buffers, or other types.
Remove some now-unneeded casts.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21793 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoEliminate the need for the domain_realm mapping table on the client side by implement...
Zhanna Tsitkov [Fri, 23 Jan 2009 19:59:50 +0000 (19:59 +0000)]
Eliminate the need for the domain_realm mapping table on the client side by implementing minimal referral support in the KDC

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21792 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove some null checks in cases where pointers can't be null
Greg Hudson [Fri, 23 Jan 2009 19:04:57 +0000 (19:04 +0000)]
Remove some null checks in cases where pointers can't be null

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21790 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5_pac_get_buffer, check the correct value for null after calling
Greg Hudson [Fri, 23 Jan 2009 19:01:56 +0000 (19:01 +0000)]
In krb5_pac_get_buffer, check the correct value for null after calling
malloc.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21789 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5_pac_parse, change the code around a bit to avoid harmlessly
Greg Hudson [Fri, 23 Jan 2009 18:41:39 +0000 (18:41 +0000)]
In krb5_pac_parse, change the code around a bit to avoid harmlessly
copying an uninitialized Buffers field of a PACTYPE structure.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21788 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoInitialize ds.magic in k5_md5_hmac_hash, to avoid harmlessly copying
Greg Hudson [Fri, 23 Jan 2009 18:19:19 +0000 (18:19 +0000)]
Initialize ds.magic in k5_md5_hmac_hash, to avoid harmlessly copying
around its uninitialized value in krb5_hmac.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21787 dc483132-0cff-0310-8789-dd5450dbe970

15 years agohash db2 code breaks if st_blksize > 64k
Ken Raeburn [Fri, 23 Jan 2009 18:04:08 +0000 (18:04 +0000)]
hash db2 code breaks if st_blksize > 64k

The hash db code assumes in places that the block size is no larger
than 64K.  There's a range check in the case where you don't have a
file but provide initialization info.  The btree code will cap the
block size used at 64K.

Apparently Sun's ZFS can report back a block size of 128K, causing the
db2 tests to fail.

Add such a cap to the hash db creation code.

Note that our default configuration is to use the btree code when
creating a new database, so it's unlikely that this will cause
real-world problems unless someone went out of their way to specify
use of the hash format.

ticket: 6342

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21786 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5_get_init_creds, null out err_reply in a case where we free it
Greg Hudson [Fri, 23 Jan 2009 17:53:52 +0000 (17:53 +0000)]
In krb5_get_init_creds, null out err_reply in a case where we free it
and do not necessarily exit the loop.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21785 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAlways initialize the output parameter in krb5_parse_name and friends
Greg Hudson [Fri, 23 Jan 2009 17:45:58 +0000 (17:45 +0000)]
Always initialize the output parameter in krb5_parse_name and friends

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21784 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn kadmin, free the correct item in an error case (fixes a double-free
Greg Hudson [Fri, 23 Jan 2009 17:24:50 +0000 (17:24 +0000)]
In kadmin, free the correct item in an error case (fixes a double-free
and a memory leak).

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21783 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd some output parameter initializations n order to eliminate some
Greg Hudson [Fri, 23 Jan 2009 06:51:03 +0000 (06:51 +0000)]
Add some output parameter initializations n order to eliminate some
spurious Coverity defects.  (Far from a comprehensive pass.)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21782 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPer coding standards, don't declare variables in inner scopes in new
Greg Hudson [Fri, 23 Jan 2009 05:02:07 +0000 (05:02 +0000)]
Per coding standards, don't declare variables in inner scopes in new
rcache code except when it really makes sense (option processing for
t_replay).

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21781 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoInclude cksumtypes.h from aead.h to get struct krb5_cksumtypes (moved
Ken Raeburn [Fri, 23 Jan 2009 00:46:46 +0000 (00:46 +0000)]
Include cksumtypes.h from aead.h to get struct krb5_cksumtypes (moved
in rev 21753).
Protect cksumtypes.h from multiple inclusions.
Update dependencies.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21780 dc483132-0cff-0310-8789-dd5450dbe970

15 years agofix trailing whitespace
Tom Yu [Thu, 22 Jan 2009 23:37:35 +0000 (23:37 +0000)]
fix trailing whitespace

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21779 dc483132-0cff-0310-8789-dd5450dbe970

15 years agowhitespace
Tom Yu [Thu, 22 Jan 2009 23:21:11 +0000 (23:21 +0000)]
whitespace

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21778 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdapted patch from Apple: in kadmind's process_chpw_request, make sure
Greg Hudson [Thu, 22 Jan 2009 19:19:34 +0000 (19:19 +0000)]
Adapted patch from Apple: in kadmind's process_chpw_request, make sure
to free error message strings.

ticket: 6284
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21776 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIf USE_VALGRIND, check that source principal is defined before copying.
Ken Raeburn [Thu, 22 Jan 2009 06:34:14 +0000 (06:34 +0000)]
If USE_VALGRIND, check that source principal is defined before copying.
Initialize magic number fields of allocated name components.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21775 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIf USE_VALGRIND, check readability of byte string before copying
Ken Raeburn [Thu, 22 Jan 2009 06:30:08 +0000 (06:30 +0000)]
If USE_VALGRIND, check readability of byte string before copying

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21774 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDefine valgrind macros as no-ops if not USE_VALGRIND, and use unconditionally, per...
Ken Raeburn [Thu, 22 Jan 2009 06:04:10 +0000 (06:04 +0000)]
Define valgrind macros as no-ops if not USE_VALGRIND, and use unconditionally, per Danilo's suggestion

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21773 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPatch from Love: when opening an existing replay cache, check more
Greg Hudson [Wed, 21 Jan 2009 19:38:12 +0000 (19:38 +0000)]
Patch from Love: when opening an existing replay cache, check more
thoroughly to prevent symlink attacks.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21770 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPatch from Luke: fix error return of krb5_gss_use_kdc_context
Greg Hudson [Wed, 21 Jan 2009 18:23:58 +0000 (18:23 +0000)]
Patch from Luke: fix error return of krb5_gss_use_kdc_context

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21768 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoWhen encoding, and compiling with -DUSE_VALGRIND, explicitly get valgrind to check...
Ken Raeburn [Tue, 20 Jan 2009 23:49:08 +0000 (23:49 +0000)]
When encoding, and compiling with -DUSE_VALGRIND, explicitly get valgrind to check the inputs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21766 dc483132-0cff-0310-8789-dd5450dbe970

15 years agodelete trailing whitespace, including insanely long 'blank' lines
Ken Raeburn [Tue, 20 Jan 2009 22:52:15 +0000 (22:52 +0000)]
delete trailing whitespace, including insanely long 'blank' lines

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21764 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5_rd_rep_dce, initialize repl to NULL to avoid using its
Greg Hudson [Tue, 20 Jan 2009 18:50:51 +0000 (18:50 +0000)]
In krb5_rd_rep_dce, initialize repl to NULL to avoid using its
initialized value when we take the first goto to clean_scratch.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21763 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIf buffer length is 0, force pointer to NULL, to keep valgrind happier when callers...
Ken Raeburn [Sat, 17 Jan 2009 01:00:22 +0000 (01:00 +0000)]
If buffer length is 0, force pointer to NULL, to keep valgrind happier when callers don't bother

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21762 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopatch from Luke - minor cleanup
Ken Raeburn [Sat, 17 Jan 2009 00:06:06 +0000 (00:06 +0000)]
patch from Luke - minor cleanup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21761 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopatch from Luke - fix enctype-nego enctype list setup
Ken Raeburn [Sat, 17 Jan 2009 00:04:49 +0000 (00:04 +0000)]
patch from Luke - fix enctype-nego enctype list setup

ticket: 6336

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21760 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopatch from Luke - fix sign problem
Ken Raeburn [Sat, 17 Jan 2009 00:02:05 +0000 (00:02 +0000)]
patch from Luke - fix sign problem

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21759 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoinclude dependencies for decoder test
Ken Raeburn [Fri, 16 Jan 2009 23:55:01 +0000 (23:55 +0000)]
include dependencies for decoder test

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21758 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUse valgrind in more cases if VALGRIND is set
Ken Raeburn [Fri, 16 Jan 2009 00:33:00 +0000 (00:33 +0000)]
Use valgrind in more cases if VALGRIND is set

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21754 dc483132-0cff-0310-8789-dd5450dbe970