Tom Yu [Fri, 13 Apr 2007 00:07:40 +0000 (00:07 +0000)]
tag krb5-1.6.1-beta1
git-svn-id: svn://anonsvn.mit.edu/krb5/tags/krb5-1-6-1-beta1@19449
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 13 Apr 2007 00:06:35 +0000 (00:06 +0000)]
fix typo
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19448
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 13 Apr 2007 00:06:26 +0000 (00:06 +0000)]
README and patchlevel for 1.6.1-beta1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19447
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 13 Apr 2007 00:06:18 +0000 (00:06 +0000)]
update copyright year
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19446
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Apr 2007 23:58:14 +0000 (23:58 +0000)]
tag krb5-1.6.1-beta1
git-svn-id: svn://anonsvn.mit.edu/krb5/tags/krb5-1-6-1-beta1@19444
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Apr 2007 23:56:32 +0000 (23:56 +0000)]
tag krb5-1.6.1-beta1
git-svn-id: svn://anonsvn.mit.edu/krb5/tags/krb5-1-6-1-beta1@19442
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Apr 2007 21:30:33 +0000 (21:30 +0000)]
pull up r19440 from trunk
r19440@cathode-dark-space: jaltman | 2007-04-12 17:19:33 -0400
ticket: new
subject: NIM - Fix taskbar button visibility on Vista
component: windows
tags: pullup
Although the Platform SDK docs suggest using ITaskbarList to add/remove
a taskbar button on the fly, it doesn't work on Vista. Instead we will
just set the window style to use WS_EX_APPWINDOW and be done with it.
No change in the NIM version number.
ticket: 5526
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19441
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Apr 2007 20:12:53 +0000 (20:12 +0000)]
pull up r19429 from trunk
r19429@cathode-dark-space: jaltman | 2007-04-12 03:44:55 -0400
ticket: 5525
Fix some typos and most importantly add Indexing
ticket: 5525
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19439
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Apr 2007 20:12:32 +0000 (20:12 +0000)]
pull up r19428 from trunk
r19428@cathode-dark-space: jaltman | 2007-04-12 01:32:20 -0400
ticket: new
subject: NIM 1.2 HtmlHelp User Documentation
component: windows
tags: pullup
Update all text for NIM 1.2.
Update most screen images.
Convert all images to PNG format from BMP in order to reduce the
size of the files.
Ensure that all pages are accessible via a path beginning at the
welcome.htm page.
ticket: 5525
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19438
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Apr 2007 20:12:20 +0000 (20:12 +0000)]
pull up r19427 from trunk
r19427@cathode-dark-space: jaltman | 2007-04-11 23:45:02 -0400
ticket: new
subject: NIM doxyfile.cfg - update to Doxygen 1.5.2
component: windows
tags: pullup
The doxyfile.cfg file was generated using Doxygen 1.2 which is years
old. There have been significant improvements in the quality of the
Html output since then. As of this commit, the current version is 1.5.2.
ticket: 5524
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19437
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Apr 2007 20:12:03 +0000 (20:12 +0000)]
pull up r19426 from trunk
r19426@cathode-dark-space: jaltman | 2007-04-11 23:40:25 -0400
ticket: new
subject: KFW 3.2 Beta 2 commits
component: windows
tags: pullup
NetIDMgr 1.2.0.2
================
nidmgr32.dll
- When the root credential set is touched, trigger an identity
refresh. This is necessary to ensure that the identity list
has a complete state of the world when the identity provider
attempts to initialize an initial default identity when none
previously existed. (see krb5cred.dll section)
- Don't set the enabled state for KHUI_ACTION_DESTROY_CRED and
KHUI_ACTION_RENEW_CRED actions. They are set elsewhere.
krb5common.obj
- Initialize variables to prevent uninitialized use.
krb4cred.dll
- Re-order controls and use CheckRadioButton() for manipulating the
radio buttons which select the ticket acquisition method.
- Use symbolic constants instead of numbers.
- If Kerberos 4 is enabled for a specific identity, then that setting
takes precedence over the global setting. The global setting is
merely a default if a per-identity setting is not specified.
However, a per-identity setting is only read for the default
identity.
- If the validity of an identity is not known, assume that it is still
being checked and don't display any credential text.
- When handling WM_COMMAND messages for the new credentials panel,
only update the data when a BN_CLICKED message is received and only
update the display if the IDC_NCK4_OBTAIN checkbox is toggled.
- Remove unused symbols from langres.h
krb5cred.dll
- When renewing an identity which was imported, first try to import it
again. If that fails to obtain newer tickets, then try initializing
the MSLSA cache and then importing again.
- Correct spelling: k5_ident_valiate_name() ->
k5_ident_validate_name().
- Refactor the code for setting an identity as the default so we can
call it internally.
- When setting the initial default identity, if there is no current
default ccache and no known last default identity, then look through
the list of ccaches with credentials and pick one with valid
tickets. If all else fails, then pick any of the ccaches.
netidmgr.exe
- Credentials Window
- Consistently use KHUI_CW_O_RELIDENT as a necessary and sufficient
indicator that the identity needs to be released when freeing an
outline node.
- Properly initialize an outline node.
- Don't group similar credentials if we aren't sorting/grouping by
any specific column.
- Use the KHUI_CW_O_EMPTY flag to indicate that an outline node
contains no children.
- Handle the case where we aren't sorting/grouping by any column.
- Make sure outline nodes have valid idx_start and idx_end values.
- Use consistent logic when painting and handling mouse hotspots.
- Don't use WS_EX_TRANSPARENT when creating the notification window.
- Use a fixed height for the notification window.
- Update the outline when the default identity changes.
- Hypertext Window
- Correctly handle the "center" attribute in the "p" element.
- Use a system brush for painting the background instead of creating
one of our own.
- Correct the handling of scroll_left and scroll_top when
calculating the coordinates for text.
- Don't check if the rectangle for the text is inside the visible
area of the window before drawing.
- Handle WM_ERASEBKGND and use a system color brush to erase the
background.
- When the size changes, force the extents to be recomputed. This
will also update the scroll bars.
- Use the proper return value after handling WM_PAINT.
- The scrollbar messages send the operation code in the low word of
wParam, not the high word.
- Use GetScrollInfo() with SIF_POS when the operation is
SB_ENDSCROLL or SB_THUMBPOSITION.
- When the hottracked link changes for a transparent window, don't
invalidate the entire parent window. Instead use
MapWindowPoints() to calculate the affected rectangle and
invalidate that.
- Misc
- Change the text of the IDS_NO_CREDS message so that it renders
better on a small window.
- Initialize COM when starting the GUI.
- When showing and hiding the main window and the new credentials
window, add a button to the task bar. This allows the user to
switch focus to the window if it's obstructed.
- Remove unused symbols from resource.h
- New Credentials Window
- Ignore the validity state of the identity when showing a password
change dialog. We don't expect the identity provider to validate
the identity when changing the password.
ticket: 5523
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19436
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 12 Apr 2007 20:11:34 +0000 (20:11 +0000)]
pull up r19425 from trunk
r19425@cathode-dark-space: jaltman | 2007-04-11 22:27:10 -0400
ticket: new
subject: NIM 3.2 documentation update
component: windows
tags: pullup
Replace the notification icon action menu image with the latest
menu structure.
ticket: 5522
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19435
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 11 Apr 2007 01:58:21 +0000 (01:58 +0000)]
pull up r19407 from trunk
r19407@cathode-dark-space: jaltman | 2007-04-06 21:02:00 -0400
ticket: new
subject: NIM 1.2.0.1 corrections
component: windows
tags: pullup
NetIdMgr Version 1.2.0.1
netidmgr.exe:
- add functionality to implement previously defined "DefaultSticky"
registry based configuration parameter. This value is can be added to
an installer by a transform or pushed by Group Policy. When set, it
controls the default setting of the "sticky" flag for new identities.
nidmgr32.dll:
- fix the version resources: FileVersion, ProductName, and ProductVersion
krb5cred.dll:
- when importing an identity from the MSLSA, if there has never been a
default identity, configure the MSLSA identity to be the default.
ticket: 5516
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19421
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 11 Apr 2007 01:58:09 +0000 (01:58 +0000)]
pull up r19406 from trunk
r19406@cathode-dark-space: jaltman | 2007-04-06 20:33:15 -0400
ticket: new
subject: KFW NSIS installer - copyright updates and aklog removal
component: windows
tags: pullup
Update copyrights to include 2007
Removal all references to aklog
Correct generation of Product Version
ticket: 5515
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19420
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 11 Apr 2007 01:57:53 +0000 (01:57 +0000)]
pull up r19402 from trunk
r19402@cathode-dark-space: jaltman | 2007-04-06 15:56:31 -0400
ticket: new
subject: wix installer - modify file list
component: windows
tags: pullup
for build script changes:
site-local.nsi -> site-local-tagged.nsi
site-local.wxi -> site-local-tagged.wxi
add missing file:
nsi-includes.nsi
ticket: 5514
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19419
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 10 Apr 2007 21:52:23 +0000 (21:52 +0000)]
pull up r19410 from trunk
r19410@cathode-dark-space: raeburn | 2007-04-09 16:58:13 -0400
ticket: new
subject: EAI_NODATA deprecated, not always defined
tags: pullup
target_version: 1.6.1
Brian Kantor reports (on the kerberos@mit list today) that krb5-1.6
doesn't build on FreeBSD 6.1 because they've done away with
EAI_NODATA, which was removed from the getaddrinfo API in RFC 3943.
This patch conditionalizes two tests for EAI_NODATA on the macro being
defined, and also adds handling for EAI_OVERFLOW, a new error code
added in RFC 3943.
ticket: 5518
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19418
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 10 Apr 2007 21:52:11 +0000 (21:52 +0000)]
pull up r19400 from trunk
r19400@cathode-dark-space: lxs | 2007-04-05 16:33:40 -0400
ticket: new
subject: krb5int_open_plugin_dirs errors out if directory does not exist
If one of the directories in the list doesn't exist and no filenames are
passed in because opendir fails and then the code gets an error. opendir()
failing should not be a fatal error. The function should just move on to
the next directory.
ticket: 5510
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19417
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 10 Apr 2007 21:51:59 +0000 (21:51 +0000)]
pull up r19399 from trunk
r19399@cathode-dark-space: raeburn | 2007-04-05 16:22:28 -0400
ticket: new
subject: service location plugin returning no addresses handled incorrectly
If a locate plugin (e.g., the Python sample plugin and script, when
given realm BOBO.MIT.EDU) returns no error but no addresses, the library
won't report an error, but will try to make contact, and eventually
crash with a null pointer dereference.
Fix: If a plugin returns a value other than PLUGIN_NO_HANDLE, including
success, continue into the code that checks for an empty address list.
ticket: 5509
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19416
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 10 Apr 2007 21:51:46 +0000 (21:51 +0000)]
pull up r19239 from trunk
r19239@cathode-dark-space: raeburn | 2007-03-21 00:14:02 -0400
ticket: new
subject: krb5 library uses kdc.conf when it shouldn't
Don't add kdc.conf to the list of config files to use unless it's
actually requested. Reported by Will Fiveash.
ticket: 5480
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19415
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 10 Apr 2007 21:51:33 +0000 (21:51 +0000)]
pull up r19225 from trunk
r19225@cathode-dark-space: raeburn | 2007-03-13 20:52:47 -0400
ticket: 5447
Fix tail portability problem by adding an expression test to the
existing awk invocation instead. Patch from Robert Basch at MIT.
ticket: 5447
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19414
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 10 Apr 2007 21:51:21 +0000 (21:51 +0000)]
pull up r19226 from trunk
r19226@cathode-dark-space: raeburn | 2007-03-13 21:52:23 -0400
ticket: 5257
* kadm5_create.c: Include fake-addrinfo.h.
(add_admin_princs): Use getaddrinfo instead of gethostbyname. Report
the correct message on getaddrinfo errors, and return EINVAL to
caller.
ticket: 5257
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19413
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Tue, 10 Apr 2007 21:51:06 +0000 (21:51 +0000)]
pull up r19024 from trunk
r19024@cathode-dark-space: epeisach | 2006-12-31 13:10:27 -0500
ticket:new
subject: Memory leak in tests/gssapi/t_imp_name.c
Memory leak by not releasing name_oid from gss_display_name().
(conditional on GSSAPI_V2 being defined).
ticket: 5246
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19412
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 4 Apr 2007 21:39:26 +0000 (21:39 +0000)]
pull up r19396 from trunk
r19396@cathode-dark-space: tlyu | 2007-04-03 17:27:25 -0400
ticket: new
subject: MITKRB5-SA-2007-001: telnetd allows login as arbitrary user
tags: pullup
target_version: 1.6.1
Fix MITKRB5-SA-2007-001:
* src/appl/telnet/telnetd/sys_term.c (start_login): Add "--"
argument preceding username, in addition to the original patch.
Explicitly check for leading hyphen in username.
* src/appl/telnet/telnetd/state.c (envvarok): Check for leading
hyphen in environment variables. On advice from Shawn Emery, not
using strchr() as in the original patch.
ticket: 5508
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19398
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Wed, 4 Apr 2007 21:08:05 +0000 (21:08 +0000)]
pull up r19395 from trunk
r19395@cathode-dark-space: tlyu | 2007-04-03 15:23:52 -0400
ticket: new
subject: MITKRB5-SA-2007-002: buffer overflow in krb5_klog_syslog
target_version: 1.6.1
tags: pullup
Fix MITKRB5-SA-2007-002: buffer overflow in krb5_klog_syslog.
* src/lib/krb5/krb/get_in_tkt.c (krb5_klog_syslog): Use vsnprintf
if available.
Everything else: use precision fields on "%s" specifiers to truncate
logged strings, in case someone doesn't have vsnprintf.
ticket: 5507
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19397
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 23:43:00 +0000 (23:43 +0000)]
back to krb5-1.6-postrelease
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19393
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 23:35:43 +0000 (23:35 +0000)]
patchlevel.h and winlevel.h for kfw-3.2.0-beta1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19391
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 23:17:18 +0000 (23:17 +0000)]
pull up r19389 from trunk
r19389@cathode-dark-space: kpkoch | 2007-04-02 17:03:36 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Add svnbranch; change internal names to svntag and svnbranch. Implement cvs tags and svn tags and branches.
Move reading of kerberos.ver to after files are fetched.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19390
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 20:46:50 +0000 (20:46 +0000)]
pull up r19375 from trunk
r19375@cathode-dark-space: kpkoch | 2007-04-02 12:13:58 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Uncomment w2k files in corebinaries.xml.
Factor processing of <Prunes> xml into pruneFiles.pl.
Factor processing of <Zips> xml into zipXML.pl.
Move SRC zip XML to <FetchSources> section of config file.
Call zipXML in /REPOSITORY CHECKOUT section of script.
Keep track of cleaning of OUTDIR so SRC zip isn't removed during packaging.
Remove UNIXFIND from config file. If UNIXFIND isn't present in the config file, set the in-memory UNIXFIND to c:\tools\cygwin\bin. UNIXFIND is now an implementation detail stored in the in-memory config XML, like the versions read from kerberos.ver.
Prune more temporary files before making SDK zip.
Remove redundant custom files from sdkfiles.xml. Copy *.* from staging/inc instead of *.h -- one .c file is also required.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19388
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 20:46:39 +0000 (20:46 +0000)]
pull up r19371 from trunk
r19371@cathode-dark-space: kpkoch | 2007-04-01 14:42:18 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Be smarter about cleaning the staging area.
Clean output area if packaging. (Will not clean if -nopackage specified.)
Pull corebinaries from staging area instead of from target area.
Don't sign before making zips. Build products are only signed in the staging area before any packaging is done. (Packaging products are signed when copied to the output area.)
Previous change: Add relnotes.html to output area.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19387
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 20:46:27 +0000 (20:46 +0000)]
pull up r19370 from trunk
r19370@cathode-dark-space: kpkoch | 2007-03-31 23:28:07 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Correct directory structure in zip files.
Make main config file match today's usage & implementation wrt /sign.
Clean staging area before using it.
Just clean output area instead of removing it.
Clean ziptemp area after each zip.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19386
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 20:46:15 +0000 (20:46 +0000)]
pull up r19369 from trunk
r19369@cathode-dark-space: kpkoch | 2007-03-31 19:20:00 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Eliminate getopt abbreviation for vverbose, which collided with the shortcut for verbose.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19385
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 20:46:00 +0000 (20:46 +0000)]
pull up r19368 from trunk
r19368@cathode-dark-space: kpkoch | 2007-03-31 18:31:33 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Add signing in staging area before building installers.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19384
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 20:45:48 +0000 (20:45 +0000)]
pull up r19367 from trunk
r19367@cathode-dark-space: kpkoch | 2007-03-31 18:09:23 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Make /OUTDIR absolute instead of relative.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19383
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 20:45:36 +0000 (20:45 +0000)]
pull up r19366 from trunk
r19366@cathode-dark-space: kpkoch | 2007-03-30 23:33:23 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Pruning no longer required before make.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19382
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 20:45:24 +0000 (20:45 +0000)]
pull up r19365 from trunk
r19365@cathode-dark-space: kpkoch | 2007-03-30 23:14:08 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Remove most pruned directories -- they are no longer checked out.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19381
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 18:26:45 +0000 (18:26 +0000)]
pull up r19376 from trunk
r19376@cathode-dark-space: jaltman | 2007-04-02 13:49:08 -0400
ticket: new
subject: More commits for NIM 1.2 Beta 1
component: windows
tags: pullup
netidmgr.exe
- Credentials display :
- When picking out the mouse hit rectangles, correctly handle the
case where a sticky identity doesn't have any outline controls.
- Move code to check and uncheck view layout action to
cw_load_view() for consistency.
- Initialize outlines properly when creating them.
- cw_select_row_creds() should be called on all rows that are being
selected or unselected.
- Actions :
- Remove the 'Contents' item from the 'Help' menu. The
KHUI_ACTION_HELP_CTX action already opens the 'Contents' section.
- Add 'Change password', 'Import', 'Help contents', and 'About' to
the notification icon context menu.
- Move the 'Import' action to be between 'Renew' and 'Destroy' for
consistency.
- Resources :
- "Run Network Identity Manager in System Tray" -> "Run from taskbar
notification area"
- "New Credentials" -> "Obtain new credentials"
- Main window :
- Don't switch the window mode when handling a
KHUI_ACTION_LAYOUT_RELOAD.
- Refresh the action tables after changing the window state actions.
- Main Menu :
- Call khm_refresh_identity_menus() when initializing the menus so
that they have a consistent initial state.
- When refreshing menus, the checked/unchecked state needs to be set
explicitly by turning off flags that are no longer necessary.
- Refresh the identities before refreshing the identity menus.
- If there are no identities with credentials, disable renew/destroy
menus and actions.
- Don't bother adding 'renew/destroy all' menu items to the
per-identity action menus if there is only one identity.
krb5cred.dll
- Resources :
- Expand the 'Credential flags' control so that it's big enough to
hold the contents.
source
- ccsv.pl :
- Handle comment lines before the actual content.
- csvschema.cfg :
- Don't bother embedding documentation in the data strucutre now.
We don't use it.
- Convert '[~]' to '\0' before we send it back to the parser.
ticket: 5505
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19380
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 18:25:56 +0000 (18:25 +0000)]
pull up r19374 from trunk
r19374@cathode-dark-space: jaltman | 2007-04-02 09:22:03 -0400
ticket: 5504
Correct some poor grammar in the opening paragraph of the
what is NIM section.
ticket: 5504
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19379
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 18:24:14 +0000 (18:24 +0000)]
pull up r19373 from trunk
r19373@cathode-dark-space: jaltman | 2007-04-01 22:58:13 -0400
ticket: new
subject: Network Identity Manager 1.2 User Manual
component: windows
tags: pullup
The NIM 1.2 User Manual includes a completely re-written
introduction to what is NIM as well as new text describing
the new default "basic" view mode and the revised "new credentials"
dialog. Updates to the menu structures, the toolbar, and
the modifications to the options pages are all provided.
All images have been updated with the new color scheme.
Image shots were taken on XP SP2 with the Silver XP Theme.
ticket: 5504
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19378
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Mon, 2 Apr 2007 18:23:58 +0000 (18:23 +0000)]
pull up r19372 from trunk
r19372@cathode-dark-space: jaltman | 2007-04-01 18:41:18 -0400
ticket: new
subject: msi deployment guide updates for KFW 3.2
component: windows
tags: pullup
Update the registry value lists for KFW 3.2
ticket: 5503
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19377
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 21:37:18 +0000 (21:37 +0000)]
pull up r19363 from trunk
r19363@cathode-dark-space: kpkoch | 2007-03-30 17:24:18 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
For the sdk zip, copy *.* and then [the new part] remove *.exe and *.msi. Further tweaks should be suggested in the form of mods to sdkfiles.xml.
Minor formatting and removing redundant code.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19364
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:55:35 +0000 (20:55 +0000)]
pull up r19211 from trunk
r19211@cathode-dark-space: jaltman | 2007-03-06 18:30:47 -0500
ticket: new
subject: reverting commit to windows WIX installer (revision 19207)
component: windows
Revision 19207 committed by Kevin Koch does not document changes
made to the Wix installer files. The changes that were made remove
the installation of the configuration files and the inclusion of
leash32.chm.
When the decision is made to remove Leash from the installer,
the entire Leash feature and the associated properties used to
determine when it is installed must be removed. Commenting out
individual file components is not sufficient.
Configuration files must be installed as part of KFW. The
source of the configuration files is defined by the variable
"ConfigDir" within the site-local.wxi directory.
Any changes made to the WIX installer must also be made to the NSIS
installer.
The changes to the src/windows/wix directory from 19207 are
therefore reverted.
ticket: 5461
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19362
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:55:24 +0000 (20:55 +0000)]
pull up r19191 from trunk
r19191@cathode-dark-space: jaltman | 2007-02-28 13:00:43 -0500
ticket: 5452
Add intalert.h which should have been added as part of
revision 19189
ticket: 5452
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19361
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:55:11 +0000 (20:55 +0000)]
pull up r19344 from trunk
r19344@cathode-dark-space: kpkoch | 2007-03-30 16:08:53 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Remove tabs. Improve some comments. Regroup files in copylist.pl according to destination.
Add signing.
Factor zipfiles out of bkw.pl and signing out of makeZip.pl.
Rename MITKerberosForWindows.exe before zipping it into the SDK zipfile.
ticket: 5490
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19360
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:54:59 +0000 (20:54 +0000)]
pull up r19305 from trunk
r19305@cathode-dark-space: kpkoch | 2007-03-29 11:48:15 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Change DEBUG and VERBOSE defaults so that omitting them from the command line has an effect!
Pass NODEBUG=1 to build.pl.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19359
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:54:48 +0000 (20:54 +0000)]
pull up r19304 from trunk
r19304@cathode-dark-space: kpkoch | 2007-03-29 10:16:16 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Remove obsolete comment.
Add -nolog switch; always pass build.pl --nolog. Logging will be done in bkw.pl.log
Create <src>/pismere/CVS if missing so checkout works.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19358
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:54:36 +0000 (20:54 +0000)]
pull up r19302 from trunk
r19302@cathode-dark-space: kpkoch | 2007-03-28 15:56:48 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Add %BUILDDIR% for nsi-includes.nsi, which was missed the first time around.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19357
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:54:24 +0000 (20:54 +0000)]
pull up r19298 from trunk
r19298@cathode-dark-space: kpkoch | 2007-03-28 14:47:34 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Add more tag substitutions to file copy and the config file, to provide a way to generate names like kfw-3-2-0-DEBUG.exe programatically.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19356
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:54:10 +0000 (20:54 +0000)]
pull up r19297 from trunk
r19297@cathode-dark-space: kpkoch | 2007-03-28 14:43:11 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Pull product version information from kerberos.ver.
Change site-local.wxi/.nsi to site-local-tagged.wxi/.nsi. Add tags such as %VERSION-MAJOR% which are substituted by the build script. NB: to build the installers directly, the build script must be run at least once to generate site-local.wxi/.nsi.
Write DEBUG, RELEASE, BETA defines to site-local.nsi, based on build setting & values from kerberos.ver.
Add more tag substitutions to file copy and the config file, to provide a way to generate names like kfw-3-2-0-DEBUG.exe programatically.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19355
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:53:59 +0000 (20:53 +0000)]
pull up r19233 from trunk
r19233@cathode-dark-space: kpkoch | 2007-03-16 14:35:59 -0400
Update 3.1.0 to 3.2.0; update location of sample directory.
Ticket: 5409
Target_Version: 1.6.1
Tags: pullup
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19354
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:53:47 +0000 (20:53 +0000)]
pull up r19232 from trunk
r19232@cathode-dark-space: kpkoch | 2007-03-15 23:55:52 -0400
Subject: Update build files for new version and file locations.
Target_Version: 1.6.1
Tags: pullup
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19353
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:53:35 +0000 (20:53 +0000)]
pull up r19294 from trunk
r19294@cathode-dark-space: kpkoch | 2007-03-27 14:42:51 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Update documentation.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19352
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:53:23 +0000 (20:53 +0000)]
pull up r19293 from trunk
r19293@cathode-dark-space: kpkoch | 2007-03-27 14:41:34 -0400
Target_Version: 1.6.1
Ticket: 5490
Tags: pullup
Correct error message text, add comments, change some command line defaults. Change plink path.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19351
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:53:09 +0000 (20:53 +0000)]
pull up r19291 from trunk
r19291@cathode-dark-space: jaltman | 2007-03-27 09:47:44 -0400
ticket: new
subject: remove unwanted files from kfw build script
component: windows
Remove aklog, khhelp.h, and the .manifest files as they are
not installed by the installer.
ticket: 5492
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19350
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:52:58 +0000 (20:52 +0000)]
pull up r19288 from trunk
r19288@cathode-dark-space: kpkoch | 2007-03-26 09:28:32 -0400
Target_Version: 1.6.1
Component: KfW
Tags: pullup
Ticket: new
Subject: KfW build automation
Don't fetch afscompat.
Handle case of checkout into non-existent directory.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19349
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:52:43 +0000 (20:52 +0000)]
pull up r19234 from trunk
r19234@cathode-dark-space: kpkoch | 2007-03-16 14:38:28 -0400
Subject: KfW automated build scripts & supporting files.
Updated scripts & additional configuration files.
Ticket: new
Target_Version: 1.6.1
tags: pullup
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19348
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:52:31 +0000 (20:52 +0000)]
pull up r19207 from trunk
r19207@cathode-dark-space: kpkoch | 2007-03-05 17:34:25 -0500
Train build script to use repository sources, omit sample configuration. [wix area.]
Add control of the repository access step, fetch all sources from the repository. Track in documentation.
Eliminate unhelpful output during pre-package step.
The next step is to fetch only krb5/src/windows/build and run the entire build.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19347
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:52:18 +0000 (20:52 +0000)]
pull up r19206 from trunk
r19206@cathode-dark-space: kpkoch | 2007-03-05 11:37:41 -0500
Move automation documentation from wiki to here.
Minor tweaks to script (start adding unzip support) and config (move svn url to right place).
Target_Version: 1.6.1
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19346
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 20:52:06 +0000 (20:52 +0000)]
pull up r19205 from trunk
r19205@cathode-dark-space: kpkoch | 2007-03-05 09:07:07 -0500
Target_Version: 1.6.1
Component: KfW
Automation for building KfW.
ticket: 5490
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19345
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 18:54:31 +0000 (18:54 +0000)]
pull up r19292 from trunk
r19292@cathode-dark-space: kpkoch | 2007-03-27 13:27:41 -0400
Ticket: 5446
Status: resolved
Target_Version: 1.6.1
Tags: pullup
All Windows apps were popping MessageBoxes when stderr is redirected. Console apps shouldn't and no longer do that. Added isGuiApp, which tests gui resource usage.
Removed duplicate nested tests for _WIN32.
ticket: 5446
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19343
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 18:39:12 +0000 (18:39 +0000)]
pull up r19306 from trunk
r19307@cathode-dark-space: jaltman | 2007-03-29 17:19:43 -0400
ticket: new
subject: more bug fixes for NIM 1.2 (KFW 3.2)
component: windows
tags: pullup
netidmgr.exe
- Credentials display :
- If an outline is marked as KHUI_CW_O_STICKY | KHUI_CW_O_RELIDENT,
release the identity when deleting the outline node.
- Correctly determine the location of UI widgets using the column
specifier of the outline node instead of the column specifier of
the row.
- Do not recompute the extents of a row.
- If there is a default identity and it has no credentials and it is
not pinned, display it anyway.
krb5common.obj
- Import profile_rename_section()
krb5cred.dll
- In the realm editor:
- When writing realm data, keep track of whether any updates were
performed.
- Reset the dirty bits for each element whose changes were written
to the profile.
- Use profile_rename_section() correctly to delete sections.
- Check if any changes were applied before setting the 'applied' bit
for the configuration node.
- Don't assume that the Kerberos 5 General configuration panel has
received WMCFG_APPLY before the realm editor. It will not receive
the notification if it hasn't indicated that there are changes to
be applied.
- New credentials :
- If there is no "ExpiresOn" value for a cached prompt set, assume
that it has already expired.
- Set the lifetime for a new prompt set to be 7 days longer than
then maximum renewable lifetime.
ticket: 5496
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19342
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 18:38:54 +0000 (18:38 +0000)]
pull up r19306 from trunk
r19306@cathode-dark-space: jaltman | 2007-03-29 13:24:34 -0400
ticket: new
subject: NIM commits for KFW 3.2 Beta 1
component: windows
(NetIDMgr 1.2.0.0)
netidmgr.exe
- Simplify credential window UI element placement calculations.
- Add the Custom_1 view to the UI schema. This is used to store
customizations to the basic view.
- Extended styles for toolbars have to be set via TB_SETEXTENDEDSTYLE
messages instead of the EX_STYLE parameter to CreateWindowEx().
Also, set the extended style to support detached arrows.
- Support drop down menus in the standard toolbar.
- The per-identity commands that are added to expiration dialogs are
now flagged for automatic dispatch.
- Remove unnecessary status bar parts and display the status bar icons
at the correct size.
- The notification alerts now display the info balloon at the correct
size.
- Increase the height of the height of the dialog button bar to 190
from 181 dialog units.
- Lock the action tables when refreshing the per-identity actions.
Perform the necessary notification after refreshing the per-identity
actions.
- "Initialize <identity>" -> "Obtain new credentials for <identity>"
- Add a button to go back to the Basic view from the Advanced view in
the new credentials dialog.
- Cache the extents of each row since we now support rows of variable
heights.
- Selecting a credential row or a header should select all the
credentials that are represented by the row.
- Update the selection state after loading a new view.
- Display the expiration times in the second line of an expanded
identity header.
- Checks for expiration flags in the credentials window now take into
account that the each flag may occupy more than one bit position.
- Calculate the expiration flags for the identity before assigning it
to a header, so that the header can display accurate expiration
data.
- Kill unnecessary timers in the credentials view and make sure taht
the KHUI_CW_ROW_TIMERSET flag is consistent with whether there is an
active timer for the row.
- In addition to rows that hold credentials, timers can also be
assigned to headers for identities in the basic view. This allows
the headers to display expiration times.
- The credentials view keeps track of the count of credentials, the
count of identity credentials (credentials which belong to the
credentials type that the identity belongs to) and the number of
initial credentials.
- Configuration spaces that hold credential view definitions now
include an additional value "_AppVersion" which contains the version
of NIM used to create the data. If the current version is greater
than the stated version, NIM will failover to using the schema
instead of using the saved data. This is because view definitions
are version dependent.
- The app_version global variable is now a const.
- The renew and destroy icons in the standard toolbar are now drop
down buttons. If the drop down arrow is clicked, they display a
menu with the list of identities that the operation can target.
- The renew and destroy actions on the credential menu have been
replaced by submenus that allow the user to select the identity
which would be the target of the operation.
- Consistently update the 'displayed' field of an alert so that
plug-ins can keep track of which alerts are being displayed.
- If the currently displayed balloon alert has
KHUI_ALERT_FLAG_DEFACTION flag, then dispatch the defualt command
when the user clicks the notification icon, or display the expanded
alert if necessary.
- Reduce flicker when drawing the credentials display by clipping the
header control from the device context.
- The state of Advanced mode is now preserved between NIM sessions.
- The credential display layout is kept track of separately for the
Basic and Advanced views. Any customization done on either view
(e.g.: changing sort order) will only affect that view.
Customizations for the Advanced view will be saved in the Custom_0
view, while customizations for the Basic view will be saved in
Custom_1.
- New color scheme.
- Selecting a credential or identity will no longer mask the
expiration state. The selection rectangle is now alpha blended.
- In Basic view, the width of the Identity column changes with the
width of the window so that the credentials display always fills the
width of the window.
- The colors for the highlight, text color, highlighted text color,
window background and other elements are now obtained via Windows so
that NetIDMgr will be more consistent with any themes that have been
applied.
- Correctly determine whether a column can be dragged or resized based
on the KHUI_CW_COL_FIXED_WIDTH and KHUI_CW_COL_FIXED_POS flags.
- Correctly update the scroll bars when switching between views.
- The "marker" button for a displayed alert should not perform any
action and it should not be the default control. Selecting it
should no longer cause an assertion to be thrown.
- Don't display the "... Click here for more." message when displaying
a balloon alert if the operating system involved does not provide a
reliable means of detecting that the user clicked on a balloon.
- When attempting to display queued alerts, if the alert at the top of
the queue is of a type that cannot be consolidated, then show it by
itself.
- If the size of the alert window changes, it should be redrawn
properly.
krb5creds.dll
- Allow setting an identity as the default even if there are no
credentials or credential caches associated with it. We generate
the name of the ccache we would use if we were getting new
credentials for the identity and then set that as the default cache.
- Controls in the per-identity configuration panels resized to fit
their contents.
- Set the credentials type and type name attributes for identities for
which we have a TGT.
- Use khm_krb5_get_identity_params() when retrieving parameters for
the identity global configuration panel.
- Add UI elements for setting the global values for forwardable,
renewable and addressless flags.
- Make the schema default to issue forwardable tickets for identities
that have no configuration and when krb5.ini does not define
'forwardable'.
- When updating the identity properties, take all the active
identities into account, so that we won't orphan any identities with
Krb5 properties but no credentials associated with them.
- If there is no TGT associated with an identity, then strip it of any
Krb5 provided properties.
- Associate identities that have a valid TGT with Krb5 by setting
KCDB_ATTR_TYPE to the Krb5 credentials type.
- Don't attempt to renew an identity if the TGT is not renewable or is
expired.
- When opening the configuration handle for an identity, if the
identity does not have any configuration information, failover to
using the per-realm configuration or the identity global
configuration.
- When opening the configuration handle, don't return a handle that
can't safely be closed.
- Add code from get_in_tkt.c that correctly handles per-realm settings
when obtaining libdefaults settings from the profile.
ticket: 5495
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19341
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 18:38:42 +0000 (18:38 +0000)]
pull up r19296 from trunk
r19296@cathode-dark-space: jaltman | 2007-03-28 14:03:45 -0400
ticket: new
subject: KFW: problems with non-interactive logons
component: windows
tags: pullup
Non-interactive logons cause two problems:
(1) on XP/2003 the logon event handlers do not get triggered and on
all platforms the LogonScript does not get executed.
As a result, ccache files are not deleted.
(2) on all platforms, accessing the credential cache causes
krbcc32s.exe to be spawned. This process never terminates.
This patch tests for interactive logons. If the logon is not
interactive, the Network Provider exits immediately.
ticket: 5493
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19340
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 18:38:26 +0000 (18:38 +0000)]
pull up r19290 from trunk
r19290@cathode-dark-space: jaltman | 2007-03-27 09:46:13 -0400
ticket: new
subject: WIX installer stores WinLogon event handler under wrong registry value
tags: pullup
component: windows
The WinLogon event handler in prior versions of the Wix installer
has been installing the event handler under the registry value "KFWLogon"
which happens to be the name that "OpenAFS" also uses for its Kerberos
logon events. The KFW NSIS installer has used "MIT_KFW" in order to
avoid the conflict. The Wix installer is being corrected to match.
When there is a name collision, only one of the event handlers gets
installed. As a result, Kerberos FILE ccaches get created with SYSTEM
only ACLs and are never destroyed. This is the same problem that
happens on Windows Vista when integrated logon is used because the
event handler hooks do not exist.
ticket: 5491
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19339
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 03:09:27 +0000 (03:09 +0000)]
pull up r19238 from trunk
r19238@cathode-dark-space: jaltman | 2007-03-20 16:41:52 -0400
ticket: new
subject: NIM: New Default View and miscellaneous fixes
component: windows
================================
KfW 3.1 Alpha (NetIDMgr 1.1.11.0)
-- nidmgr32.dll
- Only one action in a menu is allowed to have KHUI_ACTIONREF_DEFAULT
flag set. This marks the action as being the default action for the
menu and will be rendered as such.
- Newly created identities start off with the KCDB_IDENT_FLAG_EMPTY
flag set. Once credentials are associated with the identity and the
identity is refreshed, the flag will be cleared.
- When creating actions, enforce the name length.
- khm_value_exists() now handles shadowed configuration spaces.
- Add new action KHUI_ACTION_LAYOUT_MINI which toggles between
'Advanced' and 'Basic' views.
- Add support for F11 and F12 keys in khui_get_cmd_accel_string().
- New option for alerts to indicate that instead of just setting the
response field in the alert, the UI should dispatch the command
that the user has selected.
-- krb5common.obj
- khm_krb5_initialize() can return a handle to a krb5_ccache that has
already been closed. Now it doesn't.
- Also import 'krb5_string_to_deltat()'.
- Work around conditioned symbol definitions in ntsecapi.h in the
Vista Platform SDK that affect Win 2000.
-- krb5cred.dll
- Don't clear the prompts when the options for an identity changes.
The prompter code relies on the prompts being around so that the
values that the user has entered can be retained if the new set of
prompts is the same as the old one.
- Use the same code in the new credentials acquisition and the
identity configuration code to obtain krb5 parameters for an
identity.
- Reset the 'IMPORTED' flag when we get new credentials using a
password.
- If the validity of a principal is not known, then we restrict the
options that can be specified when calling
krb5_get_init_creds_password() so that we can reliably determine if
the principal is valid. If we need to get new credentials for the
principal, we need to make another call using the correct options.
- The return codes from the prompter need to indicate that the
password read operation was cancelled instead of arbiraty non-zero
values.
- When reading identity settings, if a particular setting is not
defined in the registry, then default to reading the settings out of
krb5.ini.
- Refer to credentials as 'credentials' or 'tickets' instead of
'creds'.
- If an identity has imported credentials, don't import for the same
identity again.
- When importing an identity, create the identity configuration in the
registry if we don't already have any settings there.
- Work around conditioned symbol definitions in ntsecapi.h in the
Vista Platform SDK that affect Win 2000.
- Rearrange declarations for clarity.
- Use the correct APIs to parse configuration values from krb5.ini.
-- krb4cred.dll
- The dialog layout was updated to accomodate a localized string that
no longer fit in its control.
- Remove a spurious inclusion of ntsecapi.h and work around
conditioned symbol definition in the Vista Platform SDK.
-- netidmgr.exe
- Fix the menu creation code to correctly tag the default action so
that it will be rendered properly.
- Update the menu enumeration code to use documented functions instead
of accessing acton lists directly.
- Pool of per-identity actions now include a set of actions for
obtaining credentials for specific identities.
- The default action performed when the notification icon is clicked
is now configurable. When displaying the context menu in the
notification area, the default action is highlighted.
- Remove unnecessary handlers from the notifcation event handler.
- Only handle NIN_SELECT instead of both NIN_SELECT and WM_LBUTTONUP
in the notification event handler. When the user clicks the
notication icon, both events are generated. NIN_SELECT is canonical.
- When the handling NIN_BALLOONUSERCLICK in the notification event
handler, reset balloon_alert before displaying any new alerts so
that we won't overwrite it later.
- Reset the notification alert icon after displaying an alert.
- If a renewal fails, the displayed alert contains a button that the
user can click to initiate the process of acquiring new credentials
for the identity.
- Alerts can optionally dispatch the commands that were added to it
using the KHUI_ALERT_FLAG_DISPATCH_CMD flag.
- Increase the size of the About dialog.
- Correct the action text for the IDS_ACTION_OPEN_APP and
IDS_ACTION_CLOSE_APP to say 'Show' and 'Hide' instead of 'Open' and
'Close'. These actions only control the visible state of the NIM
window.
- Add additional notification which signals that the commandline has
finished processing.
- Add an 'acquire' action to the per-identity actions.
- The per identity actions (renew, destroy, acquire) now have useful
captions, names and tooltips.
- Use WM_NEXTDLGCTL message when changing the focus of dialog
controls. SetFocus() is insufficient.
- If we get a request to show a new credential acquisition dialog and
we are already showing one, bring that one to the foreground instead
of trying to display a new one or waiting quietly.
- New configuration schema for the UI that include definitions for the
new default view.
- The alerter window can now show more than one alert at once.
- If we are about to show queued alerts, then check if the alerts that
are waiting are related and if they can be grouped together. If so,
show them in a single alert window instead of multiple ones.
- If new alerts are issued while a set of alerts are being displayed
and if the new alert is related to the alerts that are being
displayed, then add the new alert to the list being displayed.
- Make sure we have a lock on the alert when we are manipulating or
accessing it.
- Set the focus to the correct control when displaying an alert.
- When adding alerts from the alert queue, make sure we iterate
through the queue properly.
- Allow keyboard navigation inside the alert window and support scroll
bars.
- Check if we have a valid code pointer before invoking a UI callback.
- Make sure the main window is in the normal configuration before
switching to a layout that rquires it.
- When moving the main window around, if it comes close to an edge of
the working area of the display, snap to it.
- Maintain two sets of settings for the main window placement. One
for the mini mode and one for the normal mode.
- When processing saved window placement information from the
configuration, handle docking hints which note which edges of the
screen the main window should be adjacent to, if any.
- Switching to the 'Basic' view disables the layout and column
selection menus.
- Position the new credentials dialog above the main window if the
main window is visible.
- The alert that is displayed to indicate that an identity has
expired, now contains a command button that can be used to invoke
the new credentials dialog for that identity.
-- source
- Update the documentation to reflect the change in behavior regarding
KHUI_ACTIONREF_DEFAULT in khui_menu_insert_action() and
khui_menu_insert_paction().
- Remove notes about menu access functions being not thread safe.
This is no longer true.
- Update the documentation for khui_alert_show() to document new
behavior regarding KHUI_ALERT_FLAG_DISPATCH_CMD.
- Update documentation to indicate which KHUI_ALERT_FLAG_* flags are
internal and document the new KHUI_ALERT_FLAG_DISPATCH_CMD flag.
- Augment the queue handling macros to support additional operations.
Also add new tree data structure with an ordered list of children.
- Code reorganization to reuse code for obtaining the caption and
tooltip for a system defined action in netidmgr.exe.
ticket: 5478
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19338
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 03:09:14 +0000 (03:09 +0000)]
pull up r19237 from trunk
r19237@cathode-dark-space: jaltman | 2007-03-20 03:13:18 -0400
ticket: new
subject: Enable Vista support for MSLSA
tags: pullup
The MSLSA: ccache type when used on Windows Vista can take advantage of an ability to write tickets to the LSA credential cache for the current logon session. This is possible due to the addition of the KERB_SUBMIT_TICKET interface.
Also new to Vista is the CACHE_INFO_EX2 interface which permits a much more efficient method of enumerating the contents of the LSA credential cache.
The code to take advantage of these features has been present for more than a year. However, due to the lack of a public SDK that included the necessary data structures the functionality has been disabled. As of this commit, the functionality will be enabled if the version of NTSecAPI.h includes TRUST_ATTRIBUTE_TRUST_USES_AES_KEYS. This is a preprocessor symbol that is new to the Vista SDK.
In order to build with the new Vista functionality when using the XP SP2 SDK, the NTSecAPI.h file from the Vista SDK must be used in place of the version from the XP SP2 SDK.
This commit also addresses the issues associated with the inability to read session keys from a UAC limited process. When UAC limitation is detected by examining the process token elevation level all access to the MSLSA contents is disabled. At some point in the future we can implement an elevated COM service in order to obtain access to the session keys.
ticket: 5477
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19337
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 03:09:02 +0000 (03:09 +0000)]
pull up r19289 from trunk
r19289@cathode-dark-space: jaltman | 2007-03-27 09:37:30 -0400
ticket: 5469
This commit addresses several issues:
(1) The registry key used for activating event reporting to
the Windows application log was wrong. It should be
"NetworkProvider" not "Network Provider"
(2) Event logging of the state of the "Debug" value has been
added so that it is possible to debug the use of event
reporting.
(3) The code no longer performs the pre-kinit operations
if a password was not provided.
(4) A new function KFW_copy_file_cache_to_api_cache() has
been added. This is used instead of
KFW_copy_file_cache_to_default_cache() permitting the
default cache to be MSLSA, FILE, or anything else.
The API cache name will be of the form API:principal
just as is done by Network Identity Manager.
ticket: 5469
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19336
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 03:08:51 +0000 (03:08 +0000)]
pull up r19240 from trunk
r19240@cathode-dark-space: jaltman | 2007-03-21 00:48:09 -0400
ticket: 5469
When using the Vista SDK version of NTSecAPI.h it is necessary
to ensure the _WIN32_WINNT have a value of 0x0501 or greater.
Otherwise, required LSA type declarations are undeclared.
Provide a registry value that can be set to turn on Application
Event log messages for debugging.
HKLM\System\CurrentControlSet\Services\MIT Kerberos\Network Provider
DWORD "Debug"
Ensure that KFW_obtain_user_temp_directory() returns a value on
error.
Correct the declaration of KFW_copy_cache_to_system_file()
to match the prototype.
ticket: 5469
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19335
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 03:08:33 +0000 (03:08 +0000)]
pull up r19221 from trunk
r19221@cathode-dark-space: jaltman | 2007-03-13 02:35:13 -0400
ticket: new
subject: KFW: Vista Integrated Logon
component: windows
On Windows Vista the GINA architecture was removed. As a side
effect the support for the Logon Event Handlers was also removed.
The KFW Integrated Logon functionality relies on the "Logon"
event handler to migrate the user's tickets from a secure FILE:
ccache to an API: ccache so that the tickets will be available
to NetIDMgr and all other Kerberos applications.
This functionality is especially important on Vista for
accounts that are members of the Administrators group because
the User Account Control (UAC) restricts access to the session
keys of all tickets in the MSLSA ccache. The only way for
tickets to be made available to MIT Kerberos applications is
by obtaining them within the Network Provider and pushing them
into the Logon Session.
This patch replaces the missing Logon Event Handler support
with a new exported function "LogonEventHandler" which adheres
to the rundll32.exe specifications. The "LogonEventHandler"
function accepts as input the name of a FILE ccache and moves
the contents into an API: ccache and then deletes the FILE
ccache.
In order for this to work the FILE ccache must be owned by
the account that was used to logon to the current session.
The NPLogonNotify() function must therefore lookup the SID
for the active account, assign an appropriate DACL to the
ccache file, and change the owner. In addition, when Vista
is in use a LogonScript must be constructed that will perform
the call to rundll32.exe.
Other changes include altering the prototype of
KFW_copy_ccache_system_file to accept a filename instead of
the LogonID. This improves the abstraction and allows the
filename to be computed once and passed into multiple
functions from NPLogonNotify().
Many debugging calls were added to assist with implementation.
#define DEBUG 1 at the top of kfwcommon.c when you wish to
build with debugging that generates entries in the Windows
Application Event Viewer.
It is important to note that Integrated Logon attempts to
logon the username within the default realm within the
krb5.ini file using the provided password. This is so
a local machine account name matching the default realm
can obtain Kerberos tickets by synchronizing the password.
ticket: 5469
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19334
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:55:34 +0000 (00:55 +0000)]
pull up r19204 from trunk
r19204@cathode-dark-space: hartmans | 2007-03-02 19:49:58 -0500
Back out windows specific makefile change
ticket: 5457
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19333
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:55:21 +0000 (00:55 +0000)]
pull up r19203 from trunk
r19203@cathode-dark-space: kpkoch | 2007-03-02 16:44:07 -0500
ticket: 5457
subject: More existence tests; path update
tags: pullup
Modify remainder of Makefiles that were sensitive to identity/obj or other cleaned files not being present.
Update util/et/Makefile.in to look for com_err.h in src/include, not src/include/src.
ticket: 5457
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19332
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:55:10 +0000 (00:55 +0000)]
pull up r19202 from trunk
r19202@cathode-dark-space: kpkoch | 2007-03-02 15:42:26 -0500
ticket: new
subject: Test for existence of identity/obj before try to delete files.
tags: pullup
ticket: 5457
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19331
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:54:58 +0000 (00:54 +0000)]
pull up r19190 from trunk
r19190@cathode-dark-space: jaltman | 2007-02-28 02:10:33 -0500
ticket: new
subject: Windows - some apps define ssize_t as a preprocessor symbol
component: krb5-libs
tags: pullup
ticket: 5453
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19330
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:54:36 +0000 (00:54 +0000)]
pull up r19189 from trunk
r19189@cathode-dark-space: jaltman | 2007-02-28 02:01:21 -0500
ticket: new
subject: NIM Improved Alert Management
component: windows
This patch implements the new Alert Management functionality.
Many improvements to avoid race conditions and improve resource
tracking.
ticket: 5452
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19329
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:36:20 +0000 (00:36 +0000)]
pull up r19154 from trunk
r19154@cathode-dark-space: jaltman | 2007-02-12 09:54:28 -0500
ticket: new
subject: hack to permit GetEnvironmentVariable usage without requiring getenv() conversion
tags: pullup
Windows has a major flaw when it comes to the use of getenv/putenv.
getenv/putenv do not modify the actual environment of the process.
Instead, they modify a copy of the environment block at the time the
C Runtime Library was initialized for the current module. In other
words, the C Runtime Library environment block for the executable
is not the same as the C Runtime Library environment block for the
krb5_32.dll library, etc.
This results in problems when a process wants to set the default
ccache name outside the krb5_context. The krb5_context default ccname
disappears when the context is destroyed. gss_acquire_cred() suffers
from the creation and destruction of krb5_contexts and therefore the
krb5_context default ccname cannot be used to set a default ccname.
Instead, the process environment must be used.
In order to modify the process environment, SetEnvironmentVariable()
must be used. However, this does not result in the C Runtime Library
environment blocks being updated. putenv() does not see the definition
of "KRB5CCNAME".
This patch modifies get_os_ccname() for Windows to check
GetEnvironmentVariable() before checking the registry. This hack will
work as long as there is no "KRB5CCNAME" variable in the C Runtime
Library environment block.
The long term solution is to replace all calls to getenv and putenv
with GetEnvironmentVariable/SetEnvironmentVariable for Windows.
ticket: 5437
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19328
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:36:08 +0000 (00:36 +0000)]
pull up r19125 from trunk
r19125@cathode-dark-space: jaltman | 2007-01-30 06:23:59 -0500
ticket: 5419
Conditionalize ssize_t declaration
ticket: 5419
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19327
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:35:56 +0000 (00:35 +0000)]
pull up r19123 from trunk
r19123@cathode-dark-space: jaltman | 2007-01-30 06:17:35 -0500
ticket: new
subject: Microsoft Windows Visual Studio does not define ssize_t
tags: pullup
Microsoft defines size_t but not ssize_t.
Provide a definition in win-mac.h that follows the style
used by Microsoft providing a preprocessor macro
SSIZE_T_DEFINED which can be used for conditional
definition and testing in case Microsoft decides to add
it later.
ticket: 5419
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19326
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:35:43 +0000 (00:35 +0000)]
pull up r19122 from trunk
r19122@cathode-dark-space: jaltman | 2007-01-30 06:02:32 -0500
ticket: new
subject: KFW: 32-bit builds use the pismere krbv4w32.dll library
tags: pullup
Only the 32-bit builds should use the pismere krbv4w32.dll
library. Pismere does not provide 64-bit support.
ticket: 5418
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19325
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:35:31 +0000 (00:35 +0000)]
pull up r19124 from trunk
r19124@cathode-dark-space: jaltman | 2007-01-30 06:22:45 -0500
ticket: 5414
The fix for the command line race conditions
broke the ability to cancel and restart the
Obtain New Credentials dialog
ticket: 5414
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19324
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:35:18 +0000 (00:35 +0000)]
pull up r19110 from trunk
r19110@cathode-dark-space: jaltman | 2007-01-23 19:09:13 -0500
ticket: new
subject: NIM Bug Fixes
component: windows
Document User Interface Callbacks
Fix a race condition when performing renewal actions
triggered by command line parameters.
When importing credentials, kickoff a renewal after
the credentials after the API: ccache is created.
Another fix for identity expiration states. This one
fixes the behavior of the system tray icon.
ticket: 5414
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19323
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:35:04 +0000 (00:35 +0000)]
pull up r19078 from trunk
r19078@cathode-dark-space: jaltman | 2007-01-20 00:50:41 -0500
ticket: new
subject: KFW MSI installer corrections
tags: pullup
component: windows
Add missing registry keys and values for
Network Identity Manager plug-ins.
Correct short names.
ticket: 5409
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19322
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:34:52 +0000 (00:34 +0000)]
pull up r19101 from trunk
r19101@cathode-dark-space: jaltman | 2007-01-20 17:21:13 -0500
ticket: 5408
small fixes
ticket: 5408
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19321
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:34:40 +0000 (00:34 +0000)]
pull up r19100 from trunk
r19100@cathode-dark-space: jaltman | 2007-01-20 16:10:10 -0500
ticket: 5408
Move files to their correct location
ticket: 5408
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19320
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:34:24 +0000 (00:34 +0000)]
pull up r19077 from trunk
r19077@cathode-dark-space: jaltman | 2007-01-20 00:42:30 -0500
ticket: new
subject: NIM - Context sensitive system tray menu and more
component: windows
Adds context sensitive menus for renew and destroy
to the system tray menu. Select either all identities
or one of the identities with credentials.
Increases the API to 1.1.9 and adds a new interactive
callback mechanism.
ticket: 5408
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19319
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:34:11 +0000 (00:34 +0000)]
pull up r19069 from trunk
r19069@cathode-dark-space: jaltman | 2007-01-18 07:43:58 -0500
ticket: new
subject: NIM Kerberos 5 Provider corrections
tags: pullup
component: windows
When validating a Kerberos 5 principal name, the request
to the KDC should not request forwardable, renewable, or
proxiable options as these may be blocked by policy and
will result in the return of an error.
Always treat the Kerberos 5 principal name as valid
unless the KDC returns an error that clearly indicates that
the principal name does not exist.
Use a MEMORY: ccache for temporary storage instead of an
API: ccache.
Initialize pointer values with NULL instead of 0.
ticket: 5400
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19318
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:33:58 +0000 (00:33 +0000)]
pull up r19068 from trunk
r19068@cathode-dark-space: jaltman | 2007-01-18 07:39:06 -0500
ticket: new
subject: NIM Correct Visual Identity Expiration Status
tags: pullup
component: windows
The visual status for the identities in NIM 1.1 was based
upon the highest alert status of any credential that was
associated with the identity. The correct behavior that is
now implemented is that the identity status should be based
solely upon the expiration state of the credentials obtained
by the identity provider.
For example, the Kerberos v5 identity provider will based the
identity expiration status on the initial TGT. Service tickets
with short lifetimes that expire do not prevent the acquisition
of additional service tickets. Therefore, the identity should
not be listed as expired.
ticket: 5399
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19317
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:33:45 +0000 (00:33 +0000)]
pull up r19067 from trunk
r19067@cathode-dark-space: jaltman | 2007-01-18 07:33:47 -0500
ticket: new
subject: NIM Kerberos v4 configuration dialog
tags: pullup
The Kerberos v4 options for individual identities
was never wired. The controls were visible but they
did not do anything. Implement them now for NIM 1.2.
ticket: 5398
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19316
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:33:32 +0000 (00:33 +0000)]
pull up r19066 from trunk
r19066@cathode-dark-space: jaltman | 2007-01-18 07:31:23 -0500
ticket: new
subject: NIM string tables
tags: pullup
Update the string tables for NIM so that they are consistent.
Always use "Kerberos v5" or "Kerberos v4". Refer to credentials
instead of tickets. Do not abbreviate "Network Identity Manager".
Etc.
ticket: 5397
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19315
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:33:19 +0000 (00:33 +0000)]
pull up r19061 from trunk
r19061@cathode-dark-space: jaltman | 2007-01-14 03:04:46 -0500
ticket: new
subject: kfw wix installer - memory overwrite error
tags: pullup
component: windows
The custom handler allocates a buffer that is smaller
than is required to hold the input. Allocate the correct
sized buffer.
ticket: 5353
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19314
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:33:07 +0000 (00:33 +0000)]
pull up r19060 from trunk
r19060@cathode-dark-space: jaltman | 2007-01-13 12:08:28 -0500
ticket: new
component: windows
tags: pullup
subject: Update to KFW NSIS installer
Update copyright date, samples directory, and shortcut
to NetIDMgr documentation
ticket: 5344
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19313
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Fri, 30 Mar 2007 00:32:53 +0000 (00:32 +0000)]
pull up r19059 from trunk
r19059@cathode-dark-space: jaltman | 2007-01-13 12:04:44 -0500
ticket: new
subject: updated Windows README
tags: pullup
component: windows
Revise the readme text for Windows. Remove references
to old beta SDKs.
ticket: 5343
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19312
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 29 Mar 2007 21:36:50 +0000 (21:36 +0000)]
pull up r19208 from trunk
r19208@cathode-dark-space: raeburn | 2007-03-05 18:51:22 -0500
ticket: new
subject: osf1: get proper library dependencies installed
target_version: 1.6.1
tags: pullup
The LDCOMBINE setting for Tru64 left out $(CFLAGS), which meant the
-pthread option wasn't being passed in, so the libraries didn't
indicate a dependency on the pthread library despite the fact that we
need it unconditionally (if thread support is enabled). Including
$(CFLAGS) should fix this.
Our own binaries get linked with -pthread anyways, so they build okay,
but other binaries trying to link against or load our libraries could
have problems.
ticket: 5458
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19311
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 29 Mar 2007 21:36:38 +0000 (21:36 +0000)]
pull up r19196 from trunk
r19196@cathode-dark-space: raeburn | 2007-02-28 21:19:41 -0500
ticket: new
target_version: 1.6.1
tags: pullup
subject: valgrind detects uninitialized (but really unused) bytes in 'queue'
The gsstest program exports a GSSAPI security context to a blob in
memory, writes that memory to a file, and reads it back to use it.
Under valgrind, the writing phase triggers a warning about
uninitialized storage.
The "queue" structure as implemented in generic/util_ordering.c holds
an array of values, some of which may never be initialized. As far as
I can tell, those uninitialized values are never used before being
initialized, either, but valgrind doesn't know that.
This patch zaps the structure contents (including the array) before
using the queue object.
ticket: 5455
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19310
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 29 Mar 2007 21:36:26 +0000 (21:36 +0000)]
pull up r19039 from trunk
r19039@cathode-dark-space: raeburn | 2007-01-08 17:51:23 -0500
ticket: new
subject: create KDC database directory
The default directory for the KDC database files doesn't exist after a
normal "make install". Reported by Jeff Blaine.
* Makefile.in (INSTALLMKDIRS): Add var (really localstatedir) and var/krb5kdc
to directories to be created at "make install" time, even though it'll be
empty on most machines (since most probably aren't KDCs).
ticket: 5294
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19309
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 29 Mar 2007 21:36:12 +0000 (21:36 +0000)]
pull up r19038 from trunk
r19038@cathode-dark-space: raeburn | 2007-01-08 17:41:01 -0500
ticket: new
subject: crash creating db2 database in non-existent directory
* kdb_db2.c (krb5_db2_db_create): If the creation of the first database file
fails, return the error, instead of attempting to create the second (and using
a null pointer as an input string in formatting a filename).
Reported by Jeff Blaine.
ticket: 5293
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19308
dc483132-0cff-0310-8789-
dd5450dbe970
Alexandra Ellwood [Mon, 19 Mar 2007 21:17:02 +0000 (21:17 +0000)]
pullup from trunk
------------------------------------------------------------------------
r19235 | lxs | 2007-03-19 16:21:54 -0400 (Mon, 19 Mar 2007) | 9 lines
ticket: new
target_version: 1.6.1
tags: pullup
subject: Zero sockaddrs in fai_add_entry() so we can compare them with memcmp()
If we don't zero the struct sockaddrs in fai_add_entry() then any sin_zero
fields will be left as random memory and the memcmp() will return that the
addresses are different even if they aren't.
------------------------------------------------------------------------
ticket: 5476
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19236
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 10 Mar 2007 04:10:59 +0000 (04:10 +0000)]
Back out changes accidentally made to branch instead of trunk
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19220
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 10 Mar 2007 03:56:06 +0000 (03:56 +0000)]
Simple signed/unsigned fixes
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19219
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 10 Mar 2007 03:55:03 +0000 (03:55 +0000)]
Simple signed/unsigned fixes
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19218
dc483132-0cff-0310-8789-
dd5450dbe970
Ken Raeburn [Sat, 10 Mar 2007 03:54:08 +0000 (03:54 +0000)]
Need stdio.h to print no-krb4 warning
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19217
dc483132-0cff-0310-8789-
dd5450dbe970
Tom Yu [Thu, 1 Mar 2007 20:29:57 +0000 (20:29 +0000)]
pull up r19195 from trunk
r19195@cathode-dark-space: jaltman | 2007-02-28 20:49:11 -0500
ticket: new
subject: krb5_get_cred_from_kdc fails to null terminate the tgt list
tags: pullup
if the next tgt in a cross-realm traversal cannot be
obtained find_nxt_kdc() was calling krb5_free_creds()
on the last tgt in the list but was failing to nullify
the pointer to the cred that was just freed.
if there were no additional tgts obtained,
krb5_get_cred_from_kdc() would return a non-NULL terminated
cred list to the caller. This would result in a crash
when attempting to manipulate the non-existent cred past
the end of the list.
This commit nullifies the credential pointer in
find_nxt_kdc() after the call to krb5_free_creds()
ticket: 5454
version_fixed: 1.6.1
git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@19197
dc483132-0cff-0310-8789-
dd5450dbe970