krb5.git
16 years agoRemoved useless init and cleanup functions.
Alexandra Ellwood [Mon, 29 Sep 2008 05:21:46 +0000 (05:21 +0000)]
Removed useless init and cleanup functions.
Fixed request port list handling.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20778 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIf in_identity is NULL, use the identity the user entered.
Alexandra Ellwood [Mon, 29 Sep 2008 05:20:22 +0000 (05:20 +0000)]
If in_identity is NULL, use the identity the user entered.
(Fixed typo)

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20777 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFixed KerberosAgent plists so it is loading the correct server and
Alexandra Ellwood [Mon, 29 Sep 2008 05:19:37 +0000 (05:19 +0000)]
Fixed KerberosAgent plists so it is loading the correct server and
so they are both in plist format.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20776 dc483132-0cff-0310-8789-dd5450dbe970

16 years agokim_credential_create_new should support NULL in_identity.
Alexandra Ellwood [Mon, 29 Sep 2008 02:40:24 +0000 (02:40 +0000)]
kim_credential_create_new should support NULL in_identity.
Prompt for it.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20775 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoActually make [Identity -componentsString] use kim_identity_get_components_string
Justin Anderson [Sun, 28 Sep 2008 23:51:09 +0000 (23:51 +0000)]
Actually make [Identity -componentsString] use kim_identity_get_components_string

Also, better error handling in Identity and Identities classes.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20774 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoPlace structure in thread specific data to store client connection
Alexandra Ellwood [Sun, 28 Sep 2008 23:39:25 +0000 (23:39 +0000)]
Place structure in thread specific data to store client connection
port so that multiple services can be supported simultaneously.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20773 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMake [Identity -componentsString] use kim_identity_get_components_string
Justin Anderson [Sun, 28 Sep 2008 22:38:20 +0000 (22:38 +0000)]
Make [Identity -componentsString] use kim_identity_get_components_string

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20772 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFlesh out KerberosAgent Select Identity dialog. Can now add, edit, and remove favorit...
Justin Anderson [Sun, 28 Sep 2008 22:16:09 +0000 (22:16 +0000)]
Flesh out KerberosAgent Select Identity dialog. Can now add, edit, and remove favorite identities

Also, make formatters in KerberosFormatters.[hm] localizable.

Still need to add principal validation and prevent duplicates.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20771 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdded kim_selection_hints_create_from_stream and
Alexandra Ellwood [Sun, 28 Sep 2008 20:53:12 +0000 (20:53 +0000)]
Added kim_selection_hints_create_from_stream and
kim_selection_hints_write_to_stream for client/server
communication.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20770 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoCreate common stream and ipc layer for CCAPI and KIM.
Alexandra Ellwood [Sun, 28 Sep 2008 19:43:47 +0000 (19:43 +0000)]
Create common stream and ipc layer for CCAPI and KIM.
Will switch CCAPI to this new code later though, so as
not to destabilize KfM and the Windows builds.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20769 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMake kim_credential_get_options set correct renewal lifetime
Justin Anderson [Sun, 28 Sep 2008 03:59:55 +0000 (03:59 +0000)]
Make kim_credential_get_options set correct renewal lifetime

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20768 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdded launchd plist file for KerberosAgent
Alexandra Ellwood [Sat, 27 Sep 2008 23:14:40 +0000 (23:14 +0000)]
Added launchd plist file for KerberosAgent

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20767 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRenamed kim_identity_get_components to kim_identity_get_components_string
Alexandra Ellwood [Sat, 27 Sep 2008 21:31:06 +0000 (21:31 +0000)]
Renamed kim_identity_get_components to kim_identity_get_components_string
to better reflect what it does (a string of everything but the realm, not
an array of components like the old name might imply).

Added private functions which will be used by KLL to shim on top of KIM.
Private functions also reduce memory allocations inside of KIM.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20766 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdd kim_preferences_get/set_minimum/maximum_lifetime functions to export lists
Justin Anderson [Sat, 27 Sep 2008 19:22:10 +0000 (19:22 +0000)]
Add kim_preferences_get/set_minimum/maximum_lifetime functions to export lists

ticket:6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20765 dc483132-0cff-0310-8789-dd5450dbe970

16 years agokim_credential_get_options was setting the lifetime a second time instead of setting...
Justin Anderson [Sat, 27 Sep 2008 19:18:48 +0000 (19:18 +0000)]
kim_credential_get_options was setting the lifetime a second time instead of setting the renewal lifetime

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20764 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKerberosAgent MachIPC support
Alexandra Ellwood [Sat, 27 Sep 2008 00:46:39 +0000 (00:46 +0000)]
KerberosAgent MachIPC support

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20763 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoC90 compliance
Alexandra Ellwood [Sat, 27 Sep 2008 00:44:39 +0000 (00:44 +0000)]
C90 compliance

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20762 dc483132-0cff-0310-8789-dd5450dbe970

16 years agokim_options_set_service_name should be able to take a service name of NULL
Alexandra Ellwood [Fri, 26 Sep 2008 20:49:23 +0000 (20:49 +0000)]
kim_options_set_service_name should be able to take a service name of NULL

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20761 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdded kim_credential_get_options and kim_ccache_get_options
Alexandra Ellwood [Fri, 26 Sep 2008 18:56:51 +0000 (18:56 +0000)]
Added kim_credential_get_options and kim_ccache_get_options
for KerberosAgent to use to create new favorite identities

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20760 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRemoved argument from kipc_client_lookup_server
Alexandra Ellwood [Fri, 26 Sep 2008 14:13:32 +0000 (14:13 +0000)]
Removed argument from kipc_client_lookup_server

Removed unused application path argument from kipc_client_lookup_server

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20759 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRemoved application name setting function from kim_selection_hints headers
Alexandra Ellwood [Fri, 26 Sep 2008 14:08:36 +0000 (14:08 +0000)]
Removed application name setting function from kim_selection_hints headers

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20758 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoInitial checkin of Mac OS X ipc support.
Alexandra Ellwood [Fri, 26 Sep 2008 14:05:55 +0000 (14:05 +0000)]
Initial checkin of Mac OS X ipc support.
Also moved "set application name" functionality to kim_library_
because most applications do not need to call it and their name
doesn't usually change over time or per thread By putting it
in a global setting apps that do need to call it only have to
call it once instead of every time they want to authenticate.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20757 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdd test for recently fixed kim_preferences_remove_favorite_identity bug
Justin Anderson [Thu, 25 Sep 2008 21:17:59 +0000 (21:17 +0000)]
Add test for recently fixed kim_preferences_remove_favorite_identity bug

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20756 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUpdate kim_test to use new error string function
Justin Anderson [Thu, 25 Sep 2008 21:15:40 +0000 (21:15 +0000)]
Update kim_test to use new error string function

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20755 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFixed a typo in kim_preferences.c which prevented
Alexandra Ellwood [Thu, 25 Sep 2008 20:29:34 +0000 (20:29 +0000)]
Fixed a typo in kim_preferences.c which prevented
the fix to kim_preferences_remove_favorite_identity
from working.

(Accidentally tested in one source tree and committed
from another.  whoops.)

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20754 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFixed a bug where kim_preferences_remove_favorite_identity
Alexandra Ellwood [Thu, 25 Sep 2008 20:25:40 +0000 (20:25 +0000)]
Fixed a bug where kim_preferences_remove_favorite_identity
was removing the first identity which did not match the one
being passed in.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20753 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdded support to track number of prompts so UIs do not try again unless
Alexandra Ellwood [Thu, 25 Sep 2008 19:53:18 +0000 (19:53 +0000)]
Added support to track number of prompts so UIs do not try again unless
there is something the user can do differently the next time.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20752 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoModified kim_ccache_compare to match the behavior of other kim compare
Alexandra Ellwood [Thu, 25 Sep 2008 17:47:07 +0000 (17:47 +0000)]
Modified kim_ccache_compare to match the behavior of other kim compare
functions.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20751 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRemoved prototype with no implementation
Alexandra Ellwood [Thu, 25 Sep 2008 06:27:21 +0000 (06:27 +0000)]
Removed prototype with no implementation

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20750 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFixed bugs in command line change password support.
Alexandra Ellwood [Wed, 24 Sep 2008 22:11:20 +0000 (22:11 +0000)]
Fixed bugs in command line change password support.
Removed low level change password functions from export list
because they require a UI context.
Added kim_ccache functions needed by klist to export list.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20749 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKIM Identity selection dialog work. Updated to match changes to KIM API
Justin Anderson [Tue, 23 Sep 2008 22:20:04 +0000 (22:20 +0000)]
KIM Identity selection dialog work. Updated to match changes to KIM API

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20748 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRenamed error handling files to reflect what they do now.
Alexandra Ellwood [Tue, 23 Sep 2008 21:46:12 +0000 (21:46 +0000)]
Renamed error handling files to reflect what they do now.
Moved GUI code into OS-specific directory.
Fixed bugs in cache collection iterator routines where it was mishandling
the magic empty ccache created when the cache collection is empty.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20747 dc483132-0cff-0310-8789-dd5450dbe970

16 years agokim_ccache_get_display_name was calling kim_ccache_create_resolve_name with its param...
Justin Anderson [Tue, 23 Sep 2008 19:40:52 +0000 (19:40 +0000)]
kim_ccache_get_display_name was calling kim_ccache_create_resolve_name with its parameters in the wrong order

kim_ccache_iterator_next wasn't handling the end of iteration correctly.

ticket:6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20746 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdded command line UI support.
Alexandra Ellwood [Mon, 22 Sep 2008 22:13:06 +0000 (22:13 +0000)]
Added command line UI support.
Added change password and acquire credentials UI harness support.
API changes to the change password support to reflect these changes.
Removed callback prompter interfaces since there is now plugin support.
Updated documentation.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20745 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMerge three patches from Novell, with some updates related to work in
Ken Raeburn [Mon, 22 Sep 2008 18:17:38 +0000 (18:17 +0000)]
Merge three patches from Novell, with some updates related to work in
our tree since they were submitted, and reindenting for one source
file that got particularly ugly in the process.

From Savitha R on 2008-02-18 (yes, it was sitting in my queue a while):

Attached patches have fixes for some issues in LDAP backend.

1. patch-mem-pwd.txt
This patch clears the password in memory, fixes some memory leaks (in
common code) and a segfault in eDirectory specific code.

2. patch-princ-attrs.txt
This patch removes some eDirectory specific attributes from the common
code

3. patch-edir-rights.txt
This patch is specific to eDirectory code and fixes some rights issue.
It adds and deletes rights to service objects as required on the kerberos
attributes.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20744 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMerge 1.7 work on auxiliary ccache functions necessary for KIM. Adds krb5_cc_lock...
Justin Anderson [Mon, 22 Sep 2008 17:03:51 +0000 (17:03 +0000)]
Merge 1.7 work on auxiliary ccache functions necessary for KIM. Adds krb5_cc_lock/unlock, krb5_cccol_lock/unlock, krb5_cc_last_change_time, krb5_cccol_last_change_time, krb5_cc_move, and adds pertype cursor support to some cache types

Locking functions work the same as the CCAPI cc_ccache_lock / cc_context_lock functions, though not as read/write locks.

ticket: 6124
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20743 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMissed some changes for db_context->dal_handle renaming
Ken Raeburn [Mon, 22 Sep 2008 16:01:03 +0000 (16:01 +0000)]
Missed some changes for db_context->dal_handle renaming

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20742 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKIM ui plugin support and gui selection harness
Alexandra Ellwood [Fri, 19 Sep 2008 21:51:03 +0000 (21:51 +0000)]
KIM ui plugin support and gui selection harness

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20740 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRemove kim_identity_get_gss_name from the export lists
Alexandra Ellwood [Fri, 19 Sep 2008 21:03:11 +0000 (21:03 +0000)]
Remove kim_identity_get_gss_name from the export lists

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20739 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdded functions to save and get password from keychain
Alexandra Ellwood [Thu, 18 Sep 2008 18:57:01 +0000 (18:57 +0000)]
Added functions to save and get password from keychain

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20732 dc483132-0cff-0310-8789-dd5450dbe970

16 years agomakedepend
Ken Raeburn [Thu, 18 Sep 2008 15:57:27 +0000 (15:57 +0000)]
makedepend

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20731 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIf unset env(KRB5CCNAME) doesn't work, skip the tests that depend on it
Ken Raeburn [Thu, 18 Sep 2008 15:42:34 +0000 (15:42 +0000)]
If unset env(KRB5CCNAME) doesn't work, skip the tests that depend on it

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20730 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRemoved kim_identity_get_gss_name and updated documentation
Alexandra Ellwood [Thu, 18 Sep 2008 14:56:49 +0000 (14:56 +0000)]
Removed kim_identity_get_gss_name and updated documentation

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20729 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdded tentative plugin API for KIM UI
Alexandra Ellwood [Wed, 17 Sep 2008 21:30:54 +0000 (21:30 +0000)]
Added tentative plugin API for KIM UI

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20728 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdded support for options in favorite identities.
Alexandra Ellwood [Wed, 17 Sep 2008 21:29:35 +0000 (21:29 +0000)]
Added support for options in favorite identities.
Fixed KLL preference reading support to not read keys
from the wrong locations.  Updated prompter function
prototype.

Updated tests to reflect these changes.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20727 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFixed KIM export list for KerberosLite (forgot there were two)
Alexandra Ellwood [Fri, 12 Sep 2008 22:38:21 +0000 (22:38 +0000)]
Fixed KIM export list for KerberosLite (forgot there were two)

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20713 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRemoved favorite identities object from public API and merged functionality
Alexandra Ellwood [Thu, 11 Sep 2008 21:30:10 +0000 (21:30 +0000)]
Removed favorite identities object from public API and merged functionality
into the preferences API to reduce function calls.  Added options parameter
to favorite identities (Mac OS X support still needed for options though).

Updated test cases to reflect these changes.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20712 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUntabify; trim trailing whitespace; add emacs local variables to avoid tabs
Ken Raeburn [Tue, 9 Sep 2008 21:23:35 +0000 (21:23 +0000)]
Untabify; trim trailing whitespace; add emacs local variables to avoid tabs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20711 dc483132-0cff-0310-8789-dd5450dbe970

16 years agowhitespace
Ken Raeburn [Mon, 8 Sep 2008 21:53:21 +0000 (21:53 +0000)]
whitespace

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20710 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUse krb5 threading functions.
Alexandra Ellwood [Mon, 8 Sep 2008 21:21:51 +0000 (21:21 +0000)]
Use krb5 threading functions.
Remove use of ECODE since errors are no longer objects.
Fixed bug where bundle error strings were not returned when
homedir access was off.
Switched to using UTF8 unconditionally.

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20709 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUse braces to repair broken emacs indentation, caused by omission of a
Ken Raeburn [Fri, 5 Sep 2008 20:46:44 +0000 (20:46 +0000)]
Use braces to repair broken emacs indentation, caused by omission of a
semicolon, caused by use of macros that expand to compound statements.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20708 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoWhitespace changes, mostly horizontal, for consistency with current
Ken Raeburn [Fri, 5 Sep 2008 20:39:19 +0000 (20:39 +0000)]
Whitespace changes, mostly horizontal, for consistency with current
style: indentation levels, spacing around if/else/for/while and
braces.  Still plenty of inconsistency with current coding standards,
especially for when line breaks are to be used.  Didn't touch
multi-line macro definitions, or .h function declarations.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20707 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoCCAPI should only use one pthread key
Alexandra Ellwood [Thu, 4 Sep 2008 18:43:14 +0000 (18:43 +0000)]
CCAPI should only use one pthread key

Use k5 thread functions.  Also add destructors so if we ever have a way
to detect application exit that the pthread key is destroyed.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20705 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUse GSS_S_BAD_STATUS for unknown status codes
Ken Raeburn [Wed, 3 Sep 2008 17:22:58 +0000 (17:22 +0000)]
Use GSS_S_BAD_STATUS for unknown status codes

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20704 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFix vasprintf signed/unsigned mix; separate out duplicated error paths; pull success...
Ken Raeburn [Fri, 29 Aug 2008 17:42:20 +0000 (17:42 +0000)]
Fix vasprintf signed/unsigned mix; separate out duplicated error paths; pull success return path out of guts of loop

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20703 dc483132-0cff-0310-8789-dd5450dbe970

16 years agofix resource leak in USE_PASSWORD_SERVER code
Ken Raeburn [Thu, 28 Aug 2008 18:11:50 +0000 (18:11 +0000)]
fix resource leak in USE_PASSWORD_SERVER code

Don't leak file descriptors in error cases.
Remove limit from length of passwords.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20702 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFix resource leak
Ken Raeburn [Thu, 28 Aug 2008 17:17:51 +0000 (17:17 +0000)]
Fix resource leak

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20701 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdditional code for KerberosAgent. Checking in so Justin can work on it
Alexandra Ellwood [Thu, 28 Aug 2008 16:37:34 +0000 (16:37 +0000)]
Additional code for KerberosAgent.  Checking in so Justin can work on it

ticket: 6055

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20700 dc483132-0cff-0310-8789-dd5450dbe970

16 years agocompile-time flag to disable iprop
Ken Raeburn [Wed, 27 Aug 2008 22:31:57 +0000 (22:31 +0000)]
compile-time flag to disable iprop

If DISABLE_IPROP is defined at compile time, don't listen for
connections and don't register the service.  (Doesn't currently
disable compilation of all of the code.)

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20699 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoSome helper rules for running Coverity Prevent
Ken Raeburn [Wed, 27 Aug 2008 16:45:55 +0000 (16:45 +0000)]
Some helper rules for running Coverity Prevent

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20698 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoBased on patch from lxs, with some changes:
Ken Raeburn [Wed, 27 Aug 2008 16:36:00 +0000 (16:36 +0000)]
Based on patch from lxs, with some changes:

Add several new gcc warning flags, used in the KfM build process.

Put declarations before code.

Fix a bunch of signed/unsigned type mixes, mostly by changing variable
types to unsigned int.

Fix constness in handling name of default ccache name.

Make sure functions get declared with prototypes:
krb5int_pthread_loaded krb5int_gmt_mktime krb5int_aes_encrypt
krb5int_aes_decrypt gssint_mecherrmap_init gssint_mecherramp_get.

Don't shadow global names: stat accept index open encrypt.  Fix
variable shadowing in LDAP ASN.1 support.

Don't define unused krb5int_local_addresses.
Don't export internal krb5_change_set_password.
Fix error return indications from gssint_oid_to_mech.

Create and use k5-gmt_mktime.h to provide one global declaration of
krb5int_gmt_mktime, needed before we've generated krb5.h on some
platforms.

Not incorporated from initial patch: const changes in function
signatures.

ticket: 6096
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20697 dc483132-0cff-0310-8789-dd5450dbe970

16 years ago r820@NOME-KING: raeburn | 2008-08-26 18:37:41 -0400
Ken Raeburn [Wed, 27 Aug 2008 00:21:53 +0000 (00:21 +0000)]
 r820@NOME-KING:  raeburn | 2008-08-26 18:37:41 -0400
 x
 r821@NOME-KING:  raeburn | 2008-08-26 18:51:10 -0400
 Remove disabled statistics gathering support.
 r822@NOME-KING:  raeburn | 2008-08-26 18:57:20 -0400
 Remove source location tracking.
 r823@NOME-KING:  raeburn | 2008-08-26 19:05:35 -0400
 Delete DEBUG_THREADS code.
 r824@NOME-KING:  raeburn | 2008-08-26 19:18:59 -0400
 Remove now-no-op assertion checks.
 r825@NOME-KING:  raeburn | 2008-08-26 19:29:49 -0400
 Simplify some wrappers.
 r826@NOME-KING:  raeburn | 2008-08-26 19:38:23 -0400
 Remove redundant comment.
 r827@NOME-KING:  raeburn | 2008-08-26 19:49:20 -0400
 When pthreads must be checked for at run time, don't include the no-op _nothread_mutex stuff too.
 r828@NOME-KING:  raeburn | 2008-08-26 19:54:05 -0400
 Remove remaining DEBUG_THREADS bits.
 r829@NOME-KING:  raeburn | 2008-08-26 20:00:22 -0400
 fix up initializer
 r830@NOME-KING:  raeburn | 2008-08-26 20:10:37 -0400
 Flatten a couple of structs wrapping single elements.
 r831@NOME-KING:  raeburn | 2008-08-26 20:14:01 -0400
 Remove k5_pthread_mutex_*lock macros.
 r832@NOME-KING:  raeburn | 2008-08-26 20:19:14 -0400
 Update comments a bit for lack of debug support.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20696 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoChange non-debug version of k5_debug_log to int to silence some
Ken Raeburn [Tue, 26 Aug 2008 19:34:18 +0000 (19:34 +0000)]
Change non-debug version of k5_debug_log to int to silence some
compiler warnings.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20695 dc483132-0cff-0310-8789-dd5450dbe970

16 years agowhitespace
Tom Yu [Tue, 26 Aug 2008 18:05:52 +0000 (18:05 +0000)]
whitespace

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20694 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFix PROG_LIBPATH so in-tree tests work
Tom Yu [Mon, 25 Aug 2008 23:08:16 +0000 (23:08 +0000)]
Fix PROG_LIBPATH so in-tree tests work

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20693 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUpdate description of -k option: From the code it appears the default
Ken Raeburn [Mon, 25 Aug 2008 20:11:19 +0000 (20:11 +0000)]
Update description of -k option: From the code it appears the default
is des-cbc-crc, and it applies to entering passwords with -m.

ticket: 5565

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20692 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIncorporate Apple's patch
Ken Raeburn [Mon, 25 Aug 2008 19:43:03 +0000 (19:43 +0000)]
Incorporate Apple's patch

Add a test authorization data scheme, in both built-in and plugin
forms; built-in version is #ifdef'ed out.  Update configury to create
the build directory for the plugin, but don't build or install it by
default.

Create the new (and normally empty) authorization data plugin
directory at install time.

Add some (normally disabled) code to log authz data from rd_req.

Fix up some comments that still refer to preauth plugins.  Add some
details in comments on the API, and why it's private for now.

Make the plugin init context support work, by not passing null
pointers.

ticket: 5565

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20691 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFix sense of test of lock call preparing to update debug info in
Ken Raeburn [Mon, 25 Aug 2008 17:40:58 +0000 (17:40 +0000)]
Fix sense of test of lock call preparing to update debug info in
k5_mutex_destroy.
Thanks, Ezra.

ticket: 6090

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20690 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoCCAPI is leaking mach ports
Alexandra Ellwood [Fri, 22 Aug 2008 16:44:22 +0000 (16:44 +0000)]
CCAPI is leaking mach ports

Need to destroy the mach ports instead of deallocating because
we requested notifications on the port so just deallocating
won't actually destroy the port.  Also deallocate any port
which was previously registered for notifications.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20688 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoLet walk_realm_tree tests fail for now, ignore them and keep going
Ken Raeburn [Fri, 22 Aug 2008 16:26:28 +0000 (16:26 +0000)]
Let walk_realm_tree tests fail for now, ignore them and keep going

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20687 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUse capaths unconditionally. Update copyright
Ken Raeburn [Fri, 22 Aug 2008 16:25:27 +0000 (16:25 +0000)]
Use capaths unconditionally.  Update copyright

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20686 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoNew macro for testing whether the compiler supports a given
Ken Raeburn [Fri, 22 Aug 2008 15:56:32 +0000 (15:56 +0000)]
New macro for testing whether the compiler supports a given
command-line flag or not, and adding it to CFLAGS only if supported.
Use it for GCC flag -Wno-format-zero-length, which we were testing for
before, and for some additional flags: -Woverflow -Wstrict-overflow
-Wmissing-format-attribute -Werror=declaration-after-statement
-Wdeclaration-after-statement -Werror=variadic-macros
-Wvariadic-macros.  (The last few are because we've had some code
contributions that assumed full C99 support, and our baseline is
currently C89+, so if possible we want certain newer constructs
flagged as errors.)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20685 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoKIM should not provide keytab functions when building lite framework
Alexandra Ellwood [Fri, 22 Aug 2008 15:36:33 +0000 (15:36 +0000)]
KIM should not provide keytab functions when building lite framework

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20684 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUpdated documentation to be more specific about TLS impact
Alexandra Ellwood [Fri, 22 Aug 2008 15:34:46 +0000 (15:34 +0000)]
Updated documentation to be more specific about TLS impact

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20683 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoRemoved warnings of unused variable
Alexandra Ellwood [Fri, 22 Aug 2008 15:34:20 +0000 (15:34 +0000)]
Removed warnings of unused variable

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20682 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoCheck for struct sockaddr_storage only in top-level configure script, not
Ken Raeburn [Fri, 22 Aug 2008 01:20:23 +0000 (01:20 +0000)]
Check for struct sockaddr_storage only in top-level configure script, not
in code common to all.  Use an existing AC_CHECK_TYPES invocation, not a
special-purpose test.  Eliminate now-unused
KRB5_AC_CHECK_TYPE_WITH_HEADERS and KRB5_AC_CHECK_SOCKADDR_STORAGE macros.
Merge KRB5_AC_CHECK_INET6 into the one place where it gets used.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20681 dc483132-0cff-0310-8789-dd5450dbe970

16 years agolean client changes
Zhanna Tsitkov [Wed, 20 Aug 2008 21:09:14 +0000 (21:09 +0000)]
lean client changes

All changes are under LEAN_CLIENT macro. Application server functionality is disabled.

Ticket:new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20680 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdd support to send CFNotifications on ccache and cache collection changes
Alexandra Ellwood [Wed, 20 Aug 2008 18:58:04 +0000 (18:58 +0000)]
Add support to send CFNotifications on ccache and cache collection changes

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20679 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoNotify clients on ccache deletion
Alexandra Ellwood [Wed, 20 Aug 2008 18:46:46 +0000 (18:46 +0000)]
Notify clients on ccache deletion

Clients watching a ccache or the cache collection
should get a notification when the ccache is destroyed.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20678 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoAdded some carriage returns to decrease line length
Alexandra Ellwood [Wed, 20 Aug 2008 17:58:07 +0000 (17:58 +0000)]
Added some carriage returns to decrease line length

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20677 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUpdate krb4 test to use aclocal.m4 macro and default to disabled
Ken Raeburn [Tue, 19 Aug 2008 23:14:41 +0000 (23:14 +0000)]
Update krb4 test to use aclocal.m4 macro and default to disabled

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20676 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFix broken build -- conditionalize some stuff on DISABLE_PKINIT that I
Ken Raeburn [Tue, 19 Aug 2008 23:07:11 +0000 (23:07 +0000)]
Fix broken build -- conditionalize some stuff on DISABLE_PKINIT that I
missed last time.

ticket: 6076

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20675 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoprofile write code should only quote empty strings
Alexandra Ellwood [Tue, 19 Aug 2008 21:04:56 +0000 (21:04 +0000)]
profile write code should only quote empty strings

Assigned to Ken for review.

ticket: new
owner: raeburn

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20674 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoGet KerberosAgent building again after KIM changes
Alexandra Ellwood [Tue, 19 Aug 2008 20:09:22 +0000 (20:09 +0000)]
Get KerberosAgent building again after KIM changes

ticket: 6055
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20673 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoDefault to not building krb4 support
Ken Raeburn [Tue, 19 Aug 2008 19:37:16 +0000 (19:37 +0000)]
Default to not building krb4 support

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20672 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoFixed export list for new hints functions
Alexandra Ellwood [Tue, 19 Aug 2008 16:49:18 +0000 (16:49 +0000)]
Fixed export list for new hints functions
and fixed calls to set error message.

ticket: 6055
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20671 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoModified hints APIs to be a single API that takes string keys.
Alexandra Ellwood [Tue, 19 Aug 2008 16:43:17 +0000 (16:43 +0000)]
Modified hints APIs to be a single API that takes string keys.
Removed error object.
Changed error message API to use thread specific data.
Split out debugging API into separate files.

ticket: 6055
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20670 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUpdated bindings. Incomplete but commiting to avoid losing changes
Alexandra Ellwood [Mon, 18 Aug 2008 17:08:28 +0000 (17:08 +0000)]
Updated bindings.  Incomplete but commiting to avoid losing changes

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20669 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoUsing gcov, it was noted that the tests were never including authdata
Ezra Peisach [Sun, 17 Aug 2008 23:34:41 +0000 (23:34 +0000)]
Using gcov, it was noted that the tests were never including authdata
in the test credential - and a segment of code was never tested. Add
some fake authdata to the test creds.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20668 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIn parsing authorization data, if run out of memory, the authorization
Ezra Peisach [Sat, 16 Aug 2008 13:03:30 +0000 (13:03 +0000)]
In parsing authorization data, if run out of memory, the authorization
data was released, but the pointer not zeroed.  This resulted in
higher level code trying to free it again.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20667 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIn copying a credential - if we run out memory - the cleanup code failed to clear...
Ezra Peisach [Sat, 16 Aug 2008 13:01:40 +0000 (13:01 +0000)]
In copying a credential - if we run out memory - the cleanup code failed to clear the second_ticket

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20666 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMove internal cccursor structures/prototypes to the ccache private include
Ezra Peisach [Sat, 16 Aug 2008 01:14:58 +0000 (01:14 +0000)]
Move internal cccursor structures/prototypes to the ccache private include
file. Functions are not exported from library.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20665 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoConditionalize building of CCAPI ccache type on USE_CCAPI
Alexandra Ellwood [Fri, 15 Aug 2008 22:19:01 +0000 (22:19 +0000)]
Conditionalize building of CCAPI ccache type on USE_CCAPI

Still refer to Windows by OS macro because KfW builds do not set
USE_CCAPI.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20664 dc483132-0cff-0310-8789-dd5450dbe970

16 years agomac port of kim should not depend on kipc
Alexandra Ellwood [Fri, 15 Aug 2008 22:17:09 +0000 (22:17 +0000)]
mac port of kim should not depend on kipc

kipc is not necessarily built

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20663 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoMove prototype for krb5int_random_string from k5-int.h to cc-int.h as
Ezra Peisach [Fri, 15 Aug 2008 18:46:12 +0000 (18:46 +0000)]
Move prototype for krb5int_random_string from k5-int.h to cc-int.h as
it is private to the ccache code. Include cc-int.h where needed, and
update Makefile.in dependencies.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20662 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoa stash file is not a keytab
Will Fiveash [Fri, 15 Aug 2008 00:38:41 +0000 (00:38 +0000)]
a stash file is not a keytab

Note, this is the commit for the associated Krb Consortium project:
Projects/Masterkey Keytab Stash

ticket: 194

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20661 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoOnly add -Os for size optimizations if CFLAGS wasn't specified already. If
Ken Raeburn [Thu, 14 Aug 2008 22:59:54 +0000 (22:59 +0000)]
Only add -Os for size optimizations if CFLAGS wasn't specified already.  If
the configure-generated CFLAGS string is one of the usual ones with -O2,
replace -O2 rather than appending, since -Os will override previously
specified optimization levels anyways.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20660 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIf the LDAP KDB back end is being built, define ENABLE_LDAP. If
Ken Raeburn [Thu, 14 Aug 2008 21:32:58 +0000 (21:32 +0000)]
If the LDAP KDB back end is being built, define ENABLE_LDAP.  If
ENABLE_LDAP is not defined, don't build the LDAP KDB ASN.1 encoding
and decoding functions, and use null pointers for them in the accessor
function table.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20659 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIn parsing principal - if run out memory - clean up after ourselves.
Ezra Peisach [Thu, 14 Aug 2008 16:40:07 +0000 (16:40 +0000)]
In parsing principal - if run out memory - clean up after ourselves.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20658 dc483132-0cff-0310-8789-dd5450dbe970

16 years agoIn krb5int_copy_creds_contents - if we run out of memory, do not
Ezra Peisach [Thu, 14 Aug 2008 16:25:29 +0000 (16:25 +0000)]
In krb5int_copy_creds_contents - if we run out of memory, do not
release pointer to output creds structure that is passed in by caller.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20657 dc483132-0cff-0310-8789-dd5450dbe970