krb5.git
15 years agoDon't apply 'const' twice. Make kg_arcfour_l40 static
Ken Raeburn [Thu, 12 Feb 2009 20:19:21 +0000 (20:19 +0000)]
Don't apply 'const' twice.  Make kg_arcfour_l40 static

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21987 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDon't apply 'const' twice
Ken Raeburn [Thu, 12 Feb 2009 20:18:20 +0000 (20:18 +0000)]
Don't apply 'const' twice

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21986 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5_get_in_tkt_with_password, free opte before returning the error
Greg Hudson [Thu, 12 Feb 2009 20:07:15 +0000 (20:07 +0000)]
In krb5_get_in_tkt_with_password, free opte before returning the error
from krb5_unparse_name, not after.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21985 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMake output parameter of krb5_generate_subkey_extended well-defined on
Greg Hudson [Thu, 12 Feb 2009 19:43:23 +0000 (19:43 +0000)]
Make output parameter of krb5_generate_subkey_extended well-defined on
error, and reformat function to fit coding standards.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21984 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove useless unsigned >=0 tests
Ken Raeburn [Thu, 12 Feb 2009 19:43:08 +0000 (19:43 +0000)]
Remove useless unsigned >=0 tests

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21983 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5_rc_io_open_internal, d->fn is always set for the cleanup
Greg Hudson [Thu, 12 Feb 2009 19:38:08 +0000 (19:38 +0000)]
In krb5_rc_io_open_internal, d->fn is always set for the cleanup
handler, so do not check it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21982 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoModify asn12krb5_buf and asn1_do_full_encode to make output parameter
Greg Hudson [Thu, 12 Feb 2009 18:21:33 +0000 (18:21 +0000)]
Modify asn12krb5_buf and asn1_do_full_encode to make output parameter
values well-defined on error.  Clean up memory handling and an unused
variable in asn1_do_full_encode.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21981 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix allocation failure check in walk_rtree
Greg Hudson [Thu, 12 Feb 2009 17:51:45 +0000 (17:51 +0000)]
Fix allocation failure check in walk_rtree

Check the correct variable for null after allocating the server string
in rtree_capath_vals.

ticket: 6392
tags: pullup
target_version: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21980 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd a new test harness to facilitate memory leak detection in the
Greg Hudson [Wed, 11 Feb 2009 20:28:40 +0000 (20:28 +0000)]
Add a new test harness to facilitate memory leak detection in the
ASN.1 decoder routines.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21970 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoEnsure we have a free function for every data type we have an ASN.1
Greg Hudson [Wed, 11 Feb 2009 20:18:43 +0000 (20:18 +0000)]
Ensure we have a free function for every data type we have an ASN.1
decoder for.  Export the new free functions, but only declare them
in k5-int.h since they shouldn't be needed by applications.  Also
export a couple of encoder and decoder functions not previously
exported.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21969 dc483132-0cff-0310-8789-dd5450dbe970

15 years ago--disable-rpath is not working
Ezra Peisach [Wed, 11 Feb 2009 13:01:11 +0000 (13:01 +0000)]
--disable-rpath is not working

AC_ARG_ENABLE returns its value in enableval not withval.  --disable-rpath
was not working - or dependent on some previous setting...

ticket: 6390
tags: pullup
target_version: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21968 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd test for krb5_cc_get_principal and ensure returned value correct
Ezra Peisach [Wed, 11 Feb 2009 12:47:51 +0000 (12:47 +0000)]
Add test for krb5_cc_get_principal and ensure returned value correct

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21967 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoInstall ktutil and kadmin into CLIENT_BINDIR instead of ADMIN_BINDIR
Russ Allbery [Wed, 11 Feb 2009 05:00:24 +0000 (05:00 +0000)]
Install ktutil and kadmin into CLIENT_BINDIR instead of ADMIN_BINDIR
since both are useful for users other than the system administrator.

Ticket: 6348
Tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21966 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoremove local objects from list for windows
Ken Raeburn [Wed, 11 Feb 2009 01:15:58 +0000 (01:15 +0000)]
remove local objects from list for windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21965 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoremove des425 syms; add some new dce,iov syms needed for gssapi
Ken Raeburn [Wed, 11 Feb 2009 01:14:27 +0000 (01:14 +0000)]
remove des425 syms; add some new dce,iov syms needed for gssapi

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21964 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUpdates for current CCAPI code; build krb5 unicode support
Ken Raeburn [Wed, 11 Feb 2009 01:12:21 +0000 (01:12 +0000)]
Updates for current CCAPI code; build krb5 unicode support

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21963 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoSome updates to compile and link on Windows, with recent CCAPI changes
Ken Raeburn [Wed, 11 Feb 2009 00:58:41 +0000 (00:58 +0000)]
Some updates to compile and link on Windows, with recent CCAPI changes

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21962 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull in unicode stuff on windows
Ken Raeburn [Wed, 11 Feb 2009 00:53:28 +0000 (00:53 +0000)]
pull in unicode stuff on windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21961 dc483132-0cff-0310-8789-dd5450dbe970

15 years agohide stat buf init on windows
Ken Raeburn [Wed, 11 Feb 2009 00:53:00 +0000 (00:53 +0000)]
hide stat buf init on windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21960 dc483132-0cff-0310-8789-dd5450dbe970

15 years agomake build on windows, in current makefile framework
Ken Raeburn [Wed, 11 Feb 2009 00:51:46 +0000 (00:51 +0000)]
make build on windows, in current makefile framework

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21959 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoWindows version of 'copy a bunch of files around'
Ken Raeburn [Wed, 11 Feb 2009 00:51:06 +0000 (00:51 +0000)]
Windows version of 'copy a bunch of files around'

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21958 dc483132-0cff-0310-8789-dd5450dbe970

15 years agobuild strlcpy.c, printf.c, ipc_stream.c on windows
Ken Raeburn [Wed, 11 Feb 2009 00:24:39 +0000 (00:24 +0000)]
build strlcpy.c, printf.c, ipc_stream.c on windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21957 dc483132-0cff-0310-8789-dd5450dbe970

15 years agodefine SSIZE_MAX forWindows
Ken Raeburn [Wed, 11 Feb 2009 00:16:23 +0000 (00:16 +0000)]
define SSIZE_MAX forWindows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21956 dc483132-0cff-0310-8789-dd5450dbe970

15 years agounistd.h is posix only
Ken Raeburn [Wed, 11 Feb 2009 00:15:55 +0000 (00:15 +0000)]
unistd.h is posix only

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21955 dc483132-0cff-0310-8789-dd5450dbe970

15 years agopull in dependency files
Ken Raeburn [Wed, 11 Feb 2009 00:11:33 +0000 (00:11 +0000)]
pull in dependency files

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21954 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoupdate
Ken Raeburn [Tue, 10 Feb 2009 23:38:36 +0000 (23:38 +0000)]
update

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21953 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5_ccache_internalize: fix resource leaks, fix several cases
Greg Hudson [Tue, 10 Feb 2009 19:05:58 +0000 (19:05 +0000)]
In krb5_ccache_internalize: fix resource leaks, fix several cases
where success could be returned on failure, validate the length of the
ccache name, make the value of *argp well-defined on failure, and lay
out the function in a linear style with a cleanup handler.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21952 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn the ccache serialization code, remove some unnecessary checks for
Greg Hudson [Tue, 10 Feb 2009 18:25:15 +0000 (18:25 +0000)]
In the ccache serialization code, remove some unnecessary checks for
nullity of ccache->ops; we assume a valid ops pointer in neighboring
parts of the code.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21951 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix a memory leak (unlikely to happen in practice) in krb5_mcc_store;
Greg Hudson [Tue, 10 Feb 2009 17:17:39 +0000 (17:17 +0000)]
Fix a memory leak (unlikely to happen in practice) in krb5_mcc_store;
use a cleanup handler for robustness.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21950 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdjust the structure of krb5_decode.c functions to initialize output
Greg Hudson [Tue, 10 Feb 2009 02:01:58 +0000 (02:01 +0000)]
Adjust the structure of krb5_decode.c functions to initialize output
parameters to NULL and not set them to the real values until a
successful return is guaranteed.  Also fix get_eoc which was returning
without clean_return.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21940 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUpdate t_k5buf.c for the renamed buffer type constants
Greg Hudson [Tue, 10 Feb 2009 00:20:48 +0000 (00:20 +0000)]
Update t_k5buf.c for the renamed buffer type constants

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21939 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRename functions from k5_ipc_stream_* to krb5int_ipc_stream_*, because some of them...
Ken Raeburn [Mon, 9 Feb 2009 23:43:04 +0000 (23:43 +0000)]
Rename functions from k5_ipc_stream_* to krb5int_ipc_stream_*, because some of them will have to be exported

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21938 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd variables for optionally building ipc_stream.c; currently empty
Ken Raeburn [Mon, 9 Feb 2009 23:27:50 +0000 (23:27 +0000)]
Add variables for optionally building ipc_stream.c; currently empty

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21937 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdjust names to not conflict with Windows headers
Ken Raeburn [Mon, 9 Feb 2009 23:00:59 +0000 (23:00 +0000)]
Adjust names to not conflict with Windows headers

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21936 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoInclude assert.h
Ken Raeburn [Mon, 9 Feb 2009 22:59:00 +0000 (22:59 +0000)]
Include assert.h

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21935 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUse winsock2.h on Windows. Make initializer value static
Ken Raeburn [Mon, 9 Feb 2009 22:42:43 +0000 (22:42 +0000)]
Use winsock2.h on Windows.  Make initializer value static

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21934 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMore KfW generated stuff
Ken Raeburn [Mon, 9 Feb 2009 22:38:31 +0000 (22:38 +0000)]
More KfW generated stuff

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21933 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMore KfW generated stuff
Ken Raeburn [Mon, 9 Feb 2009 22:34:31 +0000 (22:34 +0000)]
More KfW generated stuff

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21932 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIgnore some stuff generated for KfW build
Ken Raeburn [Mon, 9 Feb 2009 22:31:16 +0000 (22:31 +0000)]
Ignore some stuff generated for KfW build

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21931 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRename X11 resource file to avoid name conflict on Mac in in-place build
Ken Raeburn [Mon, 9 Feb 2009 22:22:24 +0000 (22:22 +0000)]
Rename X11 resource file to avoid name conflict on Mac in in-place build

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21930 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIgnore files generated by in-place build on Mac
Ken Raeburn [Mon, 9 Feb 2009 22:20:13 +0000 (22:20 +0000)]
Ignore files generated by in-place build on Mac

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21929 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMake asn1buf_destroy return void, since it's a free function. In
Greg Hudson [Mon, 9 Feb 2009 21:25:53 +0000 (21:25 +0000)]
Make asn1buf_destroy return void, since it's a free function.  In
krb5_encode.c functions, make *code well-defined in case of error,
and clean up some memory leaks.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21928 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn asn1_k_encode.c, stop inconsistently destroying buf on some errors.
Greg Hudson [Mon, 9 Feb 2009 21:23:00 +0000 (21:23 +0000)]
In asn1_k_encode.c, stop inconsistently destroying buf on some errors.
It belongs to the caller.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21927 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix one more case of an explicit null check before calling a free
Ken Raeburn [Mon, 9 Feb 2009 20:39:54 +0000 (20:39 +0000)]
Fix one more case of an explicit null check before calling a free
function that does the null check.

Also, use krb5_free_keyblock_contents instead of open-coding all the
work (and not trying hard enough to clear the memory).

ticket: 6377

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21926 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCheck if mem allocation was successful
Zhanna Tsitkov [Mon, 9 Feb 2009 19:07:09 +0000 (19:07 +0000)]
Check if mem allocation was successful

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21925 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix possible free of uninitialized value in walk_rtree
Greg Hudson [Mon, 9 Feb 2009 18:52:40 +0000 (18:52 +0000)]
Fix possible free of uninitialized value in walk_rtree

In rtree_hier_realms, if the first rtree_hier_tweens call failed, the
cleanup handler would free stweens which had not been initialized.
Initialize ctweens and stweens to NULL in the variable declarations to
make the cleanup handler safe.

ticket: 6379
tags: pullup
target_version: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21924 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoChange contract of krb5int_utf8_normalize and fix memory leaks
Greg Hudson [Mon, 9 Feb 2009 18:35:19 +0000 (18:35 +0000)]
Change contract of krb5int_utf8_normalize and fix memory leaks

Make krb5int_utf8_normalize return a krb5_error_code and always allocate
a structure to be placed in the output parameter.  Adjust the function
structure to use a cleanup handler, fixing many memory leaks.

ticket: 6378
tags: pullup
target_version: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21923 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoProvide omitted return value in last change
Ken Raeburn [Mon, 9 Feb 2009 18:13:08 +0000 (18:13 +0000)]
Provide omitted return value in last change

ticket: 6377

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21922 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove unused file
Ken Raeburn [Mon, 9 Feb 2009 17:58:22 +0000 (17:58 +0000)]
Remove unused file

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21921 dc483132-0cff-0310-8789-dd5450dbe970

15 years agomake krb5_free_* functions ignore NULL
Ken Raeburn [Mon, 9 Feb 2009 17:53:21 +0000 (17:53 +0000)]
make krb5_free_* functions ignore NULL

This makes them safer to call in various contexts where NULL may leak
through, and makes analysis easier.

Also, remove some checks for NULL before calling a free routine that
will also check for NULL.

ticket: 6377

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21920 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCheck C++ compatibility for some internal headers that may (now or in
Ken Raeburn [Mon, 9 Feb 2009 16:36:09 +0000 (16:36 +0000)]
Check C++ compatibility for some internal headers that may (now or in
the future) be used in C++ code on Windows.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21919 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMore C++ compatibility: Don't use "typedef struct tag *tag"; rename
Ken Raeburn [Mon, 9 Feb 2009 16:35:01 +0000 (16:35 +0000)]
More C++ compatibility: Don't use "typedef struct tag *tag"; rename
the tag and keep the same typedefname.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21918 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoC++ compatibility fix -- g++ says "types may not be defined in casts",
Ken Raeburn [Mon, 9 Feb 2009 16:28:29 +0000 (16:28 +0000)]
C++ compatibility fix -- g++ says "types may not be defined in casts",
so do the gcc unaligned-struct trick only for C, not C++.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21917 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFor Sun CC, also make implicit function declarations into errors
Ken Raeburn [Mon, 9 Feb 2009 16:15:51 +0000 (16:15 +0000)]
For Sun CC, also make implicit function declarations into errors

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21916 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoSupply missing fn declarations
Ken Raeburn [Mon, 9 Feb 2009 16:14:38 +0000 (16:14 +0000)]
Supply missing fn declarations

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21915 dc483132-0cff-0310-8789-dd5450dbe970

15 years agouse unsigned value for shifting, avoiding undefined behavior
Ken Raeburn [Mon, 9 Feb 2009 16:07:42 +0000 (16:07 +0000)]
use unsigned value for shifting, avoiding undefined behavior

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21914 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFor Sun CC, create one errwarn arg with commas instead of multiple
Ken Raeburn [Mon, 9 Feb 2009 15:57:58 +0000 (15:57 +0000)]
For Sun CC, create one errwarn arg with commas instead of multiple

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21913 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoMemory handling fixes in walk_rtree
Greg Hudson [Fri, 6 Feb 2009 20:43:44 +0000 (20:43 +0000)]
Memory handling fixes in walk_rtree

In walk_rtree's rtree_hier_tree, don't leak the result of
rtree_hier_realms.  In rtree_hier_realms, avoid freeing one too many
krb5_data contents on allocation failure, and use the recommend
pattern to ensure well-defined output parameter values.

ticket: 6376
tags: pullup
target_version: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21912 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix whitespace on previous commit to ure.c. Correct two other cases
Greg Hudson [Fri, 6 Feb 2009 19:46:40 +0000 (19:46 +0000)]
Fix whitespace on previous commit to ure.c.  Correct two other cases
where %lX was used with a krb5_ui_4 type argument without a cast to
unsigned long.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21911 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoPass the correct width argument to fprintf for URE_CHAR in
Greg Hudson [Fri, 6 Feb 2009 19:18:20 +0000 (19:18 +0000)]
Pass the correct width argument to fprintf for URE_CHAR in
ure_write_dfa.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21910 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix error handling in krb5_walk_realm_tree
Greg Hudson [Fri, 6 Feb 2009 18:40:04 +0000 (18:40 +0000)]
Fix error handling in krb5_walk_realm_tree

rtree_hier_realms was forgetting to assign the return value of
krb5int_copy_data_contents to retval, which would cause a failure to
notice out-of-memory conditions.

ticket: 6375
tags: pullup
target_version: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21909 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUnsigned/signed fixes
Ezra Peisach [Fri, 6 Feb 2009 05:42:32 +0000 (05:42 +0000)]
Unsigned/signed fixes

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21908 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoChange variable accepting return from strftime to time_t. This
Ezra Peisach [Fri, 6 Feb 2009 05:31:09 +0000 (05:31 +0000)]
Change variable accepting return from strftime to time_t.  This
matches prototype for function and removes a signed/unsigned warning.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21907 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDo not assume sizeof(bool_t) == sizeof(krb5_boolean)
Ezra Peisach [Fri, 6 Feb 2009 05:22:34 +0000 (05:22 +0000)]
Do not assume sizeof(bool_t) == sizeof(krb5_boolean)

bool_t is defined as int, krb5_boolean as unsigned int.  These are
similar size but someone someday might change the krb5_boolean.
Instead of passing a krb5_boolean * to xdr_bool, implement xdr_krb5_boolean
which keeps the different types separate.

This cleans up a number of warnings.

ticket: 6374

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21906 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUnsigned/signed warnings cleanup
Ezra Peisach [Fri, 6 Feb 2009 02:46:14 +0000 (02:46 +0000)]
Unsigned/signed warnings cleanup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21905 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCleanup some warnings due to getsockname's third argument is sometimes
Ezra Peisach [Fri, 6 Feb 2009 02:45:21 +0000 (02:45 +0000)]
Cleanup some warnings due to getsockname's third argument is sometimes
unsigned. Use GETSOCKNAME_ARG3_TYPE and fallback to int if not defined.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21904 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoremove some redundant or useless qualifiers
Ken Raeburn [Fri, 6 Feb 2009 01:07:32 +0000 (01:07 +0000)]
remove some redundant or useless qualifiers

Remove some redundant qualifiers specified redundantly multiple times more than once in variable declarations.
Also remove some useless qualifiers in casts and function argument declarations.

ticket: 6373
target_version: 1.7
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21903 dc483132-0cff-0310-8789-dd5450dbe970

15 years agouse casts, for c++ compilation on windows
Ken Raeburn [Thu, 5 Feb 2009 21:56:21 +0000 (21:56 +0000)]
use casts, for c++ compilation on windows

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21902 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix memory handling bug in mk_req_ext
Greg Hudson [Thu, 5 Feb 2009 21:27:54 +0000 (21:27 +0000)]
Fix memory handling bug in mk_req_ext

In make_etype_list, assign *authdata before we have a chance to fail,
since we may have invalidated the previous value with realloc.

ticket: 6372
tags: pullup
target_version: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21901 dc483132-0cff-0310-8789-dd5450dbe970

15 years agodeal with memleaks in migrate mkey project
Will Fiveash [Thu, 5 Feb 2009 20:57:09 +0000 (20:57 +0000)]
deal with memleaks in migrate mkey project

Ken R. told me that Coverity found several potential memleaks introduced
by the mkey migration project.  This addresses those leaks and tweaks
the code formatting in a few places.

ticket: 6371
Version_Reported: 1.7
Target_Version: 1.7
Tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21900 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn gc_frm_kdc.c's do_traversal(), fix an assert which was doing an
Greg Hudson [Thu, 5 Feb 2009 20:07:45 +0000 (20:07 +0000)]
In gc_frm_kdc.c's do_traversal(), fix an assert which was doing an
assignment instead of a compare.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21899 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5_rc_io_store, check the return value of krb5int_buf_len as well
Greg Hudson [Thu, 5 Feb 2009 19:59:09 +0000 (19:59 +0000)]
In krb5_rc_io_store, check the return value of krb5int_buf_len as well
as krb5int_buf_data.  The length can't be negative if the data is
non-NULL, but Coverity doesn't know that.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21898 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn recvauth_common, initialize ap_option. It can't be used
Greg Hudson [Thu, 5 Feb 2009 19:50:41 +0000 (19:50 +0000)]
In recvauth_common, initialize ap_option.  It can't be used
uninitialized, but you can only deduce that by examining the
relationships between ap_option, problem, and outbuf.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21897 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoChange krb5_rc_resolve_type (not a public API) to allocate the rcache
Greg Hudson [Thu, 5 Feb 2009 19:44:35 +0000 (19:44 +0000)]
Change krb5_rc_resolve_type (not a public API) to allocate the rcache
structure.  Make output parameter values of krb5_rc_resolve_type and
krb5_rc_default well-defined in case of errors.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21896 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoDetect failure to register with rpcbind/portmap due to security
Ezra Peisach [Thu, 5 Feb 2009 19:02:29 +0000 (19:02 +0000)]
Detect failure to register with rpcbind/portmap due to security
restrictons and not bomb out in tests.

ticket: 6349

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21895 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoAdd a missing break in the switch statement of
Greg Hudson [Thu, 5 Feb 2009 18:43:08 +0000 (18:43 +0000)]
Add a missing break in the switch statement of
krb5int_setpw_result_code_string.

ticket: 6368
tags: pullup
target_version: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21894 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCreate and use (in several places) a variant of
Ken Raeburn [Thu, 5 Feb 2009 18:42:10 +0000 (18:42 +0000)]
Create and use (in several places) a variant of
krb5int_copy_data_contents that adds a trailing '\0' so the result can
be used as a C string.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21893 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5_ktfileint_find_slot, check for an error return from ftell.
Greg Hudson [Thu, 5 Feb 2009 18:34:57 +0000 (18:34 +0000)]
In krb5_ktfileint_find_slot, check for an error return from ftell.
(Such an error will never happen in any reasonable stdio
implementation but it's more correct to check.)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21892 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoCoverity was nervous that hst_realm.c's domain_heuristic() wasn't
Greg Hudson [Thu, 5 Feb 2009 18:26:47 +0000 (18:26 +0000)]
Coverity was nervous that hst_realm.c's domain_heuristic() wasn't
checking for a NULL return from strchr.  The code was safe because a
previous call to strchr on the same argments was checked, but make
Coverity less nervous by storing the result of that previous call and
reusing it.  Also make the function conform better to our standards.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21891 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix a memory leak in krb5_kt_resolve when we fail to lock
Greg Hudson [Thu, 5 Feb 2009 18:19:23 +0000 (18:19 +0000)]
Fix a memory leak in krb5_kt_resolve when we fail to lock
kt_typehead_lock.

ticket: 6367
tags: pullup
target_version: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21890 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoinclude omitted system header string.h
Ken Raeburn [Thu, 5 Feb 2009 02:59:08 +0000 (02:59 +0000)]
include omitted system header string.h

Sun cc warns about some of the string functions being undeclared in
several source files.  So, include string.h there.

ticket: 6365
target_version: 1.7
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21889 dc483132-0cff-0310-8789-dd5450dbe970

15 years agodeclare replacement [v]asprintf functions
Ken Raeburn [Thu, 5 Feb 2009 02:16:22 +0000 (02:16 +0000)]
declare replacement [v]asprintf functions

If HAVE_VASPRINTF is not defined, make sure krb5int_{,v}asprintf
functions always get declared, applying the preprocessor conditional
test only to the GCC format attribute.  If HAVE_VASPRINTF is defined,
don't declare them at all.

This fixes a bunch of function-not-declared warnings under Sun cc.

ticket: 6364
target_version: 1.7
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21888 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoint/ptr bug in gssapi code
Ken Raeburn [Thu, 5 Feb 2009 01:49:21 +0000 (01:49 +0000)]
int/ptr bug in gssapi code

Fix a pointer argument passed where an integer is needed.
Update Sun compiler options to make that an error.  (The options we're
currently using make it an error for assignment but not for argument passing.)

ticket: 6363
target_version: 1.7
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21887 dc483132-0cff-0310-8789-dd5450dbe970

15 years agodon't do arithmetic on void pointers
Ken Raeburn [Wed, 4 Feb 2009 23:28:09 +0000 (23:28 +0000)]
don't do arithmetic on void pointers

Fix one file in gssapi where we compute offsets from a void* without casting.
Change options used with Sun compiler to make such expressions an error.

ticket: 6362

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21886 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoregenerate
Ken Raeburn [Wed, 4 Feb 2009 23:06:12 +0000 (23:06 +0000)]
regenerate

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21885 dc483132-0cff-0310-8789-dd5450dbe970

15 years agonew multi-masterkey support doesn't work well when system clock is set
Will Fiveash [Wed, 4 Feb 2009 22:29:44 +0000 (22:29 +0000)]
new multi-masterkey support doesn't work well when system clock is set
back

The ticket contains the details.

ticket: 6361

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21884 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove xfread/xfwrite macros. Casting the first argument to char * is
Greg Hudson [Wed, 4 Feb 2009 20:32:05 +0000 (20:32 +0000)]
Remove xfread/xfwrite macros.  Casting the first argument to char * is
unnecessary (fread's first argument is void *, which does not require
a cast) and confuses Coverity's UNINIT checker; casting the third
argument to unsigned is not necessary for our current set of warnings.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21883 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn tcl_ovsec_kadm_get_policy, initialize ent since (at least in
Greg Hudson [Wed, 4 Feb 2009 19:31:33 +0000 (19:31 +0000)]
In tcl_ovsec_kadm_get_policy, initialize ent since (at least in
theory) there's a code path which gets through to the finalizers
without setting it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21882 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIn krb5int_utf8s_to_ucs2les, free the correct value on error, instead
Greg Hudson [Wed, 4 Feb 2009 19:25:51 +0000 (19:25 +0000)]
In krb5int_utf8s_to_ucs2les, free the correct value on error, instead
of the caller-supplied result pointer.

ticket: 6360
tags: pullup
target_version: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21881 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoInclude k5-int.h in several pkinit source files, in order to define
Greg Hudson [Wed, 4 Feb 2009 19:15:13 +0000 (19:15 +0000)]
Include k5-int.h in several pkinit source files, in order to define
the KRB5_CONFIG symbols now used by those files.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21880 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoUse macros for config parameters
Zhanna Tsitkov [Wed, 4 Feb 2009 17:08:44 +0000 (17:08 +0000)]
Use macros for config parameters

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21879 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoremove some krb4 testing hooks
Ken Raeburn [Wed, 4 Feb 2009 03:18:04 +0000 (03:18 +0000)]
remove some krb4 testing hooks

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21878 dc483132-0cff-0310-8789-dd5450dbe970

15 years agodon't create or delete krb.conf, krb.realms
Ken Raeburn [Wed, 4 Feb 2009 02:41:24 +0000 (02:41 +0000)]
don't create or delete krb.conf, krb.realms

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21877 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoprefer structure assignment to memcpy
Ken Raeburn [Tue, 3 Feb 2009 16:38:34 +0000 (16:38 +0000)]
prefer structure assignment to memcpy

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21876 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoRemove unnecessary pointer casts in args to free,memcpy,memset,memchr except unicode...
Ken Raeburn [Mon, 2 Feb 2009 23:41:40 +0000 (23:41 +0000)]
Remove unnecessary pointer casts in args to free,memcpy,memset,memchr except unicode, windows code

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21875 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoTWRITE_STR casts second argument; don't add redundant casting
Ken Raeburn [Mon, 2 Feb 2009 22:28:34 +0000 (22:28 +0000)]
TWRITE_STR casts second argument; don't add redundant casting

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21874 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix a whitespace error introduced when fixing a typo in the defines
Greg Hudson [Mon, 2 Feb 2009 21:55:13 +0000 (21:55 +0000)]
Fix a whitespace error introduced when fixing a typo in the defines
added to k5-int.h.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21873 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoFix a typo in the defines added to k5-int.h
Greg Hudson [Mon, 2 Feb 2009 21:53:16 +0000 (21:53 +0000)]
Fix a typo in the defines added to k5-int.h

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21872 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoIntroduces macros for config parameters
Zhanna Tsitkov [Mon, 2 Feb 2009 21:34:19 +0000 (21:34 +0000)]
Introduces macros for config parameters

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21871 dc483132-0cff-0310-8789-dd5450dbe970

15 years agoGet rid of casts of free() argument to char*, except where it's
Ken Raeburn [Mon, 2 Feb 2009 21:13:42 +0000 (21:13 +0000)]
Get rid of casts of free() argument to char*, except where it's
casting away const (so as to make this change warning-neutral), and in
unicode source (which we may want to keep in sync with another
source), and krb5_xfree macro (to be handled separately).

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21870 dc483132-0cff-0310-8789-dd5450dbe970