krb5int_copy_data_contents shouldn't free memory it didn't allocate
authorTom Yu <tlyu@mit.edu>
Tue, 28 Nov 2006 04:57:55 +0000 (04:57 +0000)
committerTom Yu <tlyu@mit.edu>
Tue, 28 Nov 2006 04:57:55 +0000 (04:57 +0000)
* src/lib/krb5/krb/copy_data.c (krb5int_copy_data_contents): Don't
free outdata on malloc failure; we didn't allocate outdata.

ticket: new
target_version: 1.6
tags: pullup
component: krb5-libs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18865 dc483132-0cff-0310-8789-dd5450dbe970

src/lib/krb5/krb/copy_data.c

index 1be2a2da59384758a5d6ef32740d186f943f3f53..aed2e863b156a555745e4409aabf8b6652468a1e 100644 (file)
@@ -65,12 +65,10 @@ krb5int_copy_data_contents(krb5_context context, const krb5_data *indata, krb5_d
     if (!indata) {
        return EINVAL;
     }
-    
 
     outdata->length = indata->length;
     if (outdata->length) {
        if (!(outdata->data = malloc(outdata->length))) {
-           krb5_xfree(outdata);
            return ENOMEM;
        }
        memcpy((char *)outdata->data, (char *)indata->data, outdata->length);