rpc unit tests can fail due to race condition

The rpc unit tests can fail in fullrun.exp due to a failure to drain
output from the server in expire.exp.  This commit works around the
problem by calling flush_server, but a real synchronization method
should probably be implemented, perhaps by having the server log when
a client disconnects.

	* rpc_test.0/expire.exp (overlap): Add another call to
	flush_server to make a race condition a little less likely.  There
	really should be better synchronization, as this test suite is
	just full of race conditions waiting to happen.

ticket: new
status: open

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@14979 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/rpc/unit-test/ChangeLog b/src/lib/rpc/unit-test/ChangeLog
index 273a2c26d2697b58762691010ceda56264523c95..06504cfbbf3ea80550b317ef8ff16f9828fbb0c2 100644 (file)
--- a/src/lib/rpc/unit-test/ChangeLog
+++ b/src/lib/rpc/unit-test/ChangeLog
@@ -1,3 +1,10 @@
+2002-11-07  Tom Yu  <tlyu@mit.edu>
+
+       * rpc_test.0/expire.exp (overlap): Add another call to
+       flush_server to make a race condition a little less likely.  There
+       really should be better synchronization, as this test suite is
+       just full of race conditions waiting to happen.
+
 2002-09-15  Ken Raeburn  <raeburn@mit.edu>
 
        * lib/helpers.exp (setup_database): Use "!=" instead of "ne" for

diff --git a/src/lib/rpc/unit-test/rpc_test.0/expire.exp b/src/lib/rpc/unit-test/rpc_test.0/expire.exp
index 6f7aa935ae0c49a9a73c63e7266998f0df3434db..5c33ffde52e7a44e65da095648020498a7aad470 100644 (file)
--- a/src/lib/rpc/unit-test/rpc_test.0/expire.exp
+++ b/src/lib/rpc/unit-test/rpc_test.0/expire.exp
@@ -38,6 +38,8 @@ proc overlap {} {
     eof_client expire 1 $client1_id 0
     eof_client expire 2 $client2_id 0
     eof_client expire 3 $client3_id 0
+
+    flush_server
 }
 overlap