* locate_kdc.c (add_host_to_list): Initialize stack variable err

which would otherwise get returned without being set in certain
circumstances.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@13235 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/krb5/os/ChangeLog b/src/lib/krb5/os/ChangeLog
index 244267ba3ae30b68fd2487126645d534a616c61c..2aa21e6f9bfafb452f8bdf0458d867fb53179904 100644 (file)
--- a/src/lib/krb5/os/ChangeLog
+++ b/src/lib/krb5/os/ChangeLog
@@ -1,3 +1,9 @@
+2001-05-08  Danilo Almeida  <dalmeida@mit.edu>
+
+       * locate_kdc.c (add_host_to_list): Initialize stack variable err
+       which would otherwise get returned without being set in certain
+       circumstances.
+
 2001-05-07  Ken Raeburn  <raeburn@mit.edu>
 
        * locate_kdc.c (add_sockaddr_to_list) [TEST]: If getnameinfo is

diff --git a/src/lib/krb5/os/locate_kdc.c b/src/lib/krb5/os/locate_kdc.c
index 7b6ec221b60a57862c08e91b4a785b893aa3965b..c518c1f1f6cdc4c20e654b847534f8b7f11a64c3 100644 (file)
--- a/src/lib/krb5/os/locate_kdc.c
+++ b/src/lib/krb5/os/locate_kdc.c
@@ -286,7 +286,9 @@ add_host_to_list (struct addrlist *lp, const char *hostname,
 #else
     struct hostent *hp;
 #endif
-    int err;
+    /* Must set err to 0 for the case we return err without ever
+       setting it -- !HAVE_GETADDRINFO and !hp */
+    int err = 0;
 
 #ifdef TEST
     fprintf (stderr, "adding hostname %s, ports %d,%d\n", hostname,