gcc -Wall cleanups. Mainly adding prototypes and

making sure that functions have return types declared.

	* ss_internal.h: Add ss_pager_create prototype.

	* ss.h: Add ss_list_requests prototype.

	* request_tbl.c (ss_add_request_table, ss_delete_request_table):
        Declare function types as void.

	* prompt.c (ss_set_prompt): Declare function as void.

	* listen.c (ss_quit): Int function should return a value.

	* list_rqs.c (ss_list_requests): Fix arguments to match proper
        prototype for a ss type handler.

	* execute_cmd.c (ss_execute_command): Declare as returning int

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@10504 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/util/ss/ChangeLog b/src/util/ss/ChangeLog
index 828c118e5b342c0fa5c8f4d38d9791105fe9e399..3e0cf7b4e0f233cd01b530c1ce6ea5ee0579ea45 100644 (file)
--- a/src/util/ss/ChangeLog
+++ b/src/util/ss/ChangeLog
@@ -1,3 +1,21 @@
+Mon Mar 30 11:30:00 1998  Ezra Peisach  <epeisach@kangaroo.mit.edu>
+
+       * ss_internal.h: Add ss_pager_create prototype.
+
+       * ss.h: Add ss_list_requests prototype.
+
+       * request_tbl.c (ss_add_request_table, ss_delete_request_table):
+        Declare function types as void.
+
+       * prompt.c (ss_set_prompt): Declare function as void.
+
+       * listen.c (ss_quit): Int function should return a value.
+
+       * list_rqs.c (ss_list_requests): Fix arguments to match proper
+        prototype for a ss type handler.
+
+       * execute_cmd.c (ss_execute_command): Declare as returning int
+
 Wed Feb 18 16:35:55 1998  Tom Yu  <tlyu@mit.edu>
 
        * Makefile.in: Remove trailing slash from thisconfigdir.  Fix up

diff --git a/src/util/ss/Makefile.in b/src/util/ss/Makefile.in
index 67d6759e2f84f511a8d6367e49dc4196d5525d81..7ff2ef17b6b41865b2efca688ebd26c3ac1a1b6f 100644 (file)
--- a/src/util/ss/Makefile.in
+++ b/src/util/ss/Makefile.in
@@ -93,8 +93,9 @@ HDRS =        $(HDRDIR)/ss.h \
 
 BUILD_HDRS = ss_err.h
 SRC_HDRS = ss.h 
+SRC_HDRS_DEP = $(srcdir)/ss.h 
 
-includes:: $(SRC_HDRS) $(BUILD_HDRS)
+includes:: $(SRC_HDRS_DEP) $(BUILD_HDRS)
        mkdir -p $(HDRDIR)
        for i in $(SRC_HDRS) ; do \
                if cmp $(srcdir)/$$i $(HDRDIR)/$$i >/dev/null 2>&1; then :; \

diff --git a/src/util/ss/execute_cmd.c b/src/util/ss/execute_cmd.c
index 52f07e2390bc55e01a40479cef39cd06f9db23bc..5fb0cad9688f0958b1ed87efc5df0d90b6ec0722 100644 (file)
--- a/src/util/ss/execute_cmd.c
+++ b/src/util/ss/execute_cmd.c
@@ -149,6 +149,7 @@ static int really_execute_command (sci_idx, argc, argv)
  * Notes:
  */
 
+int
 ss_execute_command(sci_idx, argv)
        int sci_idx;
        register char *argv[];

diff --git a/src/util/ss/list_rqs.c b/src/util/ss/list_rqs.c
index 460da3a5b56533a63b3eeb7838e3f5b4737f632f..cf2c9312fd825486678d0ded2998935a5dbba16e 100644 (file)
--- a/src/util/ss/list_rqs.c
+++ b/src/util/ss/list_rqs.c
@@ -19,11 +19,16 @@ static char const twentyfive_spaces[26] =
     "                         ";
 static char const NL[2] = "\n";
 
+void
 ss_list_requests(argc, argv, sci_idx, info_ptr)
     int argc;
-    char **argv;
+    const char * const *argv;
     int sci_idx;
-    pointer info_ptr;
+#ifdef __STDC__
+    void *info_ptr;
+#else
+    char *info_ptr;
+#endif
 {
     register ss_request_entry *entry;
     register char const * const *name;

diff --git a/src/util/ss/listen.c b/src/util/ss/listen.c
index fc27a7b7027f36df1f64c4a15efd03816978517c..c197a3f8028daa04cc7e3f45e666d63414029e94 100644 (file)
--- a/src/util/ss/listen.c
+++ b/src/util/ss/listen.c
@@ -172,4 +172,5 @@ int ss_quit(argc, argv, sci_idx, infop)
     pointer infop;
 {
     ss_abort_subsystem(sci_idx, 0);
+    return 0;
 }

diff --git a/src/util/ss/prompt.c b/src/util/ss/prompt.c
index 5df2731e0f3f9da84d52b5f7c45960b34541a6d2..0751baebacf27ee598a1fe61bbc9a5f28020640d 100644 (file)
--- a/src/util/ss/prompt.c
+++ b/src/util/ss/prompt.c
@@ -12,6 +12,7 @@
 #include <stdio.h>
 #include "ss_internal.h"
 
+void
 ss_set_prompt(sci_idx, new_prompt)
      int sci_idx;
      char *new_prompt;

diff --git a/src/util/ss/request_tbl.c b/src/util/ss/request_tbl.c
index 8dcb5837a62cd040ef8ea9a6aff0f89e8d02a519..6404b5d6b0cb52983663218d6be12b61fe85a862 100644 (file)
--- a/src/util/ss/request_tbl.c
+++ b/src/util/ss/request_tbl.c
@@ -9,6 +9,7 @@
 
 #define ssrt ss_request_table  /* for some readable code... */
 
+void
 ss_add_request_table(sci_idx, rqtbl_ptr, position, code_ptr)
        int sci_idx;
        ssrt *rqtbl_ptr;
@@ -41,6 +42,7 @@ ss_add_request_table(sci_idx, rqtbl_ptr, position, code_ptr)
        *code_ptr = 0;
 }
 
+void
 ss_delete_request_table(sci_idx, rqtbl_ptr, code_ptr)
      int sci_idx;
      ssrt *rqtbl_ptr;

diff --git a/src/util/ss/requests.c b/src/util/ss/requests.c
index 5b10356ce77c54e1590620d05a4e885c4241b0c7..6f0055f57baa7245a0cadb6ec52b7545a976fc42 100644 (file)
--- a/src/util/ss/requests.c
+++ b/src/util/ss/requests.c
@@ -9,7 +9,7 @@
 #include <stdio.h>
 #include "ss_internal.h"
 
-#define        DECLARE(name)   name(argc,argv,sci_idx)int argc,sci_idx;char **argv;
+#define        DECLARE(name)   void name(argc,argv,sci_idx)int argc,sci_idx;char **argv;
 
 /*
  * ss_self_identify -- assigned by default to the "." request

diff --git a/src/util/ss/ss.h b/src/util/ss/ss.h
index 5f3df3f3ae17509e58b388c907fc00844f278b57..b3a0aba0f8f1e19db4bba347103dd1ae8da14717 100644 (file)
--- a/src/util/ss/ss.h
+++ b/src/util/ss/ss.h
@@ -46,6 +46,7 @@ typedef struct _ss_rp_options {       /* DEFAULT VALUES */
 #define SS_OPT_DONT_SUMMARIZE  0x0002
 
 void ss_help __SS_PROTO;
+void ss_list_requests __SS_PROTO;
 char *ss_current_request();
 char *ss_name();
 #ifdef __STDC__

diff --git a/src/util/ss/ss_internal.h b/src/util/ss/ss_internal.h
index 54046df28618047f5ac1a24a8b15295c5d7a21c8..81185172bcdb35364409808de3323abf661cdc57 100644 (file)
--- a/src/util/ss/ss_internal.h
+++ b/src/util/ss/ss_internal.h
@@ -105,6 +105,7 @@ int ss_execute_line();
 char **ss_parse();
 ss_abbrev_info *ss_abbrev_initialize PROTOTYPE((char *, int *));
 void ss_page_stdin();
+int ss_pager_create();
 
 extern ss_data **_ss_table;
 extern char *ss_et_msgs[];