Remove bogus conditional from tcl_kadm5_randkey_principal(), which was
authorTom Yu <tlyu@mit.edu>
Fri, 28 Aug 2009 20:29:24 +0000 (20:29 +0000)
committerTom Yu <tlyu@mit.edu>
Fri, 28 Aug 2009 20:29:24 +0000 (20:29 +0000)
causing unparse_keyblocks() to get stack garbage as num_keys when
num_var was "null", thus overrunning the end of the array.

ticket: 6544

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@22645 dc483132-0cff-0310-8789-dd5450dbe970

src/kadmin/testing/util/tcl_kadm5.c

index 15ae99fdde23add5a3de717ecbbce019c696c1d6..6679ce0a7c5e8b46e9e010e71831c23657d20b55 100644 (file)
@@ -2033,7 +2033,7 @@ static int tcl_kadm5_randkey_principal(ClientData clientData,
 
      ret = kadm5_randkey_principal(server_handle,
                                   princ, keyblock_var ? &keyblocks : 0,
-                                  num_var ? &num_keys : 0);
+                                  &num_keys);
 
      if (ret == KADM5_OK) {
          if (keyblock_var) {