* key_sched.c (mit_des_key_sched): *always* fill in the schedule,

	regardless of the key failing other tests, as a defense against
	telnet-style bugs.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@5802 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/crypto/des/ChangeLog b/src/lib/crypto/des/ChangeLog
index 8b24e7d8628ef53badcc5f1b2ed8ca34417e0b07..e731379a9e474bfe3014586e1a3c2bc500c0e863 100644 (file)
--- a/src/lib/crypto/des/ChangeLog
+++ b/src/lib/crypto/des/ChangeLog
@@ -1,3 +1,9 @@
+Fri May 12 02:46:13 1995  Mark Eichin  <eichin@cygnus.com>
+
+       * key_sched.c (mit_des_key_sched): *always* fill in the schedule,
+       regardless of the key failing other tests, as a defense against
+       telnet-style bugs.
+
 Thu Apr 13 15:49:16 1995 Keith Vetter (keithv@fusion.com)
 
        * *.[ch]: removed unneeded INTERFACE from non-api functions.

diff --git a/src/lib/crypto/des/key_sched.c b/src/lib/crypto/des/key_sched.c
index dfe973dcfdc64258702bb5f7be33dd04c2ba83fd..651af88eff649c1b21f9f2e80cc06ed4e24d66c3 100644 (file)
--- a/src/lib/crypto/des/key_sched.c
+++ b/src/lib/crypto/des/key_sched.c
@@ -47,14 +47,14 @@ mit_des_key_sched(k,schedule)
     mit_des_cblock k;
     mit_des_key_schedule schedule;
 {
+    make_key_sched(k,schedule);
+
     if (!mit_des_check_key_parity(k))  /* bad parity --> return -1 */
        return(-1);
 
     if (mit_des_is_weak_key(k))
        return(-2);
 
-    make_key_sched(k,schedule);
-
     /* if key was good, return 0 */
     return 0;
 }