In case of permission problems, don't unlink the old replay cache;

make it a hard (repeatable) error.  This also reduces the chance we
accidentally delete valuable data.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@7150 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/krb5/rcache/ChangeLog b/src/lib/krb5/rcache/ChangeLog
index 0001ac9b9ccd247f5c9a052cb0d993ac2143c7b2..a4201c0830763c9ebd05ff6b35527178536c5198 100644 (file)
--- a/src/lib/krb5/rcache/ChangeLog
+++ b/src/lib/krb5/rcache/ChangeLog
@@ -1,3 +1,10 @@
+Fri Dec  1 17:07:24 1995  Theodore Y. Ts'o  <tytso@dcl>
+
+       * rc_io.c (krb5_rc_io_creat): In case of permission problems,
+               don't unlink the old replay cache; make it a hard
+               (repeatable) error.  This also reduces the chance we
+               accidentally delete valuable data.
+
 Mon Nov 27 14:52:23 1995  Tom Yu  <tlyu@dragons-lair.MIT.EDU>
 
        * rc_dfl.c (krb5_rc_dfl_init): default lifespan to

diff --git a/src/lib/krb5/rcache/rc_io.c b/src/lib/krb5/rcache/rc_io.c
index 96cfe2bb573d19b180acd4731cd45cb0229baf38..fa0bdc0aee7f561008aed194f4883e1afbee32e4 100644 (file)
--- a/src/lib/krb5/rcache/rc_io.c
+++ b/src/lib/krb5/rcache/rc_io.c
@@ -130,7 +130,7 @@ krb5_error_code krb5_rc_io_creat (context, d, fn)
        case EACCES: 
        case EROFS: 
        case EEXIST: 
-           retval = KRB5_RC_IO_PERM; goto fail;
+           retval = KRB5_RC_IO_PERM; goto no_unlink;
 
        default: 
            retval = KRB5_RC_IO_UNKNOWN; goto fail;
@@ -141,6 +141,7 @@ krb5_error_code krb5_rc_io_creat (context, d, fn)
     {
     fail:
      (void) unlink(d->fn);
+    no_unlink:
      FREE(d->fn);
        d->fn = NULL;
      (void) close(d->fd);