Re: [PATCH] test: Make gen-threads work with python3
authorW. Trevor King <wking@tremily.us>
Fri, 31 Oct 2014 18:18:13 +0000 (11:18 +1700)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:05:59 +0000 (10:05 -0800)
7b/2e3ad2b218af024fc3be9987f42e670125b481 [new file with mode: 0644]

diff --git a/7b/2e3ad2b218af024fc3be9987f42e670125b481 b/7b/2e3ad2b218af024fc3be9987f42e670125b481
new file mode 100644 (file)
index 0000000..17fa7c5
--- /dev/null
@@ -0,0 +1,134 @@
+Return-Path: <wking@tremily.us>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 67FF9431FBC\r
+       for <notmuch@notmuchmail.org>; Fri, 31 Oct 2014 11:18:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.1\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 9PgrCZlUVBkK for <notmuch@notmuchmail.org>;\r
+       Fri, 31 Oct 2014 11:18:16 -0700 (PDT)\r
+Received: from resqmta-ch2-02v.sys.comcast.net\r
+       (resqmta-ch2-02v.sys.comcast.net [69.252.207.34])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id C07FE431FAF\r
+       for <notmuch@notmuchmail.org>; Fri, 31 Oct 2014 11:18:16 -0700 (PDT)\r
+Received: from resomta-ch2-03v.sys.comcast.net ([69.252.207.99])\r
+       by resqmta-ch2-02v.sys.comcast.net with comcast\r
+       id 9uJ81p00729Cfhx01uJFXF; Fri, 31 Oct 2014 18:18:15 +0000\r
+Received: from odin.tremily.us ([24.18.63.50])\r
+       by resomta-ch2-03v.sys.comcast.net with comcast\r
+       id 9uJD1p00Y152l3L01uJEqz; Fri, 31 Oct 2014 18:18:15 +0000\r
+Received: by odin.tremily.us (Postfix, from userid 1000)\r
+       id 2C2CE1440C36; Fri, 31 Oct 2014 11:18:13 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin;\r
+       t=1414779493; bh=Gpjho2Ci/yDqr/kti83DN0jrgE1l+AdrCNrx75kDB74=;\r
+       h=Date:From:To:Cc:Subject:References:In-Reply-To;\r
+       b=QdvP/arKYzbGxLYnVLWjHN5i+z1eoqyZroliYqqSogyU3XE0z4KMHy5Wi+MSlWFtJ\r
+       Vx70N2kmGoLSvIC78Dvk6FJVyPHSIJEDXBLjQi3nPFVUUhZyRYVnS8unb+/4534Vf7\r
+       Ms9uWcHjYksSkeMbuR8CTNEIcag+DPiQnMVkDGLE=\r
+Date: Fri, 31 Oct 2014 11:18:13 -0700\r
+From: "W. Trevor King" <wking@tremily.us>\r
+To: Jesse Rosenthal <jrosenthal@jhu.edu>\r
+Subject: Re: [PATCH] test: Make gen-threads work with python3\r
+Message-ID: <20141031181812.GS15443@odin.tremily.us>\r
+References: <1414776805-30000-1-git-send-email-jrosenthal@jhu.edu>\r
+       <20141031174153.GQ15443@odin.tremily.us> <87bnosdsjh.fsf@jhu.edu>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; micalg=pgp-sha1;\r
+       protocol="application/pgp-signature"; boundary="vdyjigDobekge4RG"\r
+Content-Disposition: inline\r
+In-Reply-To: <87bnosdsjh.fsf@jhu.edu>\r
+OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;\r
+       url=http://tremily.us/pubkey.txt\r
+User-Agent: Mutt/1.5.23 (2014-03-12)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\r
+       s=q20140121; t=1414779495;\r
+       bh=A0Ii2kqfM7UR3h0csNuXi2dv2aQjU6l2ly1VayuhkiA=;\r
+       h=Received:Received:Received:Date:From:To:Subject:Message-ID:\r
+       MIME-Version:Content-Type;\r
+       b=aAHmRL+ROdxjA5yKlnR4EpjmJeelqTWMuwsXhEhe5i9ecU1Haa7HSxo8pNLzAye/Z\r
+       fTF9yeBBhDQzQfBEUixIsT3OfsyczzaMrPogwBg3GhXAu99QCTsvCOvy6snXMyrGu9\r
+       QR610B47SyXK+qPBRgvYTyyUBdxsuEJ75vQ2Ub8bmwn8NzkBtIzWguisBhDp96JIHz\r
+       t2QVa4LGTqNcSNEOtTUiBJLZ3zKI60c0/gMx4qXqQGLNwwcqaVGHH21WXy55J0rcG7\r
+       H+Dqb81Y9WXJOzgROCOvr4rKNeYj/6gz/pDLZ6usXYukqcSZmI64YQCiisrwL+ufe0\r
+       byP9m4+oYic/A==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 31 Oct 2014 18:18:24 -0000\r
+\r
+\r
+--vdyjigDobekge4RG\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Fri, Oct 31, 2014 at 02:04:50PM -0400, Jesse Rosenthal wrote:\r
+> W. Trevor King writes:\r
+> > On Fri, Oct 31, 2014 at 01:33:25PM -0400, Jesse Rosenthal wrote:\r
+> >> We instead initalize the dictionary using the dict comprehension\r
+> >> and then update it with the values from the tree. This will work\r
+> >> with both python2 and python3.\r
+> >\r
+> > Dict comprehensions are new in 2.7 [1,2], so this drops support\r
+> > for systems where =E2=80=98python=E2=80=99 means =E2=80=98python2.6=E2=\r
+=80=99.  Personally, I'm\r
+> > fine with that, but I thought I'd point it out in case 2.6 users\r
+> > wanted to push back ;).\r
+>=20\r
+> The comprehension was already in the previous version, so I figured that\r
+> people were already cool with 2.7+.\r
+\r
+Ah, good point :).  Besides looking good to me, I can confirm that I\r
+see a TypeError (and a lot of CPU usage ;) from T260-thread-order.sh\r
+before this patch which is fixed by this patch.\r
+\r
+Cheers,\r
+Trevor\r
+\r
+--=20\r
+This email may be signed or encrypted with GnuPG (http://www.gnupg.org).\r
+For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy\r
+\r
+--vdyjigDobekge4RG\r
+Content-Type: application/pgp-signature; name="signature.asc"\r
+Content-Description: OpenPGP digital signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v2\r
+\r
+iQIcBAEBAgAGBQJUU9JiAAoJEG8/JgBt8ol88CgP/3eB+Xr4T2KBCWgdCCHV3M/G\r
+xhcpqPnXZGw8jVQLn4RVbthrg4Z0ZbbMrpMstdqPnh6+SPlqzXUdvverz6ILlcdL\r
+MCWHDll3wiq6d9Fa2FkdQZMD3UUpYdEP/JzVM77VDQGB0EYytDs1jIHh6K1a00uE\r
+UvdBlT87ik1yoHWIBbb/n56ZWcRq3wTMcveDBaPo0Z0nrxtT8kZM0RNX6ONuYvFF\r
+8DZeREVeImjy/vgIltuXTTpZ7QdDrnuxYpv3JE08vOc2hLPtJNXhQJDypmGX7N55\r
+JfumCL0cOjlQe18tChxnlfPj7X6QqVy0wvwG+8GtJhNPAmiVhATQDpM9AxCslk4a\r
+d3LFEus1jrIysq5q86gRTmWJeGTz+XmJNqvod35cPKsWOR2WI4nvwVuqarktvFZi\r
+2kvyCqVJ80gYCyGqhQ1VkpeNf8vk1g/+isrd9Ja928pfYnfSeVRz4t2PnlCuigZA\r
+5HeKGQVTyEf6xamR9SrB2nfTMLUW9inXofEhpzX4n5uRTyPvf4ifxuqhLGBDtj+h\r
+R01COJy1Jd7x2CBErqABjk+ygKWzZd5GKoCStzFVJeAQvwm7TSAcNyPZsE/x+sLw\r
+m0Q9yCP56i4fQDTjbP4Xj0F3pnmamI0TDu31POk0LyxQmA4rK1XlHoOHxu8rNzcv\r
+sgTX8zho6VJ3NVP6TzQJ\r
+=WRqI\r
+-----END PGP SIGNATURE-----\r
+\r
+--vdyjigDobekge4RG--\r