Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

diff --git a/f0/fe899fc35335f3b63073c024ca8500d5f422d9 b/f0/fe899fc35335f3b63073c024ca8500d5f422d9
new file mode 100644 (file)
index 0000000..ffe5b48
--- /dev/null
+++ b/f0/fe899fc35335f3b63073c024ca8500d5f422d9
@@ -0,0 +1,136 @@
+Return-Path: <daniel@schoepe.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B660C431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  7 Mar 2012 12:04:28 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.502\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.502 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,\r
+       FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id WfCAAdAwyfAz for <notmuch@notmuchmail.org>;\r
+       Wed,  7 Mar 2012 12:04:27 -0800 (PST)\r
+Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com\r
+ [74.125.83.53])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ B3472431FB6   for <notmuch@notmuchmail.org>; Wed,  7 Mar 2012 12:04:27 -0800\r
+ (PST)\r
+Received: by eekb47 with SMTP id b47so3438604eek.26\r
+       for <notmuch@notmuchmail.org>; Wed, 07 Mar 2012 12:04:26 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google;\r
+       h=sender:from:to:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=Z6eoupzLnLpynutyx7IZ38iJavFQqT3T4s7wjXmJKUQ=;\r
+       b=DXpKrLLy9scKxxYPaZo7t6tKx6xihnna06USZfb9XeaiKtfOpZCgKrB2cwhJfy27VV\r
+       ZZMhGNctHIqsK7gRcNpzkq06tekqbGHhq74fboGtD0TOY1qR5xtXmChGSeC4A2Mr5ymZ\r
+       l7jXUDrO/a40VTGGdWNgwukqb0CoBqWZSLjRA=\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=sender:from:to:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type:x-gm-message-state;\r
+       bh=Z6eoupzLnLpynutyx7IZ38iJavFQqT3T4s7wjXmJKUQ=;\r
+       b=MQzdINQzHdsUuEj6zsdVBhewQicWVlqkbbUMX9zI3Tf8i8sMk/vsgry74pyh/mGVad\r
+       8T1VBQx3XaQM15IAxjeMqzLIg/Bm3KAThbj52DIfX2A/vWVIAwseAEiVNJ7t2eSAZWow\r
+       FX2nNfep5LkzgAxNDlYGBqkA1m7fvJEWX4cpxqkC5lP0twBMpkq4YBeT+b1OFFO+k0yM\r
+       0hfwcw/Tfa+GWONmLFM4FzSL7nt21h2DChzSVJztCEzlaL1C67Z9g+qYg28ECeX8kLhq\r
+       1ioeJ+qkV+DKENegRW6L8aSh0Qn52woFTFPZ9l15fsPfWcoiHDvVv/WZ1MINDSqOj2M9\r
+       kSOw==\r
+Received: by 10.213.13.72 with SMTP id b8mr847382eba.153.1331150666303;\r
+       Wed, 07 Mar 2012 12:04:26 -0800 (PST)\r
+Received: from localhost (p4FC78F99.dip0.t-ipconnect.de. [79.199.143.153])\r
+       by mx.google.com with ESMTPS id w9sm19720662eei.8.2012.03.07.12.04.23\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 07 Mar 2012 12:04:24 -0800 (PST)\r
+Sender: Daniel Schoepe <daniel@schoepe.org>\r
+From: Daniel Schoepe <daniel.schoepe@googlemail.com>\r
+To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,\r
+       Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello\r
+In-Reply-To: <87aa3s427n.fsf@praet.org>\r
+References: <1310079227-19120-1-git-send-email-daniel.schoepe@googlemail.com>\r
+       <1329490088-8323-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1329490088-8323-2-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87ipio33ce.fsf@zancas.localnet> <87aa3s427n.fsf@praet.org>\r
+User-Agent: Notmuch/0.11.1+309~g6296425 (http://notmuchmail.org)\r
+       Emacs/24.0.93.1 (x86_64-pc-linux-gnu)\r
+Date: Wed, 07 Mar 2012 21:04:17 +0100\r
+Message-ID: <87ipigtby6.fsf@schoepe.localhost>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-Gm-Message-State:\r
+ ALoCoQkrQDz1kmgQ4vF0Ux7xbeat1LgQczvuEx1P+qJ0oTI22UkrC1T8JX262cM21koyTfsGu/Z4\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 07 Mar 2012 20:04:28 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Wed, 07 Mar 2012 20:53:48 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> On Thu, 01 Mar 2012 08:36:33 -0400, David Bremner <david@tethera.net> wro=\r
+te:\r
+> >=20\r
+> > Pushed, finally. Thanks for both of your hard work on this.\r
+> >\r
+>=20\r
+> 625 lines changed (425 added, 200 removed), in a *single* commit ?\r
+>=20\r
+> It's a useful bit of functionality which definitely deserves to be\r
+> included, and I do recognize and appreciate all the hard work that\r
+> went into it, but... am I the only one who was a bit surprised to\r
+> see this patch being applied [1] as-is?\r
+\r
+I think it is hard to split this patch up into meaningful smaller\r
+pieces, since it mainly moves parts from notmuch-hello into separate\r
+functions and adds some defcustoms. So, the main opportunities for\r
+splitting would be to do this moving of code into functions one function\r
+per commit and to put the defcustoms and their quite lengthy\r
+documentation in a separate commit (which would leave you with an\r
+intermediate version that's seriously lacking in documentation).\r
+\r
+I'm not sure if those two things are that useful, but if there's\r
+consensus that the patch shouldn't stay in the way it is, I can give it\r
+a shot (although it'd be a lot of tedious work).\r
+\r
+Cheers,\r
+Daniel\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBAgAGBQJPV79BAAoJEIaTAtce+Z+Jm8YQAJDID9EyQL4lfLo6iwGh6qNu\r
+6ZdimOZ9evbH5aejIV+cqQcRI8gTgidNqWiL3lZG660vPni8pL7Tk8pCboGab13I\r
+ezllVagCYYhq2N78WOv1m7xzOrvObHcyH0T5lVVxVrRzymmaLFp09ZYSvU2vwjju\r
+k/CpDUwxF3i5l7L664qsnRft2bXoP1HwbZPoSPfQhEYSDZKJ6/nIlwaIBF1C3oUq\r
+0Xknemg9XlNBdJQv/OblTLuFMOxRQOuemfVzWVNCT3qJiNhhjhy/MEAE9zyDBAGE\r
+RQrEdpehXLyoASTaPMEpqN7tIz8wtHyGRmqQv8epdspzuxBW0reSUHaVg0K4rpTX\r
+gG+dd+Tc+Fi45bKC+2QEiWm4+lb7gNSRoIBV8+f9QiCjKrzxp7U/443x0yD9d2SS\r
+zn1HGOTBpOQYojfy+19YUtqqcoJDE3FSGPk1jMWt93cM+sM402iVN9O6igmZXG9u\r
+Cgg6XlM+mCjrT2qGfxQ5Cv/+itaGDltFDhVY17sLgBJUqD8VR1DkJrjuHiqR8Rh1\r
+E+8mrPr0LgUT6C2lk0FhZs4UGc+UUJMNhe8lTW8AASM06Mjx/Uf6PBnZEwQcygRM\r
+k7wGAtz35R8q2fhFomV7wmLErMT8vAEV5ZsARQfHNQwQphudSIGsElhZMyxgZsXP\r
+ADrTY9Uto9ftAggS5gcC\r
+=ZtOc\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r