pull up r20034 from trunk

 r20034@cathode-dark-space:  jaltman | 2007-10-01 01:32:26 -0400
 ticket: new
 subject: NIM: BUG: APP: notification icon tooltip wrong string

 The Network Identity Manager notification icon can display a tooltip
 when the user hovers the mouse cursor over it.  It is currently used
 to indicate the default identity (if one is found).  However, when
 retrieving the name of the default identity, the size of the buffer
 was left unspecified.  This patch specifies the correct buffer size.

 The function called with the incorrect buffer size was
 kcdb_identity_get_name().  That function does not write more than
 KCDB_IDENT_MAXCCH_NAME characters regardless of the size of the buffer
 specified, and the buffer that was passed in is allocated to be this
 size.  No buffer overrun was present in the existing code, although
 the behavior was incorrect.

ticket: 5797
version_fixed: 1.6.3

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-6@20075 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/windows/identity/ui/credwnd.c b/src/windows/identity/ui/credwnd.c
index 5e9740ecdfb70a42af595161a06403618ce30b5c..5b246806d88b90787091db49a7fdace0f7a71171 100644 (file)
--- a/src/windows/identity/ui/credwnd.c
+++ b/src/windows/identity/ui/credwnd.c
@@ -3603,6 +3603,8 @@ cw_kmq_wm_dispatch(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam)
             cw_update_extents(tbl, TRUE);
             InvalidateRect(hwnd, NULL, FALSE);
 
+            cb = sizeof(idname);
+
             if (KHM_SUCCEEDED(kcdb_identity_get_default(&defid)) &&
                 defid != NULL &&
                 KHM_SUCCEEDED(kcdb_identity_get_name(defid, idname, &cb)) &&