Re: [PATCH 2/8] lib: private string map (associative array) API

diff --git a/ab/ee53dd137c0d33a8b3fbba4dbac97391df01ed b/ab/ee53dd137c0d33a8b3fbba4dbac97391df01ed
new file mode 100644 (file)
index 0000000..c89d571
--- /dev/null
+++ b/ab/ee53dd137c0d33a8b3fbba4dbac97391df01ed
@@ -0,0 +1,87 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 990B06DE0159\r
+ for <notmuch@notmuchmail.org>; Mon, 13 Jun 2016 01:11:27 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.569\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.569 tagged_above=-999 required=5 tests=[AWL=-0.083,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id LCxPDj2AiK3h for <notmuch@notmuchmail.org>;\r
+ Mon, 13 Jun 2016 01:11:19 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id BB2CE6DE0127\r
+ for <notmuch@notmuchmail.org>; Mon, 13 Jun 2016 01:11:17 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 07925100063;\r
+ Mon, 13 Jun 2016 11:10:51 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/8] lib: private string map (associative array) API\r
+In-Reply-To: <1465779955-5539-3-git-send-email-david@tethera.net>\r
+References: <1465779955-5539-1-git-send-email-david@tethera.net>\r
+ <1465779955-5539-3-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.22+54~gf8fd4ff (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 13 Jun 2016 11:10:50 +0300\r
+Message-ID: <m2oa755x11.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 13 Jun 2016 08:11:27 -0000\r
+\r
+On Mon, Jun 13 2016, David Bremner <david@tethera.net> wrote:\r
+\r
+> The choice of array implementation is deliberate, for future iterator support\r
+> ---\r
+>  lib/Makefile.local    |   1 +\r
+>  lib/notmuch-private.h |  11 ++++\r
+>  lib/string-map.c      | 153 ++++++++++++++++++++++++++++++++++++++++++++++++++\r
+>  3 files changed, 165 insertions(+)\r
+>  create mode 100644 lib/string-map.c\r
+>\r
+> diff --git a/lib/Makefile.local b/lib/Makefile.local\r
+> index beb9635..9280880 100644\r
+> --- a/lib/Makefile.local\r
+> +++ b/lib/Makefile.local\r
+> @@ -40,6 +40,7 @@ libnotmuch_c_srcs =                \\r
+>      $(dir)/messages.c       \\r
+>      $(dir)/sha1.c           \\r
+>      $(dir)/built-with.c     \\r
+> +    $(dir)/string-map.c    \\r
+>      $(dir)/tags.c\r
+\r
+I suggest everyone to install editor which supports showing tabs & spaces\r
+e.g. in different color and also visualizes trailing whitespace & trailing\r
+empty lines...\r
+\r
+... personally I've been pretty happy with ethan-wspace in emacs to do\r
+that (I did M-x ethan-wspace-highlight-tabs-mode (in notmuch-show mode\r
+buffer) to recognize the above).\r
+\r
+If there is no need to further changes then the above can IMO go in --\r
+the same "dirtiness" can be observed in $(dir)/query-fp.cc 10 lines below...\r
+\r
+HTH.\r
+\r
+Tomi\r
+\r