admin_internal.h (_KADM5_CHECK_HANDLE): Add parenthesis around

	assignment used as truth value to reduce gcc -Wall flames.

misc_free.c (kadm5_free_name_list, krb5_free_key_data_contents: Add
	KADM5_OK return value upon success.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@8823 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/kadm5/ChangeLog b/src/lib/kadm5/ChangeLog
index ade62cc9824b6b5d37fc5cb2809c0681d20a2f2b..f6be228cb1748e581ed867b543e2131abf90c2e1 100644 (file)
--- a/src/lib/kadm5/ChangeLog
+++ b/src/lib/kadm5/ChangeLog
@@ -1,3 +1,11 @@
+Thu Jul 25 12:04:32 1996  Theodore Y. Ts'o  <tytso@mit.edu>
+
+       * admin_internal.h (_KADM5_CHECK_HANDLE): Add parenthesis around
+               assignment used as truth value to reduce gcc -Wall flames.
+
+       * misc_free.c (kadm5_free_name_list, krb5_free_key_data_contents: 
+               Add KADM5_OK return value upon success.
+
 Wed Jul 24 18:18:39 1996  Tom Yu  <tlyu@voltage-multiplier.mit.edu>
 
        * Makefile.in, configure.in: fix shared lib lossage by

diff --git a/src/lib/kadm5/admin_internal.h b/src/lib/kadm5/admin_internal.h
index d73837e6797e24c00022805fb15d2687dd5fb588..d2d1533bc287d09d9be4e4e862181834ad4868b7 100644 (file)
--- a/src/lib/kadm5/admin_internal.h
+++ b/src/lib/kadm5/admin_internal.h
@@ -55,7 +55,7 @@
  * Got that?
  */
 #define _KADM5_CHECK_HANDLE(handle) \
-{ int code; if (code = _kadm5_check_handle((void *)handle)) return code; }
+{ int code; if ((code = _kadm5_check_handle((void *)handle))) return code; }
 
 kadm5_ret_t _kadm5_chpass_principal_util(void *server_handle,
                                         void *lhandle,

diff --git a/src/lib/kadm5/misc_free.c b/src/lib/kadm5/misc_free.c
index cfe28a411708218c12897299cbd5669e6af50398..f1cd1278b6b68c7ee67557e6b60643c148a37dd0 100644 (file)
--- a/src/lib/kadm5/misc_free.c
+++ b/src/lib/kadm5/misc_free.c
@@ -35,6 +35,7 @@ kadm5_ret_t
     while (count--)
          free(names[count]);
      free(names);
+    return KADM5_OK;
 }
 
 
@@ -52,6 +53,7 @@ kadm5_ret_t krb5_free_key_data_contents(context, key)
               free(key->key_data_contents[i]);
          }
      }
+     return KADM5_OK;
 }
 
 kadm5_ret_t