prefer structure assignment to memcpy

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21876 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/appl/bsd/krlogin.c b/src/appl/bsd/krlogin.c
index 98b61ac2bc908c93f0b6b65db7e6d83133250b3e..0272b44aa3fdf4fd7486793c680f31f492645d81 100644 (file)
--- a/src/appl/bsd/krlogin.c
+++ b/src/appl/bsd/krlogin.c
@@ -1663,8 +1663,7 @@ int f;
        **      copy the initial modes we saved into sb; this is
        **      for restoring to the initial state
        */
-       (void)memcpy(&sb, &defmodes, sizeof(defmodes));
-       
+       sb = defmodes;
 #else
        sb.sg_flags &= ~(CBREAK|RAW|TBDELAY);
        sb.sg_flags |= defflags|tabflag;

diff --git a/src/kadmin/ktutil/ktutil_funcs.c b/src/kadmin/ktutil/ktutil_funcs.c
index 6fa2a3025dc6e64c3c2016aa326a49d376a41eed..e3e9204d964d0f8d2732c475ecc2e5c667cb5a32 100644 (file)
--- a/src/kadmin/ktutil/ktutil_funcs.c
+++ b/src/kadmin/ktutil/ktutil_funcs.c
@@ -172,7 +172,7 @@ krb5_error_code ktutil_add(context, list, princ_str, kvno,
            goto cleanup;
        memset(password.data, 0, password.length);
        password.length = 0;
-       memcpy(&lp->entry->key, &key, sizeof(krb5_keyblock));
+       lp->entry->key = key;
     } else {
         printf("Key for %s (hex): ", princ_str);
        fgets(buf, BUFSIZ, stdin);

diff --git a/src/lib/crypto/arcfour/arcfour.c b/src/lib/crypto/arcfour/arcfour.c
index 085c997ed420de61e3b4a66240b457c5004669b4..ea3129688a093ccb4bb0ebdebdda1cf9d415de25 100644 (file)
--- a/src/lib/crypto/arcfour/arcfour.c
+++ b/src/lib/crypto/arcfour/arcfour.c
@@ -81,7 +81,7 @@ krb5_arcfour_encrypt(const struct krb5_enc_provider *enc,
   d1.data=malloc(d1.length);
   if (d1.data == NULL)
     return (ENOMEM);
-  memcpy(&k1, key, sizeof (krb5_keyblock));
+  k1 = *key;
   k1.length=d1.length;
   k1.contents= (void *) d1.data;
 
@@ -91,7 +91,7 @@ krb5_arcfour_encrypt(const struct krb5_enc_provider *enc,
     free(d1.data);
     return (ENOMEM);
   }
-  memcpy(&k2, key, sizeof (krb5_keyblock));
+  k2 = *key;
   k2.length=d2.length;
   k2.contents=(void *) d2.data;
 
@@ -102,7 +102,7 @@ krb5_arcfour_encrypt(const struct krb5_enc_provider *enc,
     free(d2.data);
     return (ENOMEM);
   }
-  memcpy(&k3, key, sizeof (krb5_keyblock));
+  k3 = *key;
   k3.length=d3.length;
   k3.contents= (void *) d3.data;
   
@@ -201,7 +201,7 @@ krb5_arcfour_decrypt(const struct krb5_enc_provider *enc,
   d1.data=malloc(d1.length);
   if (d1.data == NULL)
     return (ENOMEM);
-  memcpy(&k1, key, sizeof (krb5_keyblock));
+  k1 = *key;
   k1.length=d1.length;
   k1.contents= (void *) d1.data;
   
@@ -211,7 +211,7 @@ krb5_arcfour_decrypt(const struct krb5_enc_provider *enc,
     free(d1.data);
     return (ENOMEM);
   }
-  memcpy(&k2, key, sizeof(krb5_keyblock));
+  k2 = *key;
   k2.length=d2.length;
   k2.contents= (void *) d2.data;
 
@@ -222,7 +222,7 @@ krb5_arcfour_decrypt(const struct krb5_enc_provider *enc,
     free(d2.data);
     return (ENOMEM);
   }
-  memcpy(&k3, key, sizeof(krb5_keyblock));
+  k3 = *key;
   k3.length=d3.length;
   k3.contents= (void *) d3.data;
 

diff --git a/src/lib/gssapi/mechglue/g_initialize.c b/src/lib/gssapi/mechglue/g_initialize.c
index 1149384a281ef342040cab358b3d418c63498bfe..85fbe63219fb029cf0860f8a46d25da36544c544 100644 (file)
--- a/src/lib/gssapi/mechglue/g_initialize.c
+++ b/src/lib/gssapi/mechglue/g_initialize.c
@@ -638,7 +638,7 @@ gssint_register_mechinfo(gss_mech_info template)
                releaseMechInfo(&new_cf);
                return ENOMEM;
        }
-       memcpy(new_cf->mech, template->mech, sizeof(struct gss_config));
+       *new_cf->mech = *template->mech;
        if (template->mech_type != NULL)
                new_cf->mech->mech_type = *(template->mech_type);
        new_cf->mech_type = &new_cf->mech->mech_type;

diff --git a/src/lib/kadm5/srv/svr_principal.c b/src/lib/kadm5/srv/svr_principal.c
index c44463bf727cd8cda501f318d60b7ee9ac947b1c..4ee842f4ccfefc75ca4060eff482a1a1acf72382 100644 (file)
--- a/src/lib/kadm5/srv/svr_principal.c
+++ b/src/lib/kadm5/srv/svr_principal.c
@@ -56,7 +56,7 @@ kadm5_copy_principal(krb5_context context, krb5_const_principal inprinc, krb5_pr
         return ENOMEM;
 
     VALGRIND_CHECK_DEFINED(*inprinc);
-    memcpy(tempprinc, inprinc, sizeof(krb5_principal_data));
+    *tempprinc = *inprinc;
 
     nelems = (int) krb5_princ_size(context, inprinc);
     tempprinc->data = krb5_db_alloc(context, NULL, nelems * sizeof(krb5_data));

diff --git a/src/lib/krb5/krb/serialize.c b/src/lib/krb5/krb/serialize.c
index f78bc16183beb595bb73adf833a70d77f95eaeb0..d1edcf239e16703833a9838639b9ddefb1f0dfca 100644 (file)
--- a/src/lib/krb5/krb/serialize.c
+++ b/src/lib/krb5/krb/serialize.c
@@ -84,7 +84,7 @@ krb5_register_serializer(krb5_context kcontext, const krb5_ser_entry *entry)
            kret = ENOMEM;
     }
     else
-       memcpy(stable, entry, sizeof(krb5_ser_entry));
+       *stable = *entry;
     return(kret);
 }
 \f