response

diff --git a/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn b/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
index 0e9d61398bcd945b2e6201a018f759447c0e57ab..c7438feb6b035ce7c0c17029d47ba45269e1abaa 100644 (file)
--- a/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
+++ b/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
@@ -4,6 +4,15 @@ I modeled the message on `rename.pm`, which used a lowercase initial letter and
 
 Diff follows. --[[Daniel Andersson]]
 
+> This is somewhat intentional. It's pretty usual for changes to be made
+> to a wiki without bothering to say what changed; the change speaks for
+> itself and it would just be clutter to mention what file was changed,
+> since any reasonable interface will show the filename, or a link,
+> or some summary of what files were affected when showing a change.
+> 
+> Also your patch stomps over any commit message that the user *does*
+> provide, so certianly cannot be applied as-is. --[[Joey]] 
+
 [[!tag patch]]
 
 ---

diff --git a/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn b/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn
index f000878b751069f027c7300a38e01d8e338191ac..8b1dd74a7df832f38507b197512bf795668518a9 100644 (file)
--- a/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn
+++ b/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn
@@ -2,6 +2,16 @@ As [[Add instructive commit messages for add _47_ edit pages]], but for `remove.
 
 I use a `join()` since it at least looks like the plugin is able to remove several pages at once (`foreach` looping over file parameters), thus holding multiple entries in `@pages`. I haven't seen this happen, though.
 
+> I feel that anything that shows a change should show what files were
+> changed (at least as an easily accessible option), so mentioning
+> filenames in commits is almost always clutter.
+> 
+> It could be argued that there should be no message at all here, unless
+> the user provides one (which they currently cannot), as is done when
+> adding files. But the entire removal of a page from a wiki is a fairly
+> unusual circumstance that is probably best highlighted as such in
+> recentchanges. --[[Joey]]
+
 Diff follows. --[[Daniel Andersson]]
 
 [[!tag patch]]