Re: [PATCH 0/5] Fix notmuch_database_get_directory API

diff --git a/7c/852fd1d6fc657a7afd966964766b549af344b3 b/7c/852fd1d6fc657a7afd966964766b549af344b3
new file mode 100644 (file)
index 0000000..d84e68a
--- /dev/null
+++ b/7c/852fd1d6fc657a7afd966964766b549af344b3
@@ -0,0 +1,94 @@
+Return-Path: <teythoon@jade-hamburg.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EBF62431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 13 May 2012 14:55:42 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nKP-KO2Z-0ep for <notmuch@notmuchmail.org>;\r
+       Sun, 13 May 2012 14:55:42 -0700 (PDT)\r
+Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 7AA7C431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 13 May 2012 14:55:42 -0700 (PDT)\r
+Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by mail.cryptobitch.de (Postfix) with ESMTPSA id F3C61587DD8\r
+       for <notmuch@notmuchmail.org>; Sun, 13 May 2012 23:55:40 +0200 (CEST)\r
+Received: by mail.jade-hamburg.de (Postfix, from userid 401)\r
+       id 5BCE2DF2A3; Sun, 13 May 2012 23:55:40 +0200 (CEST)\r
+Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de\r
+ [10.1.1.153]) (using TLSv1 with cipher AES256-SHA (256/256 bits))     (No client\r
+ certificate requested) (Authenticated sender: teythoon)       by\r
+ mail.jade-hamburg.de (Postfix) with ESMTPSA id 0D7CFDF2A0;    Sun, 13 May 2012\r
+ 23:55:39 +0200 (CEST)\r
+Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77)\r
+       (envelope-from <teythoon@thinkbox.jade-hamburg.de>)\r
+       id 1STglO-0004K0-I1; Sun, 13 May 2012 23:55:38 +0200\r
+Content-Type: text/plain; charset="utf-8"\r
+MIME-Version: 1.0\r
+Content-Transfer-Encoding: quoted-printable\r
+From: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+User-Agent: alot/0.3+\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, Austin Clements <amdragon@MIT.EDU>,\r
+       notmuch@notmuchmail.org\r
+References: <1336939029-13969-1-git-send-email-amdragon@mit.edu>\r
+       <m2txzjlsax.fsf@guru.guru-group.fi>\r
+In-Reply-To: <m2txzjlsax.fsf@guru.guru-group.fi>\r
+Message-ID: <20120513215538.15106.43740@thinkbox.jade-hamburg.de>\r
+Subject: Re: [PATCH 0/5] Fix notmuch_database_get_directory API\r
+Date: Sun, 13 May 2012 23:55:38 +0200\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 May 2012 21:55:43 -0000\r
+\r
+Quoting Tomi Ollila (2012-05-13 22:49:58)\r
+> On Sun, May 13 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> =\r
+\r
+> > This is a proposed last-minute change for 0.13.  It fixes the\r
+> > notmuch_database_get_directory API in the same way we're fixing\r
+> > notmuch_database_open, etc in this release.  Since this is a\r
+> > backwards-incompatible change, it would be nice to lump it with the\r
+> > other API-breaking changes.\r
+> >\r
+> > To keep the patch simple, this does not change the behavior of\r
+> > notmuch_database_get_directory, but it puts us in a good position to\r
+> > fix it in the future.\r
+> =\r
+\r
+> Looks good to me (and applied in my current environment). The c/c++ =\r
+\r
+> changes were easy to understand and the python/go/ruby binding\r
+> changes looks like the old changes -- but those who understand more\r
+> (and actually uses those bindings) could do better review.\r
+\r
+I'd say the changes to the python and go bindings are fine.\r
+\r
+> It would be nice to get those in so that we may have chance not\r
+> updating SONAME for notmuch 0.14.\r
+\r
+Yes, I'd love to see this in 0.13 as well, but I don't really see the\r
+problem with breaking the api if this fixes design issues. After all,\r
+notmuch is young and so are all the projects building uppon it.\r
+\r
+Justus\r