krb5_get_cred_via_tkt() should null out_cred on errors

Helper function krb5_kdcrep2creds(), called from
krb5_get_cred_via_tkt(), should null its output pointer after freeing
allocated memory, to avoid returning an invalid pointer.

ticket: new
tags: pullup
target_version: 1.6.4
component: krb5-libs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20527 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/krb5/krb/gc_via_tkt.c b/src/lib/krb5/krb/gc_via_tkt.c
index 7ecd2813da67e2286c324f0c9751ed5d9c46dfe2..3a9c21818721adf82068f4836aa925c8cc93a774 100644 (file)
--- a/src/lib/krb5/krb/gc_via_tkt.c
+++ b/src/lib/krb5/krb/gc_via_tkt.c
@@ -97,6 +97,7 @@ cleanup_keyblock:
 
 cleanup:
     free (*ppcreds);
+    *ppcreds = NULL;
     return retval;
 }