make_ap_req_v1 leaks memory

	* init_sec_context.c (make_ap_req_v1): Free checksum_data if
	needed, to avoid leaking memory.  Found by Kent Wu.

ticket: new
target_version: 1.3
tags: pullup
component: krb5-libs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15618 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/gssapi/krb5/ChangeLog b/src/lib/gssapi/krb5/ChangeLog
index fdecc83dcb9dbcc75e1d3e0b219efadbdc71ba55..10f85ad88d9b5907ef0bd301630e98216e74c746 100644 (file)
--- a/src/lib/gssapi/krb5/ChangeLog
+++ b/src/lib/gssapi/krb5/ChangeLog
@@ -1,3 +1,8 @@
+2003-06-13  Tom Yu  <tlyu@mit.edu>
+
+       * init_sec_context.c (make_ap_req_v1): Free checksum_data if
+       needed, to avoid leaking memory.  Found by Kent Wu.
+
 2003-05-13  Tom Yu  <tlyu@mit.edu>
 
        * gssapi_krb5.h: Remove check for GSS_RFC_COMPLIANT_OIDS.

diff --git a/src/lib/gssapi/krb5/init_sec_context.c b/src/lib/gssapi/krb5/init_sec_context.c
index ed363115287ea170b93b1559e723d71cd28161f9..a95d3048acdf393e63eeb216852f4d8ce4eb97d4 100644 (file)
--- a/src/lib/gssapi/krb5/init_sec_context.c
+++ b/src/lib/gssapi/krb5/init_sec_context.c
@@ -316,6 +316,8 @@ make_ap_req_v1(context, ctx, cred, k_cred, chan_bindings, mech_type, token)
    code = 0;
     
  cleanup:
+   if (checksum_data && checksum_data->data)
+       krb5_free_data_contents(context, checksum_data);
    if (ap_req.data)
        krb5_free_data_contents(context, &ap_req);