Memory leak, and possible freed-memory dereference, in an error (small

allocation failure) path.

ticket: 5997

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20482 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/krb5/krb/gic_opt.c b/src/lib/krb5/krb/gic_opt.c
index 227391ae42e17fcf4a5b7bb83e9068a1dd900107..ab73d2c8e1ff074aded52eeab648f94c892ee688 100644 (file)
--- a/src/lib/krb5/krb/gic_opt.c
+++ b/src/lib/krb5/krb/gic_opt.c
@@ -306,6 +306,7 @@ add_gic_opt_ext_preauth_data(krb5_context context,
        newpad = realloc(opte->opt_private->preauth_data, newsize);
     if (newpad == NULL)
        return ENOMEM;
+    opte->opt_private->preauth_data = newpad;
 
     i = opte->opt_private->num_preauth_data;
     newpad[i].attr = strdup(attr);
@@ -317,7 +318,6 @@ add_gic_opt_ext_preauth_data(krb5_context context,
        return ENOMEM;
     }
     opte->opt_private->num_preauth_data += 1;
-    opte->opt_private->preauth_data = newpad;
     return 0;
 }