Re: [PATCH] STYLE: Initial draft of coding style document

diff --git a/c4/35f3480da99dbb814635f491950e3cc28771b2 b/c4/35f3480da99dbb814635f491950e3cc28771b2
new file mode 100644 (file)
index 0000000..5e87ece
--- /dev/null
+++ b/c4/35f3480da99dbb814635f491950e3cc28771b2
@@ -0,0 +1,89 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5E5FE431E64\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 06:38:53 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id RMU7P9D2eA9S for <notmuch@notmuchmail.org>;\r
+       Mon, 30 Jan 2012 06:38:52 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id B88CA431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 06:38:52 -0800 (PST)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id A330068056; Mon, 30 Jan 2012 16:38:55 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] STYLE: Initial draft of coding style document\r
+In-Reply-To: <1327708018-1107-1-git-send-email-david@tethera.net>\r
+References: <1327708018-1107-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.11+129~g3b527ae (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 30 Jan 2012 16:38:55 +0200\r
+Message-ID: <m2ehuhdzls.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 14:38:53 -0000\r
+\r
+On Fri, 27 Jan 2012 19:46:58 -0400, David Bremner <david@tethera.net> wrote:\r
+> From: David Bremner <bremner@debian.org>\r
+\r
+[ ... ]\r
+\r
+> +\r
+> +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8.\r
+> +  Tabs should be only at the beginning of the line.\r
+\r
+So, after initial indentation (with tabs) there should not be further\r
+tabs? We'll be using the former instead of the latter in these 2 below?\r
+\r
+/* excerpt from command-line-arguments.h -- indentation without tabs */\r
+\r
+enum notmuch_opt_type {\r
+    NOTMUCH_OPT_END = 0,\r
+    NOTMUCH_OPT_BOOLEAN,        /* --verbose              */\r
+    NOTMUCH_OPT_INT,            /* --frob=8               */\r
+    NOTMUCH_OPT_KEYWORD,        /* --format=raw|json|text */\r
+    NOTMUCH_OPT_STRING,         /* --file=/tmp/gnarf.txt  */\r
+    NOTMUCH_OPT_POSITION        /* notmuch dump pos_arg   */\r
+};\r
+\r
+/* excerpt from command-line-arguments.h -- indentation with tabs */\r
+\r
+enum notmuch_opt_type {\r
+    NOTMUCH_OPT_END = 0,\r
+    NOTMUCH_OPT_BOOLEAN,       /* --verbose              */\r
+    NOTMUCH_OPT_INT,           /* --frob=8               */\r
+    NOTMUCH_OPT_KEYWORD,       /* --format=raw|json|text */\r
+    NOTMUCH_OPT_STRING,                /* --file=/tmp/gnarf.txt  */\r
+    NOTMUCH_OPT_POSITION       /* notmuch dump pos_arg   */\r
+};\r
+\r
+\r
+[ ... ]\r
+\r
+\r
+Tomi\r