--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 6BAFF431FBC\r
+ for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 14:20:15 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id n1cwre3GxeyK for <notmuch@notmuchmail.org>;\r
+ Tue, 28 Oct 2014 14:20:07 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id A4079431FB6\r
+ for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 14:20:06 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id DD812100051;\r
+ Tue, 28 Oct 2014 23:19:49 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 0/6] notmuch search --output=sender/recipients\r
+In-Reply-To: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 28 Oct 2014 23:19:49 +0200\r
+Message-ID: <m2lhnzdh8q.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 28 Oct 2014 21:20:15 -0000\r
+\r
+On Mon, Oct 27 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+\r
+> Hi all,\r
+>\r
+> this is v4 of the search --output=3Daddress series. It obsoletes v3 that\r
+> starts at id:1413150093-8383-1-git-send-email-sojkam1@fel.cvut.cz.\r
+>\r
+> It addresses most comments made by Mark Walters and others. In\r
+> addition to v3, it also implements new --output=3Dcount (also suggested\r
+> by Mark). This required changes even in the initial patches of the\r
+> series but the result is cleaner code.\r
+\r
+I looked through the messages\r
+\r
+ id:1414421455-3037-2-git-send-email-sojkam1@fel.cvut.cz\r
+ id:1414421455-3037-3-git-send-email-sojkam1@fel.cvut.cz\r
+ id:1414421455-3037-4-git-send-email-sojkam1@fel.cvut.cz\r
+ id:1414421455-3037-5-git-send-email-sojkam1@fel.cvut.cz\r
+\r
+First I read the changes in this email thread and then changes in each of\r
+these messages with xxdiff(1) -- and applied the patches and ran tests\r
+(which passed).\r
+\r
+These 4 patches LGTM.\r
+\r
+The filtering/uniqueness whatnot handling still =C2=A1IMO! has things to ho=\r
+pe\r
+for, which I will write later...\r
+\r
+Finally, a promise I made a in reply to another patch series: Although\r
+these emails are patches when sent to this mailing list, when these\r
+are applied and pushed to notmuch repository the commit message should\r
+not refer these as patches -- and therefore the email part that will\r
+eventually be in commit message should be written differently. But that\r
+is not a reason enough to require patch email resent.\r
+\r
+\r
+Tomi\r
+\r
+\r
+>\r
+> Detailed changes from v3:\r
+>\r
+> - `o' renamed to `opt'.\r
+> - Conversion of --output from keyword to keyword-flags is now a\r
+> separate patch.\r
+> - Structured output formats print name and address separately.\r
+> - Added test for --format=3Djson.\r
+> - Changed --filter-by default to nameaddr. In v2, the default was\r
+> addrfold, in v3 the default was no filtering at all. I believe that\r
+> Mark's suggestion to make nameaddr the default is good trade off.\r
+> - Added new --output=3Dcount\r
+> - Minor style fixes\r
+> - Few typos fixed\r
+> - There is no way to output unfiltered (duplicite) addresses.\r
+> Hopefully, the introduction of --output=3Dcount is sufficient\r
+> replacement for this "feature".\r
+>\r
+> Cheers,\r
+> -Michal\r
+>\r
+>\r
+> Jani Nikula (1):\r
+> cli: Add support for parsing keyword-flag arguments\r
+>\r
+> Michal Sojka (5):\r
+> cli: search: Refactor passing of command line options\r
+> cli: search: Convert --output to keyword-flag argument\r
+> cli: search: Add --output=3D{sender,recipients}\r
+> cli: search: Add configurable way to filter out duplicate addresses\r
+> cli: search: Add --output=3Dcount\r
+>\r
+> command-line-arguments.c | 6 +-\r
+> command-line-arguments.h | 1 +\r
+> completion/notmuch-completion.bash | 8 +-\r
+> completion/notmuch-completion.zsh | 4 +-\r
+> doc/man1/notmuch-search.rst | 65 ++++++-\r
+> notmuch-search.c | 385 +++++++++++++++++++++++++++++--=\r
+------\r
+> test/T090-search-output.sh | 137 +++++++++++++\r
+> test/T095-search-filter-by.sh | 64 ++++++\r
+> test/T410-argument-parsing.sh | 3 +-\r
+> test/arg-test.c | 9 +\r
+> 10 files changed, 600 insertions(+), 82 deletions(-)\r
+> create mode 100755 test/T095-search-filter-by.sh\r
+>\r
+> --=20\r
+> 2.1.1\r
projects / notmuch-archives.git / commitdiff