In krb5_rc_io_open_internal, d->fn is always set for the cleanup
authorGreg Hudson <ghudson@mit.edu>
Thu, 12 Feb 2009 19:38:08 +0000 (19:38 +0000)
committerGreg Hudson <ghudson@mit.edu>
Thu, 12 Feb 2009 19:38:08 +0000 (19:38 +0000)
handler, so do not check it.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21982 dc483132-0cff-0310-8789-dd5450dbe970

src/lib/krb5/rcache/rc_io.c

index 02a45a4552349aa535b8d5f5a6527333d504ac4b..8d7d986dad015f36b91618030a922f63fb4e367e 100644 (file)
@@ -295,12 +295,10 @@ krb5_rc_io_open_internal(krb5_context context, krb5_rc_iostuff *d, char *fn,
 
 cleanup:
     if (retval) {
-        if (d->fn) {
-            if (!do_not_unlink)
-                (void) unlink(d->fn);
-            free(d->fn);
-            d->fn = NULL;
-        }
+        if (!do_not_unlink)
+            (void) unlink(d->fn);
+        free(d->fn);
+        d->fn = NULL;
         if (d->fd >= 0)
             (void) close(d->fd);
     }