krb_check_auth clears the return value for the schedule parameter with a memset....

ticket: 1730

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@15770 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/krb4/ChangeLog b/src/lib/krb4/ChangeLog
index c3bcc973e6360b38b4efd2edffaf7b43ca6414fd..82a8d2b81e5b50aaaf5ee3096a4012fc5efa83f8 100644 (file)
--- a/src/lib/krb4/ChangeLog
+++ b/src/lib/krb4/ChangeLog
@@ -1,3 +1,9 @@
+2003-08-15  Alexandra Ellwood  <lxs@mit.edu>
+
+        * mk_auth.c: krb_check_auth clears the return value for the 
+        schedule parameter with a memset.  This prevents callers 
+        from using the key schedule, which breaks code.
+
 2003-08-06  Alexandra Ellwood  <lxs@mit.edu>
 
         * configure.in: Don't assume all darwin boxes are powerpc.

diff --git a/src/lib/krb4/mk_auth.c b/src/lib/krb4/mk_auth.c
index 9159ce177b559e35e2d2a9bc41d69769b1028704..cf85ea2f87c8a07e6071a9c331f9ed7416a5d5a8 100644 (file)
--- a/src/lib/krb4/mk_auth.c
+++ b/src/lib/krb4/mk_auth.c
@@ -230,7 +230,6 @@ krb_check_auth (buf, checksum, msg_data, session, schedule, laddr, faddr)
        return KFAILURE;
     cc = krb_rd_priv(buf->dat, (unsigned KRB4_32)buf->length, schedule,
                     (C_Block *)session, faddr, laddr, msg_data);
-    memset(schedule, 0, sizeof(schedule));
     if (cc)
        return cc;