Re: [PATCH] contrib/nmbug: convert to use batch tagging.

diff --git a/b3/806438fa5695c292c832a97080df3a6fbbdea0 b/b3/806438fa5695c292c832a97080df3a6fbbdea0
new file mode 100644 (file)
index 0000000..2d3b62e
--- /dev/null
+++ b/b3/806438fa5695c292c832a97080df3a6fbbdea0
@@ -0,0 +1,123 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D5884431FC9\r
+       for <notmuch@notmuchmail.org>; Wed, 13 Feb 2013 06:47:40 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 3ryCz639nk8A for <notmuch@notmuchmail.org>;\r
+       Wed, 13 Feb 2013 06:47:40 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 13641431FC7\r
+       for <notmuch@notmuchmail.org>; Wed, 13 Feb 2013 06:47:40 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id AB06B10007D;\r
+       Wed, 13 Feb 2013 16:47:27 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] contrib/nmbug: convert to use batch tagging.\r
+In-Reply-To: <1360374019-20988-1-git-send-email-david@tethera.net>\r
+References: <1360374019-20988-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.15+20~g7e29ae9 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 13 Feb 2013 16:47:27 +0200\r
+Message-ID: <m2boboe0e8.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 13 Feb 2013 14:47:41 -0000\r
+\r
+On Sat, Feb 09 2013, david@tethera.net wrote:\r
+\r
+> From: David Bremner <bremner@debian.org>\r
+>\r
+> In the case of large changes to the database from git, one of main\r
+> current bottlenecks is the large number of execs of notmuch tag. This\r
+> avoids that by using use the batch tagging facilities as of notmuch\r
+> 0.15.\r
+>\r
+> We use "spawn" directly rather than inventing a "notmuch_pipe", since\r
+> it seems the only place we need to pipe to notmuch so far.\r
+> ---\r
+\r
+The code LGTM. Is there any quoting differences between these 2 \r
+tagging methods ?\r
+\r
+> This is only lightly tested; please make sure you have backups of your\r
+> database.\r
+\r
+Do I dare to test -- I'm lazy taking backups (I don't know how to take\r
+one -- and especially how to restore one ;)\r
+\r
+> I'm not 100% sure about the indentation. No doubt Tomi will let me\r
+> know if it can be improved.\r
+\r
+No doubt...\r
+\r
+Tomi\r
+\r
+>\r
+>  contrib/nmbug/nmbug |   15 ++++++++++-----\r
+>  1 file changed, 10 insertions(+), 5 deletions(-)\r
+>\r
+> diff --git a/contrib/nmbug/nmbug b/contrib/nmbug/nmbug\r
+> index f003ef9..c66c526 100755\r
+> --- a/contrib/nmbug/nmbug\r
+> +++ b/contrib/nmbug/nmbug\r
+> @@ -270,17 +270,22 @@ sub do_sync {\r
+>      $D_action = '-';\r
+>    }\r
+>  \r
+> -  foreach my $pair (@{$status->{added}}) {\r
+> +  my $notmuch = spawn ({}, '|-', qw/notmuch tag --batch/)\r
+> +      or die 'notmuch tag --batch';\r
+>  \r
+> -    notmuch ('tag', $A_action.$TAGPREFIX.$pair->{tag},\r
+> -         'id:'.$pair->{id});\r
+> +  foreach my $pair (@{$status->{added}}) {\r
+> +    print $notmuch $A_action.$TAGPREFIX.$pair->{tag}, " -- ",\r
+> +      'id:'.$pair->{id};\r
+>    }\r
+>  \r
+>    foreach my $pair (@{$status->{deleted}}) {\r
+> -    notmuch ('tag', $D_action.$TAGPREFIX.$pair->{tag},\r
+> -         'id:'.$pair->{id});\r
+> +    print $notmuch $D_action.$TAGPREFIX.$pair->{tag},\r
+> +      'id:'.$pair->{id};\r
+>    }\r
+>  \r
+> +  unless (close $notmuch) {\r
+> +    die "'notmuch tag --batch' exited with nonzero value\n";\r
+> +  }\r
+>  }\r
+>  \r
+>  \r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r