Re: [PATCH 1/3] cli: add insert --must-index option

diff --git a/b1/658c383592b1f0bed5365674a9f46f28b95882 b/b1/658c383592b1f0bed5365674a9f46f28b95882
new file mode 100644 (file)
index 0000000..a14113b
--- /dev/null
+++ b/b1/658c383592b1f0bed5365674a9f46f28b95882
@@ -0,0 +1,86 @@
+Return-Path: <novalazy@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C61D4431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 07:14:03 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.099\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id sUFlCAMFQnlh for <notmuch@notmuchmail.org>;\r
+       Wed, 11 Sep 2013 07:13:58 -0700 (PDT)\r
+Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com\r
+       [209.85.192.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 366AF431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 07:13:58 -0700 (PDT)\r
+Received: by mail-pd0-f172.google.com with SMTP id z10so9245750pdj.31\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 07:13:56 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=date:message-id:from:to:cc:subject:in-reply-to:references\r
+       :mime-version:content-type:content-disposition\r
+       :content-transfer-encoding;\r
+       bh=ty5zMNmhBdqZEu4Sm/avDtvcBpTPSj3kIcERbW6Pp48=;\r
+       b=iSNfK1maHfwWuSBsTp5bKDoRVEos8JAIpQWcW6n4BqOyAelINVzgKwU7dIk6j+7plF\r
+       D2Ks5ga+DjVkTbyTsiKj75ANKmETMnUkocWK7NSuiXHUgnWZPsFzpHEHjUShnl3NS7nb\r
+       pE/45D5xcwHlyCoFvX+kntlAtW7+Mmj2Vt+I0V9bcMr65mj3vdCuszHlnEnwOxs8DkX+\r
+       s80BVqDunret8EUXpK4YM+/nbY18fK0/VDWxQHPl3PiCSVxR5+EViuJqDN/ZOKwkwRrG\r
+       /OqxQdN/9GTwGbXmKnXqqU107lCg+2AxNugq+iVTf12RS0tSXBme+fC6LnoA3/obq6h2\r
+       Wlcw==\r
+X-Received: by 10.67.14.67 with SMTP id fe3mr3959503pad.134.1378908835283;\r
+       Wed, 11 Sep 2013 07:13:55 -0700 (PDT)\r
+Received: from localhost (215.42.233.220.static.exetel.com.au.\r
+       [220.233.42.215]) by mx.google.com with ESMTPSA id\r
+       sy2sm30087727pbc.16.1969.12.31.16.00.00\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Wed, 11 Sep 2013 07:13:54 -0700 (PDT)\r
+Date: Thu, 12 Sep 2013 00:13:49 +1000\r
+Message-ID: <20130912001349.GA18821@hili.localdomain>\r
+From: Peter Wang <novalazy@gmail.com>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 1/3] cli: add insert --must-index option\r
+In-Reply-To: <87hadtxfrr.fsf@qmul.ac.uk>\r
+References: <1374365254-13227-1-git-send-email-novalazy@gmail.com>\r
+       <87ip048gbj.fsf@qmul.ac.uk>\r
+       <20130727151510.GA13750@hili.localdomain>\r
+       <87hadtxfrr.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: 8bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 11 Sep 2013 14:14:04 -0000\r
+\r
+On Tue, 10 Sep 2013 09:06:00 +0100, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> \r
+> Alternatively maybe add notmuch_database_destroy_with_flush or something\r
+> which does give a return value. notmuch_database_close is only called 3\r
+> times and notmuch_database_destroy lots of times so changing close is\r
+> much less intrusive than changing destroy. But I don't know whether we\r
+> would break any  bindings or external programs etc.\r
+> \r
+> What do you think?\r
+\r
+I think notmuch_database_close and notmuch_database_destroy should\r
+return the status, and we update the three language bindings\r
+and bump the soname.\r
+\r
+Peter\r