[PATCH v2 00/14] reply refactor, fixes

diff --git a/91/fd9f8267e556812f63cea53732cd3d0cf236e2 b/91/fd9f8267e556812f63cea53732cd3d0cf236e2
new file mode 100644 (file)
index 0000000..6b60ac2
--- /dev/null
+++ b/91/fd9f8267e556812f63cea53732cd3d0cf236e2
@@ -0,0 +1,110 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 906536DE38DA\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 04:39:12 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.573\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.573 tagged_above=-999 required=5 tests=[AWL=0.147,\r
+  DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\r
+ RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id fTZDGgRle78S for <notmuch@notmuchmail.org>;\r
+ Sat, 13 Aug 2016 04:39:04 -0700 (PDT)\r
+Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com\r
+ [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id E63C36DE3844 for\r
+ <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 04:39:03 -0700 (PDT)\r
+Received: by mail-wm0-f68.google.com with SMTP id q128so2020384wma.1\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 04:39:03 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=nikula-org.20150623.gappssmtp.com; s=20150623;\r
+ h=from:to:cc:subject:date:message-id;\r
+ bh=6P4sL+yDic0lYpSmM3Zfm1EDZDbrGoatTANJVEA1Exs=;\r
+ b=u69CGhzSYVsyME+iCSf4U0wlP1WkvvNB1y3qBb03q8NMaDlv9L+RaOUsl+sguPihdT\r
+ VvpjX3jTrmiLSpk49Pg2l8V1WxWgI6RZYUPQIszcDGmik99tJt4UTWcGGHCSPuGeFkWH\r
+ gu6zJbNo+cK4WMiWAurWNU0F2Dgf8kyo3TytmQ31kHt/ti0ieWHomXa++KoyLAN4zB9L\r
+ NDFINYQhyyrzp3JHVB+V45wWGsbN++EFV0QmHs6paIud672C53Wg6eIR9/HuR3SYDXTk\r
+ As8lgzV4hmMUFG00mzSlbxlXbsBxuDyG1sATLwoOg92zu/Knc3OSKkbTJIzSYe7URqkD\r
+ ijVQ==\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:from:to:cc:subject:date:message-id;\r
+ bh=6P4sL+yDic0lYpSmM3Zfm1EDZDbrGoatTANJVEA1Exs=;\r
+ b=WMom9HJPaPwOQrqYoGKtmVdC+bqj6qjUsFwxkw64wqSVnHzQClTW3k7yQ0E/5yQfDL\r
+ 1Mx/ICgPLhzlXxY6gB29OlBG2QryZzF7Ptrw6y2fzK+kMiAta6nyKIwXo+EkCwpNndu/\r
+ VwNKImDvUMlTwqhnljgzuf1A1b0+9fAAwQr1cMCWPYbJAgTPTgeN+slrfj2vuH47b4bV\r
+ wFC0mZRbaJFLc2apxror7+P97waDgNd1sKGnyXv1CB5Q4UF4T1ekxojoL/cbL+KMZuVM\r
+ HiXCN544SeH0x+Fz0+I76jmbAZCJ4NNDWp4ZTawo+Td6iVkzdcfXSWrZJz1K4M5ibmpF\r
+ beUg==\r
+X-Gm-Message-State:\r
+ AEkoouvR5abeoGb54LPa7p4PD4SJEGcBzFnMghV3hJz6lHl4b4mGSmvYBQMyRJN6SN107w==\r
+X-Received: by 10.28.111.213 with SMTP id c82mr3296826wmi.47.1471088342164;\r
+ Sat, 13 Aug 2016 04:39:02 -0700 (PDT)\r
+Received: from localhost (mobile-access-bcee63-250.dhcp.inet.fi.\r
+ [188.238.99.250])\r
+ by smtp.gmail.com with ESMTPSA id 142sm6811929wmh.12.2016.08.13.04.39.01\r
+ (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Sat, 13 Aug 2016 04:39:01 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: notmuch@notmuchmail.org\r
+Cc: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+       jani@nikula.org\r
+Subject: [PATCH v2 00/14] reply refactor, fixes\r
+Date: Sat, 13 Aug 2016 14:37:24 +0300\r
+Message-Id: <cover.1471088022.git.jani@nikula.org>\r
+X-Mailer: git-send-email 2.1.4\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 13 Aug 2016 11:39:12 -0000\r
+\r
+Hi all, this lengthy series fixes replies to messages with multiple Cc:\r
+headers. Daniel reported the problem in\r
+id:87d1ngv95p.fsf@alice.fifthhorseman.net.\r
+\r
+Lots of refactoring is required to switch to using more GMime functions\r
+in the reply code.\r
+\r
+This is v2 of the series in id:cover.1466284726.git.jani@nikula.org.\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+Jani Nikula (14):\r
+  test: add known broken test for reply to message with multiple Cc\r
+    headers\r
+  cli/reply: push notmuch reply format abstraction lower in the stack\r
+  cli/reply: reuse show_reply_headers() in headers-only format\r
+  cli/reply: unify reply format functions\r
+  cli/reply: reorganize create_reply_message()\r
+  cli/reply: make references header creation easier to follow\r
+  cli/reply: reuse create_reply_message() also for headers-only format\r
+  cli/reply: reduce the reply format abstractions\r
+  cli/reply: use dedicated functions for reply to mapping\r
+  cli/reply: check for NULL list first in scan_address_list()\r
+  cli/reply: return internet address list from get header funcs\r
+  cli/reply: pass internet address list to munge detect\r
+  cli/reply: pass gmime message to munge detection\r
+  cli/reply: only pass gmime message to add recipients to reply message\r
+\r
+ notmuch-reply.c    | 435 +++++++++++++++++++++--------------------------------\r
+ test/T220-reply.sh |  24 +++\r
+ 2 files changed, 192 insertions(+), 267 deletions(-)\r
+\r
+-- \r
+2.1.4\r
+\r