From 2bc2e1e1812dead8815cb4318fa86b0270635f72 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sat, 13 Aug 2016 14:37:24 +0300 Subject: [PATCH] [PATCH v2 00/14] reply refactor, fixes --- 91/fd9f8267e556812f63cea53732cd3d0cf236e2 | 110 ++++++++++++++++++++++ 1 file changed, 110 insertions(+) create mode 100644 91/fd9f8267e556812f63cea53732cd3d0cf236e2 diff --git a/91/fd9f8267e556812f63cea53732cd3d0cf236e2 b/91/fd9f8267e556812f63cea53732cd3d0cf236e2 new file mode 100644 index 000000000..6b60ac2a1 --- /dev/null +++ b/91/fd9f8267e556812f63cea53732cd3d0cf236e2 @@ -0,0 +1,110 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 906536DE38DA + for ; Sat, 13 Aug 2016 04:39:12 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.573 +X-Spam-Level: +X-Spam-Status: No, score=-0.573 tagged_above=-999 required=5 tests=[AWL=0.147, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fTZDGgRle78S for ; + Sat, 13 Aug 2016 04:39:04 -0700 (PDT) +Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com + [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id E63C36DE3844 for + ; Sat, 13 Aug 2016 04:39:03 -0700 (PDT) +Received: by mail-wm0-f68.google.com with SMTP id q128so2020384wma.1 + for ; Sat, 13 Aug 2016 04:39:03 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=nikula-org.20150623.gappssmtp.com; s=20150623; + h=from:to:cc:subject:date:message-id; + bh=6P4sL+yDic0lYpSmM3Zfm1EDZDbrGoatTANJVEA1Exs=; + b=u69CGhzSYVsyME+iCSf4U0wlP1WkvvNB1y3qBb03q8NMaDlv9L+RaOUsl+sguPihdT + VvpjX3jTrmiLSpk49Pg2l8V1WxWgI6RZYUPQIszcDGmik99tJt4UTWcGGHCSPuGeFkWH + gu6zJbNo+cK4WMiWAurWNU0F2Dgf8kyo3TytmQ31kHt/ti0ieWHomXa++KoyLAN4zB9L + NDFINYQhyyrzp3JHVB+V45wWGsbN++EFV0QmHs6paIud672C53Wg6eIR9/HuR3SYDXTk + As8lgzV4hmMUFG00mzSlbxlXbsBxuDyG1sATLwoOg92zu/Knc3OSKkbTJIzSYe7URqkD + ijVQ== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:date:message-id; + bh=6P4sL+yDic0lYpSmM3Zfm1EDZDbrGoatTANJVEA1Exs=; + b=WMom9HJPaPwOQrqYoGKtmVdC+bqj6qjUsFwxkw64wqSVnHzQClTW3k7yQ0E/5yQfDL + 1Mx/ICgPLhzlXxY6gB29OlBG2QryZzF7Ptrw6y2fzK+kMiAta6nyKIwXo+EkCwpNndu/ + VwNKImDvUMlTwqhnljgzuf1A1b0+9fAAwQr1cMCWPYbJAgTPTgeN+slrfj2vuH47b4bV + wFC0mZRbaJFLc2apxror7+P97waDgNd1sKGnyXv1CB5Q4UF4T1ekxojoL/cbL+KMZuVM + HiXCN544SeH0x+Fz0+I76jmbAZCJ4NNDWp4ZTawo+Td6iVkzdcfXSWrZJz1K4M5ibmpF + beUg== +X-Gm-Message-State: + AEkoouvR5abeoGb54LPa7p4PD4SJEGcBzFnMghV3hJz6lHl4b4mGSmvYBQMyRJN6SN107w== +X-Received: by 10.28.111.213 with SMTP id c82mr3296826wmi.47.1471088342164; + Sat, 13 Aug 2016 04:39:02 -0700 (PDT) +Received: from localhost (mobile-access-bcee63-250.dhcp.inet.fi. + [188.238.99.250]) + by smtp.gmail.com with ESMTPSA id 142sm6811929wmh.12.2016.08.13.04.39.01 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 13 Aug 2016 04:39:01 -0700 (PDT) +From: Jani Nikula +To: notmuch@notmuchmail.org +Cc: Daniel Kahn Gillmor , + jani@nikula.org +Subject: [PATCH v2 00/14] reply refactor, fixes +Date: Sat, 13 Aug 2016 14:37:24 +0300 +Message-Id: +X-Mailer: git-send-email 2.1.4 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 13 Aug 2016 11:39:12 -0000 + +Hi all, this lengthy series fixes replies to messages with multiple Cc: +headers. Daniel reported the problem in +id:87d1ngv95p.fsf@alice.fifthhorseman.net. + +Lots of refactoring is required to switch to using more GMime functions +in the reply code. + +This is v2 of the series in id:cover.1466284726.git.jani@nikula.org. + +BR, +Jani. + + +Jani Nikula (14): + test: add known broken test for reply to message with multiple Cc + headers + cli/reply: push notmuch reply format abstraction lower in the stack + cli/reply: reuse show_reply_headers() in headers-only format + cli/reply: unify reply format functions + cli/reply: reorganize create_reply_message() + cli/reply: make references header creation easier to follow + cli/reply: reuse create_reply_message() also for headers-only format + cli/reply: reduce the reply format abstractions + cli/reply: use dedicated functions for reply to mapping + cli/reply: check for NULL list first in scan_address_list() + cli/reply: return internet address list from get header funcs + cli/reply: pass internet address list to munge detect + cli/reply: pass gmime message to munge detection + cli/reply: only pass gmime message to add recipients to reply message + + notmuch-reply.c | 435 +++++++++++++++++++++-------------------------------- + test/T220-reply.sh | 24 +++ + 2 files changed, 192 insertions(+), 267 deletions(-) + +-- +2.1.4 + -- 2.26.2