Add some output parameter initializations n order to eliminate some

spurious Coverity defects.  (Far from a comprehensive pass.)

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21782 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/kdc/network.c b/src/kdc/network.c
index fffaa1e788e10594a768b11917845c6cf1914bdb..4ebaf2b326c847ca7818bad1a083d37790124e4b 100644 (file)
--- a/src/kdc/network.c
+++ b/src/kdc/network.c
@@ -1163,6 +1163,7 @@ make_too_big_error (krb5_data **out)
     krb5_error_code retval;
     krb5_data *scratch;
 
+    *out = NULL;
     memset(&errpkt, 0, sizeof(errpkt));
 
     retval = krb5_us_timeofday(kdc_context, &errpkt.stime, &errpkt.susec);

diff --git a/src/lib/kadm5/srv/svr_iters.c b/src/lib/kadm5/srv/svr_iters.c
index 9774d76ea9bc233beb00e44fcd7b0e71c1ca51dc..cd3fb417707d44afb9f9341f2b964acd2c69d6be 100644 (file)
--- a/src/lib/kadm5/srv/svr_iters.c
+++ b/src/lib/kadm5/srv/svr_iters.c
@@ -192,7 +192,8 @@ static kadm5_ret_t kadm5_get_either(int princ,
      char *regexp;
      int i, ret;
      kadm5_server_handle_t handle = server_handle;
-     
+
+     *princs = NULL;
      *count = 0;
      if (exp == NULL)
          exp = "*";

diff --git a/src/lib/kdb/kdb5.c b/src/lib/kdb/kdb5.c
index e76ebe921f493ce35db993d3f995cc7e22561e34..5cc67f9b3753f8564cbad4918b3dc59a9f610a7f 100644 (file)
--- a/src/lib/kdb/kdb5.c
+++ b/src/lib/kdb/kdb5.c
@@ -1861,6 +1861,9 @@ krb5_dbe_lookup_mod_princ_data(context, entry, mod_time, mod_princ)
     krb5_tl_data tl_data;
     krb5_error_code code;
 
+    *mod_princ = NULL;
+    *mod_time = 0;
+
     tl_data.tl_data_type = KRB5_TL_MOD_PRINC;
 
     if ((code = krb5_dbe_lookup_tl_data(context, entry, &tl_data)))

diff --git a/src/lib/krb5/os/read_msg.c b/src/lib/krb5/os/read_msg.c
index 77cda8032a5fe82f3a30e33718a0b70c39621e8a..47973bbd8c920eff3ee4eb2ee6d4a9fe129bbd29 100644 (file)
--- a/src/lib/krb5/os/read_msg.c
+++ b/src/lib/krb5/os/read_msg.c
@@ -37,7 +37,10 @@ krb5_read_message(krb5_context context, krb5_pointer fdp, krb5_data *inbuf)
        int             len2, ilen;
        char            *buf = NULL;
        int             fd = *( (int *) fdp);
-       
+
+       inbuf->data = NULL;
+       inbuf->length = 0;
+
        if ((len2 = krb5_net_read(context, fd, (char *)&len, 4)) != 4)
                return((len2 < 0) ? errno : ECONNABORTED);
        len = ntohl(len);

diff --git a/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c b/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c
index 15bbbb85c0dde841e738cabe9f66642cd027ea1c..c402e2ee1099531039fd70ad67538d982f4d8b00 100644 (file)
--- a/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c
+++ b/src/plugins/preauth/pkinit/pkinit_crypto_openssl.c
@@ -2259,6 +2259,9 @@ server_process_dh(krb5_context context,
     unsigned char *p = NULL;
     ASN1_INTEGER *pub_key = NULL;
 
+    *dh_pubkey = *server_key = NULL;
+    *dh_pubkey_len = *server_key_len = 0;
+
     /* get client's received DH parameters that we saved in server_check_dh */
     dh = cryptoctx->dh;