The memory allocated by ConstructTicketRequest is not LSA memory

  and must be freed with LocalFree().

ticket: 2561

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@16339 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/krb5/ccache/ChangeLog b/src/lib/krb5/ccache/ChangeLog
index aabd2f29a65c4b3d8dd8f0d49a6e5d99652a486b..6d469a50a79890af6e1793f3c0c98e01e95951fe 100644 (file)
--- a/src/lib/krb5/ccache/ChangeLog
+++ b/src/lib/krb5/ccache/ChangeLog
@@ -3,7 +3,8 @@
     * cc_mslsa.c:  The FAILED() macro only considered an error 
       to be a failure if the value is negative.  ConstructTicketRequest()
       returns positive errors.  Do not use FAILED() to test the result.
-      Also, fix a potential leak of LSA allocated memory.
+      Fix a potential leak of LSA allocated memory.  Fix a leak of 
+      LocalAlloc memory.
 
 2004-04-24  Ken Raeburn  <raeburn@mit.edu>
 

diff --git a/src/lib/krb5/ccache/cc_mslsa.c b/src/lib/krb5/ccache/cc_mslsa.c
index 73d6b7096d7cb6d35b82aabd76030cc58daeb21b..93a938d8284504170923d8ce89be59e2d3c8ecfc 100644 (file)
--- a/src/lib/krb5/ccache/cc_mslsa.c
+++ b/src/lib/krb5/ccache/cc_mslsa.c
@@ -854,7 +854,7 @@ GetMSTGT(HANDLE LogonHandle, ULONG PackageId,KERB_EXTERNAL_TICKET **ticket)
 
   cleanup:
     if ( pTicketRequest )
-        LsaFreeReturnBuffer(pTicketRequest);
+        LocalFree(pTicketRequest);
 
     if (FAILED(Status) || FAILED(SubStatus))
     {