krb5_build_principal_ext walks off beginning of array

On error, krb5_build_principal_ext walks off the beginning of the
array by using i-- in a conditional when it should be using --i
(so that it actually compares the value of i that will be used
below).

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20920 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/krb5/krb/bld_pr_ext.c b/src/lib/krb5/krb/bld_pr_ext.c
index c7236b7b5a80d68c0dc34249281068e975b04432..c1e19ba17f30ff2807a7cda6fba497d9baa1f701 100644 (file)
--- a/src/lib/krb5/krb/bld_pr_ext.c
+++ b/src/lib/krb5/krb/bld_pr_ext.c
@@ -93,7 +93,7 @@ krb5_build_principal_ext(krb5_context context,  krb5_principal * princ,
     return 0;
 
 free_out:
-    while (i-- >= 0)
+    while (--i >= 0)
        krb5_xfree(princ_data[i].data);
     krb5_xfree(princ_data);
     krb5_xfree(princ_ret);