* cleanup.c (pty_cleanup): Delcare local variable only if

	VHANG_LAST defined.

	* logwtmp.c (pty_logwtmp): Only declare local variables if
	logwtmp() not available on system.

	* sane_hostname.c (sockaddrlen): Only define static function if
	HAVE_GETNAMEINFO defined. (pty_make_sane_hostname) Declare goto
	target only if code compiled in.

gcc warning cleanups

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@13227 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/util/pty/ChangeLog b/src/util/pty/ChangeLog
index 90a0a1ef49112124a5e01e8fcf527912fd496ab6..a3794f7841c8f533931db961d4a70d76a32dc933 100644 (file)
--- a/src/util/pty/ChangeLog
+++ b/src/util/pty/ChangeLog
@@ -1,3 +1,15 @@
+2001-05-03  Ezra Peisach  <epeisach@mit.edu>
+
+       * cleanup.c (pty_cleanup): Delcare local variable only if
+       VHANG_LAST defined.
+
+       * logwtmp.c (pty_logwtmp): Only declare local variables if
+       logwtmp() not available on system.
+
+       * sane_hostname.c (sockaddrlen): Only define static function if
+       HAVE_GETNAMEINFO defined. (pty_make_sane_hostname) Declare goto
+       target only if code compiled in.
+
 2001-05-01  Ken Raeburn  <raeburn@mit.edu>
 
        * update_utmp.c (pty_update_utmp): Fix typo (OWRONLY ->

diff --git a/src/util/pty/cleanup.c b/src/util/pty/cleanup.c
index 32384108bf733b5ea6da0be5f442133a09f6a4f9..23db2a2f31f00bae3725dbc8ab78b088ff5d0185 100644 (file)
--- a/src/util/pty/cleanup.c
+++ b/src/util/pty/cleanup.c
@@ -32,7 +32,9 @@ long pty_cleanup (slave, pid, update_utmp)
     int pid; /* May be zero for unknown.*/
     int update_utmp;
 {
+#ifdef VHANG_LAST
     int retval, fd;
+#endif
     
     if (update_utmp)
        pty_update_utmp(PTY_DEAD_PROCESS,0,  "", slave, (char *)0, PTY_UTMP_USERNAME_VALID);

diff --git a/src/util/pty/logwtmp.c b/src/util/pty/logwtmp.c
index 684033ed28e60dede0758c065b7ae7109e1d4a57..5b10f4616ff640a3cf55b3537c7ae589dd235f6d 100644 (file)
--- a/src/util/pty/logwtmp.c
+++ b/src/util/pty/logwtmp.c
@@ -33,11 +33,13 @@
 long
 pty_logwtmp(const char *tty, const char *user, const char *host)
 {
+#ifndef HAVE_LOGWTMP
     PTY_STRUCT_UTMPX utx;
     int loggingin;
     size_t len;
     const char *cp;
     char utmp_id[5];
+#endif
 
 #ifdef HAVE_LOGWTMP
     logwtmp(tty,user,host);

diff --git a/src/util/pty/sane_hostname.c b/src/util/pty/sane_hostname.c
index 753683ccc8ed2dc7377684eda1df58ab50c1a377..5edd443ca14ae136273586626c1084f93dd34c48 100644 (file)
--- a/src/util/pty/sane_hostname.c
+++ b/src/util/pty/sane_hostname.c
@@ -26,6 +26,7 @@
 #include "libpty.h"
 #include <arpa/inet.h>
 
+#ifdef HAVE_GETNAMEINFO
 static size_t
 sockaddrlen (const struct sockaddr *addr)
 {
@@ -42,12 +43,13 @@ sockaddrlen (const struct sockaddr *addr)
     return 0;
 #endif
 }
+#endif
 
 static void
 downcase (char *s)
 {
     for (; *s != '\0'; s++)
-       *s = tolower (*s);
+       *s = tolower ((int) *s);
 }
 
 static long
@@ -106,7 +108,9 @@ pty_make_sane_hostname(const struct sockaddr *addr, int maxlen,
        return ENOMEM;
 
     if (always_ipaddr)
+#ifdef HAVE_GETNAMEINFO
     use_ipaddr:
+#endif
        return do_ntoa(addr, ut_host_len, out);
 
 #ifdef HAVE_GETNAMEINFO