* secure.c (secure_putbuf): Revert Sam's last change; if
authorTom Yu <tlyu@mit.edu>
Fri, 26 Feb 1999 04:15:45 +0000 (04:15 +0000)
committerTom Yu <tlyu@mit.edu>
Fri, 26 Feb 1999 04:15:45 +0000 (04:15 +0000)
  FUDGE_FACTOR is wrong, then badness can happen.  Also, if
  out_buf.length != nbytes+FUDGE_FACTOR, heap corruption could
  happen.  We really should be using gss_wrap_size_limit() or
  something like that, but doing so would require substantial
  amounts of reworking. [krb5-appl/685]

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@11228 dc483132-0cff-0310-8789-dd5450dbe970

src/appl/gssftp/ftp/ChangeLog
src/appl/gssftp/ftp/secure.c

index f76c9894dc63cf8322eedbb35918884e04d856fc..f275b6ea5845f049e524d017e671cc12ababe1f6 100644 (file)
@@ -1,3 +1,12 @@
+Thu Feb 25 23:05:03 1999  Tom Yu  <tlyu@mit.edu>
+
+       * secure.c (secure_putbuf): Revert Sam's last change; if
+       FUDGE_FACTOR is wrong, then badness can happen.  Also, if
+       out_buf.length != nbytes+FUDGE_FACTOR, heap corruption could
+       happen.  We really should be using gss_wrap_size_limit() or
+       something like that, but doing so would require substantial
+       amounts of reworking. [krb5-appl/685]
+
 1998-11-13  Theodore Ts'o  <tytso@rsts-11.mit.edu>
 
        * Makefile.in: Set the myfulldir and mydir variables (which are
index 57653b62817c43e7da496d56d479b264b2a1733e..48f57f93f94fecb5d77a64a4d8e07af38d15d6c9 100644 (file)
@@ -282,7 +282,7 @@ unsigned int nbyte;
                        if (outbuf?
                            (outbuf = realloc(outbuf, (unsigned) out_buf.length)):
                            (outbuf = malloc((unsigned) out_buf.length))) {
-                               bufsize = nbyte + FUDGE_FACTOR;
+                               bufsize = out_buf.length;
                        } else {
                                bufsize = 0;
                                secure_error("%s (in malloc of PROT buffer)",