Re: Parsing regression with gmime-2.6?

diff --git a/0f/99a5897f28c520da767e7d6a6f65a23a8c025f b/0f/99a5897f28c520da767e7d6a6f65a23a8c025f
new file mode 100644 (file)
index 0000000..7fffd1a
--- /dev/null
+++ b/0f/99a5897f28c520da767e7d6a6f65a23a8c025f
@@ -0,0 +1,131 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id BE529431FB6\r
+       for <notmuch@notmuchmail.org>; Thu,  8 Mar 2012 13:33:11 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 4tJfoOv3XNYZ for <notmuch@notmuchmail.org>;\r
+       Thu,  8 Mar 2012 13:33:11 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id ED61A431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  8 Mar 2012 13:33:10 -0800 (PST)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id 6FFC066E01EE;\r
+       Thu,  8 Mar 2012 13:33:10 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (DHCP-123-180.caltech.edu [131.215.123.180])\r
+       (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 292F566E00DA;\r
+       Thu,  8 Mar 2012 13:32:47 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id CAA149DE; Thu,  8 Mar 2012 13:32:46 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+       David Bremner <david@tethera.net>,\r
+       Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: Parsing regression with gmime-2.6?\r
+In-Reply-To: <87vcme3kf6.fsf@pip.fifthhorseman.net>\r
+References: <87d38w2e7h.fsf@zancas.localnet>\r
+       <1331058417-13776-1-git-send-email-amdragon@mit.edu>\r
+       <87wr6xmlml.fsf@zancas.localnet>\r
+       <87vcme3kf6.fsf@pip.fifthhorseman.net>\r
+User-Agent: Notmuch/0.11.1+266~gadb05cc (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 08 Mar 2012 13:32:44 -0800\r
+Message-ID: <874ntybwxv.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 08 Mar 2012 21:33:11 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Thu, 08 Mar 2012 15:30:21 -0500, Daniel Kahn Gillmor <dkg@fifthhorseman.=\r
+net> wrote:\r
+> This does seem to be a regression in gmime 2.6.  I've reported the bug\r
+> upstream, along with a simplified (non-notmuch) demonstration:\r
+>=20\r
+>  https://bugzilla.gnome.org/show_bug.cgi?id=3D671680\r
+>=20\r
+> We'll see what gmime's upstream has to say about it.\r
+\r
+Thanks so much for following up on this, Daniel.\r
+\r
+> As a devil's advocate, i could argue that a message in a maildir that\r
+> starts with a "From " line isn't a proper e-mail message in the first\r
+> place, and therefore gmime 2.6 is being more rigorously correct about\r
+> what it accepts.  In particular, if a user were to place a multi-message\r
+> mbox file in their notmuch message store, i think that notmuch linked\r
+> against 2.4 would happily index only the first message of it, and the\r
+> rest of the message would be "hidden", whereas gmime 2.6 allows us to\r
+> detect these failures and avoid indexing them directly.\r
+\r
+I actually agree with this position.  mbox files are not proper email\r
+messages, so if gmime does not explicitly support parsing them then we\r
+really can't expect it to parse them.  We *can* expect gmime to return\r
+some sort of proper error message/return code/etc and not fail in a bad\r
+way, but beyond that I think the burden is on us.\r
+\r
+> That said, i understand that this is probably not an entirely rare\r
+> situation, and i lean toward the idea that gmime 2.4's behavior was\r
+> actually the Right Thing.  Also, I haven't been able to find any\r
+> explicit documentation to indicate that the behavior change was\r
+> a deliberate one.\r
+\r
+And I think I don't agree with this one: I not think that handling mbox\r
+files in the way you've outlined above is the Right Thing.  Only\r
+partially parsing an mbox file, by indexing only the first message for\r
+instance, seems like a bad solution to me, and one that's likely to lead\r
+to a lot of confusion (e.g. "where are the rest of the messages that\r
+were in my mbox?").\r
+\r
+If notmuch encounters an mbox file in the store it should just skip the\r
+message and continue, while indicating that it is skipping the message\r
+because it's not a proper email message, as it does with other non-email\r
+files.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPWSV8AAoJEO00zqvie6q86N0P/RT0X702Jhcnl+53tFyUjFUH\r
+UkAH+Myqp+6di7YVvoFoDrATmXVGj4S0Z2QeO+MEjSbfmuY2Xx9V4V2Sh5QQ08ZW\r
+TeZPQ8qYkWI0FQsG6nQjZhAbxf6QEJ0DRBdDYsuNJK1a6FwayE2bqDvvSw9xf7fE\r
+D/C0Dleucr3L10utZuSmxNcJLB/flpPI3A6GcUgwf81OF5N2paqsKUW1rZdYtHkJ\r
+y8Go7rHMmsaw82ABQfG/eoEKTotQNGgNpciWsOub7/CT/PC9yF+yQBr44VsVIhTn\r
+w0tYpiy1pNFQ1eWLDe1QWDW+dv1HNYDqBeThURN3A90IgV49IVEjfJHLMaxtSKuh\r
+KCgniEOB0V40LY01Bt3ot1yHcMbY58slH15NFbVINQifs2egtRuESwBgeO+EcbGU\r
+sfqP3nrAS2aDD/bhnEeQlEidGD4xsXLVk1bT7pj+2oSImj7rXd9ph/XJCrX0KCyI\r
+3HtOkAnsxFer2x6UYAaLQ3D4CDKppwvrcwMH1pHckR6J+Foz5GC7Eq3AxGj9fUGJ\r
++SAsRFucJ50LnumziD3nQf+n+PBLfsp22ZVahT0waJJaxIiqMGdko/8mI9A4CSlA\r
+uflptkIfkiSanbt7xkk+MI7MGonvRfT4m1G/5gHqdwhsihoeHI6fIfiTXq30ozBg\r
+vCgiuNNbMG6lhfXq6o9X\r
+=Flnt\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r