* client.c (main): Ensure that end of string is NULL terminated

 	instead of assuming buffer initialized to 0. Include <string.h>
 	for memset prototype.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@13187 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/rpc/unit-test/ChangeLog b/src/lib/rpc/unit-test/ChangeLog
index bd91605d79471557763c02a15e5ffbbaad147faf..6ccd0c2fc32f717609597ccf6b138bc58d001a52 100644 (file)
--- a/src/lib/rpc/unit-test/ChangeLog
+++ b/src/lib/rpc/unit-test/ChangeLog
@@ -1,3 +1,9 @@
+2001-04-24  Ezra Peisach  <epeisach@mit.edu>
+
+       * client.c (main): Ensure that end of string is NULL terminated
+       instead of assuming buffer initialized to 0. Include <string.h>
+       for memset prototype.
+
 2000-07-01  Ken Raeburn  <raeburn@mit.edu>
 
        * Makefile.in (unit-test-body): Combine -tcp and -udp versions,

diff --git a/src/lib/rpc/unit-test/client.c b/src/lib/rpc/unit-test/client.c
index b0e831704e1530f42c46e4b39debde68494183df..e2405cf148ade3e95c5e0c34361793c7bfdc10f6 100644 (file)
--- a/src/lib/rpc/unit-test/client.c
+++ b/src/lib/rpc/unit-test/client.c
@@ -5,6 +5,11 @@
  * $Source$
  * 
  * $Log$
+ * Revision 1.17  2001/04/24 17:05:34  epeisach
+ *     * client.c (main): Ensure that end of string is NULL terminated
+ *     instead of assuming buffer initialized to 0. Include <string.h>
+ *     for memset prototype.
+ *
  * Revision 1.16  1998/02/14 02:29:42  tlyu
  *     * client.c: Update header locations.  Rename of xdr_free.
  *
@@ -95,6 +100,7 @@ static char *rcsid = "$Header$";
 #endif
 
 #include <stdio.h>
+#include <string.h>
 #include <gssrpc/rpc.h>
 #include <gssapi/gssapi.h>
 #include <gssrpc/rpc.h>
@@ -120,6 +126,13 @@ struct auth_gssapi_data {
 extern int auth_debug_gssapi;
 char *whoami;
 
+static void usage()
+{
+     fprintf(stderr, "usage: %s {-t|-u} [-a] [-s num] [-m num] host service [count]\n",
+            whoami);
+     exit(1);
+}
+
 main(argc, argv)
    int argc;
    char **argv;
@@ -177,8 +190,8 @@ main(argc, argv)
      switch (argc) {
      case 3:
          count = atoi(argv[2]);
-         if (count > BIG_BUF) {
-           fprintf(stderr, "Test count cannot exceed %d.\n", BIG_BUF);
+         if (count > BIG_BUF-1) {
+           fprintf(stderr, "Test count cannot exceed %d.\n", BIG_BUF-1);
            usage();
          }
      case 2:
@@ -312,7 +325,7 @@ main(argc, argv)
       * this last, since it takes a while..
       */
      echo_arg = buf;
-     memset(buf, 0, count);
+     memset(buf, 0, count+1);
      for (i = 0; i < count; i++) {
          echo_resp = rpc_test_echo_1(&echo_arg, clnt);
          if (echo_resp == NULL) {
@@ -342,9 +355,3 @@ main(argc, argv)
      exit(0);
 }
 
-usage()
-{
-     fprintf(stderr, "usage: %s {-t|-u} [-a] [-s num] [-m num] host service [count]\n",
-            whoami);
-     exit(1);
-}