Minimize draft9 PKINIT code by removing dead code
authorGreg Hudson <ghudson@mit.edu>
Sat, 11 Feb 2012 23:25:12 +0000 (23:25 +0000)
committerGreg Hudson <ghudson@mit.edu>
Sat, 11 Feb 2012 23:25:12 +0000 (23:25 +0000)
commitbeb36f85c88fab20e95c4a0d8f109c3d0ab942f5
tree87bf5d167d9ab3fb9fcabaf4bdf5e0a0c71d4adc
parentf0af05cf4d4fbfea0b418e94ab5f60031db57a66
Minimize draft9 PKINIT code by removing dead code

The PKINIT client code doesn't use decode_krb5_pa_pk_as_rep_draft9,
which is fortunate because it doesn't work (see issue #7072).
Instead, it passes both kinds of PKINIT replies through
decode_krb5_pa_pk_as_rep, then decodes the un-enveloped CMS data in
alternative 1 (encKeyPack) as either an RFC or draft9 ReplyKeyPack.
So, remove the unused broken pa_pk_as_rep_draft9 decoder.

For pa_pk_as_req_draft9, we only use two of the fields on encode and
only one of those on decode.  So, get rid of the unused fields and
the krb5_trusted_ca structure, and reduce the encoder and decoder
sequences to the minimum necessary fields.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@25689 dc483132-0cff-0310-8789-dd5450dbe970
22 files changed:
src/include/k5-int-pkinit.h
src/include/k5-int.h
src/lib/krb5/asn.1/asn1_k_decode.c
src/lib/krb5/asn.1/asn1_k_decode.h
src/lib/krb5/asn.1/asn1_k_decode_kdc.c
src/lib/krb5/asn.1/asn1_k_encode.c
src/lib/krb5/asn.1/krb5_decode.c
src/lib/krb5/os/accessor.c
src/plugins/preauth/pkinit/pkinit.h
src/plugins/preauth/pkinit/pkinit_accessor.c
src/plugins/preauth/pkinit/pkinit_accessor.h
src/plugins/preauth/pkinit/pkinit_clnt.c
src/plugins/preauth/pkinit/pkinit_crypto.h
src/plugins/preauth/pkinit/pkinit_crypto_nss.c
src/plugins/preauth/pkinit/pkinit_crypto_openssl.c
src/plugins/preauth/pkinit/pkinit_lib.c
src/tests/asn.1/krb5_decode_test.c
src/tests/asn.1/ktest.c
src/tests/asn.1/ktest_equal.c
src/tests/asn.1/ktest_equal.h
src/tests/asn.1/pkinit_encode.out
src/tests/asn.1/pkinit_trval.out